azure-sdk-for-python icon indicating copy to clipboard operation
azure-sdk-for-python copied to clipboard

Published 20 hours ago • verified publisher icon Azure

[KeyVault] Drop six package in key vault

Open ponopono0322 opened this issue 3 years ago • 1 comments

Description

There were several PRs(#26150, #25902) related to six package drop in key vault. But the branch is too old, so I wrote a new one.

All SDK Contribution checklist:

  • [x] The pull request does not introduce [breaking changes]
  • [x] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [x] I have read the contribution guidelines.

General Guidelines and Best Practices

  • [x] Title of the pull request is clear and informative.
  • [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [x] Pull request includes test coverage for the included changes.

ponopono0322 avatar Nov 09 '22 00:11 ponopono0322

..And I apologize for leaving the wrong commit message(fix -> refactor). I found after PR :(

ponopono0322 avatar Nov 09 '22 00:11 ponopono0322

Thank you so much for opening a new PR! I'm adding some work just to clear CI checks so I can incorporate your changes in our upcoming releases. Thank you for the patience and persistence on this issue -- it's been a huge, huge help.

mccoyp avatar Nov 15 '22 05:11 mccoyp