azure-sdk-for-python icon indicating copy to clipboard operation
azure-sdk-for-python copied to clipboard

Published 20 hours ago • verified publisher icon Azure

[ML][Endpoints] Ensure defaults property is instantiated

Open qusayalsaifi opened this issue 3 years ago • 3 comments

Our document referenced below, states that "defaults" dictionary defaults to {}, however, it is current defaults to None.

Reference: https://learn.microsoft.com/en-us/python/api/azure-ai-ml/azure.ai.ml.entities.batchendpoint?view=azure-python

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • [x] The pull request does not introduce [breaking changes]
  • [x] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [x] I have read the contribution guidelines.

General Guidelines and Best Practices

  • [x] Title of the pull request is clear and informative.
  • [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [ ] Pull request includes test coverage for the included changes.

qusayalsaifi avatar Nov 07 '22 10:11 qusayalsaifi

@qusayalsaifi please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.

  1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, that is delivered by You to Microsoft under this Agreement. “Project” means any of the projects owned or managed by Microsoft and offered under a license approved by the Open Source Initiative (www.opensource.org). “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any Project, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of discussing and improving that Project, but excluding communication that is conspicuously marked or otherwise designated in writing by You as “Not a Submission.” “Submission” means the Code and any other copyrightable material Submitted by You, including any associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any Project. This Agreement covers any and all Submissions that You, now or in the future (except as described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work. Should You wish to Submit materials that are not Your original work, You may Submit them separately to the Project if You (a) retain all copyright and license information that was in the materials as You received them, (b) in the description accompanying Your Submission, include the phrase “Submission containing materials of a third party:” followed by the names of the third party and any licenses or other restrictions of which You are aware, and (c) follow any other instructions in the Project’s written guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your Submission is made in the course of Your work for an employer or Your employer has intellectual property rights in Your Submission by contract or applicable law, You must secure permission from Your employer to make the Submission before signing this Agreement. In that case, the term “You” in this Agreement will refer to You and the employer collectively. If You change employers in the future and desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under Your patent claims that are necessarily infringed by the Submission or the combination of the Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above licenses. You represent that each of Your Submissions is entirely Your original work (except as You may have disclosed under Section 3). You represent that You have secured permission from Your employer to make the Submission in cases where Your Submission is made in the course of Your work for Your employer or Your employer has intellectual property rights in Your Submission by contract or applicable law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You have the necessary authority to bind the listed employer to the obligations contained in this Agreement. You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which You later become aware that would make Your representations in this Agreement inaccurate in any respect.
  3. Information about Submissions. You agree that contributions to Projects and information about contributions may be maintained indefinitely and disclosed publicly, including Your name and other information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County, Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and supersedes any and all prior agreements, understandings or communications, written or oral, between the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

microsoft-github-policy-service[bot] avatar Nov 07 '22 10:11 microsoft-github-policy-service[bot]

Hello Man,

Our main concern is that Dochttps://learn.microsoft.com/en-us/python/api/azure-ai-ml/azure.ai.ml.entities.batchendpoint?view=azure-python saying that "defaults" should default to {}, however, it's defaulting to None.

How this is impacting?

In the following azureml-example: azureml-examples/mlflow-for-batch-tabular.ipynb at main * Azure/azureml-examples (github.com)https://github.com/Azure/azureml-examples/blob/main/sdk/python/endpoints/batch/mlflow-for-batch-tabular.ipynb

In 3.1 Configure the endpoint, code is not setting "deployment_name" attribute, nor "defaults" dictionary. Therefore, code is calling BatchEndpoint and setting None value to "defaults".

Later on, in 4.5 Create the deployment:

  • endpoint.defaults.deployment_name = deployment.name

This line of code is causing failure because defaults = None.

If we used the attribute deployment_name and set it in 3.1, this will force the class to create defaults dictionary, following to the code in batch_endpoint.py: if not self.defaults and default_deployment_name: self.defaults = {} self.defaults["deployment_name"] = default_deployment_name

However, we cannot use "deployment_name" attribute at this stage of code, because we don't have the deployment created yet.

I found a stable workaround, by adding the following line in 3.1 of notebook: endpoint = BatchEndpoint( name="heart-classifier-batch", description="A heart condition classifier for batch inference", defaults = {} )

Here I'm creating the dictotionary of defaults manually, but the question is, should this happen automatically by calling BatchEndpoint?

Thee reason I opened this pull request, is because I saw the document saying that "defaults" should be {}.

Qusay Alsaifi Technical Support Engineer AI and Intelligent Devices Office: +962 (6) 556 4115 @.@.>

Mon - Fri | 9 AM - 6 PM UTC+3

[Microsoft Logo]

From: Man @.> Sent: Monday, November 7, 2022 8:51 PM To: Azure/azure-sdk-for-python @.> Cc: Qusay Alsaifi @.>; Mention @.> Subject: Re: [Azure/azure-sdk-for-python] Update batch_endpoint.py (PR #27337)

@Man-MSFT commented on this pull request.

In sdk/ml/azure-ai-ml/azure/ai/ml/entities/_endpoint/batch_endpoint.pyhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-python%2Fpull%2F27337%23discussion_r1015728134&data=05%7C01%7Cqusayalsaifi%40microsoft.com%7C75323689b3724efd515e08dac0e89acc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638034402534252942%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=7T6lwy%2FlPhoR8O5N1t%2Fg2KAClRqxiLhQKaiRmZnZirc%3D&reserved=0:

@@ -54,7 +54,7 @@ def init(

     auth_mode: str = AAD_TOKEN_YAML,

     description: str = None,

     location: str = None,

  •    defaults: Dict[str, str] = None,

  •    defaults: Dict[str, str] = {},

I'm not fully understanding the problem tho, our public doc will look at our type hints, here is Dict[str,str], which is what we expect the caller to pass.

Is the problem that, user can not pass defaults and also not default_deployment which makes self.defaults == None? Then we can break the logic s.t. self.defaults is always at least {}.

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-python%2Fpull%2F27337%23discussion_r1015728134&data=05%7C01%7Cqusayalsaifi%40microsoft.com%7C75323689b3724efd515e08dac0e89acc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638034402534252942%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=7T6lwy%2FlPhoR8O5N1t%2Fg2KAClRqxiLhQKaiRmZnZirc%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA2VMJXCVKZYWLGWVQWOBGL3WHE6PRANCNFSM6AAAAAARZAPTZA&data=05%7C01%7Cqusayalsaifi%40microsoft.com%7C75323689b3724efd515e08dac0e89acc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638034402534252942%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=F16DS9lP7XzwT0GvmMN80yO6sPyhyCYTiB3zGe73GAM%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

qusayalsaifi avatar Nov 08 '22 07:11 qusayalsaifi

Hello Man,

I have changed the name as requested: [ML][Endpoints] Ensure defaults property is instantiated by qusayalsaifi * Pull Request #27337 * Azure/azure-sdk-for-python (github.com)https://github.com/Azure/azure-sdk-for-python/pull/27337

And yes, this is exactly what we need, batch endpoint should initiate defaults by default, so it can be usable later on.

Qusay Alsaifi Technical Support Engineer AI and Intelligent Devices Office: +962 (6) 556 4115 @.@.>

Mon - Fri | 9 AM - 6 PM UTC+3

[Microsoft Logo]

From: Man @.> Sent: Monday, November 7, 2022 8:53 PM To: Azure/azure-sdk-for-python @.> Cc: Qusay Alsaifi @.>; Mention @.> Subject: Re: [Azure/azure-sdk-for-python] Update batch_endpoint.py (PR #27337)

@Man-MSFT commented on this pull request.

In sdk/ml/azure-ai-ml/CHANGELOG.mdhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-python%2Fpull%2F27337%23discussion_r1015729659&data=05%7C01%7Cqusayalsaifi%40microsoft.com%7C0f03ca7536094d5215df08dac0e8dc1c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638034403620948977%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Ixe7xAeetTb5iXljklcHWxMXjlacosPyU9hN1v6NNi4%3D&reserved=0:

@@ -18,6 +18,8 @@

  • Make registry delete operation return an LROPoller, and change name to begin_delete.

  • Prevent registering an already existing environment that references conda file.

  • Fix ARM id logic for registry environments (ex: Creating a registry component that references a registry environment).

+- Update "defaults" dictionary to match our public documentation.

If we follow through on this PR, can we rename the title? I think that something like [ML][Endpoints] Ensure defaults property is instantiated to go with how other PRs are named https://github.com/Azure/azure-sdk-for-python/pullshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-python%2Fpulls&data=05%7C01%7Cqusayalsaifi%40microsoft.com%7C0f03ca7536094d5215df08dac0e8dc1c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638034403620948977%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=kiFUMmzCYB%2FDwvukjPpP7k6ap65ivtjvkIivGA%2BmyJc%3D&reserved=0

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-python%2Fpull%2F27337%23pullrequestreview-1170846982&data=05%7C01%7Cqusayalsaifi%40microsoft.com%7C0f03ca7536094d5215df08dac0e8dc1c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638034403620948977%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=UChOBn1oqK3X1ACu0lnlGbeAmmaFDgQqB2%2BDbnKATQs%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA2VMJXAJTKXUK5I454VQXALWHE6WLANCNFSM6AAAAAARZAPTZA&data=05%7C01%7Cqusayalsaifi%40microsoft.com%7C0f03ca7536094d5215df08dac0e8dc1c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638034403620948977%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=zWfatDKA6i5O0qJqaEiJT2eJhQZi%2FG1lIKa4bZvSdaE%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

qusayalsaifi avatar Nov 08 '22 10:11 qusayalsaifi

Hi @qusayalsaifi. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

ghost avatar Feb 10 '23 10:02 ghost

Hi @qusayalsaifi. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

github-actions[bot] avatar Apr 14 '23 05:04 github-actions[bot]

@@.***> agree company="Microsoft"

Qusay Alsaifi Support Engineer Azure Machine Learning Developer Support

+962 (6) 556 4115 Working Hours: Sun - Thu 6AM - 3PM (UTC) Manager: Daniel @.***>

@.***

From: microsoft-github-policy-service[bot] @.> Sent: Friday, April 14, 2023 8:07 AM To: Azure/azure-sdk-for-python @.> Cc: Qusay Alsaifi @.>; Mention @.> Subject: Re: [Azure/azure-sdk-for-python] [ML][Endpoints] Ensure defaults property is instantiated (PR #27337)

@qusayalsaifihttps://github.com/qusayalsaifi please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term "You" includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft" Contributor License Agreement Contribution License Agreement

This Contribution License Agreement ("Agreement") is agreed to by the party signing below ("You"), and conveys certain license rights to Microsoft Corporation and its affiliates ("Microsoft") for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.

  1. Definitions. "Code" means the computer software code, whether in human-readable or machine-executable form, that is delivered by You to Microsoft under this Agreement. "Project" means any of the projects owned or managed by Microsoft and offered under a license approved by the Open Source Initiative (www.opensource.orghttp://www.opensource.org/). "Submit" is the act of uploading, submitting, transmitting, or distributing code or other content to any Project, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of discussing and improving that Project, but excluding communication that is conspicuously marked or otherwise designated in writing by You as "Not a Submission." "Submission" means the Code and any other copyrightable material Submitted by You, including any associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any Project. This Agreement covers any and all Submissions that You, now or in the future (except as described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work. Should You wish to Submit materials that are not Your original work, You may Submit them separately to the Project if You (a) retain all copyright and license information that was in the materials as You received them, (b) in the description accompanying Your Submission, include the phrase "Submission containing materials of a third party:" followed by the names of the third party and any licenses or other restrictions of which You are aware, and (c) follow any other instructions in the Project's written guidelines concerning Submissions.
  4. Your Employer. References to "employer" in this Agreement include Your employer or anyone else for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your Submission is made in the course of Your work for an employer or Your employer has intellectual property rights in Your Submission by contract or applicable law, You must secure permission from Your employer to make the Submission before signing this Agreement. In that case, the term "You" in this Agreement will refer to You and the employer collectively. If You change employers in the future and desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under Your patent claims that are necessarily infringed by the Submission or the combination of the Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above licenses. You represent that each of Your Submissions is entirely Your original work (except as You may have disclosed under Section 3). You represent that You have secured permission from Your employer to make the Submission in cases where Your Submission is made in the course of Your work for Your employer or Your employer has intellectual property rights in Your Submission by contract or applicable law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You have the necessary authority to bind the listed employer to the obligations contained in this Agreement. You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which You later become aware that would make Your representations in this Agreement inaccurate in any respect.
  3. Information about Submissions. You agree that contributions to Projects and information about contributions may be maintained indefinitely and disclosed publicly, including Your name and other information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County, Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and supersedes any and all prior agreements, understandings or communications, written or oral, between the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-sdk-for-python/pull/27337#issuecomment-1507929966, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2VMJXHAA7BEHHC3XL43BSTXBDLQZANCNFSM6AAAAAARZAPTZA. You are receiving this because you were mentioned.Message ID: @.***>

qusayalsaifi avatar Apr 18 '23 11:04 qusayalsaifi

@microsoft-github-policy-service agree company="Microsoft"

Qusay Alsaifi Support Engineer Azure Machine Learning Developer Support

+962 (6) 556 4115 Working Hours: Sun - Thu 6AM - 3PM (UTC) Manager: Daniel @.***>

@.***

From: microsoft-github-policy-service[bot] @.> Sent: Friday, April 14, 2023 8:07 AM To: Azure/azure-sdk-for-python @.> Cc: Qusay Alsaifi @.>; Mention @.> Subject: Re: [Azure/azure-sdk-for-python] [ML][Endpoints] Ensure defaults property is instantiated (PR #27337)

@qusayalsaifihttps://github.com/qusayalsaifi please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term "You" includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft" Contributor License Agreement Contribution License Agreement

This Contribution License Agreement ("Agreement") is agreed to by the party signing below ("You"), and conveys certain license rights to Microsoft Corporation and its affiliates ("Microsoft") for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.

  1. Definitions. "Code" means the computer software code, whether in human-readable or machine-executable form, that is delivered by You to Microsoft under this Agreement. "Project" means any of the projects owned or managed by Microsoft and offered under a license approved by the Open Source Initiative (www.opensource.orghttp://www.opensource.org/). "Submit" is the act of uploading, submitting, transmitting, or distributing code or other content to any Project, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of discussing and improving that Project, but excluding communication that is conspicuously marked or otherwise designated in writing by You as "Not a Submission." "Submission" means the Code and any other copyrightable material Submitted by You, including any associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any Project. This Agreement covers any and all Submissions that You, now or in the future (except as described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work. Should You wish to Submit materials that are not Your original work, You may Submit them separately to the Project if You (a) retain all copyright and license information that was in the materials as You received them, (b) in the description accompanying Your Submission, include the phrase "Submission containing materials of a third party:" followed by the names of the third party and any licenses or other restrictions of which You are aware, and (c) follow any other instructions in the Project's written guidelines concerning Submissions.
  4. Your Employer. References to "employer" in this Agreement include Your employer or anyone else for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your Submission is made in the course of Your work for an employer or Your employer has intellectual property rights in Your Submission by contract or applicable law, You must secure permission from Your employer to make the Submission before signing this Agreement. In that case, the term "You" in this Agreement will refer to You and the employer collectively. If You change employers in the future and desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under Your patent claims that are necessarily infringed by the Submission or the combination of the Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above licenses. You represent that each of Your Submissions is entirely Your original work (except as You may have disclosed under Section 3). You represent that You have secured permission from Your employer to make the Submission in cases where Your Submission is made in the course of Your work for Your employer or Your employer has intellectual property rights in Your Submission by contract or applicable law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You have the necessary authority to bind the listed employer to the obligations contained in this Agreement. You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which You later become aware that would make Your representations in this Agreement inaccurate in any respect.
  3. Information about Submissions. You agree that contributions to Projects and information about contributions may be maintained indefinitely and disclosed publicly, including Your name and other information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County, Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and supersedes any and all prior agreements, understandings or communications, written or oral, between the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-sdk-for-python/pull/27337#issuecomment-1507929966, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2VMJXHAA7BEHHC3XL43BSTXBDLQZANCNFSM6AAAAAARZAPTZA. You are receiving this because you were mentioned.Message ID: @.***>

qusayalsaifi avatar Apr 19 '23 07:04 qusayalsaifi

Hi @qusayalsaifi. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

github-actions[bot] avatar Jun 23 '23 05:06 github-actions[bot]

Hi @qusayalsaifi. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

github-actions[bot] avatar Jun 30 '23 08:06 github-actions[bot]