azure-sdk-for-python icon indicating copy to clipboard operation
azure-sdk-for-python copied to clipboard

[Tables] Make delete_entity also convert Partition/RowKey to string when TableEntity is passed

Open mtin opened this issue 3 years ago • 2 comments

Description

This pull request makes delete_entity do the same conversion of all properties of the TableEntity into string as the other methods (via _add_entity_properties e.g. create_entity, upsert_entity) to allow passing a TableEntity with non-string Partition/RowKey

See https://github.com/Azure/azure-sdk-for-python/issues/26360

All SDK Contribution checklist:

  • [x] The pull request does not introduce [breaking changes]
  • [x] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [x] I have read the contribution guidelines.

General Guidelines and Best Practices

  • [x] Title of the pull request is clear and informative.
  • [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [ ] Pull request includes test coverage for the included changes.
    • I did add tests, did not get them to run though; hoping for pipelines here :)

mtin avatar Sep 22 '22 11:09 mtin

Thank you for your contribution mtin! We will review the pull request and get back to you soon.

ghost avatar Sep 22 '22 11:09 ghost

CLA assistant check
All CLA requirements met.

ghost avatar Sep 22 '22 11:09 ghost

Hi @mtin thanks for your contribution! The PR is currently in draft, I'm not sure if you are preparing it. Could you please fix the failing CI? Or I can help the rest with your permission granted in your GitHub branch.

Thanks

YalinLi0312 avatar Sep 28 '22 01:09 YalinLi0312

Thank you for getting back to me @YalinLi0312! I was unsure if the proposed changes are desired at all; There were no further answers at https://github.com/Azure/azure-sdk-for-python/issues/26360. I also could not really make sense of the failing pipelines, I would be grateful if you could assist. I have granted you permission to my fork!

mtin avatar Sep 29 '22 14:09 mtin

Thank you for getting back to me @YalinLi0312! I was unsure if the proposed changes are desired at all; There were no further answers at #26360. I also could not really make sense of the failing pipelines, I would be grateful if you could assist. I have granted you permission to my fork!

I have accepted your invitation. No worries, I'll help on the rest. Thanks

YalinLi0312 avatar Sep 29 '22 18:09 YalinLi0312

/azp run python - tables - test

annatisch avatar Oct 20 '22 07:10 annatisch

No pipelines are associated with this pull request.

azure-pipelines[bot] avatar Oct 20 '22 07:10 azure-pipelines[bot]

/azp run python - tables - tests

annatisch avatar Oct 20 '22 07:10 annatisch

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 20 '22 07:10 azure-pipelines[bot]

@microsoft-github-policy-service agree

mtin avatar Oct 20 '22 12:10 mtin

Close it as we will fix the UUID type issue in our new serialization design, thanks for your contribution as well @mtin

YalinLi0312 avatar Nov 30 '22 23:11 YalinLi0312