azure-sdk-for-python icon indicating copy to clipboard operation
azure-sdk-for-python copied to clipboard

Published 20 hours ago • verified publisher icon Azure

Dont default to RequestsTransport

Open Stevenjin8 opened this issue 3 years ago • 3 comments

Description

Fix for #25533

All SDK Contribution checklist:

  • [x] The pull request does not introduce [breaking changes]
  • [ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [x] I have read the contribution guidelines.

General Guidelines and Best Practices

  • [x] Title of the pull request is clear and informative.
  • [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [x] Pull request includes test coverage for the included changes.

Stevenjin8 avatar Aug 09 '22 16:08 Stevenjin8

unsure how to test this

Stevenjin8 avatar Aug 09 '22 16:08 Stevenjin8

/azp run python - keyvault - ci

Stevenjin8 avatar Aug 09 '22 20:08 Stevenjin8

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 09 '22 20:08 azure-pipelines[bot]

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-keyvault-certificates azure-keyvault-keys azure-keyvault-secrets

azure-sdk avatar Aug 18 '22 20:08 azure-sdk

Looks good to me! Thanks again for tackling this 🙂

Thanks @mccoyp. Please merge at your convenience.

Stevenjin8 avatar Aug 18 '22 21:08 Stevenjin8