azure-sdk-for-python icon indicating copy to clipboard operation
azure-sdk-for-python copied to clipboard

[Eventgrid] Fixed spelling erros

Open wonhyeongseo opened this issue 3 years ago • 1 comments

Description

Closes: https://github.com/Azure/azure-sdk-for-python/issues/22647

All SDK Contribution checklist:

  • [x] The pull request does not introduce [breaking changes]
  • [x] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [x] I have read the contribution guidelines.

General Guidelines and Best Practices

  • [x] Title of the pull request is clear and informative.
  • [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [x] Pull request includes test coverage for the included changes.

wonhyeongseo avatar Aug 09 '22 07:08 wonhyeongseo

Thank you for your contribution wonhyeongseo! We will review the pull request and get back to you soon.

ghost avatar Aug 09 '22 07:08 ghost

@danieljurek Hello sir, may you please review my PR?

wonhyeongseo avatar Aug 17 '22 07:08 wonhyeongseo

@wonhyeongseo The build is failing due to a min dependency issue with msrest Can you update the msrest version in this PR for eventgrid? https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/eventgrid/azure-eventgrid/setup.py#L69

The conflict is caused by:
    The user requested msrest==0.6.21
    azure-mgmt-eventgrid 10.2.0 depends on msrest>=0.7.1

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

rakshith91 avatar Sep 07 '22 05:09 rakshith91

/azp run python - eventgrid - ci

xiangyan99 avatar Oct 07 '22 16:10 xiangyan99

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 07 '22 16:10 azure-pipelines[bot]