azure-sdk-for-python icon indicating copy to clipboard operation
azure-sdk-for-python copied to clipboard

[Azure Maps] - Onboarding/Signoff for Search SDKs

Open alextts627 opened this issue 3 years ago • 13 comments

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • [x] The pull request does not introduce [breaking changes]
  • [x] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [x] I have read the contribution guidelines.

General Guidelines and Best Practices

  • [x] Title of the pull request is clear and informative.
  • [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [x] Pull request includes test coverage for the included changes.

APIview

Previous APIView

alextts627 avatar Jun 23 '22 01:06 alextts627

/azp run prepare-pipelines

alextts627 avatar Jun 23 '22 01:06 alextts627

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 23 '22 01:06 azure-pipelines[bot]

/azp run python - maps - tests

alextts627 avatar Jun 23 '22 01:06 alextts627

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 23 '22 01:06 azure-pipelines[bot]

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-maps azure-maps azure-maps-search

azure-sdk avatar Jun 23 '22 02:06 azure-sdk

/azp run python - maps - tests

dubiety avatar Jun 30 '22 22:06 dubiety

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 30 '22 22:06 azure-pipelines[bot]

/azp run python - maps - tests

alextts627 avatar Jul 04 '22 01:07 alextts627

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 04 '22 01:07 azure-pipelines[bot]

/azp run python - maps - tests

alextts627 avatar Jul 04 '22 07:07 alextts627

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 04 '22 07:07 azure-pipelines[bot]

Here's the canonical APIView for this PR. Thanks to @praveenkuttappan for regenerating it: https://apiview.dev/Assemblies/Review/2e965048972a47c1aee8b731feca4078

tjprescott avatar Aug 05 '22 22:08 tjprescott

Here's the canonical APIView for this PR. Thanks to @praveenkuttappan for regenerating it: https://apiview.dev/Assemblies/Review/2e965048972a47c1aee8b731feca4078

Ping

alextts627 avatar Aug 31 '22 17:08 alextts627

I think this is definitely ready for preview. Thanks @alextts627 for your hard work on this and all the Maps Python SDKs!

Thank you @tjprescott and @annatisch for all the support and help!

alextts627 avatar Aug 31 '22 19:08 alextts627