azure-sdk-for-python icon indicating copy to clipboard operation
azure-sdk-for-python copied to clipboard

[core] add async test for offline test_compress_compressed_no_header_offline

Open iscai-msft opened this issue 3 years ago • 9 comments

Right now we only have the sync test for test_compress_compressed_no_header_offline. Please see the original here,

cc @marcusc2

iscai-msft avatar May 02 '22 23:05 iscai-msft

@kristapratico assigning you because I can't assign one of the impact students

iscai-msft avatar May 03 '22 00:05 iscai-msft

@marcusc2 is working on this issue

kristapratico avatar Jun 03 '22 21:06 kristapratico

Hey @kristapratico , it this issue still up for grabs?? . If so I would love to work on this. I would just need a little help with the setup. but I am eager to contribute.

HimanshuBarak avatar Jan 07 '24 14:01 HimanshuBarak

@HimanshuBarak I don't believe anyone is working on this issue, so feel free to give it a try and let us know if you have any questions.

kristapratico avatar Jan 08 '24 18:01 kristapratico

Hey @kristapratico I have cloned the repo and written the test. The test is successfully raising the UnicodeDecodeError error. Can I directly raise the PR ? or are there any other tests requisite I need to test first?

HimanshuBarak avatar Jan 10 '24 18:01 HimanshuBarak

@HimanshuBarak feel free to open it and just tag this issue in the description. If anything else is needed by the reviewers we can cover that in the PR. Thanks!

kristapratico avatar Jan 10 '24 18:01 kristapratico

Hey @kristapratico I have raised the PR https://github.com/Azure/azure-sdk-for-python/pull/33800. However I see some of the checks are failing. Are all of these checks mandatory ? Also is there a way to run these checks locally using tox?? Asking to know how I should proceed to debug them.

HimanshuBarak avatar Jan 11 '24 08:01 HimanshuBarak

Hey @HimanshuBarak, you can run the checks locally with tox. Here are instructions on how to do that. It is possible that the errors are unrelated to your PR. I believe there are currently a few core tests failing that we are working on fixing ASAP. The reviewers should be able to help distinguish the relevant errors from the unrelated ones.

kristapratico avatar Jan 11 '24 18:01 kristapratico

Sounds good @kristapratico . I will try to debug on my end. Meanwhile I will look around to see I could contribute anywhere else. Do you have any suggestions for any other similar issues??. I am looking to be a first time contributor to open source and am super eager to learn.

HimanshuBarak avatar Jan 11 '24 19:01 HimanshuBarak

@HimanshuBarak Any issues tagged with help wanted or good first issue labels are a good place to start. I've also updated the issue about making core tests offline to include which tests still need to be converted: https://github.com/Azure/azure-sdk-for-python/issues/9324#issuecomment-1888077552

kristapratico avatar Jan 12 '24 17:01 kristapratico

Hi @iscai-msft, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

github-actions[bot] avatar May 03 '24 18:05 github-actions[bot]