azure-sdk-for-net icon indicating copy to clipboard operation
azure-sdk-for-net copied to clipboard

Published 20 hours ago • verified publisher icon Azure

Add latest CosmosDB RP API Version 2024-09-01-preview

Open carjackson-msft opened this issue 1 year ago • 9 comments

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

carjackson-msft avatar Aug 16 '24 16:08 carjackson-msft

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.CosmosDB

azure-sdk avatar Sep 09 '24 20:09 azure-sdk

Hi @archerzz, could you please assist in reviewing?

ghost avatar Oct 02 '24 15:10 ghost

@archerzz @ArthurMa1978 Can you please review and merge?

pjohari-ms avatar Oct 15 '24 15:10 pjohari-ms

@archerzz @ArthurMa1978 Can you please review and merge?

Generally good. Left some comments.

archerzz avatar Oct 16 '24 02:10 archerzz

@archerzz Resolved all comments. Please take a look again and merge if it looks good.

pjohari-ms avatar Oct 16 '24 17:10 pjohari-ms

@archerzz Resolved all comments. Please take a look again and merge if it looks good.

@carjackson-msft There is one enum to rename: SupportAction. Also please resolve the conflicts. Thanks.

archerzz avatar Oct 17 '24 02:10 archerzz

@archerzz Resolved and merge with master.

pjohari-ms avatar Oct 18 '24 01:10 pjohari-ms

@archerzz Resolved and merge with master.

@carjackson-msft the pipeline failed, please check the build logs. looks like you need to regenerate the codes.

Generated code is not up to date. You may need to rebase on the latest main, run 'eng\scripts\Update-Snippets.ps1' if you modified sample snippets or other *.md files (https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#updating-sample-snippets), run 'eng\scripts\Export-API.ps1' if you changed public APIs (https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#public-api-additions). run 'dotnet build /t:GenerateCode' to update the generated code and samples.

To reproduce this error locally, run 'eng\scripts\CodeChecks.ps1 -ServiceDirectory cosmosdb'.

archerzz avatar Oct 21 '24 02:10 archerzz

@carjackson-msft The test recordings are out-of-date. You need to re-record some tests. Please check the error logs: https://dev.azure.com/azure-sdk/public/_build/results?buildId=4256133&view=logs&jobId=48e16184-ebea-53b1-0660-f349545896e8&j=48e16184-ebea-53b1-0660-f349545896e8&t=648d79f2-01b5-5b89-6c0b-97898f6bef3a

archerzz avatar Oct 23 '24 01:10 archerzz

Hi @archerzz, I have re-recorded all tests and verified they pass locally on playback. I can also see that all checks are passing. Could you please help in merging? CC: @pjohari-ms

ghost avatar Oct 30 '24 22:10 ghost