azure-sdk-for-net icon indicating copy to clipboard operation
azure-sdk-for-net copied to clipboard

Published 20 hours ago • verified publisher icon Azure

House or house?

Open mikeblakeuk opened this issue 1 year ago • 1 comments

https://github.com/Azure/azure-sdk-for-net/blob/92c30eb92baf8373206834fca1eb996458c32917/sdk/datafactory/Azure.ResourceManager.DataFactory/src/Generated/Models/LakeHouseTableDataset.cs#L20

Should it be LakeHouse or Lakehouse?

as per https://github.com/MicrosoftDocs/azure-docs/issues/122106

mikeblakeuk avatar Apr 30 '24 13:04 mikeblakeuk

Thank you for your feedback. Tagging and routing to the team member best able to assist.

github-actions[bot] avatar Apr 30 '24 13:04 github-actions[bot]

Add @ruowan , it's LakeHouse defined in swagger spec, so might be fixed from swagger spec if it should be Lakehouse.

ArthurMa1978 avatar May 06 '24 06:05 ArthurMa1978

We're preparing a PR to fix the naming from LakeHouse to Lakehouse, thanks.

JaylenZ8 avatar May 08 '24 07:05 JaylenZ8

According to the Azure breaking change policy, changing the name is breaking change for customer. So close this issue. If any other concern, pls reopen this.

ruowan avatar May 14 '24 08:05 ruowan

But the bot broke the name when it fixed the spelling. What does the server side expect? Why is there a mix of Lakehouse and LakeHouse?

mikeblakeuk avatar May 14 '24 08:05 mikeblakeuk

Can this be reopened? That would help this PR https://github.com/Azure/azure-sdk-for-net/pull/44121

mikeblakeuk avatar May 20 '24 08:05 mikeblakeuk