azure-sdk-for-js icon indicating copy to clipboard operation
azure-sdk-for-js copied to clipboard

[monitor-opentelemetry-exporter] Adopt OpenTelemetry HTTP semconv 1.23.1

Open hectorhdzg opened this issue 1 year ago • 5 comments

https://opentelemetry.io/blog/2023/http-conventions-declared-stable/

hectorhdzg avatar Mar 22 '24 16:03 hectorhdzg

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @cijothomas @rajkumar-rangaraj @ramthi @reyang @TimothyMothra @vishweshbankwar.

github-actions[bot] avatar Mar 22 '24 16:03 github-actions[bot]

@hectorhdzg, can you investigate why the .NET crew is getting assigned to JS issues? :)

TimothyMothra avatar Mar 22 '24 16:03 TimothyMothra

@TimothyMothra sounds like a github-actions misconfiguration, :) I was going to ask you guys the same thing. Let me see if I find some reference.

hectorhdzg avatar Mar 22 '24 16:03 hectorhdzg

This looks sus: https://github.com/Azure/azure-sdk-for-js/blob/37e3efd7bf2c29c6e6247a1d35fea6988989f38c/.github/CODEOWNERS#L1211-L1212

TimothyMothra avatar Mar 22 '24 16:03 TimothyMothra

@TimothyMothra that text is apparently is commented out, so not sure why this is triggering, @xirzec any idea about this?, I can update owners there if this is by design.

hectorhdzg avatar Mar 22 '24 17:03 hectorhdzg

@hectorhdzg I agree with @TimothyMothra that it is "sus". The double @ is odd and the owners don't seem correct. I'd also think we should tie this to the actual directory path, rather than being a <NotInRepo> comment:

/sdk/monitor/monitor-opentelemetry-exporter @hectorhdzg @JacksonWeber

Feel free to PR an update and I will approve!

xirzec avatar May 20 '24 19:05 xirzec

@xirzec created following PR

hectorhdzg avatar May 20 '24 22:05 hectorhdzg

Up to date sem conv has already been adopted. Closing this issue.

JacksonWeber avatar Sep 25 '25 23:09 JacksonWeber