azure-sdk-for-java
azure-sdk-for-java copied to clipboard
Azure
Keep db.cosmosdb.* attributes
the reason why we don't emit it earlier because db.cosmosdb.* is still Experimental. why are we breaking this rule? can we just update the docs and till db semconv becomes stable at the end of this month?
the reason why we don't emit it earlier because db.cosmosdb.* is still
Experimental. why are we breaking this rule? can we just update the docs and till db semconv becomes stable at the end of this month?
good point
cosmosdb semconv attributes aren't going to be stable with the initial db stability wave, but hopefully will be soon after
cc @lmolkova @jcocchi
@lmolkova @jcocchi @FabianMeiswinkel I forget if there are pending cosmosdb attribute renames? if so, it may be better for us to wait on this PR until after those are made, so we don't introduce potentially breaking changes to our users
I believe CosmosDB for java will remain on the existing version of semconv (1.23.0?) for a while. Based on the previous discussions with @FabianMeiswinkel they'd implement their own back-compat transition plan.
Plus we have ability to rename attribute names coming from the SDK inside azure-core-tracing-otel.
Having said that, I'm going to defer to @jcocchi and @FabianMeiswinkel
Hi @trask. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I believe CosmosDB for java will remain on the existing version of semconv (1.23.0?) for a while. Based on the previous discussions with @FabianMeiswinkel they'd implement their own back-compat transition plan.
Plus we have ability to rename attribute names coming from the SDK inside azure-core-tracing-otel.
Having said that, I'm going to defer to @jcocchi and @FabianMeiswinkel
Correct - we will keep the semconv for the forseeable future and since moving to new version would already be breaking for customers we will use a back-compatibility plan (first deprecating and making new version opt-in while keeping old version etc.) - so, no need to wait/block on this.
Hi @trask. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.
Hi @trask. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.