azure-sdk-for-java icon indicating copy to clipboard operation
azure-sdk-for-java copied to clipboard

Support azure-json in azure-core-management

Open alzimmermsft opened this issue 1 year ago • 3 comments

Description

Serializable model types in azure-core-management now implement JsonSerializable to support azure-json.

All SDK Contribution checklist:

  • [x] The pull request does not introduce [breaking changes]
  • [x] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [x] I have read the contribution guidelines.

General Guidelines and Best Practices

  • [x] Title of the pull request is clear and informative.
  • [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [x] Pull request includes test coverage for the included changes.

alzimmermsft avatar Jan 16 '24 15:01 alzimmermsft

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-core com.azure:azure-core-management

azure-sdk avatar Jan 16 '24 15:01 azure-sdk

@weidongxu-microsoft, it looks this PR may require a code generation update to resource manager libraries alongside with the changes made.

alzimmermsft avatar Jan 17 '24 16:01 alzimmermsft

@weidongxu-microsoft, it looks this PR may require a code generation update to resource manager libraries alongside with the changes made.

Yes, some change would affect / get affected by codegen change. E.g. for Resource we may want a protected ctor, or 3 protected setter (the choice would interfere with codegen when it generates the subclass of Resource -- so far mgmt does not use ctor with required parameters).

I am OK with current code though. It does not add protected API so far, so we can delay the change till we design codegen.

weidongxu-microsoft avatar Jan 18 '24 02:01 weidongxu-microsoft