azure-sdk-for-go icon indicating copy to clipboard operation
azure-sdk-for-go copied to clipboard

[azeventhubs] Breaking change required to accomodate offsets that are _truly_ strings

Open richardpark-msft opened this issue 1 year ago • 3 comments

Event Hubs events have an 'Offset' property, which has been typed as a integer in our SDK, but is actually (on the wire) a string.

This is incorrect and based on upcoming features, we need to do a breaking change to the API surface, where Offset will be properly typed as a 'string' and match the underlying protocol.

This will involve changes in the following places:

  • ReceivedEventData.Offset, int64 -> string
  • Checkpoint.Offset *int64 -> *string
  • PartitionProperties.LastEnqueuedOffset int64 -> string
  • StartPosition.Offset *int64 -> *string

(there might be others, but these are definitely the most obvious ones)

richardpark-msft avatar Sep 25 '24 23:09 richardpark-msft

Thank you for your feedback. Tagging and routing to the team member best able to assist.

github-actions[bot] avatar Sep 25 '24 23:09 github-actions[bot]

What's driving this requirement, is it the ability to specify values that aren't numeric?

jhendrixMSFT avatar Sep 26 '24 13:09 jhendrixMSFT

Yes. They’re going to start encoding more information in there.


From: Joel Hendrix @.> Sent: Thursday, September 26, 2024 6:53 AM To: Azure/azure-sdk-for-go @.> Cc: Author @.>; Assign @.> Subject: Re: [Azure/azure-sdk-for-go] [azeventhubs] Breaking change required to accomodate offsets that are truly strings (Issue #23498)

What's driving this requirement, is it the ability to specify values that aren't numeric?

— Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-sdk-for-go/issues/23498#issuecomment-2377042337 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMI4AGGDWVCPPF2DCOGXTLTZYQGT3BFKMF2HI4TJMJ2XIZLTSWBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVIYTANRSHA2TKMJWGGSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRRGM3DSNZRGI3DINVENZQW2ZNJNBQXGX3MMFRGK3FMON2WE2TFMN2F65DZOBS2YSLTON2WKQ3PNVWWK3TUUZ2G64DJMNZZJAVEOR4XAZNKOJSXA33TNF2G64TZUV3GC3DVMWUDEMRYGU2TENBQQKSHI6LQMWSWS43TOVS2K5TBNR2WLKRSGU2DSMJUGE2TMN4CUR2HS4DFUVWGCYTFNSSXMYLMOVS2UMJQGYZDQNJVGE3DDAVEOR4XAZNFNRQWEZLMUV3GC3DVMWVDCMZWHE3TCMRWGQ3KO5DSNFTWOZLSUZRXEZLBORSQ. You are receiving this email because you authored the thread.

Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

richardpark-msft avatar Sep 26 '24 16:09 richardpark-msft

This has been released: https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/messaging/azeventhubs/v2#section-readme

richardpark-msft avatar Jul 11 '25 01:07 richardpark-msft