azure-sdk-for-go icon indicating copy to clipboard operation
azure-sdk-for-go copied to clipboard

Updating to Joel's latest PR for go-amqp that removes the session mux

Open richardpark-msft opened this issue 3 years ago • 4 comments

richardpark-msft avatar Jul 21 '22 20:07 richardpark-msft

@jhendrixMSFT , getting a failure with your latest patch, specifically when using websockets:

=== RUN TestNewClientWithWebsockets /home/ripark/src/_/sb-test-latest-go-amqp/sdk/messaging/azservicebus/client_test.go:110: Error Trace: client_test.go:110 Error: Received unexpected error: (connlost): invalid protoHeader Test: TestNewClientWithWebsockets

richardpark-msft avatar Jul 21 '22 20:07 richardpark-msft

@richardpark-msft where can I find more info on the failing test?

jhendrixMSFT avatar Jul 21 '22 20:07 jhendrixMSFT

@richardpark-msft I have a repro now, investigating...

jhendrixMSFT avatar Jul 21 '22 20:07 jhendrixMSFT

@richardpark-msft fix applied, great catch.

jhendrixMSFT avatar Jul 21 '22 23:07 jhendrixMSFT

Hi @richardpark-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

msftbot[bot] avatar Sep 23 '22 10:09 msftbot[bot]

Hi @richardpark-msft. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

msftbot[bot] avatar Sep 30 '22 11:09 msftbot[bot]