azure-sdk-for-cpp

azure-sdk-for-cpp copied to clipboard

Integrate CMake formatter similar to clang-format for C++ code

1

Maybe we should use some format tools for CMake files as well (we already have it for .hpp and .cpp). [cmake-format](https://cmake-format.readthedocs.io/en/latest/) is a good candidate, I always use it for...

antkmsft

I'm not looking at this in comparison, just thinking for the angle of diagnosability. If no other component does this, then I think they should. But Identity does :) It...

LarryOsterman

Headers should not depend on whether any other header is included already. Writing `#include ` should not result in a compilation error. (This kind of came up/was noticed in PR...

antkmsft

We have a customer who is using Clang on Windows (#5123). We had a compilation error which we could've caught if we were compiling on Windows with anything but MSVC....

antkmsft

Pick one `std::(u)intX_t` vs `(u)intX_t`, `std::size_t` vs `size_t`, ptrdiff_t, etc, and update the sources to use that one form

1

Additionally, scan if we use `NULL` (in non-3rd party source) and update to `nullptr`.

antkmsft

We do friends, we do "`class C #ifndef (TESTS) final #endif {`", maybe some other approaches. In a few places we have virtual functions, but they are only the test...

antkmsft

Update guidelines to allow `internal` directory in the library source structure

3

`samples/internal` was chosen because the hierarchy of folders in the repo is: - `sdk//` - inc - samples - src - tests - vcpkg And who knows - there might...

antkmsft

We are missing copyright header comment here. _Originally posted by @ahsonkhan in https://github.com/Azure/azure-sdk-for-cpp/pull/5078#discussion_r1375106103_

LarryOsterman

Add a virtual ShouldRetry method to the RetryPolicy for customization.

1

Fixes https://github.com/Azure/azure-sdk-for-cpp/issues/5515 Related discussion: https://github.com/Azure/azure-sdk-for-cpp/pull/5530#issuecomment-2076038171 Given this is not meant for end customers to modify, I did not add it to the changelog to avoid highlighting it. cc @Jinming-Hu Here...

ahsonkhan

In the style of https://github.com/Azure/azure-sdk-tools/pull/8076/files

danieljurek