azure-sdk-for-cpp icon indicating copy to clipboard operation
azure-sdk-for-cpp copied to clipboard

Take care of the error reported in cpp

Open sima-zhu opened this issue 3 years ago • 3 comments

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1513274&view=logs&j=a129effc-2dd1-54d1-fb5a-ad7bdc0e851d&t=9036d097-2774-5136-505e-b4dc0a37f42d&l=56

sima-zhu avatar Apr 19 '22 18:04 sima-zhu

Error count went from 5 to 4 in a recent run. I think we need to update CredScanSuppression.json:

##[error]1. Credential Scanner Error CSCAN-GENERAL0020 - File: sdk/attestation/azure-security-attestation/test/ut/crypto_test.cpp:sdk/attestation/azure-security-attestation/test/ut/crypto_test.cpp. Line: 16. Column 46. 
  Tool: Credential Scanner: Rule: CSCAN-GENERAL0020 (X.509 Certificate Private Key). https://aka.ms/credscan
  A potential secret was detected in 'crypto_test.cpp':(CSCAN-GENERAL0020 X.509 Certificate Private Key) Validate file contains secrets, remove, roll credential, and use approved store. For additional information on secret remediation see https://aka.ms/credscan.
##[error]2. Credential Scanner Error CSCAN-GENERAL0020 - File: sdk/attestation/azure-security-attestation/test/ut/crypto_test.cpp:sdk/attestation/azure-security-attestation/test/ut/crypto_test.cpp. Line: 28. Column 45. 
  Tool: Credential Scanner: Rule: CSCAN-GENERAL0020 (X.509 Certificate Private Key). https://aka.ms/credscan
  A potential secret was detected in 'crypto_test.cpp':(CSCAN-GENERAL0020 X.509 Certificate Private Key) Validate file contains secrets, remove, roll credential, and use approved store. For additional information on secret remediation see https://aka.ms/credscan.
##[error]3. Credential Scanner Error CSCAN-GENERAL0020 - File: sdk/keyvault/azure-security-keyvault-certificates/test/ut/recordings/KeyVaultCertificateClientTest.DownloadImportPem.json:sdk/keyvault/azure-security-keyvault-certificates/test/ut/recordings/KeyVaultCertificateClientTest.DownloadImportPem.json. Line: 149. Column 30. 
  Tool: Credential Scanner: Rule: CSCAN-GENERAL0020 (X.509 Certificate Private Key). https://aka.ms/credscan
  A potential secret was detected in 'KeyVaultCertificateClientTest.DownloadImportPem.json':(CSCAN-GENERAL0020 X.509 Certificate Private Key) Validate file contains secrets, remove, roll credential, and use approved store. For additional information on secret remediation see https://aka.ms/credscan.
##[error]4. Credential Scanner Error CSCAN-GENERAL0020 - File: sdk/keyvault/azure-security-keyvault-certificates/test/ut/recordings/KeyVaultCertificateClientTest.DownloadImportPkcs.json:sdk/keyvault/azure-security-keyvault-certificates/test/ut/recordings/KeyVaultCertificateClientTest.DownloadImportPkcs.json. Line: 149. Column 30. 
  Tool: Credential Scanner: Rule: CSCAN-GENERAL0020 (X.509 Certificate Private Key). https://aka.ms/credscan
  A potential secret was detected in 'KeyVaultCertificateClientTest.DownloadImportPkcs.json':(CSCAN-GENERAL0020 X.509 Certificate Private Key) Validate file contains secrets, remove, roll credential, and use approved store. For additional information on secret remediation see https://aka.ms/credscan.
  Active results: 4

danieljurek avatar Apr 27 '22 13:04 danieljurek

Unassigning, adding Client tag. These will need to be updated by C++ owners.

danieljurek avatar Apr 29 '22 13:04 danieljurek

@gearama Please address the remaining cred scan issues so the CI gate can be enabled.

RickWinter avatar Oct 10 '22 18:10 RickWinter

This was fixed and credscan was added in https://github.com/Azure/azure-sdk-for-cpp/pull/4328

danieljurek avatar Feb 02 '23 22:02 danieljurek