azure-sdk-for-cpp icon indicating copy to clipboard operation
azure-sdk-for-cpp copied to clipboard

Credscan the entire repo

Open sima-zhu opened this issue 3 years ago • 13 comments

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

  • [ ] C++ Guidelines
  • [ ] Doxygen docs
  • [ ] Unit tests
  • [ ] No unwanted commits/changes
  • [ ] Descriptive title/description
    • [ ] PR is single purpose
    • [ ] Related issue listed
  • [ ] Comments in source
  • [ ] No typos
  • [ ] Update changelog
  • [ ] Not work-in-progress
  • [ ] External references or docs updated
  • [ ] Self review of PR done
  • [ ] Any breaking changes?

sima-zhu avatar Mar 01 '22 17:03 sima-zhu

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1513274&view=logs&j=a129effc-2dd1-54d1-fb5a-ad7bdc0e851d&t=9036d097-2774-5136-505e-b4dc0a37f42d

sima-zhu avatar Apr 18 '22 20:04 sima-zhu

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1516538&view=results

sima-zhu avatar Apr 19 '22 23:04 sima-zhu

/azp run cpp - core - ci

danieljurek avatar May 23 '22 18:05 danieljurek

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 23 '22 18:05 azure-pipelines[bot]

Credscan results -- https://dev.azure.com/azure-sdk/public/_build/results?buildId=1594399&view=logs&j=a129effc-2dd1-54d1-fb5a-ad7bdc0e851d&t=9036d097-2774-5136-505e-b4dc0a37f42d

##[error]1. Credential Scanner Error CSCAN-GENERAL0020 - File: sdk/attestation/azure-security-attestation/test/ut/crypto_test.cpp:sdk/attestation/azure-security-attestation/test/ut/crypto_test.cpp. Line: 16. Column 46. 

##[error]2. Credential Scanner Error CSCAN-GENERAL0020 - File: sdk/attestation/azure-security-attestation/test/ut/crypto_test.cpp:sdk/attestation/azure-security-attestation/test/ut/crypto_test.cpp. Line: 28. Column 45. 

##[error]3. Credential Scanner Error CSCAN-GENERAL0020 - File: sdk/keyvault/azure-security-keyvault-certificates/test/ut/recordings/KeyVaultCertificateClientTest.DownloadImportPem.json:sdk/keyvault/azure-security-keyvault-certificates/test/ut/recordings/KeyVaultCertificateClientTest.DownloadImportPem.json. Line: 149. Column 30. 

##[error]4. Credential Scanner Error CSCAN-GENERAL0020 - File: sdk/keyvault/azure-security-keyvault-certificates/test/ut/recordings/KeyVaultCertificateClientTest.DownloadImportPkcs.json:sdk/keyvault/azure-security-keyvault-certificates/test/ut/recordings/KeyVaultCertificateClientTest.DownloadImportPkcs.json. Line: 149. Column 30. 

danieljurek avatar May 23 '22 19:05 danieljurek

/azp run cpp - core - ci

sima-zhu avatar Jun 01 '22 00:06 sima-zhu

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 01 '22 00:06 azure-pipelines[bot]

/azp run cpp - core - ci

sima-zhu avatar Jun 01 '22 16:06 sima-zhu

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 01 '22 16:06 azure-pipelines[bot]

https://dev.azure.com/azure-sdk/public/_build/results?buildId=1613795&view=logs&j=a129effc-2dd1-54d1-fb5a-ad7bdc0e851d&t=9036d097-2774-5136-505e-b4dc0a37f42d

sima-zhu avatar Jun 02 '22 15:06 sima-zhu

https://dev.azure.com/azure-sdk/public/_build/results?buildId=1617163&view=results

sima-zhu avatar Jun 02 '22 21:06 sima-zhu

@sima-zhu Can you complete this PR and enable the process? If this is no longer applicable work, the PR should be closed.

ping: @sima-zhu

RickWinter avatar Jul 06 '22 18:07 RickWinter

Pre-requisite: https://github.com/Azure/azure-sdk-for-cpp/issues/3837

@RickWinter I will enable the PR validation once the errors get cleanup. :)

sima-zhu avatar Jul 18 '22 17:07 sima-zhu

Hi @sima-zhu. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

ghost avatar Sep 23 '22 10:09 ghost

Hi @sima-zhu. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

ghost avatar Sep 30 '22 11:09 ghost