Azure
Update metrics API limit descriptions
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Next Steps to Merge
✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Go | sdk/resourcemanager/monitor/armmonitor | https://apiview.dev/Assemblies/Review/14110b73692e404ca82e994b5fe313ad?revisionId=960d496464d74004bd5e709c1f3f1d69 |
| JavaScript | @azure/arm-monitor | https://apiview.dev/Assemblies/Review/6bb257ec6c7a48e3812505db443df4ae?revisionId=8fbe22b8347a4413bb1e4de8705566f8 |
| .Net | Azure.Monitor.Query | There is no API change compared with the previous version |
| .Net | Azure.ResourceManager.Monitor | There is no API change compared with the previous version |
Can I get a bypass on all of these? As you can see I've only updated descriptions, that should not be failing any model validation etc checks.
API change check
APIView has identified API level changes in this PR and created following API reviews.
Microsoft.Insights Microsoft.Monitor
Hmmm I think lintdiff is failing due to this error 2024-12-02T18:03:58.3631646Z Count of AutoRest exceptions found in the LintDiff stdout or stderr: 6. Context: swagger: specification/monitor/resource-manager/readme.md, beforeOrAfter: before, tag: package-2021-05-metrics, lintDiffStdoutAndStderr.length: 189094.
Specifically these 2 errors: { "type": "AutoRest exception", "message": "Ref '#/parameters/MetricNamesParameter' is not referencing a valid location. paths,/{resourceUri}/providers/Microsoft.Insights/metricBaselines,get,parameters,1", "readmeUrl": "https://github.com/Azure/azure-rest-api-specs/blob/main/specification/monitor/resource-manager/readme.md", "tag": "package-2021-05-metrics", "context": "before" }, { "type": "AutoRest exception", "message": "Ref '#/parameters/MetricNamespaceParameter' is not referencing a valid location. paths,/{resourceUri}/providers/Microsoft.Insights/metricBaselines,get,parameters,2", "readmeUrl": "https://github.com/Azure/azure-rest-api-specs/blob/main/specification/monitor/resource-manager/readme.md", "tag": "package-2021-05-metrics", "context": "before" },
I fixed these in my PR, and don't get these anymore locally but I think lint diff is hitting them when running against the checked in code. I'm not sure how to resolve that, I think I'll need another bypass for that.
posted request for help to API Spec Review channel to get help bypassing this lint diff error
posted request for help to API Spec Review channel to get help bypassing this lint diff error
This was fixed yesterday:
https://github.com/Azure/azure-rest-api-specs/pull/30787/files#diff-264accec1b0fe201eedacac26baaf709a64bed776778f36992c08265ac4b6165L644
If you merge latest main into your branch, your PR should be unblocked from the LintDiff crash. You might need to fix or suppress other (non-crash) errors.
