Sync with RPSaaSMaster for versions 2024-08-01-preview and 2024-10-01-preview
ARM (Control Plane) API Specification Update Pull Request
[!TIP] Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
- [ ] New resource provider.
- [X] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
- [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
- [ ] Update existing version to fix OpenAPI spec quality issues in S360.
- [ ] Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
- [ ] Other, please clarify:
- edit this with your clarification
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:
- [X] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
- [X] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.
Getting help
- First, please carefully read through this PR description, from top to bottom. Please fill out the
Purpose of this PRandDue diligence checklist. - If you don't have permissions to remove or add labels to the PR, request
write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories - To understand what you must do next to merge this PR, see the
Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state. - For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
- For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
- If the PR CI checks appear to be stuck in
queuedstate, please add a comment with contents/azp run. This should result in a new comment denoting aPR validation pipelinehas started and the checks should be updated after few minutes. - If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
Next Steps to Merge
✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Go | sdk/resourcemanager/oracledatabase/armoracledatabase | https://apiview.dev/Assemblies/Review/53fdd016e88740579b30965636095202?revisionId=5a4a4943edf340e3ac0653e74e563892 |
| .Net | Azure.ResourceManager.OracleDatabase | https://apiview.dev/Assemblies/Review/5d282bd7f09a435e84928bd059a01a65?revisionId=5cbd0e7cd1cc48cca96d5dc729fe0b63 |
| Java | azure-resourcemanager-oracledatabase | https://apiview.dev/Assemblies/Review/4b7e98435af54403a2b9808830126451?revisionId=dd7ee00900dc4203a3c747930c4b18fa |
| Python | azure-mgmt-oracledatabase | https://apiview.dev/Assemblies/Review/3697763a9574457abbdc98b9cdac647a?revisionId=3914d65505b6421e9157a01f62074786 |
| JavaScript | @azure/arm-oracledatabase | https://apiview.dev/Assemblies/Review/3d1650b2abad447088f364cf55a11cec?revisionId=b47283d11df9400d84c528b57572fb56 |
| TypeSpec | Oracle.Database.Management | https://apiview.dev/Assemblies/Review/2faf4b6ed221430b9137650d1d5ee620?revisionId=3e7ac050b4174027a6aea4dfed11d08b |
You have a few warnings introduced in the new properties for using booleans here : https://github.com/Azure/azure-rest-api-specs/pull/31058/checks?check_run_id=32233178833
Can you please review and update those to enum since ARM recommends enums over booleans. More details here : https://github.com/Azure/azure-openapi-validator/blob/main/docs/enum-instead-of-boolean.md
This is the PR to syncup with RPSaaSMaster: https://github.com/Azure/azure-rest-api-specs-pr/pull/19700(this one got the approval and merged already)
The suggestion of changing boolean to Enum had been discussed and decision has been made by leadership team.
Evan from MSFT approved the above PR:
I attached the screenshot of the conversation for your reference.
/azp run
Azure Pipelines successfully started running 3 pipeline(s).