moving from private repo to public as part of public preview

[adityareddy305]

ARM (Control Plane) API Specification Update Pull Request

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

• [ ] New resource provider.
• [ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
• [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
• [ ] Update existing version to fix OpenAPI spec quality issues in S360.
• [ ] Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
• [x] Other, please clarify:
  • moving from private repository to public repository as part of public preview

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

• [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
• [x] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
  I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.

Getting help

• First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
• If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
• To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
• For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
• For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
• If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
• If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

[openapi-pipeline-app[bot]]

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

[openapi-pipeline-app[bot]]

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/impact/armimpact	https://apiview.dev/Assemblies/Review/147f96bd01fb441abef9a62d951f4ad0?revisionId=8d2fe30f7e01438b8f879c57cf8d5c4a
Java	azure-resourcemanager-impact	https://apiview.dev/Assemblies/Review/5da77e05bc0d4aac8d5b1953992f47c9?revisionId=e858b64acb1d4ee0b1674baf6142531d
.Net	Azure.ResourceManager.Impact	https://apiview.dev/Assemblies/Review/987727dec37441928f79ed7bc97a430c?revisionId=d7f5f0379f594082aee7bbe0da039ced
JavaScript	@azure/arm-impact	https://apiview.dev/Assemblies/Review/a9eedeb8c28940478057ab682939b5ca?revisionId=3b696fe886554788aa785da97e4f86ec
Swagger	Microsoft.Impact	https://apiview.dev/Assemblies/Review/31eec05b3eac44a19a566f50b3ae78da?revisionId=bdbfd87331e944a09c1d5d748d40d7e2
TypeSpec	Impact.Management	https://apiview.dev/Assemblies/Review/d39e0b3edadd463f894e634e48c78f96?revisionId=3f1f4432b62b406b8e77933f9ff91f06

[adityareddy305]

here is the PR, that was approved in private repo https://github.com/Azure/azure-rest-api-specs-pr/pull/17532

supression PR; https://github.com/Azure/azure-rest-api-specs-pr/pull/13798

[ramoka178]

The Swagger jsons match till today. @adityareddy305 Please fix the Typespec validation and LintDiff errors . If LintDIff cannot be fixed, for your case, try adding suppressions

[adityareddy305]

The Swagger jsons match till today. @adityareddy305 Please fix the Typespec validation and LintDiff errors . If LintDIff cannot be fixed, for your case, try adding suppressions

@ramoka178 Changes made. fixed type spec validation by adding required changes which added readOnly for ProvisoningState in all specs some new header were added to spec 05-2024-preview

added supressions

[ramoka178]

Please fix the required failing check of typespec and also swagger avocado errors

[adityareddy305]

Please fix the required failing check of typespec and also swagger avocado errors

@TimLovellSmith

like we discussed i have added only latest API version (already approved in private repo) that we are enabling for public preview. suppression review need for one additionalProperty(dynamic) so customers can send addition metadata of a resource

[TimLovellSmith]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 2 pipeline(s).

[TimLovellSmith]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 2 pipeline(s).