azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Add cg profile api v2

Open shivg7795 opened this issue 1 year ago • 10 comments

Add CGProfile API specifications in a new version

shivg7795 avatar Oct 07 '24 07:10 shivg7795

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named Swagger PrettierCheck has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

can you please fix the Lint diff errors : https://github.com/Azure/azure-rest-api-specs/pull/30874/checks?check_run_id=31188511734

raosuhas avatar Oct 09 '24 22:10 raosuhas

      "$ref": "#/definitions/Resource"

use the tracked resource definition from common types and remove all other top level definitions from the object


Refers to: specification/containerinstance/resource-manager/Microsoft.ContainerInstance/preview/2024-11-01-preview/containerInstance.json:3348 in 9e43e2e. [](commit_id = 9e43e2e2afa147bdb377acb7b5b75f7099023401, deletion_comment = False)

raosuhas avatar Oct 09 '24 22:10 raosuhas

"NGroupIdentity": {

use commontypes definition


Refers to: specification/containerinstance/resource-manager/Microsoft.ContainerInstance/preview/2024-11-01-preview/containerInstance.json:3353 in 9e43e2e. [](commit_id = 9e43e2e2afa147bdb377acb7b5b75f7099023401, deletion_comment = False)

raosuhas avatar Oct 09 '24 22:10 raosuhas

      "$ref": "#/definitions/Resource"

use the tracked resource definition from common types and remove all other top level definitions from the object

Refers to: specification/containerinstance/resource-manager/Microsoft.ContainerInstance/preview/2024-11-01-preview/containerInstance.json:3348 in 9e43e2e. [](commit_id = 9e43e2e, deletion_comment = False)

The JSON is required by internal customers to see the swagger UI. Hence the references are limited to this file only. For future when we make this to public stable version then we can make these references to common types.

shivg7795 avatar Oct 23 '24 23:10 shivg7795

Can you please fix the newly introduced Lintdiff warnings : https://github.com/Azure/azure-rest-api-specs/pull/30874/checks?check_run_id=32564480702

raosuhas avatar Nov 06 '24 03:11 raosuhas

could you also please fix the older comments I had provided before restarting the ARM review ?

raosuhas avatar Nov 06 '24 03:11 raosuhas