azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Adding support for managed identity for ActionGroups resource type

Open thomasp98296 opened this issue 1 year ago • 7 comments

ARM (Control Plane) API Specification Update Pull Request

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • [ ] New resource provider.
  • [x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • [ ] Update existing version to fix OpenAPI spec quality issues in S360.
  • [ ] Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • [ ] Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

  • [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [x] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

thomasp98296 avatar Oct 05 '24 05:10 thomasp98296

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Next Steps to Merge

Next steps that must be taken to merge this PR:

  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-reviewFor details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named Swagger LintDiff has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Hi @rkmanda - Since you initially reviewed this same change in the PR branch, could you help review this please? Thanks!

BTW, the Swagger LintDiff failures are not introduced by this change. Thanks!

thomasp98296 avatar Oct 05 '24 06:10 thomasp98296

Thank you, @raosuhas, for reviewing and signing off on the changes. How do I get this merge? Do I need another reviewer to approve? Thank you!

@rkmanda , @akshitgoyal , @avjerafi - could you please help to review this PR? Thank you so much.

thomasp98296 avatar Oct 15 '24 18:10 thomasp98296

Thank you, @raosuhas, for reviewing and signing off on the changes. How do I get this merge? Do I need another reviewer to approve? Thank you!

@rkmanda , @akshitgoyal , @avjerafi - could you please help to review this PR? Thank you so much.

@raosuhas , could you advise me what else do I need to have this merge? The "Swagger LintDiff" failures are not introduced by my changes?

Thank you!

thomasp98296 avatar Oct 16 '24 05:10 thomasp98296

/azp run

thomasp98296 avatar Oct 23 '24 18:10 thomasp98296

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 23 '24 18:10 azure-pipelines[bot]

Approving suppressions since they are not related to the current PR at all.

raosuhas avatar Nov 04 '24 23:11 raosuhas

Thank you, @raosuhas, for reviewing and signing off on the changes. How do I get this merge? Do I need another reviewer to approve? Thank you! @rkmanda , @akshitgoyal , @avjerafi - could you please help to review this PR? Thank you so much.

@raosuhas , could you advise me what else do I need to have this merge? The "Swagger LintDiff" failures are not introduced by my changes?

Thank you!

Please follow the instructions here to complete the merge : https://eng.ms/docs/products/azure-developer-experience/design/api-specs-pr/api-specs-pr#get-your-pr-merged

raosuhas avatar Nov 04 '24 23:11 raosuhas