azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Add properties as required for ipampool and body as required for put …

Open sssharma24 opened this issue 1 year ago • 8 comments

…ipampool

ARM (Control Plane) API Specification Update Pull Request

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • [ ] New resource provider.
  • [ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • [ ] Update existing version to fix OpenAPI spec quality issues in S360.
  • [ ] Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • [ ] Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

  • [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [x] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

sssharma24 avatar Sep 24 '24 06:09 sssharma24

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/network/armnetwork https://apiview.dev/Assemblies/Review/1b263a329090477991c0a7b7b0ae21d7?revisionId=6e454809e76e47f4920d469c2dbb89ad
JavaScript @azure/arm-network https://apiview.dev/Assemblies/Review/c13fd66ecbcc4c2a9995c8a1f4187240?revisionId=83b0ad4bd636441bbd5bc610649053d9
.Net Azure.ResourceManager.Network There is no API change compared with the previous version

small update that has already been signed off in the stable https://github.com/Azure/azure-rest-api-specs/pull/30560

sssharma24 avatar Sep 24 '24 06:09 sssharma24

This PR has at least one change violating Azure versioning policy (label: VersioningReviewRequired). To unblock this PR, either a) introduce a new API version with these changes instead of modifying an existing API version, or b) follow the process at aka.ms/brch.

ms-bogdan-rotaru avatar Sep 26 '24 09:09 ms-bogdan-rotaru

This PR has at least one change violating Azure versioning policy (label: VersioningReviewRequired). To unblock this PR, either a) introduce a new API version with these changes instead of modifying an existing API version, or b) follow the process at aka.ms/brch.

I don't think this should be an issue since we don't have customers or any tools for this yet and it's basically a bug fix. The property was always required we only missed it in the swagger

sssharma24 avatar Sep 27 '24 01:09 sssharma24

Please fix the errors reported by Swagger ModelValidation check.

ms-bogdan-rotaru avatar Sep 27 '24 08:09 ms-bogdan-rotaru

Please fix the errors reported by Swagger ModelValidation check.

I have fixed the errors

sssharma24 avatar Oct 29 '24 21:10 sssharma24

@ms-bogdan-rotaru could you please review now?

sssharma24 avatar Oct 29 '24 21:10 sssharma24

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Network

azure-sdk avatar Dec 10 '24 19:12 azure-sdk

Adding back ARMSignedOff label based on offline conversation.

ms-bogdan-rotaru avatar Jan 14 '25 08:01 ms-bogdan-rotaru