azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Release machinelearningservices microsoft.machine learning services 2024 10 01

Open ragovada opened this issue 1 year ago • 21 comments

ARM (Control Plane) API Specification Update Pull Request

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • [ ] New resource provider.
  • [x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • [ ] Update existing version to fix OpenAPI spec quality issues in S360.
  • [ ] Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • [ ] Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

  • [x ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [x] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

ragovada avatar Aug 01 '24 22:08 ragovada

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named Swagger LintDiff has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

/azp run

ragovada avatar Aug 07 '24 21:08 ragovada

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Aug 07 '24 21:08 azure-pipelines[bot]

@ragovada Please fix LintDiff and PrettierCheck errors.

gary-x-li avatar Aug 13 '24 04:08 gary-x-li

/azp run

ragovada avatar Aug 26 '24 22:08 ragovada

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Aug 26 '24 22:08 azure-pipelines[bot]

Hi, @ragovada. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

All looks good from my side, but please also get approval from breaking change committee.

ms-bogdan-rotaru avatar Sep 25 '24 09:09 ms-bogdan-rotaru

No details in CI report for Python SDK breaking so added the approval label directly.

msyyc avatar Sep 26 '24 02:09 msyyc

/azp run

ragovada avatar Oct 11 '24 05:10 ragovada

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 11 '24 05:10 azure-pipelines[bot]

/azp run

raosuhas avatar Oct 11 '24 16:10 raosuhas

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 11 '24 16:10 azure-pipelines[bot]

/azp run

ZhidaLiu avatar Oct 22 '24 16:10 ZhidaLiu

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 22 '24 16:10 azure-pipelines[bot]

Please fix Swagger LintDiff issues at https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4256339&view=logs&j=0574a2a6-2d0a-5ec6-40e4-4c6e2f70bea2&t=80c3e782-49f0-5d1c-70dd-cbee57bdd0c7

I see the initial page for LintDiff is not showing any issues, but the check is failing.

ramoka178 avatar Oct 22 '24 17:10 ramoka178

/azp run

mikeharder avatar Oct 22 '24 18:10 mikeharder

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 22 '24 18:10 azure-pipelines[bot]

Please fix Swagger LintDiff issues at https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4256339&view=logs&j=0574a2a6-2d0a-5ec6-40e4-4c6e2f70bea2&t=80c3e782-49f0-5d1c-70dd-cbee57bdd0c7

I see the initial page for LintDiff is not showing any issues, but the check is failing.

Looks like there are lot of errors and warnings in the lintdiff which is causing the tool to behave incorrectly. Please address the lintdiff issues.

ramoka178 avatar Oct 22 '24 18:10 ramoka178

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

Hi, @ragovada. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

Hi, @ragovada. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.