azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Remove Get GlobalCommunicationsSite API from Orbital AODG APIs

Open nathank527 opened this issue 1 year ago • 5 comments

Get on an Individual AODG GlobalCommunicationSite resulted in an UnsupportedResourceOperation error due to the specific API using a fanout API which is unsupported by ARM.

nathank527 avatar Jul 05 '24 17:07 nathank527

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
Compared specs (v0.10.12) new version base version
aodg.json 2024-03-01-preview(da1f16c) 2024-03-01-preview(main)
aodg.json 2024-03-01(da1f16c) 2024-03-01(main)
Rule Message
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Orbital/globalCommunicationsSites/{globalCommunicationsSiteName}' removed or restructured?
Old: aodg/preview/2024-03-01-preview/aodg.json#L1053:5

Rule Message
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Orbital/globalCommunicationsSites/{globalCommunicationsSiteName}' removed or restructured?
Old: aodg/stable/2024-03-01/aodg.json#L1053:5
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
Compared specs (v2.2.2) new version base version
package-2024-03-01 package-2024-03-01(da1f16c) package-2024-03-01(main)
package-2024-03-01-preview package-2024-03-01-preview(da1f16c) package-2024-03-01-preview(main)
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
Posted by Swagger Pipeline | How to fix these errors?

Generated ApiView

Language Package Name ApiView Link
Swagger Microsoft.Orbital https://apiview.dev/Assemblies/Review/61f78f8db02248bebedfbd512c002803?revisionId=55df764ebc754b4a98f8f1fa4bf72030

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • [x] Other, please clarify:
    • Removing a Failing API from our spec. This API has no customers and should have never made it into this repo.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

  • [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [x] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

nathank527 avatar Jul 15 '24 20:07 nathank527

/azp run

nathank527 avatar Jul 15 '24 20:07 nathank527

Commenter does not have sufficient privileges for PR 29716 in repo Azure/azure-rest-api-specs

azure-pipelines[bot] avatar Jul 15 '24 20:07 azure-pipelines[bot]

/azp run

nathank527 avatar Jul 15 '24 20:07 nathank527

Commenter does not have sufficient privileges for PR 29716 in repo Azure/azure-rest-api-specs

azure-pipelines[bot] avatar Jul 15 '24 20:07 azure-pipelines[bot]

/pr RequestMerge

nathank527 avatar Jul 16 '24 14:07 nathank527