azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

PIM Only Mode Rule settings for PIM Policies

Open mazinali opened this issue 1 year ago • 4 comments

ARM (Control Plane) API Specification Update Pull Request

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • [ ] New resource provider.
  • [x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • [ ] Update existing version to fix OpenAPI spec quality issues in S360.
  • [ ] Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

  • [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [x] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

mazinali avatar Jul 03 '24 22:07 mazinali

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the BreakingChangeReviewRequired label.
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named Swagger PrettierCheck has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide
  • ❌ The required check named Swagger SpellCheck has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 24 Errors, 18 Warnings failed [Detail]
Compared specs (v0.10.12) new version base version
EligibleChildResources.json 2024-02-01-preview(78aad45) 2020-10-01(main)
EligibleChildResources.json 2024-02-01-preview(78aad45) 2020-10-01-preview(main)
RoleAssignmentSchedule.json 2024-02-01-preview(78aad45) 2020-10-01(main)
RoleAssignmentSchedule.json 2024-02-01-preview(78aad45) 2020-10-01-preview(main)
RoleAssignmentScheduleInstance.json 2024-02-01-preview(78aad45) 2020-10-01(main)
RoleAssignmentScheduleInstance.json 2024-02-01-preview(78aad45) 2020-10-01-preview(main)
RoleEligibilitySchedule.json 2024-02-01-preview(78aad45) 2020-10-01(main)
RoleEligibilitySchedule.json 2024-02-01-preview(78aad45) 2020-10-01-preview(main)
RoleEligibilityScheduleInstance.json 2024-02-01-preview(78aad45) 2020-10-01(main)
RoleEligibilityScheduleInstance.json 2024-02-01-preview(78aad45) 2020-10-01-preview(main)
RoleEligibilityScheduleRequest.json 2024-02-01-preview(78aad45) 2020-10-01(main)
RoleEligibilityScheduleRequest.json 2024-02-01-preview(78aad45) 2022-04-01-preview(main)
RoleManagementPolicy.json 2024-02-01-preview(78aad45) 2020-10-01(main)
RoleManagementPolicy.json 2024-02-01-preview(78aad45) 2020-10-01-preview(main)
RoleManagementPolicyAssignment.json 2024-02-01-preview(78aad45) 2020-10-01(main)
RoleManagementPolicyAssignment.json 2024-02-01-preview(78aad45) 2020-10-01-preview(main)
authorization-RoleAssignmentsCalls.json 2024-02-01-preview(78aad45) 2022-04-01(main)
authorization-RoleAssignmentsCalls.json 2024-02-01-preview(78aad45) 2020-10-01-preview(main)
common-types.json 2024-02-01-preview(78aad45) 2022-04-01(main)
common-types.json 2024-02-01-preview(78aad45) 2022-05-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Only 11 items are listed, please refer to log for more details.

Rule Message
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.Authorization/roleEligibilityScheduleRequests/{roleEligibilityScheduleRequestName}/validate' removed or restructured?
Old: Microsoft.Authorization/stable/2020-10-01/RoleEligibilityScheduleRequest.json#L237:5
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyRuleTarget' removed or renamed?
New: Microsoft.Authorization/preview/2024-02-01-preview/RoleManagementPolicyAssignment.json#L231:3
Old: Microsoft.Authorization/stable/2020-10-01/RoleManagementPolicyAssignment.json#L231:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyRuleType' removed or renamed?
New: Microsoft.Authorization/preview/2024-02-01-preview/RoleManagementPolicyAssignment.json#L231:3
Old: Microsoft.Authorization/stable/2020-10-01/RoleManagementPolicyAssignment.json#L231:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyNotificationRule' removed or renamed?
New: Microsoft.Authorization/preview/2024-02-01-preview/RoleManagementPolicyAssignment.json#L231:3
Old: Microsoft.Authorization/stable/2020-10-01/RoleManagementPolicyAssignment.json#L231:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyExpirationRule' removed or renamed?
New: Microsoft.Authorization/preview/2024-02-01-preview/RoleManagementPolicyAssignment.json#L231:3
Old: Microsoft.Authorization/stable/2020-10-01/RoleManagementPolicyAssignment.json#L231:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyEnablementRule' removed or renamed?
New: Microsoft.Authorization/preview/2024-02-01-preview/RoleManagementPolicyAssignment.json#L231:3
Old: Microsoft.Authorization/stable/2020-10-01/RoleManagementPolicyAssignment.json#L231:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyAuthenticationContextRule' removed or renamed?
New: Microsoft.Authorization/preview/2024-02-01-preview/RoleManagementPolicyAssignment.json#L231:3
Old: Microsoft.Authorization/stable/2020-10-01/RoleManagementPolicyAssignment.json#L231:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ApprovalSettings' removed or renamed?
New: Microsoft.Authorization/preview/2024-02-01-preview/RoleManagementPolicyAssignment.json#L231:3
Old: Microsoft.Authorization/stable/2020-10-01/RoleManagementPolicyAssignment.json#L231:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyApprovalRule' removed or renamed?
New: Microsoft.Authorization/preview/2024-02-01-preview/RoleManagementPolicyAssignment.json#L231:3
Old: Microsoft.Authorization/stable/2020-10-01/RoleManagementPolicyAssignment.json#L231:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyApprovalRule' removed or renamed?
New: Microsoft.Authorization/preview/2024-02-01-preview/common-types.json#L19:3
Old: Microsoft.Authorization/stable/2022-04-01/common-types.json#L19:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ApprovalSettings' removed or renamed?
New: Microsoft.Authorization/preview/2024-02-01-preview/common-types.json#L19:3
Old: Microsoft.Authorization/stable/2022-04-01/common-types.json#L19:3


The following breaking changes are detected by comparison with the latest preview version:

Only 11 items are listed, please refer to log for more details.

Rule Message
Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/78aad4549f3ec9af3ef2eb48ce87e4a2fc1fb343/specification/authorization/resource-manager/Microsoft.Authorization/preview/2024-02-01-preview/RoleAssignmentScheduleRequest.json",
"old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/authorization/resource-manager/Microsoft.Authorization/preview/2022-04-01-preview/RoleAssignmentScheduleRequest.json",
"details":"Breaking change detector (OAD) invoked AutoRest. AutoRest threw a runtime error. First 20 lines of stack trace follow,
indexed. First line should contain AutoRest command line invocation details. Remaining lines should contain the main message reported by AutoRest.
====================
1: Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.110/common/temp/node_modules/.pnpm/@[email protected]/node_modules/autorest/dist/app.js" --v2 --input-file=specification/authorization/resource-manager/Microsoft.Authorization/preview/2024-02-01-preview/RoleAssignmentScheduleRequest.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp/oad-jgSpK0
2: ERROR: Referenced file 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/authorization/resource-manager/Microsoft.Authorization/preview/2024-02-01-preview/examples/ValidateRoleAssignmentScheduleRequestByName.json' not found
3: - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/authorization/resource-manager/Microsoft.Authorization/preview/2024-02-01-preview/RoleAssignmentScheduleRequest.json:289:12 ($.paths["/scope/providers/Microsoft.Authorization/roleAssignmentScheduleRequests/roleAssignmentScheduleRequestName/validate"].post["x-ms-examples"].ValidateRoleAssignmentScheduleRequestByName["$ref"])
4: FATAL: swagger-document/loader - FAILED
5: FATAL: Error: [OperationAbortedException] Error occurred. Exiting.
6: Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting."
:warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/{scope}/providers/Microsoft.Authorization/roleEligibilityScheduleRequests/{roleEligibilityScheduleRequestName}/validate' removed or restructured?
Old: Microsoft.Authorization/preview/2022-04-01-preview/RoleEligibilityScheduleRequest.json#L237:5
:warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyApprovalRule' removed or renamed?
New: Microsoft.Authorization/preview/2024-02-01-preview/common-types.json#L19:3
Old: Microsoft.Authorization/preview/2022-05-01-preview/common-types.json#L19:3
:warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ApprovalSettings' removed or renamed?
New: Microsoft.Authorization/preview/2024-02-01-preview/common-types.json#L19:3
Old: Microsoft.Authorization/preview/2022-05-01-preview/common-types.json#L19:3
:warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyAuthenticationContextRule' removed or renamed?
New: Microsoft.Authorization/preview/2024-02-01-preview/common-types.json#L19:3
Old: Microsoft.Authorization/preview/2022-05-01-preview/common-types.json#L19:3
:warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyEnablementRule' removed or renamed?
New: Microsoft.Authorization/preview/2024-02-01-preview/common-types.json#L19:3
Old: Microsoft.Authorization/preview/2022-05-01-preview/common-types.json#L19:3
:warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyExpirationRule' removed or renamed?
New: Microsoft.Authorization/preview/2024-02-01-preview/common-types.json#L19:3
Old: Microsoft.Authorization/preview/2022-05-01-preview/common-types.json#L19:3
:warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyNotificationRule' removed or renamed?
New: Microsoft.Authorization/preview/2024-02-01-preview/common-types.json#L19:3
Old: Microsoft.Authorization/preview/2022-05-01-preview/common-types.json#L19:3
:warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyRuleTarget' removed or renamed?
New: Microsoft.Authorization/preview/2024-02-01-preview/common-types.json#L19:3
Old: Microsoft.Authorization/preview/2022-05-01-preview/common-types.json#L19:3
:warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'RoleManagementPolicyRuleType' removed or renamed?
New: Microsoft.Authorization/preview/2024-02-01-preview/common-types.json#L19:3
Old: Microsoft.Authorization/preview/2022-05-01-preview/common-types.json#L19:3
:warning: 1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: Microsoft.Authorization/preview/2024-02-01-preview/authorization-RoleAssignmentsCalls.json#L44:9
Old: Microsoft.Authorization/preview/2020-10-01-preview/authorization-RoleAssignmentsCalls.json#L44:9
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 3 Errors, 5 Warnings failed [Detail]
Compared specs (v2.2.2) new version base version
package-preview-2024-02 package-preview-2024-02(78aad45) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
ResourceNameRestriction The resource name parameter 'roleAssignmentName' should be defined with a 'pattern' restriction.
Location: Microsoft.Authorization/preview/2024-02-01-preview/authorization-RoleAssignmentsCalls.json#L327
RPC-Uri-V1-05
PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
Location: Microsoft.Authorization/preview/2024-02-01-preview/authorization-RoleAssignmentsCalls.json#L540
RPC-Uri-V1-07
invalid-ref Could not read file: file:///mnt/vss/_work/1/azure-rest-api-specs/specification/authorization/resource-manager/Microsoft.Authorization/preview/2024-02-01-preview/examples/ValidateRoleAssignmentScheduleRequestByName.json .
Location: Microsoft.Authorization/preview/2024-02-01-preview/RoleAssignmentScheduleRequest.json#L288
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Authorization/preview/2024-02-01-preview/authorization-RoleAssignmentsCalls.json#L358
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Authorization/preview/2024-02-01-preview/authorization-RoleAssignmentsCalls.json#L552
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.Authorization/preview/2024-02-01-preview/authorization-RoleAssignmentsCalls.json#L568
:warning: SchemaDescriptionOrTitle Schema should have a description or title.
Location: Microsoft.Authorization/preview/2024-02-01-preview/RoleAssignmentScheduleRequest.json#L577
:warning: SchemaDescriptionOrTitle Schema should have a description or title.
Location: Microsoft.Authorization/preview/2024-02-01-preview/RoleEligibilityScheduleRequest.json#L516


The following errors/warnings exist before current PR submission:

Only 11 items are listed, please refer to log for more details.

Rule Message
ResourceNameRestriction The resource name parameter 'resourceName' should be defined with a 'pattern' restriction.
Location: Microsoft.Authorization/preview/2024-02-01-preview/authorization-RoleAssignmentsCalls.json#L132
ResourceNameRestriction The resource name parameter 'roleAssignmentName' should be defined with a 'pattern' restriction.
Location: Microsoft.Authorization/preview/2024-02-01-preview/authorization-RoleAssignmentsCalls.json#L190
ParametersInPointGet Query parameter tenantId should be removed. Point Get's MUST not have query parameters other than api version.
Location: Microsoft.Authorization/preview/2024-02-01-preview/authorization-RoleAssignmentsCalls.json#L197
PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'RoleAssignments_Create' Request Model: 'parameters[2].schema' Response Model: 'responses[200].schema'
Location: Microsoft.Authorization/preview/2024-02-01-preview/authorization-RoleAssignmentsCalls.json#L231
RepeatedPathInfo The 'scope' already appears in the path, please don't repeat it in the request body.
Location: Microsoft.Authorization/preview/2024-02-01-preview/authorization-RoleAssignmentsCalls.json#L238
DeleteResponseBodyEmpty The delete response body must be empty.
Location: Microsoft.Authorization/preview/2024-02-01-preview/authorization-RoleAssignmentsCalls.json#L306
NoDuplicatePathsForScopeParameter Path '/subscriptions/{subscriptionId}/providers/Microsoft.Authorization/roleAssignments' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Authorization/roleAssignments' that has the scope parameter.'.
Location: Microsoft.Authorization/preview/2024-02-01-preview/authorization-RoleAssignmentsCalls.json#L372
NoDuplicatePathsForScopeParameter Path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Authorization/roleAssignments' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Authorization/roleAssignments' that has the scope parameter.'.
Location: Microsoft.Authorization/preview/2024-02-01-preview/authorization-RoleAssignmentsCalls.json#L372
NoDuplicatePathsForScopeParameter Path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{resourceType}/{resourceName}/providers/Microsoft.Authorization/roleAssignments' with explicitly defined scope is a duplicate of path '/{scope}/providers/Microsoft.Authorization/roleAssignments' that has the scope parameter.'.
Location: Microsoft.Authorization/preview/2024-02-01-preview/authorization-RoleAssignmentsCalls.json#L372
EvenSegmentedPathForPutOperation API path with PUT operation defined MUST have even number of segments (i.e. end in {resourceType}/{resourceName} segments).
Location: Microsoft.Authorization/preview/2024-02-01-preview/authorization-RoleAssignmentsCalls.json#L418
PathContainsResourceType The path for the CURD methods do not contain a resource type.
Location: Microsoft.Authorization/preview/2024-02-01-preview/authorization-RoleAssignmentsCalls.json#L418
️❌Avocado: 70 Errors, 0 Warnings failed [Detail]

Only 11 items are listed, please refer to log for more details.

Rule Message
NO_JSON_FILE_FOUND The JSON file is not found but it is referenced from the readme file.
readme: specification/authorization/resource-manager/readme.md
json: preview/2024-02-01-preview/examples/ValidateRoleAssignmentScheduleRequestByName.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/authorization/resource-manager/readme.md
json: preview/2024-02-01-preview/examples/RoleAssignmentScheduleRequest.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/authorization/resource-manager/readme.md
json: preview/2024-02-01-preview/examples/RoleEligibilityScheduleRequest.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.Authorization/classicAdministrators is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/authorization/resource-manager/readme.md
json: Microsoft.Authorization/preview/2015-06-01/authorization-ClassicAdminCalls.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /providers/Microsoft.Authorization/providerOperations/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/authorization/resource-manager/readme.md
json: Microsoft.Authorization/preview/2018-01-01-preview/authorization-ProviderOperationsCalls.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /providers/Microsoft.Authorization/providerOperations is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/authorization/resource-manager/readme.md
json: Microsoft.Authorization/preview/2018-01-01-preview/authorization-ProviderOperationsCalls.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/Microsoft.Authorization/permissions is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/authorization/resource-manager/readme.md
json: Microsoft.Authorization/preview/2022-05-01-preview/authorization-RoleDefinitionsCalls.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourcegroups/{}/providers/{}/{}/{}/{}/providers/Microsoft.Authorization/permissions is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/authorization/resource-manager/readme.md
json: Microsoft.Authorization/preview/2022-05-01-preview/authorization-RoleDefinitionsCalls.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /{}/providers/Microsoft.Authorization/roleDefinitions/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/authorization/resource-manager/readme.md
json: Microsoft.Authorization/preview/2022-05-01-preview/authorization-RoleDefinitionsCalls.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /{}/providers/Microsoft.Authorization/roleDefinitions is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/authorization/resource-manager/readme.md
json: Microsoft.Authorization/preview/2022-05-01-preview/authorization-RoleDefinitionsCalls.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /{}?disambiguation_dummy is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/authorization/resource-manager/readme.md
json: Microsoft.Authorization/preview/2022-05-01-preview/authorization-RoleDefinitionsCalls.json
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 10 Errors, 0 Warnings failed [Detail]
Rule Message
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: type
Url: Microsoft.Authorization/preview/2024-02-01-preview/RoleManagementPolicy.json#L642:35
ExampleUrl: preview/2024-02-01-preview/examples/PatchRoleManagementPolicy.json#L6:19
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: type
Url: Microsoft.Authorization/preview/2024-02-01-preview/RoleManagementPolicy.json#L642:35
ExampleUrl: preview/2024-02-01-preview/examples/PatchRoleManagementPolicy.json#L1116:31
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: type
Url: Microsoft.Authorization/preview/2024-02-01-preview/RoleManagementPolicy.json#L642:35
ExampleUrl: preview/2024-02-01-preview/examples/PatchRoleManagementPolicy.json#L1121:31
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: type
Url: Microsoft.Authorization/preview/2024-02-01-preview/RoleManagementPolicy.json#L642:35
ExampleUrl: preview/2024-02-01-preview/examples/PatchRoleManagementPolicy.json#L1126:31
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: type
Url: Microsoft.Authorization/preview/2024-02-01-preview/RoleManagementPolicy.json#L642:35
ExampleUrl: preview/2024-02-01-preview/examples/PatchRoleManagementPolicy.json#L6:19
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: type
Url: Microsoft.Authorization/preview/2024-02-01-preview/RoleManagementPolicy.json#L642:35
ExampleUrl: preview/2024-02-01-preview/examples/PatchRoleManagementPolicy.json#L1116:31
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: type
Url: Microsoft.Authorization/preview/2024-02-01-preview/RoleManagementPolicy.json#L642:35
ExampleUrl: preview/2024-02-01-preview/examples/PatchRoleManagementPolicy.json#L1121:31
OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: type
Url: Microsoft.Authorization/preview/2024-02-01-preview/RoleManagementPolicy.json#L642:35
ExampleUrl: preview/2024-02-01-preview/examples/PatchRoleManagementPolicy.json#L1126:31
unacceptable kind of an object to dump [object Error] "role":"Model Validation",
"url":"https://github.com/Azure/azure-rest-api-specs/blob/78aad4549f3ec9af3ef2eb48ce87e4a2fc1fb343/specification/authorization/resource-manager/Microsoft.Authorization/preview/2024-02-01-preview/RoleAssignmentScheduleRequest.json"
unacceptable kind of an object to dump [object Error] "role":"Model Validation",
"url":"https://github.com/Azure/azure-rest-api-specs/blob/78aad4549f3ec9af3ef2eb48ce87e4a2fc1fb343/specification/authorization/resource-manager/Microsoft.Authorization/preview/2024-02-01-preview/RoleAssignmentScheduleRequest.json"
️❌SemanticValidation: 1 Errors, 0 Warnings failed [Detail]
Rule Message
INTERNAL_ERROR Unexpected internal error: ENOENT: no such file or directory, open '/mnt/vss/_work/1/azure-rest-api-specs/specification/authorization/resource-manager/Microsoft.Authorization/preview/2024-02-01-preview/examples/ValidateRoleAssignmentScheduleRequestByName.json' Error: ENOENT: no such file or directory, open '/mnt/vss/_work/1/azure-rest-api-specs/specification/authorization/resource-manager/Microsoft.Authorization/preview/2024-02-01-preview/examples/ValidateRoleAssignmentScheduleRequestByName.json'
JsonUrl: Microsoft.Authorization/preview/2024-02-01-preview/RoleAssignmentScheduleRequest.json
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌SpellCheck: 1 Errors, 0 Warnings failed [Detail]
Rule Message
HowToFix Unknown word (exlude), please fix the error. See https://aka.ms/ci-fix#spell-check
path: Microsoft.Authorization/preview/2024-02-01-preview/RoleManagementPolicy.json#L712:10
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Swagger Generation Artifacts

️❌ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]
Rule Message
RestBuild error "logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=437254&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b",
"detail":"Run.ps1 failed with exit code 1 "
️⚠️ azure-sdk-for-net-track2 warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from 54b077456ecc85590a87e4a12b36cfab52eceae0. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:787
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  787 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
  • ️✔️Azure.ResourceManager.Authorization [Preview SDK Changes]
    info	[Changelog]
️🔄 azure-sdk-for-python inProgress [Detail]
️🔄 azure-sdk-for-java inProgress [Detail]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 54b077456ecc85590a87e4a12b36cfab52eceae0. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/authorization/armauthorization [Preview SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 54b077456ecc85590a87e4a12b36cfab52eceae0. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-authorization [Preview SDK Changes]
️❌ azure-resource-manager-schemas failed [Detail]
    For more instructions, please refer to the FAQ .
  • Code Generator Failed in generating from 54b077456ecc85590a87e4a12b36cfab52eceae0. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
    cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
    cmderr	[initScript.sh] npm notice To update run: npm install -g [email protected]
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.
️️✔️ azure-powershell succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 54b077456ecc85590a87e4a12b36cfab52eceae0. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ️✔️Az.authorization.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Hi, @mazinali. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

Hi, @mazinali. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.