azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Add listRegistrationToken endpoint to latest stable and preview versions

Open ryanosh opened this issue 1 year ago • 5 comments

ARM (Control Plane) API Specification Update Pull Request

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

This is related to a security incident https://portal.microsofticm.com/imp/v5/incidents/details/514392120/summary. In early api versions we returned the registrationToken on the hostpool object. That was moved to a post action in later api versions, but we still returned the registrationto the old versions. We removed that behavior recently which broke some customers using arm/bicep templates because the RetrieveRegistrationToken post call is not compatible. We added this new endpoint to the code to handle listing the registration token, and are updating our most recent swagger versions to accommodate it.

  • [ ] New resource provider.
  • [ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • [ ] Update existing version to fix OpenAPI spec quality issues in S360.
  • [X] Other, please clarify:
    • Update Existing API version for security fix

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

  • [X] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [X] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

ryanosh avatar Jul 02 '24 21:07 ryanosh

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
Compared specs (v0.10.12) new version base version
desktopvirtualization.json 2024-04-08-preview(3a75173) 2024-04-08-preview(main)
desktopvirtualization.json 2024-04-03(3a75173) 2024-04-03(main)
Rule Message
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L3357:5

Rule Message
1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L2692:5
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-preview-2024-04 package-preview-2024-04(3a75173) package-preview-2024-04(main)
package-2024-04 package-2024-04(3a75173) package-2024-04(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L50
PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L225
PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'PrivateEndpointConnections_UpdateByWorkspace' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema'
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L386
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L386
PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L773
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:hour.
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L1041
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:minute.
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L1041
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:hour.
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L1307
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:minute.
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L1307
PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:rampUpStartVMOnConnect.
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L1307
PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:peakStartVMOnConnect.
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L1307
PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:rampDownStartVMOnConnect.
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L1307
PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:offPeakStartVMOnConnect.
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L1307
PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L1618
ConsistentPatchProperties The property 'tags' in the request body either not apppear in the resource model or has the wrong level.
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L2007
ConsistentPatchProperties The property 'tags' in the request body either not apppear in the resource model or has the wrong level.
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L2172
PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L2428
SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L3741
SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L3939
PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'PrivateEndpointConnections_UpdateByHostPool' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema'
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L4900
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L4900
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L9026
OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L50
PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L225
PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'PrivateEndpointConnections_UpdateByWorkspace' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema'
Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L386
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L386
PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L773
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:hour.
Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L1041
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:minute.
Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L1041
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:hour.
Location: Microsoft.DesktopVirtualization/stable/2024-04-03/desktopvirtualization.json#L1307
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌ azure-sdk-for-net-track2 failed [Detail]
    For more instructions, please refer to the FAQ .
  • Failed in generating from 87c7ef6bdfc8edd7ed07e27f685217aaed95d3eb. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to build project. exit code: False
  • Azure.ResourceManager.DesktopVirtualization [Preview SDK Changes]
    info	[Changelog]
️⚠️ azure-sdk-for-python warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from 87c7ef6bdfc8edd7ed07e27f685217aaed95d3eb. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh] npm notice
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
    cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
    cmderr	[automation_init.sh] npm notice To update run: npm install -g [email protected]
    cmderr	[automation_init.sh] npm notice
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-desktopvirtualization [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation HostPoolsOperations.list_registration_tokens
    info	[Changelog]   - Added operation group ActiveSessionHostConfigurationsOperations
    info	[Changelog]   - Added operation group AppAttachPackageInfoOperations
    info	[Changelog]   - Added operation group AppAttachPackageOperations
    info	[Changelog]   - Added operation group ControlSessionHostUpdateOperations
    info	[Changelog]   - Added operation group InitiateSessionHostUpdateOperations
    info	[Changelog]   - Added operation group SessionHostConfigurationsOperations
    info	[Changelog]   - Added operation group SessionHostManagementsOperations
    info	[Changelog]   - Added operation group SessionHostManagementsUpdateStatusOperations
    info	[Changelog]   - Added operation group SessionHostOperations
    info	[Changelog]   - Model ApplicationGroupPatch has a new parameter system_data
    info	[Changelog]   - Model ExpandMsixImage has a new parameter certificate_expiry
    info	[Changelog]   - Model ExpandMsixImage has a new parameter certificate_name
    info	[Changelog]   - Model ExpandMsixImage has a new parameter system_data
    info	[Changelog]   - Model HostPool has a new parameter app_attach_package_references
    info	[Changelog]   - Model HostPool has a new parameter direct_udp
    info	[Changelog]   - Model HostPool has a new parameter managed_private_udp
    info	[Changelog]   - Model HostPool has a new parameter management_type
    info	[Changelog]   - Model HostPool has a new parameter public_udp
    info	[Changelog]   - Model HostPool has a new parameter relay_udp
    info	[Changelog]   - Model HostPoolPatch has a new parameter direct_udp
    info	[Changelog]   - Model HostPoolPatch has a new parameter managed_private_udp
    info	[Changelog]   - Model HostPoolPatch has a new parameter public_udp
    info	[Changelog]   - Model HostPoolPatch has a new parameter relay_udp
    info	[Changelog]   - Model HostPoolPatch has a new parameter system_data
    info	[Changelog]   - Model MSIXPackagePatch has a new parameter system_data
    info	[Changelog]   - Model PrivateEndpointConnection has a new parameter group_ids
    info	[Changelog]   - Model PrivateEndpointConnection has a new parameter system_data
    info	[Changelog]   - Model PrivateEndpointConnectionWithSystemData has a new parameter group_ids
    info	[Changelog]   - Model PrivateLinkResource has a new parameter system_data
    info	[Changelog]   - Model ProxyResource has a new parameter system_data
    info	[Changelog]   - Model Resource has a new parameter system_data
    info	[Changelog]   - Model ResourceModelWithAllowedPropertySet has a new parameter system_data
    info	[Changelog]   - Model ScalingPlanPooledSchedulePatch has a new parameter system_data
    info	[Changelog]   - Model SessionHost has a new parameter last_session_host_update_time
    info	[Changelog]   - Model SessionHost has a new parameter session_host_configuration
    info	[Changelog]   - Model SessionHostPatch has a new parameter system_data
    info	[Changelog]   - Model StartMenuItem has a new parameter system_data
    info	[Changelog]   - Operation SessionHostsOperations.list has a new optional parameter vm_path
    info	[Changelog]
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog]   - Parameter location of model ApplicationGroup is now required
    info	[Changelog]   - Parameter location of model HostPool is now required
    info	[Changelog]   - Parameter location of model ResourceModelWithAllowedPropertySet is now required
    info	[Changelog]   - Parameter location of model ScalingPlan is now required
    info	[Changelog]   - Parameter location of model Workspace is now required
    Present SDK breaking changes suppressions
    Parameter location of model ApplicationGroup is now required
    Parameter location of model HostPool is now required
    Parameter location of model ResourceModelWithAllowedPropertySet is now required
    Parameter location of model ScalingPlan is now required
    Parameter location of model Workspace is now required
    Please refer to the guidance for suppressing SDK breaking changes.
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 87c7ef6bdfc8edd7ed07e27f685217aaed95d3eb. SDK Automation 14.0.0
    command	./eng/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-desktopvirtualization [Preview SDK Changes] Breaking Change Detected
    Only showing 120 items here. Refer to log for details.
    info	[Changelog]
    info	[Changelog] #### `models.HostPool$Definition` was modified
    info	[Changelog]
    info	[Changelog] * `withManagedPrivateUdp(models.ManagedPrivateUdp)` was added
    info	[Changelog] * `withManagementType(models.ManagementType)` was added
    info	[Changelog] * `withDirectUdp(models.DirectUdp)` was added
    info	[Changelog] * `withPublicUdp(models.PublicUdp)` was added
    info	[Changelog] * `withRelayUdp(models.RelayUdp)` was added
    info	[Changelog] * `withSku(models.Sku)` was added
    info	[Changelog] * `withPlan(models.Plan)` was added
    info	[Changelog] * `withIdentity(models.ManagedServiceIdentity)` was added
    info	[Changelog]
    info	[Changelog] #### `models.PrivateLinkServiceConnectionState` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.MaintenanceWindowProperties` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.MaintenanceWindowPatchProperties` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.ScalingPlanPatch` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.SessionHost` was modified
    info	[Changelog]
    info	[Changelog] * `lastSessionHostUpdateTime()` was added
    info	[Changelog] * `sessionHostConfiguration()` was added
    info	[Changelog]
    info	[Changelog] #### `models.PrivateLinkResourceListResult` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.ExpandMsixImage` was modified
    info	[Changelog]
    info	[Changelog] * `certificateExpiry()` was added
    info	[Changelog] * `systemData()` was added
    info	[Changelog] * `certificateName()` was added
    info	[Changelog]
    info	[Changelog] #### `models.ServiceSpecification` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.SessionHosts` was modified
    info	[Changelog]
    info	[Changelog] * `list(java.lang.String,java.lang.String,java.lang.Integer,java.lang.Boolean,java.lang.Integer,java.lang.String,com.azure.core.util.Context)` was added
    info	[Changelog]
    info	[Changelog] #### `models.Time` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.PrivateEndpointConnectionListResultWithSystemData` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.ScalingPlanList` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.ScalingPlanPersonalSchedulePatch` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.MsixPackageDependencies` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.UserSessionList` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.HostPools` was modified
    info	[Changelog]
    info	[Changelog] * `listRegistrationTokensWithResponse(java.lang.String,java.lang.String,com.azure.core.util.Context)` was added
    info	[Changelog] * `listRegistrationTokens(java.lang.String,java.lang.String)` was added
    info	[Changelog]
    info	[Changelog] #### `models.ScalingPlan$Definition` was modified
    info	[Changelog]
    info	[Changelog] * `withSku(models.Sku)` was added
    info	[Changelog] * `withPlan(models.Plan)` was added
    info	[Changelog] * `withIdentity(models.ManagedServiceIdentity)` was added
    info	[Changelog]
    info	[Changelog] #### `models.Workspace$Definition` was modified
    info	[Changelog]
    info	[Changelog] * `withSku(models.Sku)` was added
    info	[Changelog] * `withIdentity(models.ManagedServiceIdentity)` was added
    info	[Changelog] * `withPlan(models.Plan)` was added
    info	[Changelog]
    info	[Changelog] #### `models.DesktopList` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.ApplicationPatch` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.Plan` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog]
    Please refer to the guidance for suppressing SDK breaking changes.
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 87c7ef6bdfc8edd7ed07e27f685217aaed95d3eb. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/desktopvirtualization/armdesktopvirtualization [Preview SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 87c7ef6bdfc8edd7ed07e27f685217aaed95d3eb. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-desktopvirtualization [Preview SDK Changes]
️❌ azure-resource-manager-schemas failed [Detail]
    For more instructions, please refer to the FAQ .
  • Code Generator Failed in generating from 87c7ef6bdfc8edd7ed07e27f685217aaed95d3eb. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
    cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
    cmderr	[initScript.sh] npm notice To update run: npm install -g [email protected]
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.
️️✔️ azure-powershell succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 87c7ef6bdfc8edd7ed07e27f685217aaed95d3eb. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ️✔️Az.desktopvirtualization.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

The ModelValidation pipeline is failing on validating common-types properties. This appears to be a false error.

ryanosh avatar Jul 04 '24 14:07 ryanosh

/azp run

ryanosh avatar Jul 18 '24 04:07 ryanosh

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jul 18 '24 04:07 azure-pipelines[bot]