Azure
Stable version API for Qumulo: 2024-06-19
ARM (Control Plane) API Specification Update Pull Request
[!TIP] Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.
[!NOTE] As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1, Breaking Changes review
If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.
Click here to see the details of Step 2, ARM review
See https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
- [ ] New resource provider.
- [x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
- [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
- [ ] Update existing version to fix OpenAPI spec quality issues in S360.
- [ ] Other, please clarify:
- edit this with your clarification
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:
- [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
- [ ] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.
Getting help
- First, please carefully read through this PR description, from top to bottom. Please fill out the
Purpose of this PRandDue diligence checklist. - To understand what you must do next to merge this PR, see the
Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state. - For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
- For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
- If the PR CI checks appear to be stuck in
queuedstate, please add a comment with contents/azp run. This should result in a new comment denoting aPR validation pipelinehas started and the checks should be updated after few minutes. - If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
Next Steps to Merge
✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 26 Errors, 58 Warnings failed [Detail]
| Compared specs (v0.10.12) | new version | base version |
|---|---|---|
| Qumulo.Storage.json | 2024-06-19(e4659de) | 2022-10-12(main) |
| Qumulo.Storage.json | 2024-06-19(e4659de) | 2022-10-12-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 30 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with the latest preview version:
Only 30 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 3 Warnings warning [Detail]
| Compared specs (v2.2.2) | new version | base version |
|---|---|---|
| package-2024-06-19 | package-2024-06-19(e4659de) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| :warning: LatestVersionOfCommonTypesMustBeUsed | Use the latest version v5 of managedidentity.json. Location: Qumulo.Storage/stable/2024-06-19/Qumulo.Storage.json#L593 |
|
| :warning: LatestVersionOfCommonTypesMustBeUsed | Use the latest version v5 of types.json. Location: Qumulo.Storage/stable/2024-06-19/Qumulo.Storage.json#L599 |
|
| :warning: LatestVersionOfCommonTypesMustBeUsed | Use the latest version v5 of managedidentity.json. Location: Qumulo.Storage/stable/2024-06-19/Qumulo.Storage.json#L662 |
The following errors/warnings exist before current PR submission:
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
️❌ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=437669&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️⚠️ azure-sdk-for-python warning [Detail]
- For more instructions, please refer to the FAQ .
⚠️Warning in generating from a5974ec50689bd8a8c5fd92f1ad2ef2a2fb97f45. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. cmderr [automation_init.sh] npm notice cmderr [automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1 cmderr [automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1 cmderr [automation_init.sh] npm notice To update run: npm install -g [email protected] cmderr [automation_init.sh] npm notice warn Warning: cannot find emitter config for azure-sdk-for-python in tspconfig.yaml for typespec project specification/liftrqumulo/Qumulo.Storage.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️azure-mgmt-qumulo [Preview SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - Added model LiftrBaseMarketplaceDetails info [Changelog] - Added model LiftrBaseStorageFileSystemResource info [Changelog] - Added model LiftrBaseStorageFileSystemResourceUpdate info [Changelog] - Added model LiftrBaseStorageFileSystemResourceUpdateProperties info [Changelog] - Added model LiftrBaseUserDetails
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
- For more instructions, please refer to the FAQ .
️✔️Succeeded in generating from a5974ec50689bd8a8c5fd92f1ad2ef2a2fb97f45. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json warn Warning: cannot find emitter config for azure-sdk-for-java in tspconfig.yaml for typespec project specification/liftrqumulo/Qumulo.Storage.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
️✔️azure-resourcemanager-qumulo [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] * `models.FileSystemResource` was removed info [Changelog] info [Changelog] * `models.FileSystemResource$DefinitionStages` was removed info [Changelog] info [Changelog] * `models.FileSystemResource$UpdateStages` was removed info [Changelog] info [Changelog] * `models.UserDetails` was removed info [Changelog] info [Changelog] * `models.FileSystemResourceUpdate` was removed info [Changelog] info [Changelog] * `models.FileSystemResourceUpdateProperties` was removed info [Changelog] info [Changelog] * `models.MarketplaceDetails` was removed info [Changelog] info [Changelog] * `models.FileSystemResource$Definition` was removed info [Changelog] info [Changelog] * `models.FileSystemResource$Update` was removed info [Changelog] info [Changelog] * `models.StorageSku` was removed info [Changelog] info [Changelog] #### `models.ProvisioningState` was modified info [Changelog] info [Changelog] * `models.ProvisioningState[] values()` -> `java.util.Collection values()` info [Changelog] * `valueOf(java.lang.String)` was removed info [Changelog] * `toString()` was removed info [Changelog] info [Changelog] #### `models.FileSystems` was modified info [Changelog] info [Changelog] * `models.FileSystemResource getByResourceGroup(java.lang.String,java.lang.String)` -> `models.LiftrBaseStorageFileSystemResource getByResourceGroup(java.lang.String,java.lang.String)` info [Changelog] * `models.FileSystemResource getById(java.lang.String)` -> `models.LiftrBaseStorageFileSystemResource getById(java.lang.String)` info [Changelog] * `models.FileSystemResource$DefinitionStages$Blank define(java.lang.String)` -> `models.LiftrBaseStorageFileSystemResource$DefinitionStages$Blank define(java.lang.String)` info [Changelog] info [Changelog] #### `models.MarketplaceSubscriptionStatus` was modified info [Changelog] info [Changelog] * `models.MarketplaceSubscriptionStatus[] values()` -> `java.util.Collection values()` info [Changelog] * `valueOf(java.lang.String)` was removed info [Changelog] * `toString()` was removed info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] * `models.LiftrBaseUserDetails` was added info [Changelog] info [Changelog] * `models.LiftrBaseStorageFileSystemResource$UpdateStages` was added info [Changelog] info [Changelog] * `models.LiftrBaseStorageFileSystemResource$Definition` was added info [Changelog] info [Changelog] * `models.LiftrBaseStorageFileSystemResourceUpdateProperties` was added info [Changelog] info [Changelog] * `models.LiftrBaseMarketplaceDetails` was added info [Changelog] info [Changelog] * `models.LiftrBaseStorageFileSystemResource$Update` was added info [Changelog] info [Changelog] * `models.LiftrBaseStorageFileSystemResource$DefinitionStages` was added info [Changelog] info [Changelog] * `models.LiftrBaseStorageFileSystemResource` was added info [Changelog] info [Changelog] * `models.LiftrBaseStorageFileSystemResourceUpdate` was added info [Changelog] info [Changelog] #### `models.OperationListResult` was modified info [Changelog] info [Changelog] * `toJson(com.azure.json.JsonWriter)` was added info [Changelog] * `fromJson(com.azure.json.JsonReader)` was added info [Changelog] info [Changelog] #### `models.UserAssignedIdentity` was modified info [Changelog] info [Changelog] * `toJson(com.azure.json.JsonWriter)` was added info [Changelog] * `fromJson(com.azure.json.JsonReader)` was added info [Changelog] info [Changelog] #### `models.OperationDisplay` was modified info [Changelog] info [Changelog] * `fromJson(com.azure.json.JsonReader)` was added info [Changelog] * `toJson(com.azure.json.JsonWriter)` was added info [Changelog] info [Changelog] #### `models.ManagedServiceIdentity` was modified info [Changelog] info [Changelog] * `toJson(com.azure.json.JsonWriter)` was added info [Changelog] * `fromJson(com.azure.json.JsonReader)` was added info [Changelog] info [Changelog] #### `models.FileSystemResourceListResult` was modified info [Changelog] info [Changelog] * `toJson(com.azure.json.JsonWriter)` was added info [Changelog] * `fromJson(com.azure.json.JsonReader)` was added info [Changelog] info [Changelog]
Please refer to the guidance for suppressing SDK breaking changes.
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
- For more instructions, please refer to the FAQ .
️✔️Succeeded in generating from a5974ec50689bd8a8c5fd92f1ad2ef2a2fb97f45. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json warn Warning: cannot find emitter config for azure-sdk-for-go in tspconfig.yaml for typespec project specification/liftrqumulo/Qumulo.Storage.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml. command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/liftrqumulo/armqumulo [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Type of `FileSystemResourceProperties.StorageSKU` has been changed from `*StorageSKU` to `*string` info [Changelog] - `ProvisioningStateNotSpecified` from enum `ProvisioningState` has been removed info [Changelog] - Enum `StorageSKU` has been removed info [Changelog] - Field `InitialCapacity` of struct `FileSystemResourceProperties` has been removed info [Changelog] - Field `ClusterLoginURL`, `PrivateIPs` of struct `FileSystemResourceUpdateProperties` has been removed info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New field `TermUnit` in struct `MarketplaceDetails` info [Changelog] info [Changelog] Total 5 breaking change(s), 1 additive change(s).
Present SDK breaking changes suppressions Enum `StorageSKU` has been removed Field `ClusterLoginURL`, `PrivateIPs` of struct `FileSystemResourceUpdateProperties` has been removed Field `InitialCapacity` of struct `FileSystemResourceProperties` has been removed Type of `FileSystemResourceProperties.StorageSKU` has been changed from `*StorageSKU` to `*string` `ProvisioningStateNotSpecified` from enum `ProvisioningState` has been removed
Please refer to the guidance for suppressing SDK breaking changes.
️🔄 azure-sdk-for-js inProgress [Detail]
️❌ azure-resource-manager-schemas failed [Detail]
- For more instructions, please refer to the FAQ .
❌Code Generator Failed in generating from a5974ec50689bd8a8c5fd92f1ad2ef2a2fb97f45. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az' cmderr [initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'... cmderr [initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types' cmderr [initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'... cmderr [initScript.sh] npm notice cmderr [initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1 cmderr [initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1 cmderr [initScript.sh] npm notice To update run: npm install -g [email protected] cmderr [initScript.sh] npm notice error Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh warn Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel. command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json cmderr [generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500 cmderr [generateScript.sh] return new TSError(diagnosticText, diagnosticCodes) cmderr [generateScript.sh] ^ cmderr [generateScript.sh] TSError: ⨯ Unable to compile TypeScript: cmderr [generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type. cmderr [generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type. cmderr [generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig. cmderr [generateScript.sh] at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12) cmderr [generateScript.sh] at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19) cmderr [generateScript.sh] at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36) cmderr [generateScript.sh] at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32) cmderr [generateScript.sh] at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43) cmderr [generateScript.sh] at Module._extensions..js (node:internal/modules/cjs/loader:1422:10) cmderr [generateScript.sh] at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12) cmderr [generateScript.sh] at Module.load (node:internal/modules/cjs/loader:1203:32) cmderr [generateScript.sh] at Function.Module._load (node:internal/modules/cjs/loader:1019:12) cmderr [generateScript.sh] at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12) error Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh warn Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel. warn Warning: cannot find emitter config for azure-resource-manager-schemas in tspconfig.yaml for typespec project specification/liftrqumulo/Qumulo.Storage.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml. warn Warning: cannot find emitter config for azure-resource-manager-schemas in tspconfig.yaml for typespec project specification/liftrqumulo/Qumulo.Storage.Management/tspconfig.yaml. This SDK will be skipped from the generation for this project. Please add the right emitter config in the 'tspconfig.yaml' file. The example project can be found at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/contosowidgetmanager/Contoso.WidgetManager/tspconfig.yaml.
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Go | sdk/resourcemanager/liftrqumulo/armqumulo | https://apiview.dev/Assemblies/Review/a09fbf534a11484aae400c9c14508f46?revisionId=6d1469f431784b9ba87528909a1f4336 |
| Java | azure-resourcemanager-qumulo | https://apiview.dev/Assemblies/Review/5a3be0e1502c4792bb9b8fe88264019d?revisionId=a58076bb2108442292480dc3d52ebfd5 |
| TypeSpec | Qumulo.Storage.Management | https://apiview.dev/Assemblies/Review/bf5eec0e1fa44bf39a225c56e55a2dcf?revisionId=e9365d5bfa384975b9d5fdd8efcdf99b |
| Swagger | Qumulo.Storage | https://apiview.dev/Assemblies/Review/c94035069dea43cabcb9fd670b63c93b?revisionId=f03ef327755941b1be18f82bb446ffb0 |
We have the Breaking change approval and the breaking changes were tested and merged in the ARM Spec private repo. Attaching the link of the Private repo PR here: https://github.com/Azure/azure-rest-api-specs-pr/pull/18600
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
@dipeshbhakat-microsoft Could you not add the JS SDK breaking change approve label here? I am the JS SDK owner and I need to get back to this tomorrow. Thank you
[like] Dipesh Bhakat reacted to your message:
From: Qiaoqiao Zhang @.> Sent: Thursday, July 4, 2024 10:07:31 AM To: Azure/azure-rest-api-specs @.> Cc: Dipesh Bhakat @.>; Mention @.> Subject: Re: [Azure/azure-rest-api-specs] Stable version API for Qumulo: 2024-06-19 (PR #29673)
@dipeshbhakat-microsofthttps://github.com/dipeshbhakat-microsoft Could you not add the JS SDK breaking change approve label here? I am the JS SDK owner and I need to get back to this tomorrow. Thank you
— Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-rest-api-specs/pull/29673#issuecomment-2208603521, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AZQQ5HR6KPCYY3SYRIRCCE3ZKUNGHAVCNFSM6AAAAABKHYDLLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBYGYYDGNJSGE. You are receiving this because you were mentioned.Message ID: @.***>
https://teams.microsoft.com/l/message/19:[email protected]/1712781721315?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&parentMessageId=1712781721315&teamName=Azure%20SDK&channelName=TypeSpec%20Discussion&createdTime=1712781721315
https://teams.microsoft.com/l/message/19:[email protected]/1714666566850?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&parentMessageId=1714666566850&teamName=Azure%20SDK&channelName=General&createdTime=1714666566850
Hi @scorpion-ajay For some of the breaking changes in this PR, I'm not seeing them in the link you shared: https://github.com/Azure/azure-rest-api-specs-pr/pull/18600#issuecomment-2177945084
-
StorageSkutype got changed fromx-ms-enumtostring. https://github.com/Azure/azure-rest-api-specs/blob/b0fe1805a7e541e4d0252c01e919f0f20721b270/specification/liftrqumulo/resource-manager/Qumulo.Storage/stable/2022-10-12/Qumulo.Storage.json#L446-L449 https://github.com/Azure/azure-rest-api-specs/blob/a977c730fda43ab19c05373b32c7159d6f265e9a/specification/liftrqumulo/resource-manager/Qumulo.Storage/stable/2024-06-19/Qumulo.Storage.json#L616-L619 -
ProvisioningStatechangedmodelAsStringfromfalsetotrue: https://github.com/Azure/azure-rest-api-specs/blob/b0fe1805a7e541e4d0252c01e919f0f20721b270/specification/liftrqumulo/resource-manager/Qumulo.Storage/stable/2022-10-12/Qumulo.Storage.json#L629 https://github.com/Azure/azure-rest-api-specs/blob/a977c730fda43ab19c05373b32c7159d6f265e9a/specification/liftrqumulo/resource-manager/Qumulo.Storage/stable/2024-06-19/Qumulo.Storage.json#L537 -
MarketplaceSubscriptionStatuschangedmodelAsStringfromfalsetotrue: https://github.com/Azure/azure-rest-api-specs/blob/b0fe1805a7e541e4d0252c01e919f0f20721b270/specification/liftrqumulo/resource-manager/Qumulo.Storage/stable/2022-10-12/Qumulo.Storage.json#L588 https://github.com/Azure/azure-rest-api-specs/blob/a977c730fda43ab19c05373b32c7159d6f265e9a/specification/liftrqumulo/resource-manager/Qumulo.Storage/stable/2024-06-19/Qumulo.Storage.json#L497 -
Some of the properties got removed:
Could you share the PR link of them getting approved please?
@XiaofeiCao This is the PR where all the mentioned changes were approved. All changes are well tested since long time and working in production. https://github.com/scorpion-ajay/azure-rest-api-specs-pr/blob/9cfcf899fa647eec39d4f96e819ec7b4df9a79ba/specification/liftrqumulo/resource-manager/Qumulo.Storage/preview/2024-02-01-preview/Qumulo.Storage.json#L535