azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard
verified publisher icon Azure

add hdinsight api version 2024-08-01-preview

Open yaning-liu opened this issue 1 year ago • 5 comments

ARM (Control Plane) API Specification Update Pull Request

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • [ ] New resource provider.
  • [x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • [ ] Update existing version to fix OpenAPI spec quality issues in S360.
  • [ ] Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

  • [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [x] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

yaning-liu avatar Jun 27 '24 09:06 yaning-liu

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app[bot] avatar Jun 27 '24 09:06 openapi-pipeline-app[bot]

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.
️⚠️Breaking Change(Cross-Version): 2 Warnings warning [Detail]
Compared specs (v0.10.12) new version base version
applications.json 2024-08-01-preview(fac7cf9) 2021-06-01(main)
applications.json 2024-08-01-preview(fac7cf9) 2023-08-15-preview(main)
cluster.json 2024-08-01-preview(fac7cf9) 2021-06-01(main)
cluster.json 2024-08-01-preview(fac7cf9) 2023-08-15-preview(main)
configurations.json 2024-08-01-preview(fac7cf9) 2021-06-01(main)
configurations.json 2024-08-01-preview(fac7cf9) 2023-08-15-preview(main)
extensions.json 2024-08-01-preview(fac7cf9) 2021-06-01(main)
extensions.json 2024-08-01-preview(fac7cf9) 2023-08-15-preview(main)
locations.json 2024-08-01-preview(fac7cf9) 2021-06-01(main)
locations.json 2024-08-01-preview(fac7cf9) 2023-08-15-preview(main)
operations.json 2024-08-01-preview(fac7cf9) 2021-06-01(main)
operations.json 2024-08-01-preview(fac7cf9) 2023-08-15-preview(main)
privateEndpointConnections.json 2024-08-01-preview(fac7cf9) 2021-06-01(main)
privateEndpointConnections.json 2024-08-01-preview(fac7cf9) 2023-08-15-preview(main)
privateLinkResources.json 2024-08-01-preview(fac7cf9) 2021-06-01(main)
privateLinkResources.json 2024-08-01-preview(fac7cf9) 2023-08-15-preview(main)
scriptActions.json 2024-08-01-preview(fac7cf9) 2021-06-01(main)
scriptActions.json 2024-08-01-preview(fac7cf9) 2023-08-15-preview(main)
virtualMachines.json 2024-08-01-preview(fac7cf9) 2021-06-01(main)
virtualMachines.json 2024-08-01-preview(fac7cf9) 2023-08-15-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule Message
:warning: 1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.HDInsight/preview/2024-08-01-preview/extensions.json#L321:5


The following breaking changes are detected by comparison with the latest preview version:

Rule Message
:warning: 1038 - AddedPath The new version is adding a path that was not found in the old version.
New: Microsoft.HDInsight/preview/2024-08-01-preview/extensions.json#L321:5
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
️⚠️LintDiff: 4 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2024-08-preview package-2024-08-preview(fac7cf9) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
:warning: UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get cluster monitoring status
Location: Microsoft.HDInsight/preview/2024-08-01-preview/extensions.json#L238
:warning: UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Disable cluster monitoring
Location: Microsoft.HDInsight/preview/2024-08-01-preview/extensions.json#L278
:warning: PutInOperationName 'PUT' operation 'Extensions_EnableAzureMonitorAgent' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/extensions.json#L332
:warning: DeleteInOperationName 'DELETE' operation 'Extensions_DisableAzureMonitorAgent' should use method name 'Delete'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/extensions.json#L425


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
❌ XmsParameterLocation The parameter 'SubscriptionIdParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/applications.json#L496
❌ XmsParameterLocation The parameter 'ApiVersionParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/applications.json#L527
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/cluster.json#L117
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/cluster.json#L173
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/cluster.json#L263
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/cluster.json#L313
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/cluster.json#L382
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/cluster.json#L496
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/cluster.json#L593
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/cluster.json#L693
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/cluster.json#L761
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/cluster.json#L801
❌ DefinitionsPropertiesNamesCamelCase Property name should be camel case.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/cluster.json#L1097
❌ DefinitionsPropertiesNamesCamelCase Property name should be camel case.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/cluster.json#L1992
❌ DefinitionsPropertiesNamesCamelCase Property name should be camel case.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/cluster.json#L1998
❌ DefinitionsPropertiesNamesCamelCase Property name should be camel case.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/cluster.json#L2003
❌ DefinitionsPropertiesNamesCamelCase Property name should be camel case.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/cluster.json#L2014
❌ DefinitionsPropertiesNamesCamelCase Property name should be camel case.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/cluster.json#L2020
❌ DefinitionsPropertiesNamesCamelCase Property name should be camel case.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/cluster.json#L2026
❌ XmsParameterLocation The parameter 'SubscriptionIdParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/cluster.json#L2258
❌ XmsParameterLocation The parameter 'ApiVersionParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/cluster.json#L2281
❌ PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/configurations.json#L79
❌ PostResponseCodes Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/configurations.json#L80
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/configurations.json#L189
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/configurations.json#L199
❌ XmsParameterLocation The parameter 'SubscriptionIdParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/configurations.json#L211
❌ XmsParameterLocation The parameter 'ApiVersionParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/configurations.json#L242
❌ AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/extensions.json#L750
❌ XmsParameterLocation The parameter 'SubscriptionIdParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/extensions.json#L781
❌ XmsParameterLocation The parameter 'ApiVersionParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
Location: Microsoft.HDInsight/preview/2024-08-01-preview/extensions.json#L812
️⚠️Avocado: 1 Warnings warning [Detail]
Rule Message
:warning: CIRCULAR_REFERENCE The JSON file has a circular reference.
readme: specification/hdinsight/resource-manager/readme.md
json: Microsoft.HDInsight/preview/2024-08-01-preview/scriptActions.json
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand] 
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand] 
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

openapi-pipeline-app[bot] avatar Jun 27 '24 09:06 openapi-pipeline-app[bot]

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand] 
 Please click here to preview with your @microsoft account.
️❌ azure-sdk-for-net-track2 failed [Detail]
    For more instructions, please refer to the FAQ .
  • ❌Pipeline Framework Failed in generating from 0b8a5fa9bfd4b64a52a6f69ae99ab1cd5801a689. SDK Automation 14.0.0 
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-Content: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:388
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  388 |        (Get-Content $file) -replace $rquirefileRex, "$requirefile" | S …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |         ~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/hdinsight/Azure.ResourceManager.HDInsight Azure.ResourceManager.HDInsight.Containers/src/autorest.md' because it does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] Resolve-Path: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:392
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  392 |      $relativeFolderPath = Resolve-Path $projectFolder -Relative
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/hdinsight/Azure.ResourceManager.HDInsight Azure.ResourceManager.HDInsight.Containers' because it does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to build project. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:787
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  787 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
fatal: 'sdkAuto/29608/Azure.ResourceManager.HDInsight Azure.ResourceManager.HDInsight.Containers' is not a valid branch namehint: See `man git check-ref-format`hint: Disable this message with "git config advice.refSyntax false"
error	GenerationError: The following packages are still pending.
error		Azure.ResourceManager.HDInsight Azure.ResourceManager.HDInsight.Containers
error		Azure.ResourceManager.HDInsight
  • ❌Azure.ResourceManager.HDInsight Azure.ResourceManager.HDInsight.Containers
    error	FatalError: fatal: 'sdkAuto/29608/Azure.ResourceManager.HDInsight Azure.ResourceManager.HDInsight.Containers' is not a valid branch namehint: See `man git check-ref-format`hint: Disable this message with "git config advice.refSyntax false". Please refer to the inner logs for details or report this issue through https://aka.ms/azsdk/support/specreview-channel.
error	ErrorStack: Error: fatal: 'sdkAuto/29608/Azure.ResourceManager.HDInsight Azure.ResourceManager.HDInsight.Containers' is not a valid branch namehint: See `man git check-ref-format`hint: Disable this message with "git config advice.refSyntax false"    at Object.action (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1451:25)    at PluginStore.exec (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1500:29)    at /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1927:43    at new Promise (<anonymous>)    at GitExecutorChain.handleTaskData (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1925:16)    at GitExecutorChain.<anonymous> (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1909:44)    at Generator.next (<anonymous>)    at fulfilled (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:52:24)    at process.processTicksAndRejections (node:internal/process/task_queues:95:5).
error	GenerationError: The following packages are still pending.
error		Azure.ResourceManager.HDInsight Azure.ResourceManager.HDInsight.Containers
error		Azure.ResourceManager.HDInsight
  • ️✔️Azure.ResourceManager.HDInsight
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 0b8a5fa9bfd4b64a52a6f69ae99ab1cd5801a689. SDK Automation 14.0.0 
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/hdinsight/armhdinsight [Preview SDK Changes]
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 0b8a5fa9bfd4b64a52a6f69ae99ab1cd5801a689. SDK Automation 14.0.0 
    command	./eng/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-hdinsight [Preview SDK Changes]
    Only showing 120 items here. Refer to log for details.
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog]
info	[Changelog] #### `models.AzureMonitorSelectedConfigurations` was modified
info	[Changelog]
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog]
info	[Changelog] #### `models.ClusterPatchParameters` was modified
info	[Changelog]
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `identity()` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `withIdentity(models.ClusterIdentity)` was added
info	[Changelog]
info	[Changelog] #### `models.ComputeIsolationProperties` was modified
info	[Changelog]
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog]
info	[Changelog] #### `models.ScriptActionExecutionHistoryList` was modified
info	[Changelog]
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog]
info	[Changelog] #### `models.ExcludedServicesConfig` was modified
info	[Changelog]
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog]
info	[Changelog] #### `models.AutoscaleRecurrence` was modified
info	[Changelog]
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog]
info	[Changelog] #### `models.Extension` was modified
info	[Changelog]
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog]
info	[Changelog] #### `models.OperationProperties` was modified
info	[Changelog]
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog]
info	[Changelog] #### `models.ApplicationGetHttpsEndpoint` was modified
info	[Changelog]
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog]
info	[Changelog] #### `models.ClusterCreateRequestValidationParameters` was modified
info	[Changelog]
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog]
info	[Changelog] #### `models.AaddsResourceDetails` was modified
info	[Changelog]
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog]
info	[Changelog] #### `models.EncryptionInTransitProperties` was modified
info	[Changelog]
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog]
info	[Changelog] #### `models.ScriptActionsList` was modified
info	[Changelog]
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog]
info	[Changelog] #### `models.AutoscaleCapacity` was modified
info	[Changelog]
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog]
info	[Changelog] #### `models.ClusterListResult` was modified
info	[Changelog]
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog]
info	[Changelog] #### `models.AzureMonitorRequest` was modified
info	[Changelog]
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog]
info	[Changelog] #### `models.UpdateClusterIdentityCertificateParameters` was modified
info	[Changelog]
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog]
info	[Changelog] #### `models.QuotaInfo` was modified
info	[Changelog]
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog]
info	[Changelog] #### `models.ClusterGetProperties` was modified
info	[Changelog]
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog]
info	[Changelog] #### `models.RuntimeScriptAction` was modified
info	[Changelog]
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog]
info	[Changelog] #### `models.SecurityProfile` was modified
info	[Changelog]
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog]
info	[Changelog] #### `models.ClusterMonitoringRequest` was modified
info	[Changelog]
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog]
info	[Changelog] #### `models.PrivateLinkServiceConnectionState` was modified
info	[Changelog]
info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
info	[Changelog]
info	[Changelog]
️⚠️ azure-sdk-for-python warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from 0b8a5fa9bfd4b64a52a6f69ae99ab1cd5801a689. SDK Automation 14.0.0 
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[automation_init.sh] npm notice
cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
cmderr	[automation_init.sh] npm notice To update run: npm install -g [email protected]
cmderr	[automation_init.sh] npm notice
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-hdinsight [Preview SDK Changes] 
    info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation ExtensionsOperations.begin_disable_azure_monitor_agent
info	[Changelog]   - Added operation ExtensionsOperations.begin_enable_azure_monitor_agent
info	[Changelog]   - Added operation ExtensionsOperations.get_azure_monitor_agent_status
info	[Changelog]   - Model ClusterPatchParameters has a new parameter identity
info	[Changelog]   - Model NetworkProperties has a new parameter outbound_dependencies_managed_type
info	[Changelog]   - Model NetworkProperties has a new parameter public_ip_tag
info	[Changelog]   - Model StorageAccount has a new parameter enable_secure_channel
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 0b8a5fa9bfd4b64a52a6f69ae99ab1cd5801a689. SDK Automation 14.0.0 
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-hdinsight [Preview SDK Changes]
️❌ azure-resource-manager-schemas failed [Detail]
    For more instructions, please refer to the FAQ .
  • ❌Code Generator Failed in generating from 0b8a5fa9bfd4b64a52a6f69ae99ab1cd5801a689. Schema Automation 14.0.0 
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
cmderr	[initScript.sh] npm notice To update run: npm install -g [email protected]
cmderr	[initScript.sh] npm notice
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
cmderr	[generateScript.sh]            ^
cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.
️️✔️ azure-powershell succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 0b8a5fa9bfd4b64a52a6f69ae99ab1cd5801a689. SDK Automation 14.0.0 
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ️✔️Az.hdinsight.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

openapi-pipeline-app[bot] avatar Jun 27 '24 09:06 openapi-pipeline-app[bot]

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/hdinsight/armhdinsight https://apiview.dev/Assemblies/Review/3982e0339ce34d2c908aa0ff15e75c04?revisionId=b6f74f5ca58547699a39218a2d80a037
Java azure-resourcemanager-hdinsight https://apiview.dev/Assemblies/Review/0f291d607ee14c79a2c95ed093df84cb?revisionId=1d04eba415a74a9c99f4b0081eedfb3f
JavaScript @azure/arm-hdinsight https://apiview.dev/Assemblies/Review/c5c3200c460d41c5a727d0fd50572a68?revisionId=3e3853b6dcce4b9083d8182513bd786b

openapi-pipeline-app[bot] avatar Jun 27 '24 09:06 openapi-pipeline-app[bot]

1.Please have the first commit to be the same as existing apiversion. Subsequent commits can have the changes that are to be introduced. This helps to review the changes only. You can choose to abondon this PR and create a new one, or, change the commits. 2. Please fill in the details for https://github.com/Azure/azure-rest-api-specs/pull/29608#issue-2377598408 3. Please fix Swagger LintDiff errors and resubmit for review.

ramoka178 avatar Jun 27 '24 18:06 ramoka178

As the comments from @ramoka178 have been addressed, we removed [ARMChangesRequested] tag to resume the PR review.

yuanhe772 avatar Jul 09 '24 03:07 yuanhe772

Suppressions are added for backward compatibility with the old API versions, therefore they're actually the correct behavior that doesn't violate Microsoft API guidelines, hence we request suppressions to be approved, ty

CC' @madhura-np @ramoka178

yuanhe772 avatar Jul 11 '24 02:07 yuanhe772

The suppression cannot be approved, because the anti-pattern is being repeated for a new type. Please attend ARM office hours for a discussion. https://aka.ms/armofficehours Changing to WaitForARMFeedback to notify author.

madhura-np avatar Jul 11 '24 21:07 madhura-np

Here is the LintDiff report right before suppressions are added. Suppressions comes from both cases:

  • existed APIs from previous API versions (2023-08-15-preview), e.g. azureMonitor.
  • new APIs which have the same format with existed APIs. We added APIs of azureMonitorAgent which are designed to be the same with existed APIs azureMonitor. You can see they are almost the same and have same LintDiff errors.

Since compatibility is the first concern we had when adding those APIs, we added those suppressions rather than updating APIs.

CC @madhura-np @ramoka178

yaning-liu avatar Jul 16 '24 05:07 yaning-liu

Here are the examples of those new APIs which have LintDiff errors:

  1. EvenSegmentedPathForPutOperation PathForNestedResource PutGetPatchResponseSchema ProvisioningStateSpecifiedForLROPut PutRequestResponseSchemeArm PutResponseCodes ResponseSchemaSpecifiedForSuccessStatusCode DefaultErrorResponseSchema LroErrorContent: EnableLinuxClusterAzureMonitorAgent

  2. XmsPageableForListCalls: GetLinuxClusterAzureMonitorAgentStatus

  3. DeleteResponseCodes DefaultErrorResponseSchema LroErrorContent LroLocationHeader: DisableLinuxClusterAzureMonitorAgent

yaning-liu avatar Jul 16 '24 05:07 yaning-liu

The suppression cannot be approved, because the anti-pattern is being repeated for a new type. Please attend ARM office hours for a discussion. https://aka.ms/armofficehours Changing to WaitForARMFeedback to notify author.

Hi @madhura-np, we've just got off the IDC ARM OH, and it was suggested that we should justify the suppressions with more detailed explanations and examples in the comment section, pls refer to @yaning-liu 's comments above ^.

yuanhe772 avatar Jul 16 '24 05:07 yuanhe772

As discuss with @suhasaraos in the meeting:

  • I added scope restrictions to those suppressions.
  • Checked with my team that we had these endpoints (/clusters/{clusterName}/extensions/{extensionName} and /clusters/{clusterName}/extensions/azureMonitorAgent) since the first API version (2015-03-01-preview) until today. It has been working fine. Please help to approve the suppressions.

yaning-liu avatar Jul 17 '24 02:07 yaning-liu

The suppression cannot be approved, because the anti-pattern is being repeated for a new type. Please attend ARM office hours for a discussion. https://aka.ms/armofficehours Changing to WaitForARMFeedback to notify author.

Hi @madhura-np, we've just got off the IDC ARM OH, and it was suggested that we should justify the suppressions with more detailed explanations and examples in the comment section, pls refer to @yaning-liu 's comments above ^.

Added the Approved-Suppresion label

razvanbadea-msft avatar Jul 22 '24 08:07 razvanbadea-msft

comments have been resolved.

yaning-liu avatar Jul 22 '24 09:07 yaning-liu

/pr RequestMerge

yuanhe772 avatar Jul 23 '24 01:07 yuanhe772

/pr RequestMerge

yuanhe772 avatar Jul 24 '24 02:07 yuanhe772