azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

revert changes for user mi

Open jmegha123 opened this issue 1 year ago • 8 comments

ARM (Control Plane) API Specification Update Pull Request

[!TIP] Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

[!NOTE] As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • [ ] New resource provider.
  • [ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • [ ] Update existing version to fix OpenAPI spec quality issues in S360.
  • [ ] Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

  • [ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [ ] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

jmegha123 avatar Apr 25 '24 02:04 jmegha123

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Swagger Validation Report

️❌BreakingChange: 3 Errors, 0 Warnings failed [Detail]
Compared specs (v0.10.8) new version base version
networkWatcher.json 2023-11-01(c0156fc) 2023-11-01(main)
Rule Message
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ManagedServiceIdentity' removed or renamed?
New: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L2346:3
Old: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L2346:3
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'identity' renamed or removed?
New: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L3295:7
Old: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L3299:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'identity' renamed or removed?
New: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L3152:7
Old: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L3152:7
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2023-11-preview package-2023-11-preview(c0156fc) package-2023-11-preview(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
ResourceNameRestriction The resource name parameter 'networkWatcherName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L37
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L178
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L284
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L323
ResourceNameRestriction The resource name parameter 'networkWatcherName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L344
ResourceNameRestriction The resource name parameter 'networkWatcherName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L403
PostResponseCodes 202 response for a LRO POST operation must not have a response schema specified.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L404
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L448
ResourceNameRestriction The resource name parameter 'networkWatcherName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L472
PostResponseCodes 202 response for a LRO POST operation must not have a response schema specified.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L473
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L517
ResourceNameRestriction The resource name parameter 'networkWatcherName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L541
PostResponseCodes 202 response for a LRO POST operation must not have a response schema specified.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L542
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L586
ResourceNameRestriction The resource name parameter 'networkWatcherName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L610
ResourceNameRestriction The resource name parameter 'packetCaptureName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L610
ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L611
PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'PacketCaptures_Create' Request Model: 'parameters[3].schema' Response Model: 'responses[201].schema'
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L611
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L611
XmsResourceInPutResponse The 200 response model for an ARM PUT operation must have x-ms-azure-resource extension set to true in its hierarchy.Operation: PacketCaptures_Create
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L611
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L773
ResourceNameRestriction The resource name parameter 'networkWatcherName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L794
ResourceNameRestriction The resource name parameter 'packetCaptureName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L794
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L795
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L834
ResourceNameRestriction The resource name parameter 'networkWatcherName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L855
ResourceNameRestriction The resource name parameter 'packetCaptureName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L855
PostResponseCodes 202 response for a LRO POST operation must not have a response schema specified.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L856
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L898
ResourceNameRestriction The resource name parameter 'networkWatcherName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2023-11-01/networkWatcher.json#L922
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 1dd6b37d99d9d9e5a04a26023ed9ec46c26a1aae. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.Network [Preview SDK Changes]
    • Microsoft.Azure.Management.Network.26.0.0.nupkg
    • Microsoft.Azure.Management.Network.26.0.0.symbols.nupkg
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 1dd6b37d99d9d9e5a04a26023ed9ec46c26a1aae. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.ResourceManager.Network [Preview SDK Changes]
    • Azure.ResourceManager.Network.1.8.0-alpha.20240509.1.nupkg
    info	[Changelog]
️🔄 azure-sdk-for-python inProgress [Detail]
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 1dd6b37d99d9d9e5a04a26023ed9ec46c26a1aae. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-network-generated [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-network-generated-1.0.0-beta.1-sources.jar
    • azure-resourcemanager-network-generated-1.0.0-beta.1.jar
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 1dd6b37d99d9d9e5a04a26023ed9ec46c26a1aae. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/network/armnetwork [Preview SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `EndpointTypeAzureArcNetwork` added to enum type `EndpointType`
    info	[Changelog] - New enum type `ApplicationGatewaySKUFamily` with values `ApplicationGatewaySKUFamilyGeneration1`, `ApplicationGatewaySKUFamilyGeneration2`
    info	[Changelog] - New enum type `InboundSecurityRuleType` with values `InboundSecurityRuleTypeAutoExpire`, `InboundSecurityRuleTypePermanent`
    info	[Changelog] - New enum type `NicTypeInRequest` with values `NicTypeInRequestPrivateNic`, `NicTypeInRequestPublicNic`
    info	[Changelog] - New enum type `NicTypeInResponse` with values `NicTypeInResponseAdditionalNic`, `NicTypeInResponsePrivateNic`, `NicTypeInResponsePublicNic`
    info	[Changelog] - New enum type `SharingScope` with values `SharingScopeDelegatedServices`, `SharingScopeTenant`
    info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyDeploymentsClient() *FirewallPolicyDeploymentsClient`
    info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyDraftsClient() *FirewallPolicyDraftsClient`
    info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyRuleCollectionGroupDraftsClient() *FirewallPolicyRuleCollectionGroupDraftsClient`
    info	[Changelog] - New function `NewFirewallPolicyDeploymentsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyDeploymentsClient, error)`
    info	[Changelog] - New function `*FirewallPolicyDeploymentsClient.BeginDeploy(context.Context, string, string, *FirewallPolicyDeploymentsClientBeginDeployOptions) (*runtime.Poller[FirewallPolicyDeploymentsClientDeployResponse], error)`
    info	[Changelog] - New function `NewFirewallPolicyDraftsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyDraftsClient, error)`
    info	[Changelog] - New function `*FirewallPolicyDraftsClient.CreateOrUpdate(context.Context, string, string, FirewallPolicyDraft, *FirewallPolicyDraftsClientCreateOrUpdateOptions) (FirewallPolicyDraftsClientCreateOrUpdateResponse, error)`
    info	[Changelog] - New function `*FirewallPolicyDraftsClient.Delete(context.Context, string, string, *FirewallPolicyDraftsClientDeleteOptions) (FirewallPolicyDraftsClientDeleteResponse, error)`
    info	[Changelog] - New function `*FirewallPolicyDraftsClient.Get(context.Context, string, string, *FirewallPolicyDraftsClientGetOptions) (FirewallPolicyDraftsClientGetResponse, error)`
    info	[Changelog] - New function `NewFirewallPolicyRuleCollectionGroupDraftsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyRuleCollectionGroupDraftsClient, error)`
    info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.CreateOrUpdate(context.Context, string, string, string, FirewallPolicyRuleCollectionGroupDraft, *FirewallPolicyRuleCollectionGroupDraftsClientCreateOrUpdateOptions) (FirewallPolicyRuleCollectionGroupDraftsClientCreateOrUpdateResponse, error)`
    info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.Delete(context.Context, string, string, string, *FirewallPolicyRuleCollectionGroupDraftsClientDeleteOptions) (FirewallPolicyRuleCollectionGroupDraftsClientDeleteResponse, error)`
    info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.Get(context.Context, string, string, string, *FirewallPolicyRuleCollectionGroupDraftsClientGetOptions) (FirewallPolicyRuleCollectionGroupDraftsClientGetResponse, error)`
    info	[Changelog] - New function `*VirtualAppliancesClient.Restart(context.Context, string, string, *VirtualAppliancesClientRestartOptions) (VirtualAppliancesClientRestartResponse, error)`
    info	[Changelog] - New struct `ConnectionMonitorEndpointLocationDetails`
    info	[Changelog] - New struct `FirewallPolicyDraft`
    info	[Changelog] - New struct `FirewallPolicyDraftProperties`
    info	[Changelog] - New struct `FirewallPolicyRuleCollectionGroupDraft`
    info	[Changelog] - New struct `FirewallPolicyRuleCollectionGroupDraftProperties`
    info	[Changelog] - New struct `HeaderValueMatcher`
    info	[Changelog] - New struct `PacketCaptureSettings`
    info	[Changelog] - New struct `VirtualApplianceIPConfiguration`
    info	[Changelog] - New struct `VirtualApplianceIPConfigurationProperties`
    info	[Changelog] - New struct `VirtualApplianceInstanceIDs`
    info	[Changelog] - New struct `VirtualApplianceNetworkInterfaceConfiguration`
    info	[Changelog] - New struct `VirtualApplianceNetworkInterfaceConfigurationProperties`
    info	[Changelog] - New struct `VirtualAppliancePropertiesFormatNetworkProfile`
    info	[Changelog] - New field `HeaderValueMatcher` in struct `ApplicationGatewayHeaderConfiguration`
    info	[Changelog] - New field `Family` in struct `ApplicationGatewaySKU`
    info	[Changelog] - New field `LocationDetails`, `SubscriptionID` in struct `ConnectionMonitorEndpoint`
    info	[Changelog] - New field `EnableDirectPortRateLimit` in struct `ExpressRouteCircuitPropertiesFormat`
    info	[Changelog] - New field `RuleType` in struct `InboundSecurityRuleProperties`
    info	[Changelog] - New field `AppliesOn`, `DestinationPortRanges`, `Name` in struct `InboundSecurityRules`
    info	[Changelog] - New field `PrivateIPAddressPrefixLength` in struct `InterfaceIPConfigurationPropertiesFormat`
    info	[Changelog] - New field `CaptureSettings`, `ContinuousCapture` in struct `PacketCaptureParameters`
    info	[Changelog] - New field `CaptureSettings`, `ContinuousCapture` in struct `PacketCaptureResultProperties`
    info	[Changelog] - New field `LocalPath` in struct `PacketCaptureStorageLocation`
    info	[Changelog] - New field `JsChallengeCookieExpirationInMins` in struct `PolicySettings`
    info	[Changelog] - New field `SharingScope` in struct `SubnetPropertiesFormat`
    info	[Changelog] - New field `DpdTimeoutSeconds` in struct `VPNSiteLinkConnectionProperties`
    info	[Changelog] - New field `NicType` in struct `VirtualApplianceNicProperties`
    info	[Changelog] - New field `NetworkProfile` in struct `VirtualAppliancePropertiesFormat`
    info	[Changelog] - New field `EnableOnlyIPv6Peering`, `LocalAddressSpace`, `LocalSubnetNames`, `LocalVirtualNetworkAddressSpace`, `PeerCompleteVnets`, `RemoteSubnetNames` in struct `VirtualNetworkPeeringPropertiesFormat`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 73 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 1dd6b37d99d9d9e5a04a26023ed9ec46c26a1aae. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-network [Preview SDK Changes]
    • azure-arm-network-33.2.0.tgz
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added operation group FirewallPolicyDeployments
    info	[Changelog]   - Added operation group FirewallPolicyDrafts
    info	[Changelog]   - Added operation group FirewallPolicyRuleCollectionGroupDrafts
    info	[Changelog]   - Added operation NetworkVirtualAppliances.restart
    info	[Changelog]   - Added Interface ConnectionMonitorEndpointLocationDetails
    info	[Changelog]   - Added Interface FirewallPolicyDeploymentsDeployHeaders
    info	[Changelog]   - Added Interface FirewallPolicyDeploymentsDeployOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyDraft
    info	[Changelog]   - Added Interface FirewallPolicyDraftsCreateOrUpdateOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyDraftsDeleteOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyDraftsGetOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraft
    info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsCreateOrUpdateOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsDeleteOptionalParams
    info	[Changelog]   - Added Interface FirewallPolicyRuleCollectionGroupDraftsGetOptionalParams
    info	[Changelog]   - Added Interface HeaderValueMatcher
    info	[Changelog]   - Added Interface NetworkVirtualApplianceInstanceIds
    info	[Changelog]   - Added Interface NetworkVirtualAppliancePropertiesFormatNetworkProfile
    info	[Changelog]   - Added Interface NetworkVirtualAppliancesRestartOptionalParams
    info	[Changelog]   - Added Interface PacketCaptureSettings
    info	[Changelog]   - Added Interface VirtualApplianceIPConfiguration
    info	[Changelog]   - Added Interface VirtualApplianceIPConfigurationProperties
    info	[Changelog]   - Added Interface VirtualApplianceNetworkInterfaceConfiguration
    info	[Changelog]   - Added Interface VirtualApplianceNetworkInterfaceConfigurationProperties
    info	[Changelog]   - Added Type Alias ApplicationGatewaySkuFamily
    info	[Changelog]   - Added Type Alias FirewallPolicyDeploymentsDeployResponse
    info	[Changelog]   - Added Type Alias FirewallPolicyDraftsCreateOrUpdateResponse
    info	[Changelog]   - Added Type Alias FirewallPolicyDraftsGetResponse
    info	[Changelog]   - Added Type Alias FirewallPolicyRuleCollectionGroupDraftsCreateOrUpdateResponse
    info	[Changelog]   - Added Type Alias FirewallPolicyRuleCollectionGroupDraftsGetResponse
    info	[Changelog]   - Added Type Alias InboundSecurityRuleType
    info	[Changelog]   - Added Type Alias NicTypeInRequest
    info	[Changelog]   - Added Type Alias NicTypeInResponse
    info	[Changelog]   - Added Type Alias SharingScope
    info	[Changelog]   - Interface ApplicationGatewayHeaderConfiguration has a new optional parameter headerValueMatcher
    info	[Changelog]   - Interface ApplicationGatewaySku has a new optional parameter family
    info	[Changelog]   - Interface ConnectionMonitorEndpoint has a new optional parameter locationDetails
    info	[Changelog]   - Interface ConnectionMonitorEndpoint has a new optional parameter subscriptionId
    info	[Changelog]   - Interface ExpressRouteCircuit has a new optional parameter enableDirectPortRateLimit
    info	[Changelog]   - Interface InboundSecurityRule has a new optional parameter ruleType
    info	[Changelog]   - Interface InboundSecurityRules has a new optional parameter appliesOn
    info	[Changelog]   - Interface InboundSecurityRules has a new optional parameter destinationPortRanges
    info	[Changelog]   - Interface InboundSecurityRules has a new optional parameter name
    info	[Changelog]   - Interface NetworkInterfaceIPConfiguration has a new optional parameter privateIPAddressPrefixLength
    info	[Changelog]   - Interface NetworkVirtualAppliance has a new optional parameter networkProfile
    info	[Changelog]   - Interface PacketCapture has a new optional parameter captureSettings
    info	[Changelog]   - Interface PacketCapture has a new optional parameter continuousCapture
    info	[Changelog]   - Interface PacketCaptureParameters has a new optional parameter captureSettings
    info	[Changelog]   - Interface PacketCaptureParameters has a new optional parameter continuousCapture
    info	[Changelog]   - Interface PacketCaptureResult has a new optional parameter captureSettings
    info	[Changelog]   - Interface PacketCaptureResult has a new optional parameter continuousCapture
    info	[Changelog]   - Interface PacketCaptureStorageLocation has a new optional parameter localPath
    info	[Changelog]   - Interface PolicySettings has a new optional parameter jsChallengeCookieExpirationInMins
    info	[Changelog]   - Interface Subnet has a new optional parameter sharingScope
    info	[Changelog]   - Interface VirtualApplianceNicProperties has a new optional parameter nicType
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter enableOnlyIPv6Peering
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localAddressSpace
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localSubnetNames
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter localVirtualNetworkAddressSpace
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter peerCompleteVnets
    info	[Changelog]   - Interface VirtualNetworkPeering has a new optional parameter remoteSubnetNames
    info	[Changelog]   - Interface VpnSiteLinkConnection has a new optional parameter dpdTimeoutSeconds
    info	[Changelog]   - Added Enum KnownApplicationGatewaySkuFamily
    info	[Changelog]   - Added Enum KnownInboundSecurityRuleType
    info	[Changelog]   - Added Enum KnownNicTypeInRequest
    info	[Changelog]   - Added Enum KnownNicTypeInResponse
    info	[Changelog]   - Added Enum KnownSharingScope
    info	[Changelog]   - Enum KnownEndpointType has a new value AzureArcNetwork
️❌ azure-resource-manager-schemas failed [Detail]
  • Code Generator Failed in generating from 1dd6b37d99d9d9e5a04a26023ed9ec46c26a1aae. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh]  notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Skip package processing as generation is failed
    error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning in generating from 1dd6b37d99d9d9e5a04a26023ed9ec46c26a1aae. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.network.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

/azp run

jmegha123 avatar Apr 25 '24 04:04 jmegha123

Azure Pipelines successfully started running 4 pipeline(s).

azure-pipelines[bot] avatar Apr 25 '24 04:04 azure-pipelines[bot]

Lint Diff is an existing issue https://github.com/Azure/azure-openapi-validator/issues/680 of the Lint tool

Please provide exception approval for it

jmegha123 avatar Apr 25 '24 05:04 jmegha123

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

Please fill in purpose of PR and due diligence sections

TimLovellSmith avatar May 02 '24 18:05 TimLovellSmith

updated Purpose and Due diligence check section above

jmegha123 avatar May 04 '24 11:05 jmegha123