Azure
Microsoft.Security 2024-05-15-preview DevOps Policy
ARM (Control Plane) API Specification Update Pull Request
[!TIP] Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.
[!NOTE] As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1, Breaking Changes review
If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.
Click here to see the details of Step 2, ARM review
See https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
- [ ] New resource provider.
- [x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
- [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
- [ ] Update existing version to fix OpenAPI spec quality issues in S360.
- [ ] Other, please clarify:
- edit this with your clarification
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:
- [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
- [x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.
Getting help
- First, please carefully read through this PR description, from top to bottom. Please fill out the
Purpose of this PRandDue diligence checklist. - To understand what you must do next to merge this PR, see the
Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state. - For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
- For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
- If the PR CI checks appear to be stuck in
queuedstate, please add a comment with contents/azp run. This should result in a new comment denoting aPR validation pipelinehas started and the checks should be updated after few minutes. - If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
Next Steps to Merge
✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 9 Errors, 9 Warnings failed [Detail]
| Compared specs (v0.10.9) | new version | base version |
|---|---|---|
| securityConnectorsDevOps.json | 2024-05-15-preview(10853c2) | 2024-04-01(main) |
| securityConnectorsDevOps.json | 2024-05-15-preview(10853c2) | 2023-09-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
The following breaking changes are detected by comparison with the latest preview version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 2 Errors, 32 Warnings failed [Detail]
| Compared specs (v2.2.2) | new version | base version |
|---|---|---|
| package-composite-v3 | package-composite-v3(10853c2) | package-composite-v3(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 30 items are listed, please refer to log for more details.
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| :warning: MULTIPLE_API_VERSION | The default tag contains multiple API versions swaggers. readme: specification/security/resource-manager/readme.md tag: specification/security/resource-manager/readme.md#tag-package-composite-v3 |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️✔️Succeeded in generating from 0f1d2d5a28f7e0b64abd00c0d942a93d18807462. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️Azure.ResourceManager.SecurityCenter [Preview SDK Changes]- Azure.ResourceManager.SecurityCenter.1.2.0-alpha.20240528.1.nupkg
info [Changelog]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded in generating from 0f1d2d5a28f7e0b64abd00c0d942a93d18807462. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/security/armsecurity [Preview SDK Changes]
️⚠️ azure-sdk-for-python warning [Detail]
⚠️Warning in generating from 0f1d2d5a28f7e0b64abd00c0d942a93d18807462. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1 cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. cmderr [automation_init.sh] cmderr [automation_init.sh] npm notice New minor version of npm available! 10.5.0 -> 10.8.0 cmderr [automation_init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.8.0> cmderr [automation_init.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_init.sh] npm notice command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json warn No file changes detected after generation warn No package detected after generation
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded in generating from 0f1d2d5a28f7e0b64abd00c0d942a93d18807462. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-security [Preview SDK Changes]- azure-arm-security-6.0.0-beta.6.tgz
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
️✔️Succeeded in generating from 0f1d2d5a28f7e0b64abd00c0d942a93d18807462. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-security [Preview SDK Changes]- pom.xml
- azure-resourcemanager-security-1.0.0-beta.8-sources.jar
- azure-resourcemanager-security-1.0.0-beta.8.jar
️❌ azure-resource-manager-schemas failed [Detail]
❌Code Generator Failed in generating from 0f1d2d5a28f7e0b64abd00c0d942a93d18807462. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az' cmderr [initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'... cmderr [initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types' cmderr [initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'... cmderr [initScript.sh] notice cmderr [initScript.sh] npm notice New minor version of npm available! 10.5.0 -> 10.8.0 cmderr [initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.8.0> cmderr [initScript.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [initScript.sh] npm notice error Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json cmderr [generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500 cmderr [generateScript.sh] return new TSError(diagnosticText, diagnosticCodes) cmderr [generateScript.sh] ^ cmderr [generateScript.sh] TSError: ⨯ Unable to compile TypeScript: cmderr [generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations. cmderr [generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type. cmderr [generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type. cmderr [generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'. cmderr [generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig. cmderr [generateScript.sh] at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12) cmderr [generateScript.sh] at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19) cmderr [generateScript.sh] at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36) cmderr [generateScript.sh] at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32) cmderr [generateScript.sh] at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43) cmderr [generateScript.sh] at Module._extensions..js (node:internal/modules/cjs/loader:1422:10) cmderr [generateScript.sh] at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12) cmderr [generateScript.sh] at Module.load (node:internal/modules/cjs/loader:1203:32) cmderr [generateScript.sh] at Function.Module._load (node:internal/modules/cjs/loader:1019:12) cmderr [generateScript.sh] at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12) error Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh warn Skip package processing as generation is failed error ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.
️⚠️ azure-powershell warning [Detail]
⚠️Warning in generating from 0f1d2d5a28f7e0b64abd00c0d942a93d18807462. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
⚠️Az.security.DefaultTag [Preview SDK Changes]
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Go | sdk/resourcemanager/security/armsecurity | https://apiview.dev/Assemblies/Review/88de20a29c604e9cbb6f756102580913?revisionId=3903a19c120b4dddb5a07c8597d34766 |
| Java | azure-resourcemanager-security | https://apiview.dev/Assemblies/Review/4bbce61669f64b1bb4b00043576ed1e7?revisionId=a5f6f1a2e4d2492280de67c19adfbfba |
| JavaScript | @azure/arm-security | https://apiview.dev/Assemblies/Review/7b0611da161f46f58e9bb08f96d69207?revisionId=7ff5e15e265b4bbeaa67ad563842d28f |
| .Net | Azure.ResourceManager.SecurityCenter | https://apiview.dev/Assemblies/Review/74fbb1c9067c4827bd67f3e2cffb4080?revisionId=ee32961ddd1b4070a18faebf13676225 |
| Swagger | Microsoft.Security | https://apiview.dev/Assemblies/Review/0be86090d4af4a1abff7bcf36507d1ab?revisionId=1675bed7e564486fad2f5cceb6633316 |
This looks to be just copying the older stable version 2024-04-01 into this new preview api version. Are there any other additional changes you are doing ?
Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️⌛BreakingChange pending [Detail]
️🔄Breaking Change(Cross-Version) inProgress [Detail]
️⌛CredScan pending [Detail]
️⌛LintDiff pending [Detail]
️🔄Avocado inProgress [Detail]
️⌛SwaggerAPIView pending [Detail]
️🔄TypeSpecAPIView inProgress [Detail]
️🔄ModelValidation inProgress [Detail]
️🔄SemanticValidation inProgress [Detail]
️⌛PoliCheck pending [Detail]
️⌛SpellCheck pending [Detail]
️⌛Lint(RPaaS) pending [Detail]
️⌛PR Summary pending [Detail]
️⌛Automated merging requirements met pending [Detail]
This looks to be just copying the older stable version 2024-04-01 into this new preview api version. Are there any other additional changes you are doing ?
I completely forgot to push my latest commit.
There are new endpoints for DevOps Policy - devops/default/policies and devops/default/policyAssignments and I made ProvisioningState readOnly.
It's now throwing a breaking change for making the ProvState readonly, but our RP has always had it readonly, it just wasnt properly defined in the Swagger
@Ramoka178
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
},
is this needed ? #Resolved
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2024-05-15-preview/securityConnectorsDevOps.json:1097 in 4e12e73. [](commit_id = 4e12e73f75cf2a818e5c910bcd74393b35ef6695, deletion_comment = False)
"DevOpsPolicyAssignmentProperties": {
same comments as DevOpsPolicyProperties for common properties #Resolved
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2024-05-15-preview/securityConnectorsDevOps.json:2555 in 4e12e73. [](commit_id = 4e12e73f75cf2a818e5c910bcd74393b35ef6695, deletion_comment = False)
"overridesDescendantAssignments": {
Standard guidance is: replace boolean/switch properties with a more meaningful enum whenever possible.
A boolean will forever have two valid values (true or false). A string enum type is always preferred. Also, properties should always provide better values just than True and False. For example two switches "isTypeA" and "isTypeB" should be replaced with one enum "type": [A, B, DefaultType]. Enums are always a more flexible and future proof option because they allow additional values to be added in the future in a non-breaking way, e.g. [Enabled, Disabled, Suspended, Deallocated].
Note: do NOT define a 'boolean enum' with two values 'True and False'. This might be easier to 'extend' in terms of types, but semantically its cofusing, and no better than a boolean. #Resolved
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2024-05-15-preview/securityConnectorsDevOps.json:2583 in 4e12e73. [](commit_id = 4e12e73f75cf2a818e5c910bcd74393b35ef6695, deletion_comment = False)
"resourceIdentifier": {
is this resourceId ? format: arm-id ? #Resolved
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2024-05-15-preview/securityConnectorsDevOps.json:2579 in 4e12e73. [](commit_id = 4e12e73f75cf2a818e5c910bcd74393b35ef6695, deletion_comment = False)
"assignedAtUtc": {
assignedAt #Resolved
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2024-05-15-preview/securityConnectorsDevOps.json:2590 in 4e12e73. [](commit_id = 4e12e73f75cf2a818e5c910bcd74393b35ef6695, deletion_comment = False)
"name": {
any regex pattern restrictions ? #Resolved
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2024-05-15-preview/securityConnectorsDevOps.json:2601 in 4e12e73. [](commit_id = 4e12e73f75cf2a818e5c910bcd74393b35ef6695, deletion_comment = False)
"version": {
possible to have enums ? #Resolved
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2024-05-15-preview/securityConnectorsDevOps.json:2609 in 4e12e73. [](commit_id = 4e12e73f75cf2a818e5c910bcd74393b35ef6695, deletion_comment = False)
"id": {
arm-id ? #Resolved
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2024-05-15-preview/securityConnectorsDevOps.json:2605 in 4e12e73. [](commit_id = 4e12e73f75cf2a818e5c910bcd74393b35ef6695, deletion_comment = False)
"assignmentId": {
arm-id ? #Resolved
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2024-05-15-preview/securityConnectorsDevOps.json:2574 in 4e12e73. [](commit_id = 4e12e73f75cf2a818e5c910bcd74393b35ef6695, deletion_comment = False)
"provisioningStatusMessage": {
provisioningState gives the same meaning though right ? #Resolved
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2024-05-15-preview/securityConnectorsDevOps.json:2640 in 4e12e73. [](commit_id = 4e12e73f75cf2a818e5c910bcd74393b35ef6695, deletion_comment = False)
"provisioningStatusUpdateTimeUtc": {
provisioningStatusUpdatedAt. You can mention the format and time zone in description.
#Resolved
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2024-05-15-preview/securityConnectorsDevOps.json:2646 in 4e12e73. [](commit_id = 4e12e73f75cf2a818e5c910bcd74393b35ef6695, deletion_comment = False)
"policyId": {
format: arm-id? #Resolved
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2024-05-15-preview/securityConnectorsDevOps.json:2658 in 4e12e73. [](commit_id = 4e12e73f75cf2a818e5c910bcd74393b35ef6695, deletion_comment = False)
"version": {
are there a set of versions that this can be made enum ? #Resolved
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2024-05-15-preview/securityConnectorsDevOps.json:2668 in 4e12e73. [](commit_id = 4e12e73f75cf2a818e5c910bcd74393b35ef6695, deletion_comment = False)
"webUrl": {
format: url
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2024-05-15-preview/securityConnectorsDevOps.json:2663 in 4e12e73. [](commit_id = 4e12e73f75cf2a818e5c910bcd74393b35ef6695, deletion_comment = False)
},
are these 2 needed ? #Resolved
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2024-05-15-preview/securityConnectorsDevOps.json:1199 in 4e12e73. [](commit_id = 4e12e73f75cf2a818e5c910bcd74393b35ef6695, deletion_comment = False)
This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
Learn more at aka.ms/azsdk/pr-arm-review.
},is this needed ?
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2024-05-15-preview/securityConnectorsDevOps.json:1097 in 4e12e73. [](commit_id = 4e12e73, deletion_comment = False)
This is to allow filtering by policy type in the return. Will be needed by our UX for this preview version
"version": {possible to have enums ?
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2024-05-15-preview/securityConnectorsDevOps.json:2609 in 4e12e73. [](commit_id = 4e12e73, deletion_comment = False)
Updated the description, this refers to semantic versioning so enums arent possible
},are these 2 needed ?
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2024-05-15-preview/securityConnectorsDevOps.json:1199 in 4e12e73. [](commit_id = 4e12e73, deletion_comment = False)
Needed for filtering by our UX for this preview version. In future when we can publish to ARG, we will remove from the RP
"provisioningStatusMessage": {provisioningState gives the same meaning though right ?
Refers to: specification/security/resource-manager/Microsoft.Security/preview/2024-05-15-preview/securityConnectorsDevOps.json:2640 in 4e12e73. [](commit_id = 4e12e73, deletion_comment = False)
For provisioningStatusUpdateTimeUtc and provisioningStatusMessage, these are properties in our RP's base resource classwhere every resource we support has them and so changing it for this preview version would incur a lot of cost and inconsistency in the short term,
I've brought up these changes to my wider team and its something we will pursue in our next GA version