Azure
[Hub Generated] Publish private branch 'rahuls-microsoft-quota-Microsoft.Quota-GroupQuota-Update'
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
[!TIP] Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.
[!NOTE] As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
- For help with Step 2 / "ARM review", see https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
- [ ] New resource provider.
- [ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
- [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
- [ ] Update existing version to fix OpenAPI spec quality issues in S360.
- [ ] Other, please clarify:
- edit this with your clarification
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:
- [ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
- [ ] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.
Getting help
- First, please carefully read through this PR description, from top to bottom. Please fill out the
Purpose of this PRandDue diligence checklist. - To understand what you must do next to merge this PR, see the
Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state. - For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
- For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
- If the PR CI checks appear to be stuck in
queuedstate, please add a comment with contents/azp run. This should result in a new comment denoting aPR validation pipelinehas started and the checks should be updated after few minutes. - If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/15893
Next Steps to Merge
✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️❌BreakingChange: 8 Errors, 0 Warnings failed [Detail]
| Compared specs (v0.10.7) | new version | base version |
|---|---|---|
| quota.json | 2023-06-01-preview(69a1ccd) | 2023-06-01-preview(main) |
| Rule | Message |
|---|---|
|
The new version is adding a path that was not found in the old version. New: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L37:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L85:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L136:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L302:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L353:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L398:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L450:5 |
|
"new":"https://github.com/Azure/azure-rest-api-specs/blob/69a1ccd8f036643aa4c9aa6d8b64f754759ac1d9/specification/quota/resource-manager/Microsoft.Quota/preview/2023-06-01-preview/groupquota.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/quota/resource-manager/Microsoft.Quota/preview/2023-06-01-preview/groupquota.json", "details":"Breaking change detector (OAD) invoked AutoRest. AutoRest threw a runtime error. First 20 lines of stack trace follow, indexed. First line should contain AutoRest command line invocation details. Remaining lines should contain the main message reported by AutoRest. ==================== 1: Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.94/common/temp/node_modules/.pnpm/@[email protected]/node_modules/autorest/dist/app.js" --v2 --input-file=specification/quota/resource-manager/Microsoft.Quota/preview/2023-06-01-preview/groupquota.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp/oad-2AZnJD 2: ERROR: Schema violation: Data does not match any schemas from 'oneOf' 3: 4: code: 'ONE-OF-MISSING', 5: params: [], 6: message: "Data does not match any schemas from 'oneOf'", 7: path: '#/paths/~1providers~1Microsoft.Management~1managementGroups~1managementGroupId~1providers~1Microsoft.Quota~1groupQuotas~1groupQuotaName~1resourceProviders~1resourceProviderName~1locationSettings~1location/patch/x-ms-examples/GroupQuotaLocationSettings-Patch', 8: schemaId: 'https://raw.githubusercontent.com/Azure/autorest/master/schema/swagger-extensions.json#', 9: inner: [ 10: 11: code: 'INVALID-TYPE', 12: params: [ 'string', 'integer' ], 13: message: 'Expected type string but found type integer', 14: path: '#/paths/~1providers~1Microsoft.Management~1managementGroups~1managementGroupId~1providers~1Microsoft.Quota~1groupQuotas~1groupQuotaName~1resourceProviders~1resourceProviderName~1locationSettings~1location/patch/x-ms-examples/GroupQuotaLocationSettings-Patch/responses/202/headers/retry-after', 15: schemaId: undefined, 16: description: 'An example value of the retry-after header sent by the server, if applicable in the example.' 17: , 18: 19: code: 'OBJECT-MISSING-REQUIRED-PROPERTY', 20: params: [ '$ref' ], " |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 2 Errors, 7 Warnings failed [Detail]
| Compared specs (v2.2.0) | new version | base version |
|---|---|---|
| package-2023-06-01-preview | package-2023-06-01-preview(69a1ccd) | package-2023-06-01-preview(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
Query parameter $filter should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Quota/preview/2023-06-01-preview/groupquota.json#L687 |
RPC-Get-V1-08 |
|
Query parameter $filter should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Quota/preview/2023-06-01-preview/groupquota.json#L1080 |
RPC-Get-V1-08 |
| :warning: AvoidNestedProperties | Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Quota/preview/2023-06-01-preview/groupquota.json#L1747 |
|
| :warning: XmsIdentifierValidation | Missing identifier id in array item property Location: Microsoft.Quota/preview/2023-06-01-preview/groupquota.json#L1858 |
|
| :warning: AvoidNestedProperties | Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Quota/preview/2023-06-01-preview/groupquota.json#L1964 |
|
| :warning: AllProxyResourcesShouldHaveDelete | The resource SubmittedResourceRequestStatus does not have a corresponding delete operation. Location: Microsoft.Quota/preview/2023-06-01-preview/groupquota.json#L2134 |
RPC-Delete-V1-05 |
| :warning: AvoidNestedProperties | Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Quota/preview/2023-06-01-preview/groupquota.json#L2143 |
|
| :warning: AllProxyResourcesShouldHaveDelete | The resource GroupQuotasEnforcementResponse does not have a corresponding delete operation. Location: Microsoft.Quota/preview/2023-06-01-preview/groupquota.json#L2510 |
RPC-Delete-V1-05 |
| :warning: AvoidNestedProperties | Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Quota/preview/2023-06-01-preview/groupquota.json#L2519 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The resource name parameter 'resourceName' should be defined with a 'pattern' restriction. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L37 |
|
The parameters:resourceName,scope should be kept in the same order as they present in the path. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L38 |
|
The resource name parameter 'resourceName' should be defined with a 'pattern' restriction. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L136 |
|
The parameters:resourceName,scope should be kept in the same order as they present in the path. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L137 |
|
The parameters:resourceName,scope should be kept in the same order as they present in the path. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L183 |
|
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L183 |
|
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L183 |
|
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L183 |
|
A 202 response should include an Location response header. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L234 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L240 |
|
The parameters:resourceName,scope should be kept in the same order as they present in the path. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L245 |
|
Properties of a PATCH request body must not be required, property:limitObjectType. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L278 |
|
200 response schema in long running PATCH operation is missing ProvisioningState property. A LRO PATCH operations 200 response schema must have ProvisioningState specified. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L284 |
|
A 202 response should include an Location response header. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L290 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L296 |
|
The parameters:id,scope should be kept in the same order as they present in the path. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L354 |
|
The response schema of operations API '/providers/Microsoft.Quota/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L474 |
|
Operations API path must follow the schema provided in the common types. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L475 |
|
The parameter 'ApiVersionParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L1239 |
| :warning: AvoidNestedProperties | Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Quota/preview/2023-06-01-preview/groupquota.json#L2012 |
| :warning: RequiredReadOnlySystemData | The response of operation:'Usages_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L38 |
| :warning: RequiredReadOnlySystemData | The response of operation:'Quota_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L137 |
| :warning: UniqueXmsExample | Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Quotas_UsagesRequest_ForNetwork Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L143 |
| :warning: RequiredReadOnlySystemData | The response of operation:'Quota_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L183 |
| :warning: RequiredReadOnlySystemData | The response of operation:'Quota_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L245 |
| :warning: SchemaDescriptionOrTitle | Schema should have a description or title. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L489 |
| :warning: SchemaDescriptionOrTitle | Schema should have a description or title. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L507 |
| :warning: SchemaDescriptionOrTitle | Schema should have a description or title. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L521 |
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L615 |
| :warning: AllProxyResourcesShouldHaveDelete | The resource CurrentQuotaLimitBase does not have a corresponding delete operation. Location: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L643 |
️❌Avocado: 22 Errors, 0 Warnings failed [Detail]
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️❌ azure-sdk-for-net-track2 failed [Detail]
❌Failed [Logs] Generate from ba08fd2480aa831f35bb0b5455c2dc4b42d2b62b. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1mLine |[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m 714 | [0m [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m | [31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m | [31;1mFailed to generate sdk. exit code: False[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1mGet-ChildItem: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1mLine |[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m 807 | [0m … rtifacts += [36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s[0m …[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m | [31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m | [31;1mCannot find path[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m[31;1m[36;1m | [31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m[31;1m[36;1m[31;1m[36;1m | [31;1mit does not exist.[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1mLine |[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m 714 | [0m [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m | [31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~[0m cmderr [Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m | [31;1mFailed to generate sdk artifact[0m
❌Azure.ResourceManager.Quota [View full logs] [Preview SDK Changes]info [Changelog]
️⚠️ azure-sdk-for-python warning [Detail]
⚠️Warning [Logs] Generate from ba08fd2480aa831f35bb0b5455c2dc4b42d2b62b. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] npm notice cmderr [automation_generate.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.1 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.1> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️azure-mgmt-quota [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation group GroupQuotaLimitsOperations info [Changelog] - Added operation group GroupQuotaLimitsRequestOperations info [Changelog] - Added operation group GroupQuotaLocationSettingsOperations info [Changelog] - Added operation group GroupQuotaSubscriptionAllocationOperations info [Changelog] - Added operation group GroupQuotaSubscriptionAllocationRequestOperations info [Changelog] - Added operation group GroupQuotaSubscriptionRequestsOperations info [Changelog] - Added operation group GroupQuotaSubscriptionsOperations info [Changelog] - Added operation group GroupQuotaUsagesOperations info [Changelog] - Added operation group GroupQuotasOperations info [Changelog] - Model QuotaRequestDetails has a new parameter properties info [Changelog] info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Model QuotaRequestDetails no longer has parameter error info [Changelog] - Model QuotaRequestDetails no longer has parameter message info [Changelog] - Model QuotaRequestDetails no longer has parameter provisioning_state info [Changelog] - Model QuotaRequestDetails no longer has parameter request_submit_time info [Changelog] - Model QuotaRequestDetails no longer has parameter value info [Changelog] - Model QuotaRequestOneResourceSubmitResponse no longer has parameter current_value info [Changelog] - Model QuotaRequestOneResourceSubmitResponse no longer has parameter error info [Changelog] - Model QuotaRequestOneResourceSubmitResponse no longer has parameter is_quota_applicable info [Changelog] - Model QuotaRequestOneResourceSubmitResponse no longer has parameter limit info [Changelog] - Model QuotaRequestOneResourceSubmitResponse no longer has parameter message info [Changelog] - Model QuotaRequestOneResourceSubmitResponse no longer has parameter name_properties_name info [Changelog] - Model QuotaRequestOneResourceSubmitResponse no longer has parameter provisioning_state info [Changelog] - Model QuotaRequestOneResourceSubmitResponse no longer has parameter quota_period info [Changelog] - Model QuotaRequestOneResourceSubmitResponse no longer has parameter request_submit_time info [Changelog] - Model QuotaRequestOneResourceSubmitResponse no longer has parameter resource_type info [Changelog] - Model QuotaRequestOneResourceSubmitResponse no longer has parameter unit info [Changelog] - Model QuotaRequestSubmitResponse202 no longer has parameter limit info [Changelog] - Model QuotaRequestSubmitResponse202 no longer has parameter message info [Changelog] - Model QuotaRequestSubmitResponse202 no longer has parameter name_properties_name info [Changelog] - Model QuotaRequestSubmitResponse202 no longer has parameter provisioning_state info [Changelog] - Model QuotaRequestSubmitResponse202 no longer has parameter quota_period info [Changelog] - Model QuotaRequestSubmitResponse202 no longer has parameter resource_type info [Changelog] - Model QuotaRequestSubmitResponse202 no longer has parameter unit
Present SDK breaking changes suppressions No suppression file added.
Absent SDK breaking changes suppressions - Model QuotaRequestDetails no longer has parameter error - Model QuotaRequestDetails no longer has parameter message - Model QuotaRequestDetails no longer has parameter provisioning_state - Model QuotaRequestDetails no longer has parameter request_submit_time - Model QuotaRequestDetails no longer has parameter value - Model QuotaRequestOneResourceSubmitResponse no longer has parameter current_value - Model QuotaRequestOneResourceSubmitResponse no longer has parameter error - Model QuotaRequestOneResourceSubmitResponse no longer has parameter is_quota_applicable - Model QuotaRequestOneResourceSubmitResponse no longer has parameter limit - Model QuotaRequestOneResourceSubmitResponse no longer has parameter message - Model QuotaRequestOneResourceSubmitResponse no longer has parameter name_properties_name - Model QuotaRequestOneResourceSubmitResponse no longer has parameter provisioning_state - Model QuotaRequestOneResourceSubmitResponse no longer has parameter quota_period - Model QuotaRequestOneResourceSubmitResponse no longer has parameter request_submit_time - Model QuotaRequestOneResourceSubmitResponse no longer has parameter resource_type - Model QuotaRequestOneResourceSubmitResponse no longer has parameter unit - Model QuotaRequestSubmitResponse202 no longer has parameter limit - Model QuotaRequestSubmitResponse202 no longer has parameter message - Model QuotaRequestSubmitResponse202 no longer has parameter name_properties_name - Model QuotaRequestSubmitResponse202 no longer has parameter provisioning_state - Model QuotaRequestSubmitResponse202 no longer has parameter quota_period - Model QuotaRequestSubmitResponse202 no longer has parameter resource_type - Model QuotaRequestSubmitResponse202 no longer has parameter unit
Parse Suppression File Errors No suppression file added.
Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs] Generate from ba08fd2480aa831f35bb0b5455c2dc4b42d2b62b. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-quota [View full logs] [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from ba08fd2480aa831f35bb0b5455c2dc4b42d2b62b. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/quota/armquota [View full logs] [Preview SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from ba08fd2480aa831f35bb0b5455c2dc4b42d2b62b. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-quota [View full logs] [Preview SDK Changes]
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from ba08fd2480aa831f35bb0b5455c2dc4b42d2b62b. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] npm notice cmderr [initScript.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.1 cmderr [initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.1> cmderr [initScript.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [initScript.sh] npm notice warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️quota [View full logs] [Preview Schema Changes]
️⚠️ azure-powershell warning [Detail]
⚠️Warning [Logs] Generate from ba08fd2480aa831f35bb0b5455c2dc4b42d2b62b. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
⚠️Az.quota.DefaultTag [View full logs] [Preview SDK Changes]
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Go | sdk/resourcemanager/quota/armquota | https://apiview.dev/Assemblies/Review/2240947364984f26bb2e33fabc6c9977?revisionId=cc333f3d6c1147d6a4200ebe57e1ff89 |
| JavaScript | @azure/arm-quota | https://apiview.dev/Assemblies/Review/166160c2c3eb435d9cfc004062a94073?revisionId=5649e39fe49d48d297745ed7221b936e |
| Java | azure-resourcemanager-quota | https://apiview.dev/Assemblies/Review/3820744e9b174f1db39817eaf9819e47?revisionId=089434ad27874f0abc05b473d4307a79 |
| Swagger | Microsoft.Quota | https://apiview.dev/Assemblies/Review/68231935e236449991c31c50e5145e97?revisionId=1c56a2d028a24a3cab97975a1153e982 |
@msyyc @tadelesh - This is the new PR based on the PR branch with the history. So, all the approval should be visible.
Please let me know, if any further action is needed from my side? Thanks for your help to merge this PR.
Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
Please address or respond to feedback from the ARM API reviewer. When you are ready to continue the ARM API review, please remove the
ARMChangesRequestedlabel. This will notify the reviewer to have another look. If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel. Please include[ARM Query]in the title of your question to indicate that it is ARM-related.
The new API version is getting updated. No customer, user onboarded. The API was changed based on the ARM team's suggestion, as ARM routing was not working 3 providers in the URI.
The details are reviewed by ARM multiple ARM team members and signed off.
[ARM Query] Hi ARM Team, the swagger was reviewed by ARM team members, which you can see in the history. Please let me know if there any questions.
Original PR on PR branch was - https://github.com/Azure/azure-rest-api-specs-pr/pull/15893
Snapshot from the PR for reference-
[ARM Query] Hi ARM Team, the swagger was reviewed by ARM team members, which you can see in the history. Please let me know if there any questions. Original PR on PR branch was - Azure/azure-rest-api-specs-pr#15893 Snapshot from the PR for reference-
Adding @TimLovellSmith Who reviewed the API from ARM side on the PR.
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
Please get a breaking changes approval from Azure Breaking Changes Reviewers [email protected] and ARM can review the changes afterwards.
And fix the lint diff error and model validation error.
Please get a breaking changes approval from Azure Breaking Changes Reviewers [email protected] and ARM can review the changes afterwards.
And fix the lint diff error and model validation error.
The changes are for the new GroupQuota APIs. And no customers are onboarded yet. So, there should not be any impact. For Private preview, the GroupQuota API was changed based on ARM team suggestions, as there were 3 providers in the URL, which was breaking ARM routing. It was already reviewed and signed off. Do we need to get started again with all the process? We have spent more than a month going through all the reviews!
Please check the previous approvals. So, that we can expedite the process.
Hi ARM Reviewer -
- This is the private preview of API, no customer is onboarded, hence won't require BreakingChange review.
- This API was approved in the PR branch by ARM reviewers. Please check the notes in original PR on PR branch was - https://github.com/Azure/azure-rest-api-specs-pr/pull/15893
- This is a new API version, still getting ready for Private Preview.
Please let me know if there are any questions to expedite the review process.
@msyyc Please let me know if any action is needed from my side? When we can merge the swagger and generate the SDKs, as lots of internal teams are waiting for it to onboard the new GroupQuota APIs. Thanks for your help and expedited action.
The remaining LintDiff errors are already approved, as -
- This API is at MG level, not subscription level.
- The filter parameters are added after ARM review discussion, as ARM routing doesn't work with 3 providers in URI.
Please let me know how I can help to expedite the merging. Thanks. Rahul.
Hi @msyyc The remaining LintDiff errors are already approved, as -
- This API is at MG level, not subscription level.
- The filter parameters are added after ARM review discussion, as ARM routing doesn't work with 3 providers in URI.
Please let me know how I can help to expedite the merging.
Please let me know when we can merge to main and get the SDKs ready for internal customers. Thanks for your help.!
Based on the flow:
The SDK breaking change, Suppression review was already approved. Can we proceed? Please let me know how I can expedite the process and give our internal teams .net SDK and other SDKs next week. Teams are waiting, so please help. Thanks.
@JeffreyRichter Please approve the breaking change as we discussed and got your approval in PR- https://github.com/Azure/azure-rest-api-specs-pr/pull/15893
@konrad-jamrozik Please approve the PR as we discussed and got your approval in PR- https://github.com/Azure/azure-rest-api-specs-pr/pull/15893
@ms-henglu Please approve the PR as we discussed and got your approval in PR- https://github.com/Azure/azure-rest-api-specs-pr/pull/15893
Why do you have filter query parameters on the path
"/providers/Microsoft.Management/managementGroups/{managementGroupId}/subscriptions/{subscriptionId}/providers/Microsoft.Quota/groupQuotas/{groupQuotaName}/quotaAllocations/{resourceName}": {
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Quotas_UsagesRequest_ForNetworkLocation: Microsoft.Quota/preview/2023-06-01-preview/quota.json#L143