deletedWorkbooks resource type
ARM (Control Plane) API Specification Update Pull Request
[!TIP] Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.
[!NOTE] As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
- For help with Step 2 / "ARM review", see https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
- [ ] New resource provider.
- [ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
- [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
- [ ] Update existing version to fix OpenAPI spec quality issues in S360.
- [x] Other, please clarify:
- new resource type deletedWorkbooks in the microsoft.insights resource provider
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:
- [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
- [x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.
Getting help
- First, please carefully read through this PR description, from top to bottom. Please fill out the
Purpose of this PRandDue diligence checklist. - To understand what you must do next to merge this PR, see the
Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state. - For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
- For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
- If the PR CI checks appear to be stuck in
queuedstate, please add a comment with contents/azp run. This should result in a new comment denoting aPR validation pipelinehas started and the checks should be updated after few minutes. - If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
Next Steps to Merge
✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.
Swagger Validation Report
️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
| Compared specs (v2.2.0) | new version | base version |
|---|---|---|
| package-2024-02-01-only | package-2024-02-01-only(4820123) | default(main) |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| :warning: MULTIPLE_API_VERSION | The default tag contains multiple API versions swaggers. readme: specification/applicationinsights/resource-manager/readme.md tag: specification/applicationinsights/resource-manager/readme.md#tag-package-2024-02-01-only |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️❌ azure-sdk-for-net-track2 failed [Detail]
❌Failed in generating from 3eb955f830e1fda21d940bbffc460a7f234405d0. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json cmderr [Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714 cmderr [Invoke-GenerateAndBuildV2.ps1] Line | cmderr [Invoke-GenerateAndBuildV2.ps1] 714 | GeneratePackage -projectFolder $projectFolder -sdkRootPath $s … cmderr [Invoke-GenerateAndBuildV2.ps1] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] | Failed to generate sdk. exit code: False cmderr [Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807 cmderr [Invoke-GenerateAndBuildV2.ps1] Line | cmderr [Invoke-GenerateAndBuildV2.ps1] 807 | … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s … cmderr [Invoke-GenerateAndBuildV2.ps1] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] | Cannot find path cmderr [Invoke-GenerateAndBuildV2.ps1] | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because cmderr [Invoke-GenerateAndBuildV2.ps1] | it does not exist. cmderr [Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714 cmderr [Invoke-GenerateAndBuildV2.ps1] Line | cmderr [Invoke-GenerateAndBuildV2.ps1] 714 | GeneratePackage -projectFolder $projectFolder -sdkRootPath $s … cmderr [Invoke-GenerateAndBuildV2.ps1] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] | Failed to generate sdk artifact
❌Azure.ResourceManager.ApplicationInsights [Preview SDK Changes]info [Changelog]
️⚠️ azure-sdk-for-python warning [Detail]
⚠️Warning in generating from 3eb955f830e1fda21d940bbffc460a7f234405d0. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] cmderr [automation_generate.sh] npm notice New minor version of npm available! 10.5.0 -> 10.6.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.6.0> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️azure-mgmt-applicationinsights [Preview SDK Changes]- azure-mgmt-applicationinsights-4.0.0.zip
- azure_mgmt_applicationinsights-4.0.0-py3-none-any.whl
info [Changelog]
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning in generating from 3eb955f830e1fda21d940bbffc460a7f234405d0. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] cmderr [init.sh] npm notice New minor version of npm available! 10.5.0 -> 10.6.0 cmderr [init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.6.0> cmderr [init.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [init.sh] npm notice command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-applicationinsights [Preview SDK Changes]- pom.xml
- azure-resourcemanager-applicationinsights-1.1.0-beta.1.jar
- azure-resourcemanager-applicationinsights-1.1.0-beta.1-sources.jar
️❌ azure-sdk-for-go failed [Detail]
❌Code Generator Failed in generating from 3eb955f830e1fda21d940bbffc460a7f234405d0. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json cmderr [generator automation-v2] [ERROR] total 1 error(s): cmderr [generator automation-v2] [ERROR] failed to execute `go generate` 'WARNING: Unable to find version for /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/applicationinsights/armapplicationinsights cmderr [generator automation-v2] [ERROR] Cannot find go module under resourcemanager/applicationinsights/armapplicationinsights, try to build in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/applicationinsights/armapplicationinsights cmderr [generator automation-v2] [ERROR] ##[command]Cleaning auto-generated files in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/applicationinsights/armapplicationinsights cmderr [generator automation-v2] [ERROR] ##[command]Executing autorest.go in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/applicationinsights/armapplicationinsights cmderr [generator automation-v2] [ERROR] autorest --use=@autorest/[email protected] --go --track2 --output-folder=/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/applicationinsights/armapplicationinsights --clear-output-folder=false --go.clear-output-folder=false --honor-body-placement=true --remove-unreferenced-types=false ./autorest.md cmderr [generator automation-v2] [ERROR] AutoRest code generation utility [cli version: 3.6.1; node: v18.20.2] cmderr [generator automation-v2] [ERROR] (C) 2018 Microsoft Corporation. cmderr [generator automation-v2] [ERROR] https://aka.ms/autorest cmderr [generator automation-v2] [ERROR] There is a new version of AutoRest available (3.7.1). cmderr [generator automation-v2] [ERROR] > You can install the newer version with with npm install -g autorest@latest cmderr [generator automation-v2] [ERROR] info | Loading AutoRest core '/home/cloudtest/.autorest/@[email protected]/nodemodules/@autorest/core/dist' (3.10.2) cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.0.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.1.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.2.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.3.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.4.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.5.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.6.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.7.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.8.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.9.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.10.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.11.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.12.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.13.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.14.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.15.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.16.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.17.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.18.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.19.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.20.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.21.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.22.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.23.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.24.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.25.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.26.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.27.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.28.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.29.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.30.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.31.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.32.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.33.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.34.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.35.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.36.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.37.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.38.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.39.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.40.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.41.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.42.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.43.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.44.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.45.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.46.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.47.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.48.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.49.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.50.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.51.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.52.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.53.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.54.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.55.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.56.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.57.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.58.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.59.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.60.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.61.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.62.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] warning | DeprecatedConfig | Using directive.63.suppress which is deprecated and will be removed in the future. cmderr [generator automation-v2] [ERROR] info | Installing AutoRest extension '@autorest/go' (4.0.0-preview.63 -> 4.0.0-preview.63) cmderr [generator automation-v2] [ERROR] info | Installed AutoRest extension '@autorest/go' (4.0.0-preview.63->4.0.0-preview.63) cmderr [generator automation-v2] [ERROR] info | Installing AutoRest extension '@autorest/modelerfour' (4.26.2 -> 4.26.2) cmderr [generator automation-v2] [ERROR] info | Installed AutoRest extension '@autorest/modelerfour' (4.26.2->4.26.2) cmderr [generator automation-v2] [ERROR] warning | IgnoredPropertyNextToRef | Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > ApplicationInsightsComponentAvailableFeatures > properties > Result > items) cmderr [generator automation-v2] [ERROR] keys: [ 'type' ] cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2015-05-01/componentFeaturesAndPricing_API.json:373:11 cmderr [generator automation-v2] [ERROR] warning | IgnoredPropertyNextToRef | Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > ApplicationInsightsComponentFeature > properties > Capabilities > items) cmderr [generator automation-v2] [ERROR] keys: [ 'type' ] cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2015-05-01/componentFeaturesAndPricing_API.json:416:11 cmderr [generator automation-v2] [ERROR] warning | OutdatedExtension | Semantic violation: Extension 'x-ms-code-generation-settings' is not supported in Autorest V3. It will just be ignored. (info > x-ms-code-generation-settings) cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2021-10-14/livetoken_API.json:5:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'ComponentsResource' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-02-02/components_API.json:390:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'ComponentsResource-tags' with an undefined type and additionalProperties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-02-02/components_API.json:415:9 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'TagsResource' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-02-02/components_API.json:428:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'TagsResource-tags' with an undefined type and additionalProperties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-02-02/components_API.json:430:9 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'ApplicationInsightsComponent' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-02-02/components_API.json:439:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'ApplicationInsightsComponentProperties' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-02-02/components_API.json:465:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'PrivateLinkScopedResource' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-02-02/components_API.json:641:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'ApplicationInsightsComponentListResult' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-02-02/components_API.json:654:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'ComponentPurgeBody' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-02-02/components_API.json:673:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'ComponentPurgeBodyFilters' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-02-02/components_API.json:694:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'ComponentPurgeResponse' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-02-02/components_API.json:714:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'ComponentPurgeStatusResponse' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-02-02/components_API.json:726:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'AnnotationsListResult' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2015-05-01/componentAnnotations_API.json:244:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'ApplicationInsightsComponentAPIKeyListResult' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2015-05-01/componentApiKeys_API.json:209:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'WorkItemConfigurationsListResult' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2015-05-01/componentWorkItemConfigs_API.json:290:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'ApplicationInsightsComponentFavorite' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2015-05-01/favorites_API.json:240:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'ApplicationInsightsWebTestLocationsListResult' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2015-05-01/webTestLocations_API.json:75:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'WebtestsResource' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2022-06-15/webTests_API.json:288:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'WebtestsResource-tags' with an undefined type and additionalProperties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2022-06-15/webTests_API.json:313:9 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'TagsResource' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2022-06-15/webTests_API.json:326:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'TagsResource-tags' with an undefined type and additionalProperties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2022-06-15/webTests_API.json:328:9 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'webTestListResult' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2022-06-15/webTests_API.json:337:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'WebTest' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2022-06-15/webTests_API.json:356:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'WebTestProperties' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2022-06-15/webTests_API.json:385:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'ErrorFieldContract' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2021-03-08/workbookOperations_API.json:101:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'Operation-display' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2021-03-08/workbookOperations_API.json:126:9 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'OperationListResult' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2021-03-08/workbookOperations_API.json:145:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'WorkbookTemplateResource' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json:252:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'WorkbookTemplatesListResult' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json:291:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'WorkbookTemplate' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json:303:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'WorkbookTemplateProperties' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json:318:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'WorkbookTemplateGallery' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json:362:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'WorkbookTemplateLocalizedGallery' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json:388:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'WorkbookTemplateUpdateParameters' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json:408:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'WorkbookTemplateErrorFieldContract' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json:425:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'WorkbookTemplateError' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json:442:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'WorkbookTemplateErrorBody' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json:451:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'WorkbookResource-identity' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2023-06-01/workbooks_API.json:436:9 cmderr [generator automation-v2] [ERROR] warning | PreCheck/CheckDuplicateSchemas | Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail. cmderr [generator automation-v2] [ERROR] error | PreCheck/DuplicateSchema | Duplicate Schema named 'Resource' (3 differences): cmderr [generator automation-v2] [ERROR] - properties.id.$ref: "#/components/schemas/schemas:449" => "#/components/schemas/schemas:542" cmderr [generator automation-v2] [ERROR] - properties.id.description: "Fully qualified resource ID for the resource. Ex - /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{resourceType}/{resourceName}" => "Fully qualified resource ID for the resource. E.g. \"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{resourceType}/{resourceName}\"" cmderr [generator automation-v2] [ERROR] - properties.systemData: <none> => {"readOnly":true,"description":"Azure Resource Manager metadata containing createdBy and modifiedBy information.","$ref":"#/components/schemas/schemas:514"}; This error can be *temporarily* avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that. cmderr [generator automation-v2] [ERROR] error | PreCheck/DuplicateSchema | Duplicate Schema named 'TrackedResource' (1 differences): cmderr [generator automation-v2] [ERROR] - allOf.0.$ref: "#/components/schemas/schemas:448" => "#/components/schemas/schemas:541"; This error can be *temporarily* avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that. cmderr [generator automation-v2] [ERROR] warning | PreCheck/PropertyRedeclarationWarning | Schema 'DeletedWorkbook' has a property 'systemData' that is already declared the parent schema 'Resource' but isn't significantly different. The property has been removed from DeletedWorkbook cmderr [generator automation-v2] [ERROR] fatal | Error: 2 errors occured -- cannot continue. cmderr [generator automation-v2] [ERROR] fatal | Process() cancelled due to failure cmderr [generator automation-v2] [ERROR] error | Error: Plugin prechecker reported failure. cmderr [generator automation-v2] [ERROR] error | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing. cmderr [generator automation-v2] [ERROR] ##[error]Error running autorest.go cmderr [generator automation-v2] [ERROR] build.go:5: running "pwsh": exit status 1 cmderr [generator automation-v2] [ERROR] ': exit status 1 error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2 warn Skip package processing as generation is failed
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded in generating from 3eb955f830e1fda21d940bbffc460a7f234405d0. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-appinsights [Preview SDK Changes]- azure-arm-appinsights-5.0.0-beta.8.tgz
️❌ azure-resource-manager-schemas failed [Detail]
❌Failed in generating from 3eb955f830e1fda21d940bbffc460a7f234405d0. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] npm notice cmderr [initScript.sh] npm notice New minor version of npm available! 10.5.0 -> 10.6.0 cmderr [initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.6.0> cmderr [initScript.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [initScript.sh] npm notice warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
❌applicationinsights/resource-manager [Preview Schema Changes]
️️✔️ azure-powershell succeeded [Detail] [Expand]
️✔️Succeeded in generating from 3eb955f830e1fda21d940bbffc460a7f234405d0. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
️✔️Az.applicationinsights.DefaultTag [Preview SDK Changes]- Az.ApplicationInsights.0.1.0.nupkg
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Go | sdk/resourcemanager/applicationinsights/armapplicationinsights | https://apiview.dev/Assemblies/Review/adf41208f2aa4e3080e8bb32f634e705?revisionId=ad6723384a7f49048f07508b333e4305 |
| .Net | Azure.ResourceManager.ApplicationInsights | https://apiview.dev/Assemblies/Review/a88c47ddd8fe4cb2a4b1ec7255d3df8e?revisionId=d2128b93ccff4500bdae0da3e2b10fd6 |
| JavaScript | @azure/arm-appinsights | https://apiview.dev/Assemblies/Review/b6a94273650f4ab7b27d29ce6cefc751?revisionId=ba6e93b3d6304982ad7f6901e643e5de |
| Swagger | Microsoft.Insights | https://apiview.dev/Assemblies/Review/b1062e1dbaa34b189b1d407e01e2e372?revisionId=7f55bc64d5ae412b83d614b426d15cba |
Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.
@ms-henglu, I don't see an option to reopen this PR, can you help reopen this guy now that we're ready to release the swagger?
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.
@ms-henglu, I don't see an option to reopen this PR, can you help reopen this guy now that we're ready to release the swagger?
Done!
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.
@ms-henglu for the Avocado error, should preview resource type be part of the tag default packages? componentLinkedStorageAccounts_API was removed in https://github.com/Azure/azure-rest-api-specs/pull/28843 when they created a new package.
For SDK azure-sdk-for-go error, deletedWorkbooks has a warning for SystemData but the error is from other resource types not in this PR. Any suggestion here?
/pr RequestMerge