azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Azure
Raymondluo1 containerregistry microsoft.container registry 2023 11 01 preview
ARM (Control Plane) API Specification Update Pull Request
[!TIP] Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.
[!NOTE] As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
- For help with Step 2 / "ARM review", see https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
- [ ] New resource provider.
- [ ] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
- [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
- [X] Update existing version to fix OpenAPI spec quality issues in S360.
- [ ] Other, please clarify:
- edit this with your clarification
This PR is to fix a bug in our swagger for the List Webhook operations. The next link operation should use a POST request instead of the default GET request for the next pages.
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:
- [ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
- [ ] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the suppressions guide to get approval.
Getting help
- First, please carefully read through this PR description, from top to bottom. Please fill out the
Purpose of this PRandDue diligence checklist. - To understand what you must do next to merge this PR, see the
Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state. - For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
- For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
- If the PR CI checks appear to be stuck in
queuedstate, please add a comment with contents/azp run. This should result in a new comment denoting aPR validation pipelinehas started and the checks should be updated after few minutes. - If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
Next Steps to Merge
Next steps that must be taken to merge this PR:- ❌ This PR is in purview of the ARM review (label:
ARMReview). This PR must getARMSignedOfflabel from an ARM reviewer.
This PR hasARMChangesRequestedlabel. Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove theARMChangesRequestedlabel.
Automation should then addWaitForARMFeedbacklabel.
❗If you don't have permissions to remove the label, requestwrite accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
For details of the ARM review, see aka.ms/azsdk/pr-arm-review - ❌ The required check named
Swagger ModelValidationhas failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"new":"https://github.com/Azure/azure-rest-api-specs/blob/0a24ea2a7a5a818126c2051a3881508eefbf67df/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json", "details":"Breaking change detector (OAD) invoked AutoRest. AutoRest threw a runtime error. First 6 lines of stack trace follow, indexed. First line should contain AutoRest command line invocation details. Second line should contain the main message reported by AutoRest. ==================== 1: Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.72/common/temp/node_modules/.pnpm/@[email protected]/node_modules/autorest/dist/app.js" --v2 --input-file=specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp -------------------- 2: ERROR: Schema violation: Additional properties not allowed: nextLink?Webhooks_ListEventsNext -------------------- 3: - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json:4083:2 ($["x-ms-paths"]) -------------------- 4: FATAL: swagger-document/individual/schema-validator - FAILED -------------------- 5: FATAL: Error: [OperationAbortedException] Error occurred. Exiting. -------------------- 6: Process() cancelled due to exception : [OperationAbortedException] Error occurred. Exiting. --------------------" |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 5 Errors, 0 Warnings failed [Detail]
| compared tags (via openapi-validator v2.1.6) | new version | base version |
|---|---|---|
| package-2023-11-preview | package-2023-11-preview(0a24ea2) | package-2023-11-preview(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
$skiptoken is a query parameter. Post operation must not contain any query parameter other than api-version. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L4004 |
RPC-Post-V1-05 |
|
Path for 'post' method on a resource type MUST follow valid resource naming. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L4084 |
RPC-Uri-V1-07 |
|
Paths in x-ms-paths must overload a normal path in the paths section, i.e. a path in the x-ms-paths must either be same as a path in the paths section or a path in the paths sections followed by additional parameters. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L4084 |
|
|
Synchronous POST operations must have one of the following combinations of responses - 200 and default ; 204 and default. They also must not have other response codes. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L4085 |
RPC-Async-V1-11, RPC-Async-V1-14 |
|
$skiptoken is a query parameter. Post operation must not contain any query parameter other than api-version. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L4091 |
RPC-Post-V1-05 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L726 |
|
The async patch operation should return 202. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L758 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L953 |
|
Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L1008 |
|
The property 'properties.syncProperties' in the request body either not apppear in the resource model or has the wrong level. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L1035 |
|
The async patch operation should return 202. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L1040 |
|
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L1077 |
|
Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L1338 |
|
The async patch operation should return 202. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L1370 |
|
A tracked resource MUST always have tags as a top level optional property. Tracked resource does not have tags in the request schema. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L1495 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L1562 |
|
Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L1619 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L1648 |
|
A tracked resource MUST always have tags as a top level optional property. Tracked resource does not have tags in the request schema. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L1767 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L1834 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L1902 |
|
Operations API path must follow the schema provided in the common types. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L1906 |
|
Synchronous POST operations must have one of the following combinations of responses - 200 and default ; 204 and default. They also must not have other response codes. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L1921 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L1944 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L2121 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L2198 |
|
The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L2216 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L2240 |
|
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L2254 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L2286 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L2315 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L2338 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L2380 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L2416 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L2455 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| :warning: MULTIPLE_API_VERSION | The default tag contains multiple API versions swaggers. readme: specification/containerregistry/resource-manager/readme.md tag: specification/containerregistry/resource-manager/readme.md#tag-package-2023-11-preview |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Missing required property: nextLink Url: Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json#L4098:11 ExampleUrl: preview/2023-11-01-preview/examples/WebhookListEvents.json |
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-js - @azure/arm-containerregistry - 11.0.0-beta.4+ Class ContainerRegistryManagementClient has a new signature + Type of parameter error of interface ErrorResponse is changed from ErrorResponseBody to ErrorDetail
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 2650c6bdc7a939f9b2bbaf3138f09dabf7cfa3ad. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️Azure.ResourceManager.ContainerRegistry [View full logs] [Preview SDK Changes]info [Changelog]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from 2650c6bdc7a939f9b2bbaf3138f09dabf7cfa3ad. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-containerregistry [View full logs] [Preview SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - Operation WebhooksOperations.list_events has a new optional parameter skip_token
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs] Generate from 2650c6bdc7a939f9b2bbaf3138f09dabf7cfa3ad. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.2 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.2 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] rrent cmderr [init.sh] Dload Upload Total Spent Left Speed cmderr [init.sh] 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0-:-- --:--:-- 199k cmderr [init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz... cmderr [init.sh] ################ 100.0% cmderr [init.sh] Computing checksum with sha256sum cmderr [init.sh] Checksums matched! command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-containerregistry-generated [View full logs] [Preview SDK Changes]
️❌ azure-sdk-for-go failed [Detail]
❌Code Generator Failed [Logs] Generate from 2650c6bdc7a939f9b2bbaf3138f09dabf7cfa3ad. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json cmderr [generator automation-v2] [ERROR] total 1 error(s): cmderr [generator automation-v2] [ERROR] failed to execute `go generate` '[33;1mWARNING: Unable to find version for /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/containerregistry/armcontainerregistry[0m cmderr [generator automation-v2] [ERROR] Cannot find go module under resourcemanager/containerregistry/armcontainerregistry, try to build in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/containerregistry/armcontainerregistry cmderr [generator automation-v2] [ERROR] ##[command]Cleaning auto-generated files in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/containerregistry/armcontainerregistry cmderr [generator automation-v2] [ERROR] ##[command]Executing autorest.go in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/containerregistry/armcontainerregistry cmderr [generator automation-v2] [ERROR] autorest --use=@autorest/[email protected] --go --track2 --output-folder=/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/containerregistry/armcontainerregistry --clear-output-folder=false --go.clear-output-folder=false --honor-body-placement=true --remove-unreferenced-types=true ./autorest.md cmderr [generator automation-v2] [ERROR] AutoRest code generation utility [cli version: 3.6.1; node: v18.19.0] cmderr [generator automation-v2] [ERROR] (C) 2018 Microsoft Corporation. cmderr [generator automation-v2] [ERROR] https://aka.ms/autorest cmderr [generator automation-v2] [ERROR] There is a new version of AutoRest available (3.7.1). cmderr [generator automation-v2] [ERROR] > You can install the newer version with with npm install -g autorest@latest cmderr [generator automation-v2] [ERROR] info | Loading AutoRest core '/home/cloudtest/.autorest/@[email protected]/nodemodules/@autorest/core/dist' (3.10.1) cmderr [generator automation-v2] [ERROR] info | Installing AutoRest extension '@autorest/go' (4.0.0-preview.60 -> 4.0.0-preview.60) cmderr [generator automation-v2] [ERROR] info | Installed AutoRest extension '@autorest/go' (4.0.0-preview.60->4.0.0-preview.60) cmderr [generator automation-v2] [ERROR] info | Installing AutoRest extension '@autorest/modelerfour' (4.26.2 -> 4.26.2) cmderr [generator automation-v2] [ERROR] info | Installed AutoRest extension '@autorest/modelerfour' (4.26.2->4.26.2) cmderr [generator automation-v2] [ERROR] warning | IgnoredPropertyNextToRef | Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > Resource > properties > systemData) cmderr [generator automation-v2] [ERROR] keys: [ [32m'type'[39m ] cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json:4966:9 cmderr [generator automation-v2] [ERROR] warning | IgnoredPropertyNextToRef | Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > ProxyResource > properties > systemData) cmderr [generator automation-v2] [ERROR] keys: [ [32m'type'[39m ] cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json:5023:9 cmderr [generator automation-v2] [ERROR] warning | IgnoredPropertyNextToRef | Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > Resource > properties > systemData) cmderr [generator automation-v2] [ERROR] keys: [ [32m'type'[39m ] cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json:2998:9 cmderr [generator automation-v2] [ERROR] warning | IgnoredPropertyNextToRef | Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > ProxyResource > properties > systemData) cmderr [generator automation-v2] [ERROR] keys: [ [32m'type'[39m ] cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json:3025:9 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'Resource' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json:4930:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'ProxyResource' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2023-11-01-preview/containerregistry.json:5005:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'Resource' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json:2962:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'ProxyResource' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json:3007:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'ErrorResponseBody' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json:3087:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'ErrorResponse' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json:3119:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'InnerErrorDescription' with an undefined type and declared properties is a bit ambiguous. This has been auto-corrected to 'type:object' cmderr [generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/preview/2019-06-01-preview/containerregistry_build.json:3128:5 cmderr [generator automation-v2] [ERROR] warning | PreCheck/CheckDuplicateSchemas | Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail. cmderr [generator automation-v2] [ERROR] warning | UsingTemporaryFlag | modelerfour.treat-type-object-as-anything options is a temporary flag. It WILL be removed in the future. cmderr [generator automation-v2] [ERROR] warning | SecurityDefinedSpecAndConfig | OpenAPI spec has a security definition but autorest security config is defined. Security config from autorest will be used. cmderr [generator automation-v2] [ERROR] fatal | TypeError: Cannot read properties of undefined (reading 'isNextOp') cmderr [generator automation-v2] [ERROR] fatal | Process() cancelled due to failure cmderr [generator automation-v2] [ERROR] error | Error: Plugin go-transform-m4 reported failure. cmderr [generator automation-v2] [ERROR] error | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing. cmderr [generator automation-v2] [ERROR] ##[error]Error running autorest.go cmderr [generator automation-v2] [ERROR] build.go:5: running "pwsh": exit status 1 cmderr [generator automation-v2] [ERROR] ': exit status 1 error Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2 warn Skip package processing as generation is failed
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 2650c6bdc7a939f9b2bbaf3138f09dabf7cfa3ad. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
- Only show 120 items here, please refer to log for details.
️✔️@azure/arm-containerregistry [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] - Added Interface ImportPipelinesCreateHeaders info [Changelog] - Added Interface ImportPipelinesCreateOptionalParams info [Changelog] - Added Interface ImportPipelinesDeleteHeaders info [Changelog] - Added Interface ImportPipelinesDeleteOptionalParams info [Changelog] - Added Interface ImportPipelinesGetOptionalParams info [Changelog] - Added Interface ImportPipelinesListNextOptionalParams info [Changelog] - Added Interface ImportPipelinesListOptionalParams info [Changelog] - Added Interface ImportPipelineSourceProperties info [Changelog] - Added Interface LoggingProperties info [Changelog] - Added Interface LoginServerProperties info [Changelog] - Added Interface ParentProperties info [Changelog] - Added Interface PipelineRun info [Changelog] - Added Interface PipelineRunListResult info [Changelog] - Added Interface PipelineRunRequest info [Changelog] - Added Interface PipelineRunResponse info [Changelog] - Added Interface PipelineRunsCreateHeaders info [Changelog] - Added Interface PipelineRunsCreateOptionalParams info [Changelog] - Added Interface PipelineRunsDeleteHeaders info [Changelog] - Added Interface PipelineRunsDeleteOptionalParams info [Changelog] - Added Interface PipelineRunsGetOptionalParams info [Changelog] - Added Interface PipelineRunsListNextOptionalParams info [Changelog] - Added Interface PipelineRunsListOptionalParams info [Changelog] - Added Interface PipelineRunSourceProperties info [Changelog] - Added Interface PipelineRunTargetProperties info [Changelog] - Added Interface PipelineSourceTriggerDescriptor info [Changelog] - Added Interface PipelineSourceTriggerProperties info [Changelog] - Added Interface PipelineTriggerDescriptor info [Changelog] - Added Interface PipelineTriggerProperties info [Changelog] - Added Interface ProgressProperties info [Changelog] - Added Interface SoftDeletePolicy info [Changelog] - Added Interface StatusDetailProperties info [Changelog] - Added Interface SyncProperties info [Changelog] - Added Interface SyncUpdateProperties info [Changelog] - Added Interface TlsCertificateProperties info [Changelog] - Added Interface TlsProperties info [Changelog] - Added Type Alias ActivationStatus info [Changelog] - Added Type Alias ArchivesCreateResponse info [Changelog] - Added Type Alias ArchivesDeleteResponse info [Changelog] - Added Type Alias ArchivesGetResponse info [Changelog] - Added Type Alias ArchivesListNextResponse info [Changelog] - Added Type Alias ArchivesListResponse info [Changelog] - Added Type Alias ArchivesUpdateResponse info [Changelog] - Added Type Alias ArchiveVersionsCreateResponse info [Changelog] - Added Type Alias ArchiveVersionsDeleteResponse info [Changelog] - Added Type Alias ArchiveVersionsGetResponse info [Changelog] - Added Type Alias ArchiveVersionsListNextResponse info [Changelog] - Added Type Alias ArchiveVersionsListResponse info [Changelog] - Added Type Alias AuditLogStatus info [Changelog] - Added Type Alias AzureADAuthenticationAsArmPolicyStatus info [Changelog] - Added Type Alias CacheRulesCreateResponse info [Changelog] - Added Type Alias CacheRulesDeleteResponse info [Changelog] - Added Type Alias CacheRulesGetResponse info [Changelog] - Added Type Alias CacheRulesListNextResponse info [Changelog] - Added Type Alias CacheRulesListResponse info [Changelog] - Added Type Alias CacheRulesUpdateResponse info [Changelog] - Added Type Alias CertificateType info [Changelog] - Added Type Alias ConnectedRegistriesCreateResponse info [Changelog] - Added Type Alias ConnectedRegistriesGetResponse info [Changelog] - Added Type Alias ConnectedRegistriesListNextResponse info [Changelog] - Added Type Alias ConnectedRegistriesListResponse info [Changelog] - Added Type Alias ConnectedRegistriesUpdateResponse info [Changelog] - Added Type Alias ConnectedRegistryMode info [Changelog] - Added Type Alias ConnectionState info [Changelog] - Added Type Alias CredentialHealthStatus info [Changelog] - Added Type Alias CredentialName info [Changelog] - Added Type Alias CredentialSetsCreateResponse info [Changelog] - Added Type Alias CredentialSetsDeleteResponse info [Changelog] - Added Type Alias CredentialSetsGetResponse info [Changelog] - Added Type Alias CredentialSetsListNextResponse info [Changelog] - Added Type Alias CredentialSetsListResponse info [Changelog] - Added Type Alias CredentialSetsUpdateResponse info [Changelog] - Added Type Alias ExportPipelinesCreateResponse info [Changelog] - Added Type Alias ExportPipelinesGetResponse info [Changelog] - Added Type Alias ExportPipelinesListNextResponse info [Changelog] - Added Type Alias ExportPipelinesListResponse info [Changelog] - Added Type Alias ImportPipelinesCreateResponse info [Changelog] - Added Type Alias ImportPipelinesGetResponse info [Changelog] - Added Type Alias ImportPipelinesListNextResponse info [Changelog] - Added Type Alias ImportPipelinesListResponse info [Changelog] - Added Type Alias LogLevel info [Changelog] - Added Type Alias MetadataSearch info [Changelog] - Added Type Alias PackageSourceType info [Changelog] - Added Type Alias PipelineOptions info [Changelog] - Added Type Alias PipelineRunsCreateResponse info [Changelog] - Added Type Alias PipelineRunsGetResponse info [Changelog] - Added Type Alias PipelineRunsListNextResponse info [Changelog] - Added Type Alias PipelineRunsListResponse info [Changelog] - Added Type Alias PipelineRunSourceType info [Changelog] - Added Type Alias PipelineRunTargetType info [Changelog] - Added Type Alias PipelineSourceType info [Changelog] - Added Type Alias TlsStatus info [Changelog] - Interface Policies has a new optional parameter azureADAuthenticationAsArmPolicy info [Changelog] - Interface Policies has a new optional parameter softDeletePolicy info [Changelog] - Interface Registry has a new optional parameter anonymousPullEnabled info [Changelog] - Interface Registry has a new optional parameter metadataSearch info [Changelog] - Interface RegistryUpdateParameters has a new optional parameter anonymousPullEnabled info [Changelog] - Interface RegistryUpdateParameters has a new optional parameter metadataSearch info [Changelog] - Interface WebhooksListEventsNextOptionalParams has a new optional parameter skipToken info [Changelog] - Interface WebhooksListEventsOptionalParams has a new optional parameter skipToken info [Changelog] - Added Enum KnownActivationStatus info [Changelog] - Added Enum KnownAuditLogStatus info [Changelog] - Added Enum KnownAzureADAuthenticationAsArmPolicyStatus info [Changelog] - Added Enum KnownCertificateType info [Changelog] - Added Enum KnownConnectedRegistryMode info [Changelog] - Added Enum KnownConnectionState info [Changelog] - Added Enum KnownCredentialHealthStatus info [Changelog] - Added Enum KnownCredentialName info [Changelog] - Added Enum KnownLogLevel info [Changelog] - Added Enum KnownMetadataSearch info [Changelog] - Added Enum KnownPackageSourceType info [Changelog] - Added Enum KnownPipelineOptions info [Changelog] - Added Enum KnownPipelineRunSourceType info [Changelog] - Added Enum KnownPipelineRunTargetType info [Changelog] - Added Enum KnownPipelineSourceType info [Changelog] - Added Enum KnownTlsStatus info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Class ContainerRegistryManagementClient has a new signature info [Changelog] - Type of parameter error of interface ErrorResponse is changed from ErrorResponseBody to ErrorDetail
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from 2650c6bdc7a939f9b2bbaf3138f09dabf7cfa3ad. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] notice cmderr [initScript.sh] npm notice New minor version of npm available! 10.2.3 -> 10.3.0 cmderr [initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.3.0> cmderr [initScript.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [initScript.sh] npm notice warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json warn No file changes detected after generation
️✔️containerregistry [View full logs]
️⚠️ azure-powershell warning [Detail]
⚠️Warning [Logs] Generate from 2650c6bdc7a939f9b2bbaf3138f09dabf7cfa3ad. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
⚠️Az.containerregistry.DefaultTag [View full logs] [Preview SDK Changes]
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Java | azure-resourcemanager-containerregistry-generated | https://apiview.dev/Assemblies/Review/57cd8acbf63e43ee990a4e4df6cba9a3?revisionId=05dd74cea41141e89d1197f4a361354d |
| .Net | Azure.ResourceManager.ContainerRegistry | There is no API change compared with the previous version |
| JavaScript | @azure/arm-containerregistry | https://apiview.dev/Assemblies/Review/d10c9472429444ccb9776a87507d6033?revisionId=70bd9f1b0e854d468cef7ec40523f2bf |
| Swagger | Microsoft.ContainerRegistry | https://apiview.dev/Assemblies/Review/8042660a02024c0e93516b65a9b6f1a7?revisionId=ed70a8c35c864777bb54c0280413fa32 |
your PR has introduced a number of lint errors can you please check : https://github.com/Azure/azure-rest-api-specs/pull/27468/checks?check_run_id=20678824771
the root cause is that you are adding a skip token to a POST api which is not a recommended model under ARM semantics. FOr larger data sets , it is better to model the "events" as resources and model it as LIST \ GET api
Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
@raosuhas Thanks for the quick help. Our team might need to make the same changes to all our SDK versions. After I address the issue, how could I update all the other versions? Could I put all the SDK version updates in one PR or should I open one PR per version update? Thanks!
Hi, @raymondluo1. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
![microsoft-github-policy-service[bot] avatar](https://avatars.githubusercontent.com/in/95686?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi, @raymondluo1. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.