azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Azure
Create Api Version Microsoft.Search 2024-03-01-preview
ARM (Control Plane) API Specification Update Pull Request
[!TIP] Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.
[!NOTE] As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
- For help with Step 2 / "ARM review", see https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
- [ ] New resource provider.
- [x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
- [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
- [ ] Update existing version to fix swagger quality issues in S360.
- [ ] Other, please clarify:
- edit this with your clarification
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:
- [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
- [x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the Swagger-Suppression-Process to get approval.
Getting help
- First, please carefully read through this PR description, from top to bottom. Please fill out the
Purpose of this PRandDue diligence checklist. - To understand what you must do next to merge this PR, see the
Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state. - For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
- For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
- If the PR CI checks appear to be stuck in
queuedstate, please add a comment with contents/azp run. This should result in a new comment denoting aPR validation pipelinehas started and the checks should be updated after few minutes. - If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
Next Steps to Merge
✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 22 Errors, 17 Warnings failed [Detail]
| compared swaggers (via Oad v0.10.5)] | new version | base version |
|---|---|---|
| search.json | 2024-03-01-preview(d6c12b4) | 2023-11-01(main) |
| search.json | 2024-03-01-preview(d6c12b4) | 2021-04-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
The following breaking changes are detected by comparison with the latest preview version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 7 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.7) | new version | base version |
|---|---|---|
| package-preview-2024-03 | package-preview-2024-03(d6c12b4) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| :warning: RequiredReadOnlySystemData | The response of operation:'NetworkSecurityPerimeterConfigurations_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L1409 |
|
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L2683 |
|
| :warning: XmsIdentifierValidation | Missing identifier id in array item property Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L2716 |
|
| :warning: XmsIdentifierValidation | Missing identifier id in array item property Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L2724 |
|
| :warning: XmsIdentifierValidation | Missing identifier id in array item property Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L2764 |
|
| :warning: XmsIdentifierValidation | Missing identifier id in array item property Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L2772 |
|
| :warning: LatestVersionOfCommonTypesMustBeUsed | Use the latest version v5 of types.json. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L3001 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Operations API path must follow the schema provided in the common types. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L58 |
|
Path for 'post' method on a resource type MUST follow valid resource naming. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L121 |
|
Path for 'post' method on a resource type MUST follow valid resource naming. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L196 |
|
Synchronous delete operations must have responses with 200, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L303 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L348 |
|
Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L348 |
|
The resource name parameter 'searchServiceName' should be defined with a 'pattern' restriction. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L360 |
|
Synchronous delete operations must have responses with 200, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L586 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L624 |
|
Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L624 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L722 |
|
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L736 |
|
provisioningState property must be set to readOnly. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L782 |
|
provisioningState property must be set to readOnly. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L831 |
|
Synchronous delete operations must have responses with 200, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L843 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L877 |
|
The delete response body must be empty. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L880 |
|
provisioningState property must be set to readOnly. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L880 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L884 |
|
Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L884 |
|
The resource name parameter 'sharedPrivateLinkResourceName' should be defined with a 'pattern' restriction. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L947 |
|
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L948 |
|
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L948 |
|
provisioningState property must be set to readOnly. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L998 |
|
A 202 response should include an Location response header. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L1002 |
|
provisioningState property must be set to readOnly. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L1050 |
|
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L1062 |
|
A 202 response should include an Location response header. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L1101 |
|
Response code 404 is defined without a x-ms-error-response. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L1107 |
|
Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.Search/preview/2024-03-01-preview/search.json#L1107 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from c8865a38405a72270591070cc3c6391ce21ed584. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️Azure.ResourceManager.Search [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Search.Models.SearchServicePatch Azure.ResourceManager.Search.Models.ArmSearchModelFactory.SearchServicePatch(Azure.Core.ResourceIdentifier, System.String, Azure.Core.ResourceType, Azure.ResourceManager.Models.SystemData, System.Collections.Generic.IDictionary<System.String, System.String>, Azure.Core.AzureLocation, System.Nullable<Azure.ResourceManager.Search.Models.SearchSkuName>, Azure.ResourceManager.Models.ManagedServiceIdentity, System.Nullable<System.Int32>, System.Nullable<System.Int32>, System.Nullable<Azure.ResourceManager.Search.Models.SearchServiceHostingMode>, System.Nullable<Azure.ResourceManager.Search.Models.SearchServicePublicNetworkAccess>, System.Nullable<Azure.ResourceManager.Search.Models.SearchServiceStatus>, System.String, System.Nullable<Azure.ResourceManager.Search.Models.SearchServiceProvisioningState>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Search.Models.SearchServiceIPRule>, Azure.ResourceManager.Search.Models.SearchEncryptionWithCmk, System.Nullable<System.Boolean>, Azure.ResourceManager.Search.Models.SearchAadAuthDataPlaneAuthOptions, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Search.SearchPrivateEndpointConnectionData>, System.Nullable<Azure.ResourceManager.Search.Models.SearchSemanticSearch>, System.Collections.Generic.IEnumerable<Azure.ResourceManager.Search.SharedSearchServicePrivateLinkResourceData>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Collections.Generic.IList<Azure.ResourceManager.Search.Models.SearchServiceIPRule> Azure.ResourceManager.Search.Models.SearchServicePatch.IPRules.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Search.Models.SearchServicePublicNetworkAccess Azure.ResourceManager.Search.Models.SearchServicePublicNetworkAccess Azure.ResourceManager.Search.Models.SearchServicePublicNetworkAccess.Disabled' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Search.Models.SearchServicePublicNetworkAccess Azure.ResourceManager.Search.Models.SearchServicePublicNetworkAccess Azure.ResourceManager.Search.Models.SearchServicePublicNetworkAccess.Enabled' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Int32 System.Int32 Azure.ResourceManager.Search.Models.SearchServicePublicNetworkAccess.value__' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Search.Models.SearchSkuName Azure.ResourceManager.Search.Models.SearchSkuName Azure.ResourceManager.Search.Models.SearchSkuName.Basic' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Search.Models.SearchSkuName Azure.ResourceManager.Search.Models.SearchSkuName Azure.ResourceManager.Search.Models.SearchSkuName.Free' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Search.Models.SearchSkuName Azure.ResourceManager.Search.Models.SearchSkuName Azure.ResourceManager.Search.Models.SearchSkuName.Standard' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Search.Models.SearchSkuName Azure.ResourceManager.Search.Models.SearchSkuName Azure.ResourceManager.Search.Models.SearchSkuName.Standard2' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Search.Models.SearchSkuName Azure.ResourceManager.Search.Models.SearchSkuName Azure.ResourceManager.Search.Models.SearchSkuName.Standard3' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Search.Models.SearchSkuName Azure.ResourceManager.Search.Models.SearchSkuName Azure.ResourceManager.Search.Models.SearchSkuName.StorageOptimizedL1' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Search.Models.SearchSkuName Azure.ResourceManager.Search.Models.SearchSkuName Azure.ResourceManager.Search.Models.SearchSkuName.StorageOptimizedL2' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Int32 System.Int32 Azure.ResourceManager.Search.Models.SearchSkuName.value__' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceProvisioningState Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceProvisioningState Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceProvisioningState.Deleting' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceProvisioningState Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceProvisioningState Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceProvisioningState.Failed' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceProvisioningState Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceProvisioningState Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceProvisioningState.Incomplete' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceProvisioningState Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceProvisioningState Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceProvisioningState.Succeeded' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceProvisioningState Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceProvisioningState Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceProvisioningState.Updating' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Int32 System.Int32 Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceProvisioningState.value__' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceStatus Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceStatus Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceStatus.Approved' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceStatus Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceStatus Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceStatus.Disconnected' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceStatus Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceStatus Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceStatus.Pending' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceStatus Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceStatus Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceStatus.Rejected' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Int32 System.Int32 Azure.ResourceManager.Search.Models.SharedSearchServicePrivateLinkResourceStatus.value__' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Search/Debug/netstandard2.0/Azure.ResourceManager.Search.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/search/Azure.ResourceManager.Search/src/Azure.ResourceManager.Search.csproj::TargetFramework=netstandard2.0]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from c8865a38405a72270591070cc3c6391ce21ed584. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] cmderr [automation_generate.sh] New minor version of npm available! 10.2.3 -> 10.4.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-search [View full logs] [Preview SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation group NetworkSecurityPerimeterConfigurationsOperations info [Changelog] - Model Identity has a new parameter user_assigned_identities info [Changelog] - Model NetworkRuleSet has a new parameter bypass info [Changelog] - Model Operation has a new parameter is_data_action info [Changelog] - Model Operation has a new parameter origin info [Changelog] - Model Operation has a new parameter properties info [Changelog] - Model SearchService has a new parameter disabled_data_exfiltration_options info [Changelog] - Model SearchService has a new parameter e_tag info [Changelog] - Model SearchServiceUpdate has a new parameter disabled_data_exfiltration_options info [Changelog] - Model SearchServiceUpdate has a new parameter e_tag
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs] Generate from c8865a38405a72270591070cc3c6391ce21ed584. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] Average Speed Time Time Time Current cmderr [init.sh] Dload Upload Total Spent Left Speed cmderr [init.sh] 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0647k cmderr [init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz... cmderr [init.sh] Computing checksum with sha256sum cmderr [init.sh] Checksums matched! cmderr [init.sh] notice cmderr [init.sh] npm notice New major version of npm available! 9.5.0 -> 10.4.0 cmderr [init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0> cmderr [init.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [init.sh] npm notice command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-search [View full logs] [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from c8865a38405a72270591070cc3c6391ce21ed584. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/search/armsearch [View full logs] [Preview SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from c8865a38405a72270591070cc3c6391ce21ed584. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-search [View full logs] [Preview SDK Changes]
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from c8865a38405a72270591070cc3c6391ce21ed584. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] notice cmderr [initScript.sh] npm notice New minor version of npm available! 10.2.3 -> 10.4.0 cmderr [initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0> cmderr [initScript.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [initScript.sh] npm notice warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️search [View full logs] [Preview Schema Changes]
️️✔️ azure-powershell succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from c8865a38405a72270591070cc3c6391ce21ed584. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
️✔️Az.search.DefaultTag [View full logs] [Preview SDK Changes]
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Go | sdk/resourcemanager/search/armsearch | https://apiview.dev/Assemblies/Review/101ce97ad12043329431e945c1a4c018?revisionId=7cd6fe2f54c442958c3096fe7d9dbeb6 |
| .Net | Azure.ResourceManager.Search | https://apiview.dev/Assemblies/Review/3d158aec12a44b6ab7dd9a0e19643903?revisionId=1f760ca5897f4e95bc701ce680182408 |
| JavaScript | @azure/arm-search | https://apiview.dev/Assemblies/Review/df1404ded70142f5960b743c38e22076?revisionId=320ae719400c44bfaa3dbc3ebff30836 |
| Swagger | Microsoft.Search | https://apiview.dev/Assemblies/Review/8d0ebd94865b40c39787f62744bc81eb?revisionId=817146978cb44a2f91da87df490e49da |
Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @efrainretana! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.
Note FYI: Pushed some breaking changes post-breaking change approval which might've waived off a few labels. I reverted those back to the changes that got breaking change approval, so no other breaking change approvals should be needed.
Please address the LROerrorcontent error in the swagger lintdiff check and add a suppression for the AvoidAdditionalProperties error stating it is a false alarm. https://github.com/Azure/azure-rest-api-specs/pull/27450/checks
Please address the LROerrorcontent error in the swagger lintdiff check and add a suppression for the AvoidAdditionalProperties error stating it is a false alarm. https://github.com/Azure/azure-rest-api-specs/pull/27450/checks
Please add a suppression for LROerrorcontent as well using this guide https://github.com/Azure/autorest/blob/main/docs/generate/suppress-warnings.md
Please indicate the reason indicating we had a n agreement to fix LROerrorcontent in the next API version.
please fix duplicate schema: Resource
@kazrael2119 , I can't quite seem to understand why the error is being thrown and from where it is being thrown. Is it possible to get help around what issues we need to address to remove/suppress this warning?
please fix duplicate schema: Resource
@kazrael2119 , I can't quite seem to understand why the error is being thrown and from where it is being thrown. Is it possible to get help around what issues we need to address to remove/suppress this warning?
please check whether you reference different version from common-type definition
please fix duplicate schema: Resource
@kazrael2119 , I can't quite seem to understand why the error is being thrown and from where it is being thrown. Is it possible to get help around what issues we need to address to remove/suppress this warning?
please check whether you reference different version from common-type definition
@kazrael2119 , we utilize Resource v2 from common types. As far as I have seen, these are all uniformed and nonconflicting, yet still getting the error.
please fix duplicate schema: Resource
@kazrael2119 , I can't quite seem to understand why the error is being thrown and from where it is being thrown. Is it possible to get help around what issues we need to address to remove/suppress this warning?
please check whether you reference different version from common-type definition
@kazrael2119 , we utilize Resource v2 from common types. As far as I have seen, these are all uniformed and nonconflicting, yet still getting the error.
@efrainretana https://github.com/Azure/azure-rest-api-specs/blob/50997e50d8a6c91bdafb2fa6fc92215372e7710d/specification/search/resource-manager/Microsoft.Search/preview/2024-03-01-preview/search.json#L3001
ProxyResource references from Resource, so we get duplicate schema Resource
please fix duplicate schema: Resource
@kazrael2119 , I can't quite seem to understand why the error is being thrown and from where it is being thrown. Is it possible to get help around what issues we need to address to remove/suppress this warning?
please check whether you reference different version from common-type definition
@kazrael2119 , we utilize Resource v2 from common types. As far as I have seen, these are all uniformed and nonconflicting, yet still getting the error.
@efrainretana
https://github.com/Azure/azure-rest-api-specs/blob/50997e50d8a6c91bdafb2fa6fc92215372e7710d/specification/search/resource-manager/Microsoft.Search/preview/2024-03-01-preview/search.json#L3001
ProxyResource references from Resource, so we get duplicate schema Resource
Thanks for the clarification on the Resources, @kazrael2119 . Just updated our common types.
