azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Introducing new public preview API 2024-03-01-preview for AODGv1

Open kkashojjula-msft opened this issue 1 year ago • 8 comments

ARM (Control Plane) API Specification Update Pull Request

Tip: overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you, you must follow the breaking changes process.
IMPORTANT This applies even if:

  • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
  • You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.
Click here to see the diagram footnotes

Diagram footnotes

[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page. If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested is removed from your PR. This should cause the label WaitForARMFeedback to be added. [2] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • [X] New API version. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • [ ] Update existing version to fix swagger quality issues in S360.
  • [ ] Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

  • [X] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [X] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the Swagger-Suppression-Process to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

kkashojjula-msft avatar Jan 18 '24 19:01 kkashojjula-msft

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR is in purview of ARM review (label: ARMReview). Please ensure your PR is on the ARM PR review queue - see instructions in steps 1 and 2 in the PR description diagram.
  • ❌ The required check named SDK azure-sdk-for-go has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it. In addition, refer to step 3 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Important checks have failed. As of today they are not blocking this PR, but in near future they will.
Addressing the following failures is highly recommended:
  • ⚠️ The check named TypeSpec Requirement has failed. TypeSpec usage is required for all new (greenfield) services. This is currently enforced as a warning, but will be made a blocking error in the near future. For information on converting from OpenAPI specs to TypeSpec specs or on data-plane (DP) policies, refer to aka.ms/azsdk/typespec. If you have general questions on resource provider (RP) policies, refer to aka.ms/rphelp.

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 1 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-2024-03-01-preview package-2024-03-01-preview(fbae523) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
:warning: XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Orbital/preview/2024-03-01-preview/orbital.json#L1161
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️❌PR Summary: 0 Errors, 0 Warnings failed [Detail]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

azure-sdk-for-python-track2 - track2_azure-mgmt-orbital - 2.0.0
+	Removed operation group AvailableGroundStationsOperations
+	Removed operation group ContactProfilesOperations
+	Removed operation group ContactsOperations
+	Removed operation group OperationsResultsOperations
+	Removed operation group SpacecraftsOperations
azure-sdk-for-js - @azure/arm-orbital - 3.0.0-beta.1
+	Class AzureOrbital no longer has parameter availableGroundStations
+	Class AzureOrbital no longer has parameter contactProfiles
+	Class AzureOrbital no longer has parameter contacts
+	Class AzureOrbital no longer has parameter operationsResults
+	Class AzureOrbital no longer has parameter spacecrafts
+	Removed Enum KnownContactProfilesPropertiesProvisioningState
+	Removed Enum KnownContactsPropertiesProvisioningState
+	Removed Enum KnownContactsStatus
+	Removed Enum KnownDirection
+	Removed Enum KnownPolarization
+	Removed Enum KnownProtocol
+	Removed Enum KnownSpacecraftsPropertiesProvisioningState
+	Removed operation group AvailableGroundStations
+	Removed operation group ContactProfiles
+	Removed operation group Contacts
+	Removed operation group OperationsResults
+	Removed operation group Spacecrafts
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from 4fb358d0aa557260078aac14daaa50e123949b20. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh]  New minor version of npm available! 10.2.3 -> 10.3.0
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.3.0>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-orbital [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation group EdgeSitesOperations
    info	[Changelog]   - Added operation group GlobalCommunicationsSitesOperations
    info	[Changelog]   - Added operation group GroundStationsOperations
    info	[Changelog]   - Added operation group L2ConnectionsOperations
    info	[Changelog]
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog]   - Removed operation group AvailableGroundStationsOperations
    info	[Changelog]   - Removed operation group ContactProfilesOperations
    info	[Changelog]   - Removed operation group ContactsOperations
    info	[Changelog]   - Removed operation group OperationsResultsOperations
    info	[Changelog]   - Removed operation group SpacecraftsOperations
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from 4fb358d0aa557260078aac14daaa50e123949b20. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.2
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.2
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] rd  Average Speed   Time    Time     Time  Current
    cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
    cmderr	[init.sh] 
      0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     00k
    cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
    cmderr	[init.sh] %
    cmderr	[init.sh] Computing checksum with sha256sum
    cmderr	[init.sh] Checksums matched!
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-aodgv1 [View full logs]  [Preview SDK Changes]
️❌ azure-sdk-for-go failed [Detail]
  • Code Generator Failed [Logs] Generate from 4fb358d0aa557260078aac14daaa50e123949b20. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    cmderr	[generator automation-v2] [ERROR] total 1 error(s):
    cmderr	[generator automation-v2] [ERROR] failed to execute `go generate` '[33;1mWARNING: Unable to find version for /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/orbital/armorbital[0m
    cmderr	[generator automation-v2] [ERROR] Cannot find go module under resourcemanager/orbital/armorbital, try to build in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/orbital/armorbital
    cmderr	[generator automation-v2] [ERROR] ##[command]Cleaning auto-generated files in /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/orbital/armorbital
    cmderr	[generator automation-v2] [ERROR] ##[command]Executing autorest.go in  /mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/orbital/armorbital
    cmderr	[generator automation-v2] [ERROR] autorest --use=@autorest/[email protected] --go --track2 --output-folder=/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/orbital/armorbital --clear-output-folder=false --go.clear-output-folder=false --honor-body-placement=true --remove-unreferenced-types=false ./autorest.md
    cmderr	[generator automation-v2] [ERROR] AutoRest code generation utility [cli version: 3.6.1; node: v18.19.0]
    cmderr	[generator automation-v2] [ERROR] (C) 2018 Microsoft Corporation.
    cmderr	[generator automation-v2] [ERROR] https://aka.ms/autorest
    cmderr	[generator automation-v2] [ERROR] There is a new version of AutoRest available (3.7.1).
    cmderr	[generator automation-v2] [ERROR] > You can install the newer version with with npm install -g autorest@latest
    cmderr	[generator automation-v2] [ERROR] info    |    Loading AutoRest core      '/home/cloudtest/.autorest/@[email protected]/nodemodules/@autorest/core/dist' (3.10.1)
    cmderr	[generator automation-v2] [ERROR] info    |    Installing AutoRest extension '@autorest/go' (4.0.0-preview.60 -> 4.0.0-preview.60)
    cmderr	[generator automation-v2] [ERROR] info    |    Installed AutoRest extension '@autorest/go' (4.0.0-preview.60->4.0.0-preview.60)
    cmderr	[generator automation-v2] [ERROR] info    |    Installing AutoRest extension '@autorest/modelerfour' (4.26.2 -> 4.26.2)
    cmderr	[generator automation-v2] [ERROR] info    |    Installed AutoRest extension '@autorest/modelerfour' (4.26.2->4.26.2)
    cmderr	[generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'GroundStation-properties' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambiguous. This has been auto-corrected to 'type:object'
    cmderr	[generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/aodgv1/resource-manager/Microsoft.Orbital/preview/2024-03-01-preview/orbital.json:1128:9
    cmderr	[generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'GlobalCommunicationsSitesProperties-locationData' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambiguous. This has been auto-corrected to 'type:object'
    cmderr	[generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/aodgv1/resource-manager/Microsoft.Orbital/preview/2024-03-01-preview/orbital.json:1279:9
    cmderr	[generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'GlobalCommunicationsSite-properties' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambiguous. This has been auto-corrected to 'type:object'
    cmderr	[generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/aodgv1/resource-manager/Microsoft.Orbital/preview/2024-03-01-preview/orbital.json:1318:9
    cmderr	[generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'EdgeSite-properties' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambiguous. This has been auto-corrected to 'type:object'
    cmderr	[generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/aodgv1/resource-manager/Microsoft.Orbital/preview/2024-03-01-preview/orbital.json:1359:9
    cmderr	[generator automation-v2] [ERROR] warning | PreCheck/SchemaMissingType | The schema 'L2Connection-properties' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambiguous. This has been auto-corrected to 'type:object'
    cmderr	[generator automation-v2] [ERROR] - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/aodgv1/resource-manager/Microsoft.Orbital/preview/2024-03-01-preview/orbital.json:1507:9
    cmderr	[generator automation-v2] [ERROR] warning | PreCheck/CheckDuplicateSchemas | Checking for duplicate schemas, this could take a (long) while.  Run with --verbose for more detail.
    cmderr	[generator automation-v2] [ERROR] warning | UsingTemporaryFlag | modelerfour.treat-type-object-as-anything options is a temporary flag. It WILL be removed in the future.
    cmderr	[generator automation-v2] [ERROR] fatal   | Error: optional client parameters for ARM is not supported
    cmderr	[generator automation-v2] [ERROR] fatal   | Process() cancelled due to failure
    cmderr	[generator automation-v2] [ERROR] error   |   Error: Plugin go-codegen reported failure.
    cmderr	[generator automation-v2] [ERROR] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
    cmderr	[generator automation-v2] [ERROR] ##[error]Error running autorest.go
    cmderr	[generator automation-v2] [ERROR] build.go:5: running "pwsh": exit status 1
    cmderr	[generator automation-v2] [ERROR] ': exit status 1
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: generator automation-v2
    warn	Skip package processing as generation is failed
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 4fb358d0aa557260078aac14daaa50e123949b20. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-orbital [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added operation group EdgeSites
    info	[Changelog]   - Added operation group GlobalCommunicationsSites
    info	[Changelog]   - Added operation group GroundStations
    info	[Changelog]   - Added operation group L2Connections
    info	[Changelog]   - Added Interface CloudError
    info	[Changelog]   - Added Interface CloudErrorBody
    info	[Changelog]   - Added Interface EdgeSite
    info	[Changelog]   - Added Interface EdgeSiteListResult
    info	[Changelog]   - Added Interface EdgeSiteProperties
    info	[Changelog]   - Added Interface EdgeSitesCreateOrUpdateOptionalParams
    info	[Changelog]   - Added Interface EdgeSitesDeleteOptionalParams
    info	[Changelog]   - Added Interface EdgeSitesGetOptionalParams
    info	[Changelog]   - Added Interface EdgeSitesListBySubscriptionNextOptionalParams
    info	[Changelog]   - Added Interface EdgeSitesListBySubscriptionOptionalParams
    info	[Changelog]   - Added Interface EdgeSitesListL2ConnectionsNextOptionalParams
    info	[Changelog]   - Added Interface EdgeSitesListL2ConnectionsOptionalParams
    info	[Changelog]   - Added Interface EdgeSitesListNextOptionalParams
    info	[Changelog]   - Added Interface EdgeSitesListOptionalParams
    info	[Changelog]   - Added Interface EdgeSitesProperties
    info	[Changelog]   - Added Interface EdgeSitesUpdateTagsOptionalParams
    info	[Changelog]   - Added Interface GlobalCommunicationsSite
    info	[Changelog]   - Added Interface GlobalCommunicationsSiteListResult
    info	[Changelog]   - Added Interface GlobalCommunicationsSiteProperties
    info	[Changelog]   - Added Interface GlobalCommunicationsSitesGetOptionalParams
    info	[Changelog]   - Added Interface GlobalCommunicationsSitesListBySubscriptionNextOptionalParams
    info	[Changelog]   - Added Interface GlobalCommunicationsSitesListBySubscriptionOptionalParams
    info	[Changelog]   - Added Interface GlobalCommunicationsSitesProperties
    info	[Changelog]   - Added Interface GlobalCommunicationsSitesPropertiesLocationData
    info	[Changelog]   - Added Interface GroundStation
    info	[Changelog]   - Added Interface GroundStationListResult
    info	[Changelog]   - Added Interface GroundStationProperties
    info	[Changelog]   - Added Interface GroundStationsCreateOrUpdateOptionalParams
    info	[Changelog]   - Added Interface GroundStationsDeleteOptionalParams
    info	[Changelog]   - Added Interface GroundStationsGetOptionalParams
    info	[Changelog]   - Added Interface GroundStationsListBySubscriptionNextOptionalParams
    info	[Changelog]   - Added Interface GroundStationsListBySubscriptionOptionalParams
    info	[Changelog]   - Added Interface GroundStationsListL2ConnectionsNextOptionalParams
    info	[Changelog]   - Added Interface GroundStationsListL2ConnectionsOptionalParams
    info	[Changelog]   - Added Interface GroundStationsListNextOptionalParams
    info	[Changelog]   - Added Interface GroundStationsListOptionalParams
    info	[Changelog]   - Added Interface GroundStationsProperties
    info	[Changelog]   - Added Interface GroundStationsUpdateTagsOptionalParams
    info	[Changelog]   - Added Interface L2Connection
    info	[Changelog]   - Added Interface L2ConnectionListResult
    info	[Changelog]   - Added Interface L2ConnectionProperties
    info	[Changelog]   - Added Interface L2ConnectionsCreateOrUpdateHeaders
    info	[Changelog]   - Added Interface L2ConnectionsCreateOrUpdateOptionalParams
    info	[Changelog]   - Added Interface L2ConnectionsDeleteHeaders
    info	[Changelog]   - Added Interface L2ConnectionsDeleteOptionalParams
    info	[Changelog]   - Added Interface L2ConnectionsGetOptionalParams
    info	[Changelog]   - Added Interface L2ConnectionsListBySubscriptionNextOptionalParams
    info	[Changelog]   - Added Interface L2ConnectionsListBySubscriptionOptionalParams
    info	[Changelog]   - Added Interface L2ConnectionsListNextOptionalParams
    info	[Changelog]   - Added Interface L2ConnectionsListOptionalParams
    info	[Changelog]   - Added Interface L2ConnectionsProperties
    info	[Changelog]   - Added Interface L2ConnectionsUpdateTagsHeaders
    info	[Changelog]   - Added Interface L2ConnectionsUpdateTagsOptionalParams
    info	[Changelog]   - Added Interface LocationData
    info	[Changelog]   - Added Interface PartnerRouter
    info	[Changelog]   - Added Interface ProvisionedBandwidth
    info	[Changelog]   - Added Type Alias EdgeSitesCreateOrUpdateResponse
    info	[Changelog]   - Added Type Alias EdgeSitesGetResponse
    info	[Changelog]   - Added Type Alias EdgeSitesListBySubscriptionNextResponse
    info	[Changelog]   - Added Type Alias EdgeSitesListBySubscriptionResponse
    info	[Changelog]   - Added Type Alias EdgeSitesListL2ConnectionsNextResponse
    info	[Changelog]   - Added Type Alias EdgeSitesListL2ConnectionsResponse
    info	[Changelog]   - Added Type Alias EdgeSitesListNextResponse
    info	[Changelog]   - Added Type Alias EdgeSitesListResponse
    info	[Changelog]   - Added Type Alias EdgeSitesUpdateTagsResponse
    info	[Changelog]   - Added Type Alias GlobalCommunicationsSitesGetResponse
    info	[Changelog]   - Added Type Alias GlobalCommunicationsSitesListBySubscriptionNextResponse
    info	[Changelog]   - Added Type Alias GlobalCommunicationsSitesListBySubscriptionResponse
    info	[Changelog]   - Added Type Alias GlobalCommunicationsSitesPropertiesGlobalCommunicationsSiteType
    info	[Changelog]   - Added Type Alias GlobalCommunicationsSiteType
    info	[Changelog]   - Added Type Alias GroundStationsCreateOrUpdateResponse
    info	[Changelog]   - Added Type Alias GroundStationsGetResponse
    info	[Changelog]   - Added Type Alias GroundStationsListBySubscriptionNextResponse
    info	[Changelog]   - Added Type Alias GroundStationsListBySubscriptionResponse
    info	[Changelog]   - Added Type Alias GroundStationsListL2ConnectionsNextResponse
    info	[Changelog]   - Added Type Alias GroundStationsListL2ConnectionsResponse
    info	[Changelog]   - Added Type Alias GroundStationsListNextResponse
    info	[Changelog]   - Added Type Alias GroundStationsListResponse
    info	[Changelog]   - Added Type Alias GroundStationsUpdateTagsResponse
    info	[Changelog]   - Added Type Alias L2ConnectionsCreateOrUpdateResponse
    info	[Changelog]   - Added Type Alias L2ConnectionsDeleteResponse
    info	[Changelog]   - Added Type Alias L2ConnectionsGetResponse
    info	[Changelog]   - Added Type Alias L2ConnectionsListBySubscriptionNextResponse
    info	[Changelog]   - Added Type Alias L2ConnectionsListBySubscriptionResponse
    info	[Changelog]   - Added Type Alias L2ConnectionsListNextResponse
    info	[Changelog]   - Added Type Alias L2ConnectionsListResponse
    info	[Changelog]   - Added Type Alias L2ConnectionsPropertiesProvisioningState
    info	[Changelog]   - Added Type Alias L2ConnectionsUpdateTagsResponse
    info	[Changelog]   - Interface AzureOrbitalOptionalParams has a new optional parameter skiptoken
    info	[Changelog]   - Added Enum KnownGlobalCommunicationsSitesPropertiesGlobalCommunicationsSiteType
    info	[Changelog]   - Added Enum KnownGlobalCommunicationsSiteType
    info	[Changelog]   - Added Enum KnownL2ConnectionsPropertiesProvisioningState
    info	[Changelog]
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Removed operation group AvailableGroundStations
    info	[Changelog]   - Removed operation group ContactProfiles
    info	[Changelog]   - Removed operation group Contacts
    info	[Changelog]   - Removed operation group OperationsResults
    info	[Changelog]   - Removed operation group Spacecrafts
    info	[Changelog]   - Class AzureOrbital no longer has parameter availableGroundStations
    info	[Changelog]   - Class AzureOrbital no longer has parameter contactProfiles
    info	[Changelog]   - Class AzureOrbital no longer has parameter contacts
    info	[Changelog]   - Class AzureOrbital no longer has parameter operationsResults
    info	[Changelog]   - Class AzureOrbital no longer has parameter spacecrafts
    info	[Changelog]   - Removed Enum KnownContactProfilesPropertiesProvisioningState
    info	[Changelog]   - Removed Enum KnownContactsPropertiesProvisioningState
    info	[Changelog]   - Removed Enum KnownContactsStatus
    info	[Changelog]   - Removed Enum KnownDirection
    info	[Changelog]   - Removed Enum KnownPolarization
    info	[Changelog]   - Removed Enum KnownProtocol
    info	[Changelog]   - Removed Enum KnownSpacecraftsPropertiesProvisioningState
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs] Generate from 4fb358d0aa557260078aac14daaa50e123949b20. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh]
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.2.3 -> 10.3.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.3.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • ️✔️aodgv1 [View full logs]  [Preview Schema Changes]
️️✔️ azure-powershell succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 4fb358d0aa557260078aac14daaa50e123949b20. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ️✔️Az.aodgv1.DefaultTag [View full logs]  [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Hi @kkashojjula-msft! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.

Hi, @kkashojjula-msft, our workflow has detected that there is no management SDK ever released for your RP, to further process SDK onboard for your RP, you should have the SDK client library name of your RP reviewed and approved. Action Required:

  • Follow this guidance Naming for new initial management or client libraries (new SDKs) - Overview (azure.com) to create an issue for management client library name arch board review.
  • Paste the issue link that you created in step 1 in this PR
  • Impact: SDK release owner will take the approved management client library name to release SDK. No client library name approval will leads to SDK release delayed.

    Hi @kkashojjula-msft This PR was flagged for introducing a new RP namespace that is not being onboarded with RPaaS. Merging this PR to the main branch will be blocked as RPaaS is required for new RPs. To resolve this and allow the PR to be merged into the main branch, please use RPaaS to onboard the new RP.

    @msyyc Can I get review on this PR for CI-BreakingChange-?

    kkashojjula-msft avatar Jan 23 '24 20:01 kkashojjula-msft

    can you explain the intention behind this PR ? , it looks like you have the same rp in the private repo : https://github.com/Azure/azure-rest-api-specs-pr/tree/581bcb0b1c072350690be50b1fe2606522d2986c/specification/orbital/resource-manager/Microsoft.Orbital/stable

    although that is under a different folder called "orbital" but here it is under aodgv1 ?

    Also I see that the resources from the private repo are not in this PR and vice versa.

    raosuhas avatar Jan 26 '24 22:01 raosuhas

    Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    This will notify the reviewer to have another look.
    If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
    Please include [ARM Query] in the title of your question to indicate that it is ARM-related.