azure-rest-api-specs
azure-rest-api-specs copied to clipboard
Azure
[Hub Generated] Review request for Microsoft.ContainerService/aks to add version preview/2023-11-02-preview
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
Tip: overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
- If this PR is in purview of ARM review then automation will add the
ARMReviewlabel. - If you want to force ARM review, add the label yourself.
- Proceed according to the diagram at the top of this comment.
Click here to see the diagram footnotes
Diagram footnotes
[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see Getting help section below.
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
- [x] New API version. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
- [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
- [ ] Update existing version to fix swagger quality issues in S360.
- [ ] Other, please clarify:
- edit this with your clarification
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:
- [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
- [x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the Swagger-Suppression-Process to get approval.
Getting help
- First, please carefully read through this PR description, from top to bottom. Please fill out the
Purpose of this PRandDue diligence checklist. - To understand what you must do next to merge this PR, see the
Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state. - For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
- If the PR CI checks appear to be stuck in
queuedstate, please add a comment with contents/azp run. This should result in a new comment denoting aPR validation pipelinehas started and the checks should be updated after few minutes. - If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
Next Steps to Merge
✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️Breaking Change(Cross-Version): 10 Warnings warning [Detail]
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| managedClusters.json | 2023-11-02-preview(79b877c) | 2023-11-01(main) |
| managedClusters.json | 2023-11-02-preview(79b877c) | 2023-10-02-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
The following breaking changes are detected by comparison with the latest preview version:
| Rule | Message |
|---|---|
| :warning: 1006 - RemovedDefinition | The new version is missing a definition that was found in the old version. Was 'GuardrailsProfile' removed or renamed? New: aks/preview/2023-11-02-preview/managedClusters.json#L3731:3 Old: aks/preview/2023-10-02-preview/managedClusters.json#L3645:3 |
| :warning: 1033 - RemovedProperty | The new version is missing a property found in the old version. Was 'guardrailsProfile' renamed or removed? New: aks/preview/2023-11-02-preview/managedClusters.json#L5488:7 Old: aks/preview/2023-10-02-preview/managedClusters.json#L5402:7 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 45 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.6) | new version | base version |
|---|---|---|
| package-preview-2023-11 | package-preview-2023-11(79b877c) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 30 items are listed, please refer to log for more details.
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| :warning: RequiredReadOnlySystemData | The response of operation:'Machines_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: aks/preview/2023-11-02-preview/managedClusters.json#L1458 |
|
| :warning: LatestVersionOfCommonTypesMustBeUsed | Use the latest version v5 of types.json. Location: aks/preview/2023-11-02-preview/managedClusters.json#L2478 |
|
| :warning: LatestVersionOfCommonTypesMustBeUsed | Use the latest version v5 of types.json. Location: aks/preview/2023-11-02-preview/managedClusters.json#L2481 |
|
| :warning: LatestVersionOfCommonTypesMustBeUsed | Use the latest version v5 of types.json. Location: aks/preview/2023-11-02-preview/managedClusters.json#L2484 |
|
| :warning: LatestVersionOfCommonTypesMustBeUsed | Use the latest version v5 of types.json. Location: aks/preview/2023-11-02-preview/managedClusters.json#L2523 |
|
| :warning: LatestVersionOfCommonTypesMustBeUsed | Use the latest version v5 of types.json. Location: aks/preview/2023-11-02-preview/managedClusters.json#L2526 |
|
| :warning: LatestVersionOfCommonTypesMustBeUsed | Use the latest version v5 of types.json. Location: aks/preview/2023-11-02-preview/managedClusters.json#L2529 |
|
| :warning: LatestVersionOfCommonTypesMustBeUsed | Use the latest version v5 of types.json. Location: aks/preview/2023-11-02-preview/managedClusters.json#L2535 |
|
| :warning: LatestVersionOfCommonTypesMustBeUsed | Use the latest version v5 of types.json. Location: aks/preview/2023-11-02-preview/managedClusters.json#L2568 |
|
| :warning: LatestVersionOfCommonTypesMustBeUsed | Use the latest version v5 of types.json. Location: aks/preview/2023-11-02-preview/managedClusters.json#L2571 |
|
| :warning: LatestVersionOfCommonTypesMustBeUsed | Use the latest version v5 of types.json. Location: aks/preview/2023-11-02-preview/managedClusters.json#L2574 |
|
| :warning: LatestVersionOfCommonTypesMustBeUsed | Use the latest version v5 of types.json. Location: aks/preview/2023-11-02-preview/managedClusters.json#L2583 |
|
| :warning: UniqueXmsExample | Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get OperationStatusResult Location: aks/preview/2023-11-02-preview/managedClusters.json#L2600 |
|
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: aks/preview/2023-11-02-preview/managedClusters.json#L4054 |
|
| :warning: AvoidNestedProperties | Consider using x-ms-client-flatten to provide a better end user experience Location: aks/preview/2023-11-02-preview/managedClusters.json#L4766 |
|
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: aks/preview/2023-11-02-preview/managedClusters.json#L4769 |
|
| :warning: AvoidNestedProperties | Consider using x-ms-client-flatten to provide a better end user experience Location: aks/preview/2023-11-02-preview/managedClusters.json#L4795 |
|
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: aks/preview/2023-11-02-preview/managedClusters.json#L5601 |
|
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: aks/preview/2023-11-02-preview/managedClusters.json#L5630 |
|
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: aks/preview/2023-11-02-preview/managedClusters.json#L5635 |
|
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: aks/preview/2023-11-02-preview/managedClusters.json#L5640 |
|
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: aks/preview/2023-11-02-preview/managedClusters.json#L5932 |
|
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: aks/preview/2023-11-02-preview/managedClusters.json#L7222 |
|
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: aks/preview/2023-11-02-preview/managedClusters.json#L7236 |
|
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: aks/preview/2023-11-02-preview/managedClusters.json#L7240 |
|
| :warning: SchemaDescriptionOrTitle | Schema should have a description or title. Location: aks/preview/2023-11-02-preview/managedClusters.json#L7247 |
|
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: aks/preview/2023-11-02-preview/managedClusters.json#L7250 |
|
| :warning: SchemaDescriptionOrTitle | Schema should have a description or title. Location: aks/preview/2023-11-02-preview/managedClusters.json#L7257 |
|
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: aks/preview/2023-11-02-preview/managedClusters.json#L7260 |
|
| :warning: EnumInsteadOfBoolean | Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: aks/preview/2023-11-02-preview/managedClusters.json#L7579 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The response schema of operations API '/providers/Microsoft.ContainerService/operations' does not match the ARM specification. Please standardize the schema. Location: aks/preview/2023-11-02-preview/managedClusters.json#L52 |
|
Operations API path must follow the schema provided in the common types. Location: aks/preview/2023-11-02-preview/managedClusters.json#L53 |
|
x-ms-pageable extension must be specified for LIST APIs.Location: aks/preview/2023-11-02-preview/managedClusters.json#L74 |
|
Query parameter resource-type should be removed. Point Get's MUST not have query parameters other than api version. Location: aks/preview/2023-11-02-preview/managedClusters.json#L80 |
|
x-ms-pageable extension must be specified for LIST APIs.Location: aks/preview/2023-11-02-preview/managedClusters.json#L116 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: aks/preview/2023-11-02-preview/managedClusters.json#L137 |
|
x-ms-pageable extension must be specified for LIST APIs.Location: aks/preview/2023-11-02-preview/managedClusters.json#L237 |
|
The resource name parameter 'roleName' should be defined with a 'pattern' restriction. Location: aks/preview/2023-11-02-preview/managedClusters.json#L278 |
|
server-fqdn is a query parameter. Post operation must not contain any query parameter other than api-version. Location: aks/preview/2023-11-02-preview/managedClusters.json#L336 |
|
server-fqdn is a query parameter. Post operation must not contain any query parameter other than api-version. Location: aks/preview/2023-11-02-preview/managedClusters.json#L381 |
|
format is a query parameter. Post operation must not contain any query parameter other than api-version. Location: aks/preview/2023-11-02-preview/managedClusters.json#L381 |
|
server-fqdn is a query parameter. Post operation must not contain any query parameter other than api-version. Location: aks/preview/2023-11-02-preview/managedClusters.json#L429 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-11-02-preview/managedClusters.json#L553 |
|
Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes. Location: aks/preview/2023-11-02-preview/managedClusters.json#L660 |
|
The patch operation body parameter schema should contain property 'identity'. Location: aks/preview/2023-11-02-preview/managedClusters.json#L679 |
|
The async patch operation should return 202. Location: aks/preview/2023-11-02-preview/managedClusters.json#L689 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-11-02-preview/managedClusters.json#L699 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-11-02-preview/managedClusters.json#L749 |
|
The resource name parameter 'configName' should be defined with a 'pattern' restriction. Location: aks/preview/2023-11-02-preview/managedClusters.json#L809 |
|
Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes. Location: aks/preview/2023-11-02-preview/managedClusters.json#L979 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-11-02-preview/managedClusters.json#L1023 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-11-02-preview/managedClusters.json#L1175 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-11-02-preview/managedClusters.json#L1291 |
|
x-ms-pageable extension must be specified for LIST APIs.Location: aks/preview/2023-11-02-preview/managedClusters.json#L1307 |
|
x-ms-pageable extension must be specified for LIST APIs.Location: aks/preview/2023-11-02-preview/managedClusters.json#L1506 |
|
Per the Noun_Verb convention for Operation Ids, the noun 'AgentPools' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: aks/preview/2023-11-02-preview/managedClusters.json#L1510 |
|
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: aks/preview/2023-11-02-preview/managedClusters.json#L1530 |
|
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: aks/preview/2023-11-02-preview/managedClusters.json#L1549 |
|
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: aks/preview/2023-11-02-preview/managedClusters.json#L1595 |
|
200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: aks/preview/2023-11-02-preview/managedClusters.json#L1611 |
️❌Avocado: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The swagger JSON file is not referenced from the readme file. readme: resource-manager/Microsoft.ContainerService/aks/readme.md json: aks/preview/2023-11-02-preview/scheduledEvents.json |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from 4c3a171d3b5c3a562d131841a729c6c620a05f21. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] cmderr [automation_generate.sh] New minor version of npm available! 10.2.3 -> 10.4.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-containerservice [View full logs] [Preview SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation AgentPoolsOperations.begin_delete_machines info [Changelog] - Added operation ManagedClustersOperations.get_guardrails_versions info [Changelog] - Added operation ManagedClustersOperations.get_safeguards_versions info [Changelog] - Added operation ManagedClustersOperations.list_guardrails_versions info [Changelog] - Added operation ManagedClustersOperations.list_safeguards_versions info [Changelog] - Model AgentPool has a new parameter artifact_streaming_profile info [Changelog] - Model AgentPool has a new parameter enable_custom_ca_trust info [Changelog] - Model AgentPool has a new parameter gpu_profile info [Changelog] - Model AgentPool has a new parameter message_of_the_day info [Changelog] - Model AgentPool has a new parameter node_initialization_taints info [Changelog] - Model AgentPool has a new parameter security_profile info [Changelog] - Model AgentPool has a new parameter virtual_machine_nodes_status info [Changelog] - Model AgentPool has a new parameter virtual_machines_profile info [Changelog] - Model AgentPool has a new parameter windows_profile info [Changelog] - Model AgentPoolSecurityProfile has a new parameter enable_secure_boot info [Changelog] - Model AgentPoolSecurityProfile has a new parameter enable_vtpm info [Changelog] - Model ContainerServiceNetworkProfile has a new parameter kube_proxy_config info [Changelog] - Model ContainerServiceNetworkProfile has a new parameter monitoring info [Changelog] - Model ManagedCluster has a new parameter ai_toolchain_operator_profile info [Changelog] - Model ManagedCluster has a new parameter creation_data info [Changelog] - Model ManagedCluster has a new parameter enable_namespace_resources info [Changelog] - Model ManagedCluster has a new parameter ingress_profile info [Changelog] - Model ManagedCluster has a new parameter metrics_profile info [Changelog] - Model ManagedCluster has a new parameter node_provisioning_profile info [Changelog] - Model ManagedCluster has a new parameter node_resource_group_profile info [Changelog] - Model ManagedCluster has a new parameter safeguards_profile info [Changelog] - Model ManagedClusterAPIServerAccessProfile has a new parameter enable_vnet_integration info [Changelog] - Model ManagedClusterAPIServerAccessProfile has a new parameter subnet_id info [Changelog] - Model ManagedClusterAgentPoolProfile has a new parameter artifact_streaming_profile info [Changelog] - Model ManagedClusterAgentPoolProfile has a new parameter enable_custom_ca_trust info [Changelog] - Model ManagedClusterAgentPoolProfile has a new parameter gpu_profile info [Changelog] - Model ManagedClusterAgentPoolProfile has a new parameter message_of_the_day info [Changelog] - Model ManagedClusterAgentPoolProfile has a new parameter node_initialization_taints info [Changelog] - Model ManagedClusterAgentPoolProfile has a new parameter security_profile info [Changelog] - Model ManagedClusterAgentPoolProfile has a new parameter virtual_machine_nodes_status info [Changelog] - Model ManagedClusterAgentPoolProfile has a new parameter virtual_machines_profile info [Changelog] - Model ManagedClusterAgentPoolProfile has a new parameter windows_profile info [Changelog] - Model ManagedClusterAgentPoolProfileProperties has a new parameter artifact_streaming_profile info [Changelog] - Model ManagedClusterAgentPoolProfileProperties has a new parameter enable_custom_ca_trust info [Changelog] - Model ManagedClusterAgentPoolProfileProperties has a new parameter gpu_profile info [Changelog] - Model ManagedClusterAgentPoolProfileProperties has a new parameter message_of_the_day info [Changelog] - Model ManagedClusterAgentPoolProfileProperties has a new parameter node_initialization_taints info [Changelog] - Model ManagedClusterAgentPoolProfileProperties has a new parameter security_profile info [Changelog] - Model ManagedClusterAgentPoolProfileProperties has a new parameter virtual_machine_nodes_status info [Changelog] - Model ManagedClusterAgentPoolProfileProperties has a new parameter virtual_machines_profile info [Changelog] - Model ManagedClusterAgentPoolProfileProperties has a new parameter windows_profile info [Changelog] - Model ManagedClusterAzureMonitorProfile has a new parameter logs info [Changelog] - Model ManagedClusterAzureMonitorProfileMetrics has a new parameter app_monitoring_open_telemetry_metrics info [Changelog] - Model ManagedClusterHTTPProxyConfig has a new parameter effective_no_proxy info [Changelog] - Model ManagedClusterPropertiesAutoScalerProfile has a new parameter daemonset_eviction_for_empty_nodes info [Changelog] - Model ManagedClusterPropertiesAutoScalerProfile has a new parameter daemonset_eviction_for_occupied_nodes info [Changelog] - Model ManagedClusterPropertiesAutoScalerProfile has a new parameter ignore_daemonsets_utilization info [Changelog] - Model ManagedClusterSecurityProfile has a new parameter custom_ca_trust_certificates info [Changelog] - Model ManagedClusterSecurityProfile has a new parameter image_integrity info [Changelog] - Model ManagedClusterSecurityProfile has a new parameter node_restriction info [Changelog] - Model ManagedClusterStorageProfileDiskCSIDriver has a new parameter version info [Changelog] - Model ManagedClusterWorkloadAutoScalerProfileVerticalPodAutoscaler has a new parameter addon_autoscaling info [Changelog] - Operation AgentPoolsOperations.begin_delete has a new optional parameter ignore_pod_disruption_budget info [Changelog] - Operation ManagedClustersOperations.begin_delete has a new optional parameter ignore_pod_disruption_budget
️❌ azure-sdk-for-java failed [Detail]
❌Pipeline Framework Failed [Logs] Generate from 4c3a171d3b5c3a562d131841a729c6c620a05f21. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.2 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.2 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] e Speed Time Time Time Current cmderr [init.sh] Dload Upload Total Spent Left Speed cmderr [init.sh] 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 01k cmderr [init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz... cmderr [init.sh] Computing checksum with sha256sum cmderr [init.sh] Checksums matched! command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/containerservicemicrosoftcontainerserviceaks/azure-resourcemanager-containerservicemicrosoftcontainerserviceaks-generated/pom.xml'
❌azure-resourcemanager-containerservicemicrosoftcontainerserviceaks-generated [View full logs]error Fatal error: ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/containerservicemicrosoftcontainerserviceaks/azure-resourcemanager-containerservicemicrosoftcontainerserviceaks-generated/pom.xml' error Fatal error: Error: ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/containerservicemicrosoftcontainerserviceaks/azure-resourcemanager-containerservicemicrosoftcontainerserviceaks-generated/pom.xml' error The following packages are still pending: error azure-resourcemanager-containerservicemicrosoftcontainerserviceaks-generated
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 4c3a171d3b5c3a562d131841a729c6c620a05f21. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/containerservice/armcontainerservice [View full logs] [Preview SDK Changes]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 4c3a171d3b5c3a562d131841a729c6c620a05f21. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-containerservice [View full logs] [Preview SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Interface AgentPoolUpgradeSettings has a new optional parameter nodeSoakDurationInMinutes
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 4c3a171d3b5c3a562d131841a729c6c620a05f21. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️Azure.ResourceManager.ContainerService [View full logs] [Preview SDK Changes]info [Changelog]
️❌ azure-resource-manager-schemas failed [Detail]
❌Pipeline Framework Failed [Logs] Generate from 4c3a171d3b5c3a562d131841a729c6c620a05f21. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] cmderr [initScript.sh] npm notice New minor version of npm available! 10.2.3 -> 10.4.0 cmderr [initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0> cmderr [initScript.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [initScript.sh] npm notice warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json warn No file changes detected after generation fatal: cannot force update the branch 'sdkAuto/27431/containerservice' used by worktree at '/mnt/vss/_work/1/s/azure-resource-manager-schemas'
️✔️containerservice [View full logs]️✔️containerservice [View full logs]error Fatal error: fatal: cannot force update the branch 'sdkAuto/27431/containerservice' used by worktree at '/mnt/vss/_work/1/s/azure-resource-manager-schemas' error Fatal error: Error: fatal: cannot force update the branch 'sdkAuto/27431/containerservice' used by worktree at '/mnt/vss/_work/1/s/azure-resource-manager-schemas' at Object.action (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1274:25) at PluginStore.exec (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1309:29) at /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1674:43 at new Promise (<anonymous>) at GitExecutorChain.handleTaskData (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1672:16) at GitExecutorChain.<anonymous> (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1656:44) at Generator.next (<anonymous>) at fulfilled (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:55:24) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) error The following packages are still pending: error containerservice error containerservice
️️✔️ azure-powershell succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 4c3a171d3b5c3a562d131841a729c6c620a05f21. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
️✔️Az.containerservice.DefaultTag [View full logs] [Preview SDK Changes]
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Go | sdk/resourcemanager/containerservice/armcontainerservice | https://apiview.dev/Assemblies/Review/54b1e1dfd98c4c2cb44c0a03efa8326f?revisionId=a750c0c075aa4db993f138a602a76094 |
| .Net | Azure.ResourceManager.ContainerService | https://apiview.dev/Assemblies/Review/52837c343d7a486c97a62dfd430600a8?revisionId=1dfa4720df3c4598994a339454d51ce8 |
| JavaScript | @azure/arm-containerservice | https://apiview.dev/Assemblies/Review/dabf043916d14dc38e0c2d456d89f55a?revisionId=c416564f851d4892a371242fd408113d |
| Swagger | Microsoft.ContainerService | https://apiview.dev/Assemblies/Review/71d5cd3d2d1c46b59eabc692899ea0b4?revisionId=a53804df3441499d8cf3a9e0b21cd4a1 |
@rkmanda, I would like to apply for suppression of failed CI Swagger Avocado as we deliberately did not add the new swagger file aks/preview/2023-11-02-preview/scheduledEvents.json (change committed in #26774) to the SDK config. The intended consumer of this swagger model is the Azure Resource Notification team. Their requirement is the swagger should be published publicly as the consumption model, but meanwhile AKS does not want to expose it to the SDK.
+ avocado owners @konrad-jamrozik, @raych1 + feature owners @JunSun17, @matthchr
Followed the guidance in doc https://eng.ms/docs/products/azure-developer-experience/design/specs-pr-guides/pr-suppressions
@FumingZhang don't worry about avocado, it is non-blocking. Instead, see Getting help section from your PR description.
}
consider updating these to enum as explained here :
https://github.com/Azure/azure-openapi-validator/blob/main/docs/enum-instead-of-boolean.md #Resolved
Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-11-02-preview/managedClusters.json:7243 in 5aefecb. [](commit_id = 5aefecbe32408d68e731023417158b347cc0c1f2, deletion_comment = False)
"type": "boolean",
same here:
for example :
Version: Default (later you could add Latest\Oldest etc as required) #Resolved
Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-11-02-preview/managedClusters.json:7648 in 5aefecb. [](commit_id = 5aefecbe32408d68e731023417158b347cc0c1f2, deletion_comment = False)
Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
}consider updating these to enum as explained here :
https://github.com/Azure/azure-openapi-validator/blob/main/docs/enum-instead-of-boolean.md
Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-11-02-preview/managedClusters.json:7243 in 5aefecb. [](commit_id = 5aefecb, deletion_comment = False)
changed added in PR #26850
"type": "boolean",same here:
for example :
Version: Default (later you could add Latest\Oldest etc as required)
Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-11-02-preview/managedClusters.json:7648 in 5aefecb. [](commit_id = 5aefecb, deletion_comment = False)
change added in PR #26798
"type": "boolean",same here:
for example :
Version: Default (later you could add Latest\Oldest etc as required)
Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-11-02-preview/managedClusters.json:7648 in 5aefecb. [](commit_id = 5aefecb, deletion_comment = False)
@raosuhas this property is absolutely a boolean. Either it is the default version, or it isn't. We have no plans to add a "Latest" or "Oldest" category
}consider updating these to enum as explained here :
https://github.com/Azure/azure-openapi-validator/blob/main/docs/enum-instead-of-boolean.md
Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-11-02-preview/managedClusters.json:7243 in 5aefecb. [](commit_id = 5aefecb, deletion_comment = False)
These two new boolean fields are made to match the fields exposed by VMSS. Those fields are shown here.
Since these fields are just proxying VMSS fields, which themselves are booleans, it doesn't make sense to use an enum.
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hey @msyyc, could you please help review and approve the CI-BreakingChange-Python-Track2? The latest released SDK is taking a stable API version as default and all listed added features in the comparison results are new in the preview API version compared to the stable API version, which is also in line with expectations.
https://github.com/Azure/azure-rest-api-specs/pull/27431/checks?check_run_id=20886076235
Hey @weidongxu-microsoft, could you please help find out why CI SDK azure-sdk-for-java is failing? I reran the CI but met the same error. The error message is
ENOENT: no such file or directory, stat 'azure-sdk-for-java/sdk/containerservicemicrosoftcontainerserviceaks/azure-resourcemanager-containerservicemicrosoftcontainerserviceaks-generated/pom.xml'