azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

New preview version for MICROSOFT.DBFORMYSQL

Open xiaoxuqi-ms opened this issue 1 year ago • 9 comments

ARM (Control Plane) API Specification Update Pull Request

Tip: overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you, you must follow the breaking changes process.
IMPORTANT This applies even if:

  • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
  • You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.
Click here to see the diagram footnotes

Diagram footnotes

[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page. If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested is removed from your PR. This should cause the label WaitForARMFeedback to be added. [2] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • [x] New API version. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • [ ] Update existing version to fix swagger quality issues in S360.
  • [ ] Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

  • [ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [ ] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the Swagger-Suppression-Process to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

xiaoxuqi-ms avatar Jan 09 '24 08:01 xiaoxuqi-ms

Next Steps to Merge

Important checks have failed. As of today they are not blocking this PR, but in near future they will.
Addressing the following failures is highly recommended:
  • ⚠️ The check named TypeSpec Requirement has failed. TypeSpec usage is required for all new (greenfield) services. This is currently enforced as a warning, but will be made a blocking error in the near future. For information on converting from OpenAPI specs to TypeSpec specs or on data-plane (DP) policies, refer to aka.ms/azsdk/typespec. If you have general questions on resource provider (RP) policies, refer to aka.ms/rphelp.
If you still want to proceed merging this PR without addressing the above failures, refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
compared swaggers (via Oad v0.10.4)] new version base version
BackupAndExport.json 2023-10-01-preview(7541c62) 2023-06-30(main)
BackupAndExport.json 2023-10-01-preview(7541c62) 2023-06-01-preview(main)
Backups.json 2023-10-01-preview(7541c62) 2023-06-30(main)
Backups.json 2023-10-01-preview(7541c62) 2023-06-01-preview(main)
AdvancedThreatProtectionSettings.json 2023-12-01-preview(7541c62) 2023-10-01-preview(main)
FlexibleServers.json 2023-12-01-preview(7541c62) 2023-06-30(main)
FlexibleServers.json 2023-12-01-preview(7541c62) 2023-10-01-preview(main)
ServiceOperations.json 2023-12-01-preview(7541c62) 2023-06-30(main)
ServiceOperations.json 2023-12-01-preview(7541c62) 2023-06-01-preview(main)
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 4 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-flexibleserver-2023-12-01-preview package-flexibleserver-2023-12-01-preview(7541c62) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
:warning: MissingSegmentsInNestedResourceListOperation A nested resource type's List operation must include all the parent segments in its api path.
Location: Backups/preview/2023-10-01-preview/LongRunningBackups.json#L156
RPC-Get-V1-11
:warning: AllProxyResourcesShouldHaveDelete The resource ServerBackupV2 does not have a corresponding delete operation.
Location: Backups/preview/2023-10-01-preview/LongRunningBackups.json#L262
RPC-Delete-V1-05
:warning: GetInOperationName 'GET' operation 'Maintenances_Read' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Maintenance/preview/2023-10-01-preview/Maintenances.json#L42
:warning: MissingSegmentsInNestedResourceListOperation A nested resource type's List operation must include all the parent segments in its api path.
Location: Maintenance/preview/2023-10-01-preview/Maintenances.json#L143
RPC-Get-V1-11


The following errors/warnings exist before current PR submission:

Rule Message
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Backups/preview/2023-10-01-preview/Backups.json#L38
ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: FlexibleServers/preview/2023-12-01-preview/FlexibleServers.json#L38
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: FlexibleServers/preview/2023-12-01-preview/FlexibleServers.json#L38
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: FlexibleServers/preview/2023-12-01-preview/FlexibleServers.json#L38
ProvisioningStateSpecifiedForLROPatch 200 response schema in long running PATCH operation is missing ProvisioningState property. A LRO PATCH operations 200 response schema must have ProvisioningState specified.
Location: FlexibleServers/preview/2023-12-01-preview/FlexibleServers.json#L152
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: FlexibleServers/preview/2023-12-01-preview/FlexibleServers.json#L175
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: FlexibleServers/preview/2023-12-01-preview/FlexibleServers.json#L353
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: FlexibleServers/preview/2023-12-01-preview/FlexibleServers.json#L452
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: FlexibleServers/preview/2023-12-01-preview/FlexibleServers.json#L509
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: FlexibleServers/preview/2023-12-01-preview/FlexibleServers.json#L557
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: FlexibleServers/preview/2023-12-01-preview/FlexibleServers.json#L605
OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.DBforMySQL/operations' does not match the ARM specification. Please standardize the schema.
Location: ServiceOperations/preview/2023-12-01-preview/ServiceOperations.json#L456
OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
Location: ServiceOperations/preview/2023-12-01-preview/ServiceOperations.json#L457
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: ServiceOperations/preview/2023-12-01-preview/ServiceOperations.json#L953
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: ServiceOperations/preview/2023-12-01-preview/ServiceOperations.json#L973
:warning: PostOperationIdContainsUrlVerb OperationId should contain the verb: 'backupandexport' in:'BackupAndExport_Create'. Consider updating the operationId
Location: Backups/preview/2023-10-01-preview/BackupAndExport.json#L29
:warning: PutInOperationName 'PUT' operation 'Backups_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Backups/preview/2023-10-01-preview/Backups.json#L42
:warning: MissingSegmentsInNestedResourceListOperation A nested resource type's List operation must include all the parent segments in its api path.
Location: Backups/preview/2023-10-01-preview/Backups.json#L125
:warning: AllProxyResourcesShouldHaveDelete The resource ServerBackup does not have a corresponding delete operation.
Location: Backups/preview/2023-10-01-preview/Backups.json#L191
:warning: MissingSegmentsInNestedResourceListOperation A nested resource type's List operation must include all the parent segments in its api path.
Location: FlexibleServers/preview/2023-12-01-preview/AdvancedThreatProtectionSettings.json#L232
:warning: UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Restart a server
Location: FlexibleServers/preview/2023-12-01-preview/FlexibleServers.json#L457
:warning: LatestVersionOfCommonTypesMustBeUsed Use the latest version v4 of privatelinks.json.
Location: FlexibleServers/preview/2023-12-01-preview/FlexibleServers.json#L1206
:warning: PostOperationIdContainsUrlVerb OperationId should contain the verb: 'checkvirtualnetworksubnetusage' in:'CheckVirtualNetworkSubnetUsage_Execute'. Consider updating the operationId
Location: ServiceOperations/preview/2023-12-01-preview/ServiceOperations.json#L174
:warning: PostOperationIdContainsUrlVerb OperationId should contain the verb: 'checknameavailability' in:'CheckNameAvailability_Execute'. Consider updating the operationId
Location: ServiceOperations/preview/2023-12-01-preview/ServiceOperations.json#L222
:warning: PostOperationIdContainsUrlVerb OperationId should contain the verb: 'checknameavailability' in:'CheckNameAvailabilityWithoutLocation_Execute'. Consider updating the operationId
Location: ServiceOperations/preview/2023-12-01-preview/ServiceOperations.json#L270
:warning: UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Check name availability
Location: ServiceOperations/preview/2023-12-01-preview/ServiceOperations.json#L271
:warning: PostOperationIdContainsUrlVerb OperationId should contain the verb: 'getprivatednszonesuffix' in:'GetPrivateDnsZoneSuffix_Execute'. Consider updating the operationId
Location: ServiceOperations/preview/2023-12-01-preview/ServiceOperations.json#L408
:warning: LocationMustHaveXmsMutability Property location must have 'x-ms-mutability':['read', 'create'] extension defined.
Location: ServiceOperations/preview/2023-12-01-preview/ServiceOperations.json#L504
:warning: EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: ServiceOperations/preview/2023-12-01-preview/ServiceOperations.json#L905
️❌Avocado: 1 Errors, 1 Warnings failed [Detail]
Rule Message
MULTIPLE_DEFAULT_TAGS The readme file has more than one default tag.
readme: specification/mysql/resource-manager/readme.md
:warning: MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/mysql/resource-manager/readme.md
tag: specification/mysql/resource-manager/readme.md#tag-package-2020-01-01
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking



azure-sdk-for-go - sdk/resourcemanager/mysql/armmysqlflexibleservers - Approved - 2.0.0-beta.3
+	Enum `SKUTier` has been removed
+	Field `AdditionalInfo`, `Code`, `Details`, `Message`, `Target` of struct `ErrorResponse` has been removed
+	Struct `Identity` has been removed
+	Struct `SKU` has been removed
+	Type of `BackupAndExportResponse.Error` has been changed from `*ErrorResponse` to `*ErrorDetail`
+	Type of `Server.Identity` has been changed from `*Identity` to `*MySQLServerIdentity`
+	Type of `Server.SKU` has been changed from `*SKU` to `*MySQLServerSKU`
+	Type of `ServerForUpdate.Identity` has been changed from `*Identity` to `*MySQLServerIdentity`
+	Type of `ServerForUpdate.SKU` has been changed from `*SKU` to `*MySQLServerSKU`
+	`BackupFormatNone` from enum `BackupFormat` has been removed
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 26ab9d53faf09651bff58cf9e5b455d7ebd60ffc. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.ResourceManager.MySql [View full logs]  [Preview SDK Changes]
    info	[Changelog]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from 26ab9d53faf09651bff58cf9e5b455d7ebd60ffc. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh] npm notice
    cmderr	[automation_generate.sh] npm notice New minor version of npm available! 10.2.3 -> 10.4.0
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-rdbms [View full logs]  [Preview SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation AdvancedThreatProtectionSettingsOperations.begin_update_put
    info	[Changelog]   - Added operation group LongRunningBackupOperations
    info	[Changelog]   - Added operation group LongRunningBackupsOperations
    info	[Changelog]   - Added operation group MaintenancesOperations
    info	[Changelog]   - Added operation group OperationProgressOperations
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from 26ab9d53faf09651bff58cf9e5b455d7ebd60ffc. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.2
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.2
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh]  Average Speed   Time    Time     Time  Current
    cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
    cmderr	[init.sh] 
      0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0k
    cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
    cmderr	[init.sh] ################################ 100.0%
    cmderr	[init.sh] Computing checksum with sha256sum
    cmderr	[init.sh] Checksums matched!
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-mysqlflexibleserver [View full logs]  [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 26ab9d53faf09651bff58cf9e5b455d7ebd60ffc. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/mysql/armmysql [View full logs]  [Preview SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
  • ️✔️sdk/resourcemanager/mysql/armmysqlflexibleservers [View full logs]  [Preview SDK Changes] Breaking Change Detected
    Only show 60 items here, please refer to log for details.
    info	[Changelog] - New function `*LongRunningBackupsClient.Get(context.Context, string, string, string, *LongRunningBackupsClientGetOptions) (LongRunningBackupsClientGetResponse, error)`
    info	[Changelog] - New function `*LongRunningBackupsClient.NewListPager(string, string, *LongRunningBackupsClientListOptions) *runtime.Pager[LongRunningBackupsClientListResponse]`
    info	[Changelog] - New function `NewMaintenancesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*MaintenancesClient, error)`
    info	[Changelog] - New function `*MaintenancesClient.NewListPager(string, string, *MaintenancesClientListOptions) *runtime.Pager[MaintenancesClientListResponse]`
    info	[Changelog] - New function `*MaintenancesClient.Read(context.Context, string, string, string, *MaintenancesClientReadOptions) (MaintenancesClientReadResponse, error)`
    info	[Changelog] - New function `*MaintenancesClient.BeginUpdate(context.Context, string, string, string, *MaintenancesClientBeginUpdateOptions) (*runtime.Poller[MaintenancesClientUpdateResponse], error)`
    info	[Changelog] - New function `NewOperationProgressClient(string, azcore.TokenCredential, *arm.ClientOptions) (*OperationProgressClient, error)`
    info	[Changelog] - New function `*OperationProgressClient.Get(context.Context, string, string, *OperationProgressClientGetOptions) (OperationProgressClientGetResponse, error)`
    info	[Changelog] - New function `*OperationProgressResponseType.GetOperationProgressResponseType() *OperationProgressResponseType`
    info	[Changelog] - New function `NewOperationResultsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*OperationResultsClient, error)`
    info	[Changelog] - New function `*OperationResultsClient.Get(context.Context, string, string, *OperationResultsClientGetOptions) (OperationResultsClientGetResponse, error)`
    info	[Changelog] - New function `*ServersClient.ValidateEstimateHighAvailability(context.Context, string, string, HighAvailabilityValidationEstimation, *ServersClientValidateEstimateHighAvailabilityOptions) (ServersClientValidateEstimateHighAvailabilityResponse, error)`
    info	[Changelog] - New function `NewServersMigrationClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ServersMigrationClient, error)`
    info	[Changelog] - New function `*ServersMigrationClient.BeginCutoverMigration(context.Context, string, string, *ServersMigrationClientBeginCutoverMigrationOptions) (*runtime.Poller[ServersMigrationClientCutoverMigrationResponse], error)`
    info	[Changelog] - New struct `AdvancedThreatProtection`
    info	[Changelog] - New struct `AdvancedThreatProtectionForUpdate`
    info	[Changelog] - New struct `AdvancedThreatProtectionListResult`
    info	[Changelog] - New struct `AdvancedThreatProtectionProperties`
    info	[Changelog] - New struct `AdvancedThreatProtectionUpdateProperties`
    info	[Changelog] - New struct `BackupAndExportResponseType`
    info	[Changelog] - New struct `Capability`
    info	[Changelog] - New struct `CapabilityPropertiesV2`
    info	[Changelog] - New struct `CapabilitySetsList`
    info	[Changelog] - New struct `ErrorDetail`
    info	[Changelog] - New struct `HighAvailabilityValidationEstimation`
    info	[Changelog] - New struct `ImportFromStorageResponseType`
    info	[Changelog] - New struct `ImportSourceProperties`
    info	[Changelog] - New struct `Maintenance`
    info	[Changelog] - New struct `MaintenanceListResult`
    info	[Changelog] - New struct `MaintenanceProperties`
    info	[Changelog] - New struct `MaintenancePropertiesForUpdate`
    info	[Changelog] - New struct `MaintenanceUpdate`
    info	[Changelog] - New struct `MySQLServerIdentity`
    info	[Changelog] - New struct `MySQLServerSKU`
    info	[Changelog] - New struct `OperationProgressResult`
    info	[Changelog] - New struct `OperationStatusExtendedResult`
    info	[Changelog] - New struct `OperationStatusResult`
    info	[Changelog] - New struct `PrivateEndpoint`
    info	[Changelog] - New struct `PrivateEndpointConnection`
    info	[Changelog] - New struct `PrivateEndpointConnectionProperties`
    info	[Changelog] - New struct `PrivateLinkServiceConnectionState`
    info	[Changelog] - New struct `Provisioning`
    info	[Changelog] - New struct `ProvisioningStateProperties`
    info	[Changelog] - New struct `SKUCapabilityV2`
    info	[Changelog] - New struct `ServerBackupPropertiesV2`
    info	[Changelog] - New struct `ServerBackupV2`
    info	[Changelog] - New struct `ServerBackupV2ListResult`
    info	[Changelog] - New struct `ServerEditionCapabilityV2`
    info	[Changelog] - New struct `ServerVersionCapabilityV2`
    info	[Changelog] - New field `BackupIntervalHours` in struct `Backup`
    info	[Changelog] - New field `SystemData` in struct `BackupAndExportResponse`
    info	[Changelog] - New field `Error` in struct `ErrorResponse`
    info	[Changelog] - New field `SystemData` in struct `ProxyResource`
    info	[Changelog] - New field `SystemData` in struct `Resource`
    info	[Changelog] - New field `ImportSourceProperties`, `PrivateEndpointConnections` in struct `ServerProperties`
    info	[Changelog] - New field `Network` in struct `ServerPropertiesForUpdate`
    info	[Changelog] - New field `MaxBackupIntervalHours`, `MinBackupIntervalHours` in struct `StorageEditionCapability`
    info	[Changelog] - New field `SystemData` in struct `TrackedResource`
    info	[Changelog]
    info	[Changelog] Total 10 breaking change(s), 169 additive change(s).
️⚠️ azure-sdk-for-js warning [Detail]
  • ⚠️Warning [Logs] Generate from 26ab9d53faf09651bff58cf9e5b455d7ebd60ffc. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    warn	No file changes detected after generation
    warn	No package detected after generation
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs] Generate from 26ab9d53faf09651bff58cf9e5b455d7ebd60ffc. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh]  notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.2.3 -> 10.4.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️️✔️ azure-powershell succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 26ab9d53faf09651bff58cf9e5b455d7ebd60ffc. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ️✔️Az.mysql.DefaultTag [View full logs]  [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/mysql/armmysql There is no API change compared with the previous version
Go sdk/resourcemanager/mysql/armmysqlflexibleservers https://apiview.dev/Assemblies/Review/002d4025b23b4299a8d5ac660d16826d?revisionId=9c2a6d7f366c42e2b2020446c2414db4
Java azure-resourcemanager-mysqlflexibleserver https://apiview.dev/Assemblies/Review/8dd7313daf5c47d38f304b7fbef01335?revisionId=a96f8a5ac71b4031af474b5e9df13cc7
.Net Azure.ResourceManager.MySql https://apiview.dev/Assemblies/Review/b80a2697e0fb4ff9b9c79951b0360c75?revisionId=32466a8b11214338b867a73bbf5bb0fb
Swagger Microsoft.DBforMySQL https://apiview.dev/Assemblies/Review/0e6b5a22d4bd461b959309d41fc1634e?revisionId=28f9631a68d043daa65d82fbeb1006c6

Hi @xiaoxuqi-ms! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.

Hi Reviewer, This pr is to release a new version 2023-12-01-preview for MICROSOFT.DBFORMYSQL based on the changes in private repo, these changes have been approved in private repo and our backend is implemented upon ARM approval: https://github.com/Azure/azure-rest-api-specs-pr/pull/16642 https://github.com/Azure/azure-rest-api-specs-pr/pull/16088 https://github.com/Azure/azure-rest-api-specs-pr/pull/16454 https://github.com/Azure/azure-rest-api-specs-pr/pull/16358 https://github.com/Azure/azure-rest-api-specs-pr/pull/16018 https://github.com/Azure/azure-rest-api-specs-pr/pull/15825 https://github.com/Azure/azure-rest-api-specs-pr/pull/14608 https://github.com/Azure/azure-rest-api-specs-pr/pull/15947

Please kindly help to approve these changes in public repo so that we can release these features after deployment in prod.

xiaoxuqi-ms avatar Jan 09 '24 09:01 xiaoxuqi-ms

Avocado error is expected as we support both single server and flex server. And the multiple tag is as it always is, not introduced by this pr.

xiaoxuqi-ms avatar Jan 09 '24 09:01 xiaoxuqi-ms

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

@xiaoxuqi-ms - I've signed off for ARM with comments. Please take a look.

mentat9 avatar Jan 13 '24 01:01 mentat9

/pr RequestMerge

xiaoxuqi-ms avatar Jan 31 '24 02:01 xiaoxuqi-ms

/azp run

visingla-ms avatar Feb 01 '24 16:02 visingla-ms

Azure Pipelines successfully started running 4 pipeline(s).

azure-pipelines[bot] avatar Feb 01 '24 16:02 azure-pipelines[bot]