Azure
Review request for Microsoft.RecoveryServices to add version stable/2024-01-01
ARM (Control Plane) API Specification Update Pull Request
Tip: overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
- If this PR is in purview of ARM review then automation will add the
ARMReviewlabel. - If you want to force ARM review, add the label yourself.
- Proceed according to the diagram at the top of this comment.
Click here to see the diagram footnotes
Diagram footnotes
[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see Getting help section below.
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
- [x] New API version. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
- [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
- [ ] Update existing version to fix swagger quality issues in S360.
- [ ] Other, please clarify:
- edit this with your clarification
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:
- [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
- [x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the Swagger-Suppression-Process to get approval.
Getting help
- First, please carefully read through this PR description, from top to bottom. Please fill out the
Purpose of this PRandDue diligence checklist. - To understand what you must do next to merge this PR, see the
Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state. - For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
- If the PR CI checks appear to be stuck in
queuedstate, please add a comment with contents/azp run. This should result in a new comment denoting aPR validation pipelinehas started and the checks should be updated after few minutes. - If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
Next Steps to Merge
✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️Breaking Change(Cross-Version): 9 Warnings warning [Detail]
| Compared specs (v0.10.5) | new version | base version |
|---|---|---|
| service.json | 2024-01-01(3b19762) | 2023-08-01(main) |
The following breaking changes are detected by comparison with the latest stable version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄LintDiff inProgress [Detail]
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 8e1a3603b9bac871e77b4ececd9d30292d2fff8e. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️Azure.ResourceManager.RecoveryServicesSiteRecovery [View full logs] [Preview SDK Changes]info [Changelog]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from 8e1a3603b9bac871e77b4ececd9d30292d2fff8e. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools' cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-recoveryservicessiterecovery [View full logs] [Preview SDK Changes]- azure_mgmt_recoveryservicessiterecovery-1.0.0b1-py3-none-any.whl
- azure-mgmt-recoveryservicessiterecovery-1.0.0b1.zip
info [Changelog] ### Features Added info [Changelog] info [Changelog] - Model HyperVReplicaAzureDiskInputDetails has a new parameter sector_size_in_bytes info [Changelog] - Model HyperVReplicaAzureEnableProtectionInput has a new parameter target_vm_security_profile info [Changelog] - Model HyperVReplicaAzureEnableProtectionInput has a new parameter user_selected_os_name info [Changelog] - Model HyperVReplicaAzureManagedDiskDetails has a new parameter sector_size_in_bytes info [Changelog] - Model HyperVReplicaAzureManagedDiskDetails has a new parameter target_disk_account_type info [Changelog] - Model HyperVReplicaAzureReplicationDetails has a new parameter target_vm_security_profile info [Changelog] - Model InMageRcmDiskInput has a new parameter sector_size_in_bytes info [Changelog] - Model InMageRcmDisksDefaultInput has a new parameter sector_size_in_bytes info [Changelog] - Model InMageRcmEnableProtectionInput has a new parameter seed_managed_disk_tags info [Changelog] - Model InMageRcmEnableProtectionInput has a new parameter sql_server_license_type info [Changelog] - Model InMageRcmEnableProtectionInput has a new parameter target_managed_disk_tags info [Changelog] - Model InMageRcmEnableProtectionInput has a new parameter target_nic_tags info [Changelog] - Model InMageRcmEnableProtectionInput has a new parameter target_vm_security_profile info [Changelog] - Model InMageRcmEnableProtectionInput has a new parameter target_vm_tags info [Changelog] - Model InMageRcmEnableProtectionInput has a new parameter user_selected_os_name info [Changelog] - Model InMageRcmProtectedDiskDetails has a new parameter custom_target_disk_name info [Changelog] - Model InMageRcmProtectedDiskDetails has a new parameter disk_state info [Changelog] - Model InMageRcmProtectedDiskDetails has a new parameter sector_size_in_bytes info [Changelog] - Model InMageRcmReplicationDetails has a new parameter os_name info [Changelog] - Model InMageRcmReplicationDetails has a new parameter seed_managed_disk_tags info [Changelog] - Model InMageRcmReplicationDetails has a new parameter sql_server_license_type info [Changelog] - Model InMageRcmReplicationDetails has a new parameter supported_os_versions info [Changelog] - Model InMageRcmReplicationDetails has a new parameter target_managed_disk_tags info [Changelog] - Model InMageRcmReplicationDetails has a new parameter target_nic_tags info [Changelog] - Model InMageRcmReplicationDetails has a new parameter target_vm_security_profile info [Changelog] - Model InMageRcmReplicationDetails has a new parameter target_vm_tags info [Changelog] - Model InMageRcmReplicationDetails has a new parameter unprotected_disks info [Changelog] - Model InMageRcmUpdateReplicationProtectedItemInput has a new parameter sql_server_license_type info [Changelog] - Model InMageRcmUpdateReplicationProtectedItemInput has a new parameter target_managed_disk_tags info [Changelog] - Model InMageRcmUpdateReplicationProtectedItemInput has a new parameter target_nic_tags info [Changelog] - Model InMageRcmUpdateReplicationProtectedItemInput has a new parameter target_vm_tags info [Changelog] - Model OSDetails has a new parameter user_selected_os_name info [Changelog] - Model VMwareCbtDiskInput has a new parameter sector_size_in_bytes info [Changelog] - Model VMwareCbtEnableMigrationInput has a new parameter linux_license_type info [Changelog] - Model VMwareCbtEnableMigrationInput has a new parameter user_selected_os_name info [Changelog] - Model VMwareCbtMigrateInput has a new parameter post_migration_steps info [Changelog] - Model VMwareCbtMigrationDetails has a new parameter linux_license_type info [Changelog] - Model VMwareCbtProtectedDiskDetails has a new parameter sector_size_in_bytes info [Changelog] - Model VMwareCbtTestMigrateInput has a new parameter post_migration_steps info [Changelog] - Model VMwareCbtUpdateMigrationItemInput has a new parameter linux_license_type
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs] Generate from 8e1a3603b9bac871e77b4ececd9d30292d2fff8e. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0 cmderr [init.sh] [notice] To update, run: pip install --upgrade pip cmderr [init.sh] Average Speed Time Time Time Current cmderr [init.sh] Dload Upload Total Spent Left Speed cmderr [init.sh] 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 09475 cmderr [init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz... cmderr [init.sh] Computing checksum with sha256sum cmderr [init.sh] Checksums matched! command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-recoveryservicessiterecovery [View full logs] [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 8e1a3603b9bac871e77b4ececd9d30292d2fff8e. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery [View full logs] [Preview SDK Changes]info [Changelog] ### Features Added info [Changelog] info [Changelog] - New value `DiskAccountTypePremiumV2LRS`, `DiskAccountTypePremiumZRS`, `DiskAccountTypeStandardSSDZRS`, `DiskAccountTypeUltraSSDLRS` added to enum type `DiskAccountType` info [Changelog] - New enum type `DiskState` with values `DiskStateInitialReplicationFailed`, `DiskStateInitialReplicationPending`, `DiskStateProtected`, `DiskStateUnavailable` info [Changelog] - New enum type `LinuxLicenseType` with values `LinuxLicenseTypeLinuxServer`, `LinuxLicenseTypeNoLicenseType`, `LinuxLicenseTypeNotSpecified` info [Changelog] - New enum type `SecurityConfiguration` with values `SecurityConfigurationDisabled`, `SecurityConfigurationEnabled` info [Changelog] - New function `*InMageRcmAddDisksInput.GetAddDisksProviderSpecificInput() *AddDisksProviderSpecificInput` info [Changelog] - New struct `InMageRcmAddDisksInput` info [Changelog] - New struct `InMageRcmUnProtectedDiskDetails` info [Changelog] - New struct `ManagedRunCommandScriptInput` info [Changelog] - New struct `SecurityProfileProperties` info [Changelog] - New struct `UserCreatedResourceTag` info [Changelog] - New field `SectorSizeInBytes` in struct `HyperVReplicaAzureDiskInputDetails` info [Changelog] - New field `TargetVMSecurityProfile`, `UserSelectedOSName` in struct `HyperVReplicaAzureEnableProtectionInput` info [Changelog] - New field `SectorSizeInBytes`, `TargetDiskAccountType` in struct `HyperVReplicaAzureManagedDiskDetails` info [Changelog] - New field `TargetVMSecurityProfile` in struct `HyperVReplicaAzureReplicationDetails` info [Changelog] - New field `SectorSizeInBytes` in struct `InMageRcmDiskInput` info [Changelog] - New field `SectorSizeInBytes` in struct `InMageRcmDisksDefaultInput` info [Changelog] - New field `SQLServerLicenseType`, `SeedManagedDiskTags`, `TargetManagedDiskTags`, `TargetNicTags`, `TargetVMSecurityProfile`, `TargetVMTags`, `UserSelectedOSName` in struct `InMageRcmEnableProtectionInput` info [Changelog] - New field `CustomTargetDiskName`, `DiskState`, `SectorSizeInBytes` in struct `InMageRcmProtectedDiskDetails` info [Changelog] - New field `OSName`, `SQLServerLicenseType`, `SeedManagedDiskTags`, `SupportedOSVersions`, `TargetManagedDiskTags`, `TargetNicTags`, `TargetVMSecurityProfile`, `TargetVMTags`, `UnprotectedDisks` in struct `InMageRcmReplicationDetails` info [Changelog] - New field `SQLServerLicenseType`, `TargetManagedDiskTags`, `TargetNicTags`, `TargetVMTags` in struct `InMageRcmUpdateReplicationProtectedItemInput` info [Changelog] - New field `UserSelectedOSName` in struct `OSDetails` info [Changelog] - New field `SectorSizeInBytes` in struct `VMwareCbtDiskInput` info [Changelog] - New field `LinuxLicenseType`, `UserSelectedOSName` in struct `VMwareCbtEnableMigrationInput` info [Changelog] - New field `PostMigrationSteps` in struct `VMwareCbtMigrateInput` info [Changelog] - New field `LinuxLicenseType` in struct `VMwareCbtMigrationDetails` info [Changelog] - New field `SectorSizeInBytes` in struct `VMwareCbtProtectedDiskDetails` info [Changelog] - New field `PostMigrationSteps` in struct `VMwareCbtTestMigrateInput` info [Changelog] - New field `LinuxLicenseType` in struct `VMwareCbtUpdateMigrationItemInput` info [Changelog] info [Changelog] Total 0 breaking change(s), 45 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 8e1a3603b9bac871e77b4ececd9d30292d2fff8e. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-recoveryservices-siterecovery [View full logs] [Preview SDK Changes]info [Changelog] **Features** info [Changelog] info [Changelog] - Added Interface InMageRcmAddDisksInput info [Changelog] - Added Interface InMageRcmUnProtectedDiskDetails info [Changelog] - Added Interface ManagedRunCommandScriptInput info [Changelog] - Added Interface SecurityProfileProperties info [Changelog] - Added Interface UserCreatedResourceTag info [Changelog] - Added Type Alias DiskState info [Changelog] - Added Type Alias LinuxLicenseType info [Changelog] - Added Type Alias SecurityConfiguration info [Changelog] - Interface HyperVReplicaAzureDiskInputDetails has a new optional parameter sectorSizeInBytes info [Changelog] - Interface HyperVReplicaAzureEnableProtectionInput has a new optional parameter targetVmSecurityProfile info [Changelog] - Interface HyperVReplicaAzureEnableProtectionInput has a new optional parameter userSelectedOSName info [Changelog] - Interface HyperVReplicaAzureManagedDiskDetails has a new optional parameter sectorSizeInBytes info [Changelog] - Interface HyperVReplicaAzureManagedDiskDetails has a new optional parameter targetDiskAccountType info [Changelog] - Interface HyperVReplicaAzureReplicationDetails has a new optional parameter targetVmSecurityProfile info [Changelog] - Interface InMageRcmDiskInput has a new optional parameter sectorSizeInBytes info [Changelog] - Interface InMageRcmDisksDefaultInput has a new optional parameter sectorSizeInBytes info [Changelog] - Interface InMageRcmEnableProtectionInput has a new optional parameter seedManagedDiskTags info [Changelog] - Interface InMageRcmEnableProtectionInput has a new optional parameter sqlServerLicenseType info [Changelog] - Interface InMageRcmEnableProtectionInput has a new optional parameter targetManagedDiskTags info [Changelog] - Interface InMageRcmEnableProtectionInput has a new optional parameter targetNicTags info [Changelog] - Interface InMageRcmEnableProtectionInput has a new optional parameter targetVmSecurityProfile info [Changelog] - Interface InMageRcmEnableProtectionInput has a new optional parameter targetVmTags info [Changelog] - Interface InMageRcmEnableProtectionInput has a new optional parameter userSelectedOSName info [Changelog] - Interface InMageRcmProtectedDiskDetails has a new optional parameter customTargetDiskName info [Changelog] - Interface InMageRcmProtectedDiskDetails has a new optional parameter diskState info [Changelog] - Interface InMageRcmProtectedDiskDetails has a new optional parameter sectorSizeInBytes info [Changelog] - Interface InMageRcmReplicationDetails has a new optional parameter osName info [Changelog] - Interface InMageRcmReplicationDetails has a new optional parameter seedManagedDiskTags info [Changelog] - Interface InMageRcmReplicationDetails has a new optional parameter sqlServerLicenseType info [Changelog] - Interface InMageRcmReplicationDetails has a new optional parameter supportedOSVersions info [Changelog] - Interface InMageRcmReplicationDetails has a new optional parameter targetManagedDiskTags info [Changelog] - Interface InMageRcmReplicationDetails has a new optional parameter targetNicTags info [Changelog] - Interface InMageRcmReplicationDetails has a new optional parameter targetVmSecurityProfile info [Changelog] - Interface InMageRcmReplicationDetails has a new optional parameter targetVmTags info [Changelog] - Interface InMageRcmReplicationDetails has a new optional parameter unprotectedDisks info [Changelog] - Interface InMageRcmUpdateReplicationProtectedItemInput has a new optional parameter sqlServerLicenseType info [Changelog] - Interface InMageRcmUpdateReplicationProtectedItemInput has a new optional parameter targetManagedDiskTags info [Changelog] - Interface InMageRcmUpdateReplicationProtectedItemInput has a new optional parameter targetNicTags info [Changelog] - Interface InMageRcmUpdateReplicationProtectedItemInput has a new optional parameter targetVmTags info [Changelog] - Interface OSDetails has a new optional parameter userSelectedOSName info [Changelog] - Interface VMwareCbtDiskInput has a new optional parameter sectorSizeInBytes info [Changelog] - Interface VMwareCbtEnableMigrationInput has a new optional parameter linuxLicenseType info [Changelog] - Interface VMwareCbtEnableMigrationInput has a new optional parameter userSelectedOSName info [Changelog] - Interface VMwareCbtMigrateInput has a new optional parameter postMigrationSteps info [Changelog] - Interface VMwareCbtMigrationDetails has a new optional parameter linuxLicenseType info [Changelog] - Interface VMwareCbtProtectedDiskDetails has a new optional parameter sectorSizeInBytes info [Changelog] - Interface VMwareCbtTestMigrateInput has a new optional parameter postMigrationSteps info [Changelog] - Interface VMwareCbtUpdateMigrationItemInput has a new optional parameter linuxLicenseType info [Changelog] - Type of parameter instanceType of interface AddDisksProviderSpecificInput is changed from "A2A" to "A2A" | "InMageRcm" info [Changelog] - Added Enum KnownDiskState info [Changelog] - Added Enum KnownLinuxLicenseType info [Changelog] - Added Enum KnownSecurityConfiguration info [Changelog] - Enum KnownDiskAccountType has a new value PremiumV2LRS info [Changelog] - Enum KnownDiskAccountType has a new value PremiumZRS info [Changelog] - Enum KnownDiskAccountType has a new value StandardSSDZRS info [Changelog] - Enum KnownDiskAccountType has a new value UltraSSDLRS
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from 8e1a3603b9bac871e77b4ececd9d30292d2fff8e. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] cmderr [initScript.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0 cmderr [initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0> cmderr [initScript.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [initScript.sh] npm notice warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️recoveryservicessiterecovery [View full logs] [Preview Schema Changes]
️️✔️ azure-powershell succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 8e1a3603b9bac871e77b4ececd9d30292d2fff8e. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
️✔️Az.recoveryservicessiterecovery.DefaultTag [View full logs] [Preview SDK Changes]
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Go | sdk/resourcemanager/recoveryservices/armrecoveryservicessiterecovery | https://apiview.dev/Assemblies/Review/002d4025b23b4299a8d5ac660d16826d?revisionId=2d11e67108c74f9da36488eb5930448b |
| Java | azure-resourcemanager-recoveryservicessiterecovery | https://apiview.dev/Assemblies/Review/56a0cbaa5df94d7b8fd51641094fb1f3?revisionId=86fcf6886223420fb5a3dcc157660b36 |
| .Net | Azure.ResourceManager.RecoveryServicesSiteRecovery | https://apiview.dev/Assemblies/Review/bdf0e97b155548f8b16e13b632cee53e?revisionId=4ad817b5b5c048b6954382a26ecc8c3d |
| JavaScript | @azure/arm-recoveryservices-siterecovery | https://apiview.dev/Assemblies/Review/4b2c6980393e4b0484ef43ef7741ac15?revisionId=16ea78478d044d62a96bc7db01a0fd5e |
| Swagger | Microsoft.RecoveryServices | https://apiview.dev/Assemblies/Review/87cb55db6e9f4146a1f242e528aece8b?revisionId=8c40bcaf4e8c4e3ab0f83552c6f66449 |
Hi @singhabh27! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
@singhabh27 - Please read and fill out the intake form carefully and completely.
Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.
"diskType": {
This is used in many places: consider moving it to a common definition below and $ref-ing it where it's used.
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:12296 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"targetDiskAccountType": {
Does this also take a fixed number of values? If so, it should be modeled as a string enum as well.
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:12584 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"diskType": {
Consider using a $ref to a common definition.
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:12450 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"diskType": {
Same here
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:13742 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"diskType": {
Same
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:13836 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"diskType": {
Same
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:15477 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"diskType": {
Same
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:15520 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"diskType": {
Same
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:16964 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"diskType": {
Same
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:24213 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"diskType": {
Same
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:24957 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"additionalProperties": {
Use of additionalProperties is not allowed for properties owned by the service. The only time its ok to use it is when the properties are pass thru (user defined) and not subject to any validations. Please make this an array or provide an explanation for why you need this.
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:15668 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"additionalProperties": {
Same
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:15676 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"additionalProperties": {
Same
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:15684 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"additionalProperties": {
Same
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:15692 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"additionalProperties": {
Same
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:17371 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"additionalProperties": {
Same
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:17378 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"additionalProperties": {
Same
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:17385 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"additionalProperties": {
Same
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:17392 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"additionalProperties": {
Same
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:17674 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"additionalProperties": {
Same
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:17682 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"additionalProperties": {
Same
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:17690 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"isTargetVmSecureBootEnabled": {
Recommend enum, e.g. targetVmBootType: { Default, Secure } or similar/better.
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:22534 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)
"isTargetVmTpmEnabled": {
Recommend enum e.g. targetVmTpm: { None, Present } or similar/better.
Refers to: specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2024-01-01/service.json:22538 in e245e8d. [](commit_id = e245e8d84e74624e6ec460f37ceaecc7e2e6574a, deletion_comment = False)