azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Noneumar alertsmanagement microsoft.alerts management 2024 01 01 preview

Open noneumar opened this issue 1 year ago • 7 comments

ARM (Control Plane) API Specification Update Pull Request

Tip: overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you, you must follow the breaking changes process.
IMPORTANT This applies even if:

  • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
  • You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.
Click here to see the diagram footnotes

Diagram footnotes

[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page. If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested is removed from your PR. This should cause the label WaitForARMFeedback to be added. [2] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • [x] New API version. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • [ ] Update existing version to fix swagger quality issues in S360.
  • [ ] Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

  • [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [x] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the Swagger-Suppression-Process to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run. This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

noneumar avatar Dec 31 '23 13:12 noneumar

Next Steps to Merge

✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 15 Errors, 20 Warnings failed [Detail]
compared swaggers (via Oad v0.10.5)] new version base version
AlertsManagement.json 2024-01-01-preview(3df24b0) 2019-03-01(main)
AlertsManagement.json 2024-01-01-preview(3df24b0) 2023-07-12-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Only 30 items are listed, please refer to log for more details.

Rule Message
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'api-version' removed or renamed?
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L455:3
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L374:3
1011 - AddingResponseCode The new version adds a response code 'default'.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L49:11
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L106:9
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L100:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L1294:9
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L1242:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L1299:9
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L1246:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L1326:9
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L1271:9
1023 - TypeFormatChanged The new version has a different format than the previous one.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L704:5
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L636:5
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L106:9
1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L776:5
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L707:5
1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L34:9
1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L64:9
1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L100:9
1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L194:9
1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L230:9
1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L308:9
:warning: 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L34:9
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L34:9
:warning: 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L70:9
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L64:9
:warning: 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L106:9
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L100:9
:warning: 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L200:9
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L194:9
:warning: 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L236:9
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L230:9
:warning: 1016 - ConstantStatusHasChanged The 'constant' status changed from the old version to the new.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L314:9
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L308:9
:warning: 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L90:13
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L84:13
:warning: 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L177:13
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L171:13
:warning: 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L220:13
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L214:13
:warning: 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L262:13
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L256:13
:warning: 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L298:13
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L292:13
:warning: 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L367:13
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L361:13
:warning: 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L955:11
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L872:11
:warning: 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L214:13
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L208:13
:warning: 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L256:13
Old: Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json#L250:13
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 2 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.7) new version base version
package-2023-03 package-2023-03(3df24b0) package-2023-03(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
:warning: EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L1180
:warning: EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L1185


The following errors/warnings exist before current PR submission:

Rule Message
OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.AlertsManagement/operations' does not match the ARM specification. Please standardize the schema.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L45
OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L46
XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L67
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L84
ParametersInPost newState is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L236
XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L275
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L292
XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L311
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L361
XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L419
XmsParameterLocation The parameter 'subscriptionId' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L465
:warning: GetInOperationName 'GET' operation 'Alerts_MetaData' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L68
:warning: ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L103
:warning: RequiredReadOnlySystemData The response of operation:'Alerts_GetById' is defined without 'systemData'. Consider adding the systemData to the response.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L193
:warning: UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Resolve
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L303
:warning: UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Resolve
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L408
:warning: UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Resolve
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L447
:warning: ParameterNotUsingCommonTypes Not using the common-types defined parameter 'scope'.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L457
:warning: ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L466
:warning: EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L680
:warning: EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L688
:warning: EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L696
:warning: AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L825
:warning: XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L899
:warning: EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.AlertsManagement/preview/2024-01-01-preview/AlertsManagement.json#L999
️⚠️Avocado: 1 Warnings warning [Detail]
Rule Message
:warning: MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/alertsmanagement/resource-manager/readme.md
tag: specification/alertsmanagement/resource-manager/readme.md#tag-package-2023-03
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

azure-sdk-for-go - sdk/resourcemanager/alertsmanagement/armalertsmanagement - Approved - 0.10.0
+	Function `*AlertsClient.ChangeState` parameter(s) have been changed from `(context.Context, string, AlertState, *AlertsClientChangeStateOptions)` to `(context.Context, string, string, AlertState, *AlertsClientChangeStateOptions)`
+	Function `*AlertsClient.GetByID` parameter(s) have been changed from `(context.Context, string, *AlertsClientGetByIDOptions)` to `(context.Context, string, string, *AlertsClientGetByIDOptions)`
+	Function `*AlertsClient.GetHistory` parameter(s) have been changed from `(context.Context, string, *AlertsClientGetHistoryOptions)` to `(context.Context, string, string, *AlertsClientGetHistoryOptions)`
+	Function `*AlertsClient.GetSummary` parameter(s) have been changed from `(context.Context, AlertsSummaryGroupByFields, *AlertsClientGetSummaryOptions)` to `(context.Context, string, AlertsSummaryGroupByFields, *AlertsClientGetSummaryOptions)`
+	Function `*AlertsClient.NewGetAllPager` parameter(s) have been changed from `(*AlertsClientGetAllOptions)` to `(string, *AlertsClientGetAllOptions)`
+	Type of `AlertsClientChangeStateOptions.Comment` has been changed from `*string` to `*Comments`
+	Type of `ErrorResponse.Error` has been changed from `*ErrorResponseBody` to `*ErrorDetail`
+	Type of `ErrorResponseAutoGenerated.Error` has been changed from `*ErrorResponseBodyAutoGenerated` to `*ErrorResponseBody`
+	Type of `ErrorResponseAutoGenerated2.Error` has been changed from `*ErrorResponseBodyAutoGenerated2` to `*ErrorDetailAutoGenerated`
azure-sdk-for-python-track2 - track2_azure-mgmt-alertsmanagement - Approved - 2.0.0b2
+	Model ResourceAutoGenerated no longer has parameter system_data
+	Operation AlertsOperations.change_state has a new required parameter scope
+	Operation AlertsOperations.get_all has a new required parameter scope
+	Operation AlertsOperations.get_by_id has a new required parameter scope
+	Operation AlertsOperations.get_history has a new required parameter scope
+	Operation AlertsOperations.get_summary has a new required parameter scope
️❌ azure-sdk-for-net-track2 failed [Detail]
  • Failed [Logs] Generate from fcd36f2b7e8c715bceeeb8a5419965c12b244791. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1mLine |[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m 714 | [0m         [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m     | [31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m     | [31;1mFailed to generate sdk. exit code: False[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGet-ChildItem: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1mLine |[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m 807 | [0m … rtifacts += [36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s[0m …[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m     | [31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m     | [31;1mCannot find path[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m[31;1m[36;1m     | [31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m[31;1m[36;1m[31;1m[36;1m     | [31;1mit does not exist.[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1mLine |[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m 714 | [0m         [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m     | [31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m     | [31;1mFailed to generate sdk artifact[0m
  • Azure.ResourceManager.AlertsManagement [View full logs]  [Preview SDK Changes]
    info	[Changelog]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from fcd36f2b7e8c715bceeeb8a5419965c12b244791. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New minor version of npm available! 10.2.3 -> 10.4.0
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-alertsmanagement [View full logs]  [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from fcd36f2b7e8c715bceeeb8a5419965c12b244791. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/alertsmanagement/armalertsmanagement [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Function `*AlertsClient.ChangeState` parameter(s) have been changed from `(context.Context, string, AlertState, *AlertsClientChangeStateOptions)` to `(context.Context, string, string, AlertState, *AlertsClientChangeStateOptions)`
    info	[Changelog] - Function `*AlertsClient.GetByID` parameter(s) have been changed from `(context.Context, string, *AlertsClientGetByIDOptions)` to `(context.Context, string, string, *AlertsClientGetByIDOptions)`
    info	[Changelog] - Function `*AlertsClient.GetHistory` parameter(s) have been changed from `(context.Context, string, *AlertsClientGetHistoryOptions)` to `(context.Context, string, string, *AlertsClientGetHistoryOptions)`
    info	[Changelog] - Function `*AlertsClient.GetSummary` parameter(s) have been changed from `(context.Context, AlertsSummaryGroupByFields, *AlertsClientGetSummaryOptions)` to `(context.Context, string, AlertsSummaryGroupByFields, *AlertsClientGetSummaryOptions)`
    info	[Changelog] - Function `*AlertsClient.NewGetAllPager` parameter(s) have been changed from `(*AlertsClientGetAllOptions)` to `(string, *AlertsClientGetAllOptions)`
    info	[Changelog] - Type of `AlertsClientChangeStateOptions.Comment` has been changed from `*string` to `*Comments`
    info	[Changelog] - Type of `ErrorResponse.Error` has been changed from `*ErrorResponseBody` to `*ErrorDetail`
    info	[Changelog] - Type of `ErrorResponseAutoGenerated.Error` has been changed from `*ErrorResponseBodyAutoGenerated` to `*ErrorResponseBody`
    info	[Changelog] - Type of `ErrorResponseAutoGenerated2.Error` has been changed from `*ErrorResponseBodyAutoGenerated2` to `*ErrorDetailAutoGenerated`
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `ActionTypeCorrelateAlerts` added to enum type `ActionType`
    info	[Changelog] - New value `MonitorServiceResourceHealth` added to enum type `MonitorService`
    info	[Changelog] - New enum type `MetricAlertsDisplayUnit` with values `MetricAlertsDisplayUnitBillion`, `MetricAlertsDisplayUnitBillionPerSecond`, `MetricAlertsDisplayUnitBytes`, `MetricAlertsDisplayUnitBytesPerDay`, `MetricAlertsDisplayUnitBytesPerHour`, `MetricAlertsDisplayUnitBytesPerMinute`, `MetricAlertsDisplayUnitBytesPerSecond`, `MetricAlertsDisplayUnitCount`, `MetricAlertsDisplayUnitCountPerDay`, `MetricAlertsDisplayUnitCountPerHour`, `MetricAlertsDisplayUnitCountPerMinute`, `MetricAlertsDisplayUnitCountPerSecond`, `MetricAlertsDisplayUnitDays`, `MetricAlertsDisplayUnitGigabytes`, `MetricAlertsDisplayUnitGigabytesPerSecond`, `MetricAlertsDisplayUnitHours`, `MetricAlertsDisplayUnitKilobytes`, `MetricAlertsDisplayUnitKilobytesPerSecond`, `MetricAlertsDisplayUnitMegabytes`, `MetricAlertsDisplayUnitMegabytesPerSecond`, `MetricAlertsDisplayUnitMicroSeconds`, `MetricAlertsDisplayUnitMilliSeconds`, `MetricAlertsDisplayUnitMillion`, `MetricAlertsDisplayUnitMillionPerSecond`, `MetricAlertsDisplayUnitMinutes`, `MetricAlertsDisplayUnitNone`, `MetricAlertsDisplayUnitPercentage`, `MetricAlertsDisplayUnitPetabytes`, `MetricAlertsDisplayUnitPetabytesPerSecond`, `MetricAlertsDisplayUnitSeconds`, `MetricAlertsDisplayUnitTerabytes`, `MetricAlertsDisplayUnitTerabytesPerSecond`, `MetricAlertsDisplayUnitThousand`, `MetricAlertsDisplayUnitThousandPerSecond`, `MetricAlertsDisplayUnitTrillion`, `MetricAlertsDisplayUnitTrillionPerSecond`
    info	[Changelog] - New enum type `NotificationsForCorrelatedAlerts` with values `NotificationsForCorrelatedAlertsNotifyAlways`, `NotificationsForCorrelatedAlertsSuppressAlways`
    info	[Changelog] - New enum type `Status` with values `StatusFailed`, `StatusSucceeded`
    info	[Changelog] - New enum type `Type` with values `TypePrometheusInstantQuery`, `TypePrometheusRangeQuery`
    info	[Changelog] - New function `*AlertEnrichmentItem.GetAlertEnrichmentItem() *AlertEnrichmentItem`
    info	[Changelog] - New function `NewAlertRuleRecommendationsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AlertRuleRecommendationsClient, error)`
    info	[Changelog] - New function `*AlertRuleRecommendationsClient.NewListByResourcePager(string, *AlertRuleRecommendationsClientListByResourceOptions) *runtime.Pager[AlertRuleRecommendationsClientListByResourceResponse]`
    info	[Changelog] - New function `*AlertRuleRecommendationsClient.NewListByTargetTypePager(string, *AlertRuleRecommendationsClientListByTargetTypeOptions) *runtime.Pager[AlertRuleRecommendationsClientListByTargetTypeResponse]`
    info	[Changelog] - New function `*AlertsClient.GetEnrichments(context.Context, string, string, *AlertsClientGetEnrichmentsOptions) (AlertsClientGetEnrichmentsResponse, error)`
    info	[Changelog] - New function `*AlertsClient.NewListEnrichmentsPager(string, string, *AlertsClientListEnrichmentsOptions) *runtime.Pager[AlertsClientListEnrichmentsResponse]`
    info	[Changelog] - New function `*ClientFactory.NewAlertRuleRecommendationsClient() *AlertRuleRecommendationsClient`
    info	[Changelog] - New function `*ClientFactory.NewPrometheusRuleGroupsClient() *PrometheusRuleGroupsClient`
    info	[Changelog] - New function `*CorrelateAlerts.GetAction() *Action`
    info	[Changelog] - New function `*PrometheusEnrichmentItem.GetAlertEnrichmentItem() *AlertEnrichmentItem`
    info	[Changelog] - New function `*PrometheusEnrichmentItem.GetPrometheusEnrichmentItem() *PrometheusEnrichmentItem`
    info	[Changelog] - New function `*PrometheusInstantQuery.GetAlertEnrichmentItem() *AlertEnrichmentItem`
    info	[Changelog] - New function `*PrometheusInstantQuery.GetPrometheusEnrichmentItem() *PrometheusEnrichmentItem`
    info	[Changelog] - New function `*PrometheusRangeQuery.GetAlertEnrichmentItem() *AlertEnrichmentItem`
    info	[Changelog] - New function `*PrometheusRangeQuery.GetPrometheusEnrichmentItem() *PrometheusEnrichmentItem`
    info	[Changelog] - New function `NewPrometheusRuleGroupsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PrometheusRuleGroupsClient, error)`
    info	[Changelog] - New function `*PrometheusRuleGroupsClient.CreateOrUpdate(context.Context, string, string, PrometheusRuleGroupResource, *PrometheusRuleGroupsClientCreateOrUpdateOptions) (PrometheusRuleGroupsClientCreateOrUpdateResponse, error)`
    info	[Changelog] - New function `*PrometheusRuleGroupsClient.Delete(context.Context, string, string, *PrometheusRuleGroupsClientDeleteOptions) (PrometheusRuleGroupsClientDeleteResponse, error)`
    info	[Changelog] - New function `*PrometheusRuleGroupsClient.Get(context.Context, string, string, *PrometheusRuleGroupsClientGetOptions) (PrometheusRuleGroupsClientGetResponse, error)`
    info	[Changelog] - New function `*PrometheusRuleGroupsClient.NewListByResourceGroupPager(string, *PrometheusRuleGroupsClientListByResourceGroupOptions) *runtime.Pager[PrometheusRuleGroupsClientListByResourceGroupResponse]`
    info	[Changelog] - New function `*PrometheusRuleGroupsClient.NewListBySubscriptionPager(*PrometheusRuleGroupsClientListBySubscriptionOptions) *runtime.Pager[PrometheusRuleGroupsClientListBySubscriptionResponse]`
    info	[Changelog] - New function `*PrometheusRuleGroupsClient.Update(context.Context, string, string, PrometheusRuleGroupResourcePatchParameters, *PrometheusRuleGroupsClientUpdateOptions) (PrometheusRuleGroupsClientUpdateResponse, error)`
    info	[Changelog] - New struct `AlertEnrichmentProperties`
    info	[Changelog] - New struct `AlertEnrichmentResponse`
    info	[Changelog] - New struct `AlertEnrichmentsList`
    info	[Changelog] - New struct `AlertRuleRecommendationProperties`
    info	[Changelog] - New struct `AlertRuleRecommendationResource`
    info	[Changelog] - New struct `AlertRuleRecommendationsListResponse`
    info	[Changelog] - New struct `Comments`
    info	[Changelog] - New struct `CorrelateAlerts`
    info	[Changelog] - New struct `CorrelateBy`
    info	[Changelog] - New struct `CorrelationDetails`
    info	[Changelog] - New struct `ErrorAdditionalInfo`
    info	[Changelog] - New struct `ErrorDetail`
    info	[Changelog] - New struct `ErrorDetailAutoGenerated`
    info	[Changelog] - New struct `ErrorResponseAutoGenerated3`
    info	[Changelog] - New struct `ErrorResponseAutoGenerated4`
    info	[Changelog] - New struct `PrometheusInstantQuery`
    info	[Changelog] - New struct `PrometheusRangeQuery`
    info	[Changelog] - New struct `PrometheusRule`
    info	[Changelog] - New struct `PrometheusRuleGroupAction`
    info	[Changelog] - New struct `PrometheusRuleGroupProperties`
    info	[Changelog] - New struct `PrometheusRuleGroupResource`
    info	[Changelog] - New struct `PrometheusRuleGroupResourceCollection`
    info	[Changelog] - New struct `PrometheusRuleGroupResourcePatchParameters`
    info	[Changelog] - New struct `PrometheusRuleGroupResourcePatchParametersProperties`
    info	[Changelog] - New struct `PrometheusRuleResolveConfiguration`
    info	[Changelog] - New struct `ProxyResource`
    info	[Changelog] - New struct `ResourceAutoGenerated`
    info	[Changelog] - New struct `ResourceAutoGenerated2`
    info	[Changelog] - New struct `RuleArmTemplate`
    info	[Changelog] - New struct `TrackedResource`
    info	[Changelog] - New field `CorrelationDetails`, `HasEnrichments`, `IsStatefulAlert` in struct `Essentials`
    info	[Changelog] - New field `SystemData` in struct `Resource`
    info	[Changelog]
    info	[Changelog] Total 9 breaking change(s), 134 additive change(s).
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs] Generate from fcd36f2b7e8c715bceeeb8a5419965c12b244791. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh]  notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.2.3 -> 10.4.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.4.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    warn	No file changes detected after generation
  • ️✔️alertsmanagement [View full logs
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning [Logs] Generate from fcd36f2b7e8c715bceeeb8a5419965c12b244791. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.alertsmanagement.DefaultTag [View full logs]  [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Hi @noneumar! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.

Breaking changes previously reviewed and approved in #25472

mikekistler avatar Jan 02 '24 13:01 mikekistler

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

/pr RequestMerge

noneumar avatar Feb 29 '24 07:02 noneumar