Azure
Azure Deployment Manager is being decommissioned. Deleting the Rest API Specs related to ADM
Azure Deployment Manager is being decommissioned. Deleting the Rest API Specs related to ADM
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
- If this PR is in purview of ARM review then automation will add the
ARMReviewlabel. - If you want to force ARM review, add the label yourself.
- Proceed according to the diagram at the top of this comment.
Click here to see the diagram footnotes
Diagram footnotes
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see Getting help section below.
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
- [ ] New API version. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
- [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
- [ ] Update existing version to fix swagger quality issues in S360.
- [x] Other, please clarify:
- To remove a deprecated RP's module.
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:
- [x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
- [x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the Swagger-Suppression-Process to get approval.
Getting help
- For general PR approval workflow, see the diagram at the top of this comment.
- For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
- If the PR CI checks appear to be stuck in
queuedstate, please add a comment with contents/azp run. This should result in a new comment denoting aPR validation pipelinehas started and the checks should be updated after few minutes. - If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
Next Steps to Merge
✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️❌BreakingChange: 76 Errors, 0 Warnings failed [Detail]
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| deploymentmanager.json | 2018-09-01-preview(8f27190) | 2018-09-01-preview(main) |
| deploymentmanager.json | 2019-11-01-preview(8f27190) | 2019-11-01-preview(main) |
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/serviceTopologies/{serviceTopologyName}' removed or restructured? Old: Microsoft.DeploymentManager/preview/2018-09-01-preview/deploymentmanager.json#L26:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/serviceTopologies/{serviceTopologyName}/services/{serviceName}' removed or restructured? Old: Microsoft.DeploymentManager/preview/2018-09-01-preview/deploymentmanager.json#L163:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/serviceTopologies/{serviceTopologyName}/services/{serviceName}/serviceUnits/{serviceUnitName}' removed or restructured? Old: Microsoft.DeploymentManager/preview/2018-09-01-preview/deploymentmanager.json#L304:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/steps/{stepName}' removed or restructured? Old: Microsoft.DeploymentManager/preview/2018-09-01-preview/deploymentmanager.json#L464:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/rollouts/{rolloutName}' removed or restructured? Old: Microsoft.DeploymentManager/preview/2018-09-01-preview/deploymentmanager.json#L595:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/rollouts/{rolloutName}/cancel' removed or restructured? Old: Microsoft.DeploymentManager/preview/2018-09-01-preview/deploymentmanager.json#L737:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/rollouts/{rolloutName}/restart' removed or restructured? Old: Microsoft.DeploymentManager/preview/2018-09-01-preview/deploymentmanager.json#L780:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/artifactSources/{artifactSourceName}' removed or restructured? Old: Microsoft.DeploymentManager/preview/2018-09-01-preview/deploymentmanager.json#L830:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DeploymentManager/operations' removed or restructured? Old: Microsoft.DeploymentManager/preview/2018-09-01-preview/deploymentmanager.json#L964:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/serviceTopologies/{serviceTopologyName}' removed or restructured? Old: Microsoft.DeploymentManager/preview/2019-11-01-preview/deploymentmanager.json#L26:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/serviceTopologies' removed or restructured? Old: Microsoft.DeploymentManager/preview/2019-11-01-preview/deploymentmanager.json#L161:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/serviceTopologies/{serviceTopologyName}/services/{serviceName}' removed or restructured? Old: Microsoft.DeploymentManager/preview/2019-11-01-preview/deploymentmanager.json#L200:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/serviceTopologies/{serviceTopologyName}/services' removed or restructured? Old: Microsoft.DeploymentManager/preview/2019-11-01-preview/deploymentmanager.json#L341:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/serviceTopologies/{serviceTopologyName}/services/{serviceName}/serviceUnits/{serviceUnitName}' removed or restructured? Old: Microsoft.DeploymentManager/preview/2019-11-01-preview/deploymentmanager.json#L383:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/serviceTopologies/{serviceTopologyName}/services/{serviceName}/serviceUnits' removed or restructured? Old: Microsoft.DeploymentManager/preview/2019-11-01-preview/deploymentmanager.json#L543:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/steps/{stepName}' removed or restructured? Old: Microsoft.DeploymentManager/preview/2019-11-01-preview/deploymentmanager.json#L588:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/steps' removed or restructured? Old: Microsoft.DeploymentManager/preview/2019-11-01-preview/deploymentmanager.json#L722:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/rollouts/{rolloutName}' removed or restructured? Old: Microsoft.DeploymentManager/preview/2019-11-01-preview/deploymentmanager.json#L761:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/rollouts/{rolloutName}/cancel' removed or restructured? Old: Microsoft.DeploymentManager/preview/2019-11-01-preview/deploymentmanager.json#L903:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/rollouts/{rolloutName}/restart' removed or restructured? Old: Microsoft.DeploymentManager/preview/2019-11-01-preview/deploymentmanager.json#L946:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/rollouts' removed or restructured? Old: Microsoft.DeploymentManager/preview/2019-11-01-preview/deploymentmanager.json#L996:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/artifactSources/{artifactSourceName}' removed or restructured? Old: Microsoft.DeploymentManager/preview/2019-11-01-preview/deploymentmanager.json#L1035:5 |
|
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DeploymentManager/artifactSources' removed or restructured? Old: Microsoft.DeploymentManager/preview/2019-11-01-preview/deploymentmanager.json#L1169:5 |
|
The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.DeploymentManager/operations' removed or restructured? Old: Microsoft.DeploymentManager/preview/2019-11-01-preview/deploymentmanager.json#L1208:5 |
|
The new version is missing a definition that was found in the old version. Was 'Identity' removed or renamed? New: Microsoft.DeploymentManager/preview/2018-09-01-preview/deploymentmanager.json#L26:3 Old: Microsoft.DeploymentManager/preview/2018-09-01-preview/deploymentmanager.json#L1001:3 |
|
The new version is missing a definition that was found in the old version. Was 'RolloutRequest' removed or renamed? New: Microsoft.DeploymentManager/preview/2018-09-01-preview/deploymentmanager.json#L26:3 Old: Microsoft.DeploymentManager/preview/2018-09-01-preview/deploymentmanager.json#L1001:3 |
|
The new version is missing a definition that was found in the old version. Was 'RolloutRequestProperties' removed or renamed? New: Microsoft.DeploymentManager/preview/2018-09-01-preview/deploymentmanager.json#L26:3 Old: Microsoft.DeploymentManager/preview/2018-09-01-preview/deploymentmanager.json#L1001:3 |
|
The new version is missing a definition that was found in the old version. Was 'ArtifactSource' removed or renamed? New: Microsoft.DeploymentManager/preview/2018-09-01-preview/deploymentmanager.json#L26:3 Old: Microsoft.DeploymentManager/preview/2018-09-01-preview/deploymentmanager.json#L1001:3 |
|
The new version is missing a definition that was found in the old version. Was 'SasAuthentication' removed or renamed? New: Microsoft.DeploymentManager/preview/2018-09-01-preview/deploymentmanager.json#L26:3 Old: Microsoft.DeploymentManager/preview/2018-09-01-preview/deploymentmanager.json#L1001:3 |
|
The new version is missing a definition that was found in the old version. Was 'SasProperties' removed or renamed? New: Microsoft.DeploymentManager/preview/2018-09-01-preview/deploymentmanager.json#L26:3 Old: Microsoft.DeploymentManager/preview/2018-09-01-preview/deploymentmanager.json#L1001:3 |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
| compared tags (via openapi-validator v2.1.6) | new version | base version |
|---|---|---|
| default | default(8f27190) | default(main) |
️❌Avocado: 5 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: resource-manager/Microsoft.DeploymentManager/preview/2018-09-01-preview |
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: Microsoft.DeploymentManager/preview/2018-09-01-preview/examples |
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: resource-manager/Microsoft.DeploymentManager/preview/2019-11-01-preview |
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: Microsoft.DeploymentManager/preview/2019-11-01-preview/examples |
|
Can not find readme.md in the folder. If no readme.md file, it will block SDK generation. folder: 8f27190a08a58211c12bcd091ce20cae475d8993/specification/deploymentmanager/resource-manager |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]
Breaking Changes Tracking
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.
Commenter does not have sufficient privileges for PR 26818 in repo Azure/azure-rest-api-specs
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
The labels, like ARMReview, were not added because of a known bug:
- https://github.com/Azure/azure-sdk-tools/issues/6672
Youll need to delete this after the manifest has been completely decommissioned. It does not looks like this has even rolled out yet right : https://armmanifest.visualstudio.com/One/_git/Manifest/commit/ed061903251b1866fddf4fe0ac1107793df74bca?refName=refs%2Fheads%2Fmaster&path=%2FMICROSOFT.DEPLOYMENTMANAGER%2FPROD%2FMANIFEST.JSON&_a=compare
Youll need to delete this after the manifest has been completely decommissioned. It does not looks like this has even rolled out yet right : https://armmanifest.visualstudio.com/One/_git/Manifest/commit/ed061903251b1866fddf4fe0ac1107793df74bca?refName=refs%2Fheads%2Fmaster&path=%2FMICROSOFT.DEPLOYMENTMANAGER%2FPROD%2FMANIFEST.JSON&_a=compare
The s360 swagger validator will still be checking for reads so I am not sure if we can delete this folder yet
Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
@rohantagaru I fixed the issue with README removal (#6672) hence the Summary task is now unblocked:
- https://github.com/Azure/azure-rest-api-specs/pull/26818/checks?check_run_id=20992177504
@raosuhas the manifest has been updated with "Hidden, Decommissioned". The SDP of the manifest check-in and apply also finished.
@konrad-jamrozik this PR is still blocked for merging due to the failing Avocado checks. How do we unblock ourselves here?