azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

`operationalinsights` - add 202 definition for `clusters_update`

Open ziyeqf opened this issue 2 years ago • 9 comments

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page. If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • [ ] New API version. (Such PR should have been generated with OpenAPI Hub).
  • [ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • [ ] Update existing version to fix swagger quality issues in S360.
  • [x] Other, please clarify:
    • adding missed response definition

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood and followed the instructions by checking all the boxes:

  • [ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [ ] I have reviewed following Resource Provider guidelines, including ARM resource provider contract and REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you, you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the Swagger-Suppression-Process to get approval.

Getting help

  • For general PR approval workflow, see the diagram at the top of this comment.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

fixes #26678

ziyeqf avatar Nov 13 '23 07:11 ziyeqf

Next Steps to Merge

✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Swagger Validation Report

️❌BreakingChange: 5 Errors, 0 Warnings failed [Detail]
Compared specs (v0.10.5) new version base version
Clusters.json 2020-08-01(2665e77) 2020-08-01(main)
Clusters.json 2020-10-01(2665e77) 2020-10-01(main)
Clusters.json 2021-06-01(2665e77) 2021-06-01(main)
Rule Message
1011 - AddingResponseCode The new version adds a response code '202'.
New: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L319:11
1011 - AddingResponseCode The new version adds a response code '202'.
New: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L322:11
1011 - AddingResponseCode The new version adds a response code '202'.
New: Microsoft.OperationalInsights/stable/2021-06-01/Clusters.json#L322:11
1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
New: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L274:7
Old: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L274:7
1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
New: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L277:7
Old: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L277:7
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.0) new version base version
package-2020-10-only package-2020-10-only(2665e77) package-2020-10-only(main)
package-2020-08 package-2020-08(2665e77) package-2020-08(main)
package-2020-10 package-2020-10(2665e77) package-2020-10(main)
package-2021-06 package-2021-06(2665e77) package-2021-06(main)
package-2022-02 package-2022-02(2665e77) package-2022-02(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
Location: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L37
SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
Location: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L118
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L119
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L161
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L185
PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L296
MissingTypeObject The schema 'ClusterProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L339
MissingTypeObject The schema 'ClusterPatchProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L375
MissingTypeObject The schema 'ClusterPatch' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L384
MissingTypeObject The schema 'Cluster' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L411
MissingTypeObject The schema 'ClusterListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L434
MissingTypeObject The schema 'keyVaultProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L450
MissingTypeObject The schema 'ClusterSku' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L467
MissingTypeObject The schema 'Identity' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.OperationalInsights/stable/2020-08-01/Clusters.json#L488
SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
Location: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L37
SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
Location: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L37
SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
Location: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L118
SubscriptionsAndResourceGroupCasing The path segment resourcegroups should be resourceGroups.
Location: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L118
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L119
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L119
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L161
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L161
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L185
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L185
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L215
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L215
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:type.
Location: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L303
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:type.
Location: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L303
MissingTypeObject The schema 'ClusterProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L342
MissingTypeObject The schema 'ClusterProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.OperationalInsights/stable/2020-10-01/Clusters.json#L342
️⚠️Avocado: 1 Warnings warning [Detail]
Rule Message
:warning: MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/operationalinsights/resource-manager/readme.md
tag: specification/operationalinsights/resource-manager/readme.md#tag-package-2023-09
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

azure-sdk-for-python - track2_azure-mgmt-loganalytics - 12.0.0
+	Model Table no longer has parameter is_troubleshoot_enabled
+	Model Table no longer has parameter is_troubleshooting_allowed
+	Model Table no longer has parameter last_troubleshoot_date
+	Model Workspace no longer has parameter e_tag
+	Removed operation TablesOperations.create
+	Renamed operation TablesOperations.update to TablesOperations.begin_update
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 320ecba518d2c521d5402f9f1b21ce5da126a910. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.ResourceManager.OperationalInsights [View full logs]  [Preview SDK Changes]
    info	[Changelog]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 320ecba518d2c521d5402f9f1b21ce5da126a910. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/operationalinsights/armoperationalinsights [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Type of `Cluster.Identity` has been changed from `*Identity` to `*ManagedServiceIdentity`
    info	[Changelog] - Type of `ClusterPatch.Identity` has been changed from `*Identity` to `*ManagedServiceIdentity`
    info	[Changelog] - Operation `*TablesClient.Update` has been changed to LRO, use `*TablesClient.BeginUpdate` instead.
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `CapacityFiftyThousand`, `CapacityFourHundred`, `CapacityOneHundred`, `CapacityTenThousand`, `CapacityThreeHundred`, `CapacityTwentyFiveThousand`, `CapacityTwoHundred` added to enum type `Capacity`
    info	[Changelog] - New value `CapacityReservationLevelFiftyThousand`, `CapacityReservationLevelTenThousand`, `CapacityReservationLevelTwentyFiveThousand` added to enum type `CapacityReservationLevel`
    info	[Changelog] - New value `DataSourceTypeIngestion` added to enum type `DataSourceType`
    info	[Changelog] - New value `IdentityTypeApplication`, `IdentityTypeKey`, `IdentityTypeManagedIdentity`, `IdentityTypeUser` added to enum type `IdentityType`
    info	[Changelog] - New enum type `ColumnDataTypeHintEnum` with values `ColumnDataTypeHintEnumArmPath`, `ColumnDataTypeHintEnumGUID`, `ColumnDataTypeHintEnumIP`, `ColumnDataTypeHintEnumURI`
    info	[Changelog] - New enum type `ColumnTypeEnum` with values `ColumnTypeEnumBoolean`, `ColumnTypeEnumDateTime`, `ColumnTypeEnumDynamic`, `ColumnTypeEnumGUID`, `ColumnTypeEnumInt`, `ColumnTypeEnumLong`, `ColumnTypeEnumReal`, `ColumnTypeEnumString`
    info	[Changelog] - New enum type `CreatedByType` with values `CreatedByTypeApplication`, `CreatedByTypeKey`, `CreatedByTypeManagedIdentity`, `CreatedByTypeUser`
    info	[Changelog] - New enum type `ManagedServiceIdentityType` with values `ManagedServiceIdentityTypeNone`, `ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned`, `ManagedServiceIdentityTypeUserAssigned`
    info	[Changelog] - New enum type `ProvisioningStateEnum` with values `ProvisioningStateEnumDeleting`, `ProvisioningStateEnumInProgress`, `ProvisioningStateEnumSucceeded`, `ProvisioningStateEnumUpdating`
    info	[Changelog] - New enum type `SourceEnum` with values `SourceEnumCustomer`, `SourceEnumMicrosoft`
    info	[Changelog] - New enum type `TablePlanEnum` with values `TablePlanEnumAnalytics`, `TablePlanEnumBasic`
    info	[Changelog] - New enum type `TableSubTypeEnum` with values `TableSubTypeEnumAny`, `TableSubTypeEnumClassic`, `TableSubTypeEnumDataCollectionRuleBased`
    info	[Changelog] - New enum type `TableTypeEnum` with values `TableTypeEnumCustomLog`, `TableTypeEnumMicrosoft`, `TableTypeEnumRestoredLogs`, `TableTypeEnumSearchResults`
    info	[Changelog] - New function `*ClientFactory.NewQueriesClient() *QueriesClient`
    info	[Changelog] - New function `*ClientFactory.NewQueryPacksClient() *QueryPacksClient`
    info	[Changelog] - New function `NewQueriesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*QueriesClient, error)`
    info	[Changelog] - New function `*QueriesClient.Delete(context.Context, string, string, string, *QueriesClientDeleteOptions) (QueriesClientDeleteResponse, error)`
    info	[Changelog] - New function `*QueriesClient.Get(context.Context, string, string, string, *QueriesClientGetOptions) (QueriesClientGetResponse, error)`
    info	[Changelog] - New function `*QueriesClient.NewListPager(string, string, *QueriesClientListOptions) *runtime.Pager[QueriesClientListResponse]`
    info	[Changelog] - New function `*QueriesClient.Put(context.Context, string, string, string, LogAnalyticsQueryPackQuery, *QueriesClientPutOptions) (QueriesClientPutResponse, error)`
    info	[Changelog] - New function `*QueriesClient.NewSearchPager(string, string, LogAnalyticsQueryPackQuerySearchProperties, *QueriesClientSearchOptions) *runtime.Pager[QueriesClientSearchResponse]`
    info	[Changelog] - New function `*QueriesClient.Update(context.Context, string, string, string, LogAnalyticsQueryPackQuery, *QueriesClientUpdateOptions) (QueriesClientUpdateResponse, error)`
    info	[Changelog] - New function `NewQueryPacksClient(string, azcore.TokenCredential, *arm.ClientOptions) (*QueryPacksClient, error)`
    info	[Changelog] - New function `*QueryPacksClient.CreateOrUpdate(context.Context, string, string, LogAnalyticsQueryPack, *QueryPacksClientCreateOrUpdateOptions) (QueryPacksClientCreateOrUpdateResponse, error)`
    info	[Changelog] - New function `*QueryPacksClient.CreateOrUpdateWithoutName(context.Context, string, LogAnalyticsQueryPack, *QueryPacksClientCreateOrUpdateWithoutNameOptions) (QueryPacksClientCreateOrUpdateWithoutNameResponse, error)`
    info	[Changelog] - New function `*QueryPacksClient.Delete(context.Context, string, string, *QueryPacksClientDeleteOptions) (QueryPacksClientDeleteResponse, error)`
    info	[Changelog] - New function `*QueryPacksClient.Get(context.Context, string, string, *QueryPacksClientGetOptions) (QueryPacksClientGetResponse, error)`
    info	[Changelog] - New function `*QueryPacksClient.NewListByResourceGroupPager(string, *QueryPacksClientListByResourceGroupOptions) *runtime.Pager[QueryPacksClientListByResourceGroupResponse]`
    info	[Changelog] - New function `*QueryPacksClient.NewListPager(*QueryPacksClientListOptions) *runtime.Pager[QueryPacksClientListResponse]`
    info	[Changelog] - New function `*QueryPacksClient.UpdateTags(context.Context, string, string, TagsResource, *QueryPacksClientUpdateTagsOptions) (QueryPacksClientUpdateTagsResponse, error)`
    info	[Changelog] - New function `*TablesClient.CancelSearch(context.Context, string, string, string, *TablesClientCancelSearchOptions) (TablesClientCancelSearchResponse, error)`
    info	[Changelog] - New function `*TablesClient.BeginCreateOrUpdate(context.Context, string, string, string, Table, *TablesClientBeginCreateOrUpdateOptions) (*runtime.Poller[TablesClientCreateOrUpdateResponse], error)`
    info	[Changelog] - New function `*TablesClient.BeginDelete(context.Context, string, string, string, *TablesClientBeginDeleteOptions) (*runtime.Poller[TablesClientDeleteResponse], error)`
    info	[Changelog] - New function `*TablesClient.Migrate(context.Context, string, string, string, *TablesClientMigrateOptions) (TablesClientMigrateResponse, error)`
    info	[Changelog] - New struct `AzureResourceProperties`
    info	[Changelog] - New struct `Column`
    info	[Changelog] - New struct `LogAnalyticsQueryPack`
    info	[Changelog] - New struct `LogAnalyticsQueryPackListResult`
    info	[Changelog] - New struct `LogAnalyticsQueryPackProperties`
    info	[Changelog] - New struct `LogAnalyticsQueryPackQuery`
    info	[Changelog] - New struct `LogAnalyticsQueryPackQueryListResult`
    info	[Changelog] - New struct `LogAnalyticsQueryPackQueryProperties`
    info	[Changelog] - New struct `LogAnalyticsQueryPackQueryPropertiesRelated`
    info	[Changelog] - New struct `LogAnalyticsQueryPackQuerySearchProperties`
    info	[Changelog] - New struct `LogAnalyticsQueryPackQuerySearchPropertiesRelated`
    info	[Changelog] - New struct `ManagedServiceIdentity`
    info	[Changelog] - New struct `QueryPacksResource`
    info	[Changelog] - New struct `RestoredLogs`
    info	[Changelog] - New struct `ResultStatistics`
    info	[Changelog] - New struct `Schema`
    info	[Changelog] - New struct `SearchResults`
    info	[Changelog] - New struct `SystemData`
    info	[Changelog] - New struct `SystemDataAutoGenerated`
    info	[Changelog] - New struct `TagsResource`
    info	[Changelog] - New struct `UserAssignedIdentity`
    info	[Changelog] - New field `SystemData` in struct `Table`
    info	[Changelog] - New field `ArchiveRetentionInDays`, `LastPlanModifiedDate`, `Plan`, `ProvisioningState`, `RestoredLogs`, `ResultStatistics`, `RetentionInDaysAsDefault`, `Schema`, `SearchResults`, `TotalRetentionInDays`, `TotalRetentionInDaysAsDefault` in struct `TableProperties`
    info	[Changelog] - New field `Identity`, `SystemData` in struct `Workspace`
    info	[Changelog] - New field `UnifiedSentinelBillingOnly` in struct `WorkspaceFeatures`
    info	[Changelog] - New field `Identity` in struct `WorkspacePatch`
    info	[Changelog] - New field `DefaultDataCollectionRuleResourceID` in struct `WorkspaceProperties`
    info	[Changelog]
    info	[Changelog] Total 3 breaking change(s), 128 additive change(s).
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning [Logs] Generate from 320ecba518d2c521d5402f9f1b21ce5da126a910. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-loganalytics [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation TablesOperations.begin_create_or_update
    info	[Changelog]   - Added operation TablesOperations.begin_delete
    info	[Changelog]   - Added operation TablesOperations.cancel_search
    info	[Changelog]   - Added operation TablesOperations.migrate
    info	[Changelog]   - Added operation group QueriesOperations
    info	[Changelog]   - Added operation group QueryPacksOperations
    info	[Changelog]   - Model Table has a new parameter archive_retention_in_days
    info	[Changelog]   - Model Table has a new parameter last_plan_modified_date
    info	[Changelog]   - Model Table has a new parameter plan
    info	[Changelog]   - Model Table has a new parameter provisioning_state
    info	[Changelog]   - Model Table has a new parameter restored_logs
    info	[Changelog]   - Model Table has a new parameter result_statistics
    info	[Changelog]   - Model Table has a new parameter retention_in_days_as_default
    info	[Changelog]   - Model Table has a new parameter schema
    info	[Changelog]   - Model Table has a new parameter search_results
    info	[Changelog]   - Model Table has a new parameter system_data
    info	[Changelog]   - Model Table has a new parameter total_retention_in_days
    info	[Changelog]   - Model Table has a new parameter total_retention_in_days_as_default
    info	[Changelog]   - Model Workspace has a new parameter default_data_collection_rule_resource_id
    info	[Changelog]   - Model Workspace has a new parameter etag
    info	[Changelog]   - Model Workspace has a new parameter identity
    info	[Changelog]   - Model Workspace has a new parameter system_data
    info	[Changelog]   - Model WorkspaceFeatures has a new parameter unified_sentinel_billing_only
    info	[Changelog]   - Model WorkspacePatch has a new parameter default_data_collection_rule_resource_id
    info	[Changelog]   - Model WorkspacePatch has a new parameter identity
    info	[Changelog]
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog]   - Model Table no longer has parameter is_troubleshoot_enabled
    info	[Changelog]   - Model Table no longer has parameter is_troubleshooting_allowed
    info	[Changelog]   - Model Table no longer has parameter last_troubleshoot_date
    info	[Changelog]   - Model Workspace no longer has parameter e_tag
    info	[Changelog]   - Removed operation TablesOperations.create
    info	[Changelog]   - Renamed operation TablesOperations.update to TablesOperations.begin_update
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 320ecba518d2c521d5402f9f1b21ce5da126a910. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-operationalinsights [View full logs]  [Preview SDK Changes]
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from 320ecba518d2c521d5402f9f1b21ce5da126a910. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] ed % Xferd  Average Speed   Time    Time     Time  Current
    cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
    cmderr	[init.sh] 
      0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0  1110k      0 --:--:-- --:--:-- --:--:-- 1195k
    cmderr	[init.sh]  notice
    cmderr	[init.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
    cmderr	[init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
    cmderr	[init.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[init.sh] npm notice
    cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
    cmderr	[init.sh] Computing checksum with sha256sum
    cmderr	[init.sh] Checksums matched!
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-loganalytics [View full logs]  [Preview SDK Changes]
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs] Generate from 320ecba518d2c521d5402f9f1b21ce5da126a910. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    warn	No file changes detected after generation
    warn	Skip detect changed packages
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning [Logs] Generate from 320ecba518d2c521d5402f9f1b21ce5da126a910. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.operationalinsights.DefaultTag [View full logs]  [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

Could someone take a look at this PR? it's fix the swagger so it might not should be "breaking change"?

ziyeqf avatar Dec 04 '23 03:12 ziyeqf

@rkmanda, could you please review this? It would be helpful to have it merged.

wuxu92 avatar Jan 18 '24 09:01 wuxu92

@ziyeqf Can we update all versions of Clusters.json?

wuxu92 avatar Jan 24 '24 07:01 wuxu92

@ziyeqf Can we update all versions of Clusters.json?

Sure, code updated

ziyeqf avatar Jan 24 '24 08:01 ziyeqf

kindly bubble this up

ziyeqf avatar Mar 04 '24 07:03 ziyeqf

@ziyeqf , There are a bunch of breaking changes reported on this PR. Please get a breaking changes approval from Azure Breaking Changes Reviewers [email protected] and ARM can review the changes afterwards. Once you have the approval, please remove the "ARMChangesRequested" label from the PR to make the PR visible to the ARM reviewers.

ms-henglu avatar Mar 18 '24 05:03 ms-henglu

@ms-henglu I do not have the permission to remove ARMChangesRequested label, could you please help removing that? Thanks!

ziyeqf avatar Mar 19 '24 01:03 ziyeqf

@ziyeqf, please fix errors in the following links, then remove ARMChangesRequested to continue the review. https://github.com/Azure/azure-rest-api-specs/pull/26679/checks?check_run_id=22813622544 https://github.com/Azure/azure-rest-api-specs/pull/26679/checks?check_run_id=22813665009

ms-zhenhua avatar Mar 19 '24 05:03 ms-zhenhua

@ms-zhenhua could you please help changing the labels as the checks passed now?

ziyeqf avatar Mar 20 '24 07:03 ziyeqf