azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

[Draft] schemaregistry tsp

Open swathipil opened this issue 2 years ago • 10 comments

Data Plane API - Pull Request

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • [ ] a private preview
  • [ ] a public preview
  • [ ] GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc:
  • Updated paths:

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

swathipil avatar Aug 04 '23 05:08 swathipil

Swagger Validation Report

️❌BreakingChange: 129 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.10.5)] new version base version
schemaregistry.json 2022-10(70fdb12) 2022-10(main)
schemaregistry.json 2023-07-01(70fdb12) 2023-07-01(main)

Only 30 items are listed, please refer to log for more details.

Rule Message
1003 - RequestBodyFormatNoLongerSupported The new version does not support 'application/json; serialization=json' as a request body format.
New: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L101:9
Old: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L314:9
1003 - RequestBodyFormatNoLongerSupported The new version does not support 'application/json; serialization=json' as a request body format.
New: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L193:9
Old: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L402:9
1003 - RequestBodyFormatNoLongerSupported The new version does not support 'application/json; serialization=json' as a request body format.
New: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L101:9
Old: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L316:9
1003 - RequestBodyFormatNoLongerSupported The new version does not support 'application/json; serialization=json' as a request body format.
New: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L194:9
Old: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L405:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json; serialization=Json' as a response body format.
New: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L462:9
Old: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L93:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L462:9
Old: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L93:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json; serialization=Json' as a response body format.
New: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L341:9
Old: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L227:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L341:9
Old: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L227:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json; serialization=Json' as a response body format.
New: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L470:9
Old: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L93:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L470:9
Old: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L93:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json; serialization=Json' as a response body format.
New: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L343:9
Old: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L228:9
1004 - ResponseBodyFormatNowSupported The old version did not support 'application/json' as a response body format.
New: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L343:9
Old: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L228:9
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ApiVersionParameter' removed or renamed?
New: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L770:3
Old: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L574:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'Endpoint' removed or renamed?
New: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L770:3
Old: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L574:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'SchemaName' removed or renamed?
New: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L770:3
Old: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L574:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'SchemaVersion' removed or renamed?
New: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L770:3
Old: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L574:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ApiVersionParameter' removed or renamed?
New: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L789:3
Old: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L578:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'Endpoint' removed or renamed?
New: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L789:3
Old: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L578:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'SchemaName' removed or renamed?
New: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L789:3
Old: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L578:3
1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'SchemaVersion' removed or renamed?
New: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L789:3
Old: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L578:3
1008 - ModifiedOperationId The operation id has been changed from 'SchemaGroups_List' to 'ListSchemaGroups'. This will impact generated code.
New: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L57:7
Old: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L40:7
1008 - ModifiedOperationId The operation id has been changed from 'Schema_GetById' to 'GetSchemaById'. This will impact generated code.
New: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L458:7
Old: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L84:7
1008 - ModifiedOperationId The operation id has been changed from 'Schema_GetVersions' to 'ListSchemaVersions'. This will impact generated code.
New: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L281:7
Old: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L164:7
1008 - ModifiedOperationId The operation id has been changed from 'Schema_GetSchemaVersion' to 'GetSchemaByVersion'. This will impact generated code.
New: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L337:7
Old: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L218:7
1008 - ModifiedOperationId The operation id has been changed from 'Schema_QueryIdByContent' to 'GetSchemaPropertiesByContent'. This will impact generated code.
New: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L97:7
Old: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L305:7
1008 - ModifiedOperationId The operation id has been changed from 'Schema_Register' to 'RegisterSchema'. This will impact generated code.
New: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L189:7
Old: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L393:7
1008 - ModifiedOperationId The operation id has been changed from 'SchemaGroups_List' to 'ListSchemaGroups'. This will impact generated code.
New: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L57:7
Old: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L40:7
1008 - ModifiedOperationId The operation id has been changed from 'Schema_GetById' to 'GetSchemaById'. This will impact generated code.
New: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L466:7
Old: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L84:7
1008 - ModifiedOperationId The operation id has been changed from 'Schema_GetVersions' to 'ListSchemaVersions'. This will impact generated code.
New: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L283:7
Old: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L165:7
1008 - ModifiedOperationId The operation id has been changed from 'Schema_GetSchemaVersion' to 'GetSchemaByVersion'. This will impact generated code.
New: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L339:7
Old: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L219:7
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 45 Warnings warning [Detail]
compared tags (via openapi-validator v2.2.0) new version base version
package-2021-10 package-2021-10(70fdb12) package-2021-10(main)
package-2022-10 package-2022-10(70fdb12) package-2022-10(main)
package-2023-07-01 package-2023-07-01(70fdb12) package-2023-07-01(main)

[must fix]The following errors/warnings are introduced by current PR:

Only 30 items are listed, please refer to log for more details.

Rule Message Related RPC [For API reviewers]
:warning: SecurityDefinitionDescription Security definition should have a description.
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L45
:warning: ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L57
:warning: OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L58
:warning: OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L98
:warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L108
:warning: OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L188
:warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L198
:warning: OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L278
:warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L285
:warning: OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L334
:warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L345
:warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L361
:warning: PathParameterSchema Path parameter should be defined as type: string.
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L366
:warning: OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L437
:warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L448
:warning: SecurityDefinitionDescription Security definition should have a description.
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L45
:warning: ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L57
:warning: OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L58
:warning: OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L98
:warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L110
:warning: OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L190
:warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L202
:warning: OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L282
:warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L289
:warning: OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L338
:warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L351
:warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L367
:warning: PathParameterSchema Path parameter should be defined as type: string.
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L372
:warning: OperationId OperationId should be of the form 'Noun_Verb'
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L459
:warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L472


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
:warning: VersionConvention API version should be a date in YYYY-MM-DD format, optionally suffixed with '-preview'.
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L5
:warning: PathCharacters Path contains non-recommended characters.
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L56
:warning: PaginationResponse Response body schema of pageable response should contain top-level array property value
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L69
:warning: PathCharacters Path contains non-recommended characters.
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L96
:warning: PathCharacters Path contains non-recommended characters.
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L186
:warning: OperationId OperationId for put method should contain 'Create' or 'Update'
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L188
:warning: PathCharacters Path contains non-recommended characters.
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L276
:warning: ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L277
:warning: PaginationResponse Response body schema of pageable response should contain top-level array property value
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L305
:warning: PathCharacters Path contains non-recommended characters.
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L332
:warning: PathCharacters Path contains non-recommended characters.
Location: Microsoft.EventHub/stable/2021-10/schemaregistry.json#L435
:warning: VersionConvention API version should be a date in YYYY-MM-DD format, optionally suffixed with '-preview'.
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L5
:warning: PathCharacters Path contains non-recommended characters.
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L56
:warning: PaginationResponse Response body schema of pageable response should contain top-level array property value
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L69
:warning: PathCharacters Path contains non-recommended characters.
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L96
:warning: PathCharacters Path contains non-recommended characters.
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L188
:warning: OperationId OperationId for put method should contain 'Create' or 'Update'
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L190
:warning: PathCharacters Path contains non-recommended characters.
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L280
:warning: ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L281
:warning: PaginationResponse Response body schema of pageable response should contain top-level array property value
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L309
:warning: PathCharacters Path contains non-recommended characters.
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L336
:warning: PathCharacters Path contains non-recommended characters.
Location: Microsoft.EventHub/stable/2022-10/schemaregistry.json#L457
:warning: PathCharacters Path contains non-recommended characters.
Location: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L56
:warning: PaginationResponse Response body schema of pageable response should contain top-level array property value
Location: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L69
:warning: PathCharacters Path contains non-recommended characters.
Location: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L96
:warning: PathCharacters Path contains non-recommended characters.
Location: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L189
:warning: OperationId OperationId for put method should contain 'Create' or 'Update'
Location: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L191
:warning: PathCharacters Path contains non-recommended characters.
Location: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L282
:warning: ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
Location: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L283
:warning: PaginationResponse Response body schema of pageable response should contain top-level array property value
Location: Microsoft.EventHub/stable/2023-07-01/schemaregistry.json#L311
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Hi, @swathipil! Thank you for your pull request. To help get your PR merged:

  • Ensure you reviewed the checklists in the PR description.
  • Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.
  • For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
  • Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking


    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs] Generate from 9f8b1154146fe5b37e6327c3b5833bec118a4b0d. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
      cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      warn		specification/schemaregistry/data-plane/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-schemaregistry [View full logs]  [Preview SDK Changes]
      info	[Changelog] data-plan skip changelog generation temporarily
    ️❌ azure-sdk-for-java failed [Detail]
    • Failed [Logs] Generate from 9f8b1154146fe5b37e6327c3b5833bec118a4b0d. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] peed   Time    Time     Time  Current
      cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
      cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
      cmderr	[init.sh] ###################################### 100.0%
      cmderr	[init.sh] Computing checksum with sha256sum
      cmderr	[init.sh] Checksums matched!
      warn		specification/schemaregistry/data-plane/readme.md skipped due to azure-sdk-for-java not found in swagger-to-sdk
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py]
      cmderr	[generate.py] npm notice New major version of npm available! 9.5.0 -> 10.5.0
      cmderr	[generate.py] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
      cmderr	[generate.py] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[generate.py] npm notice
    • azure-data-schemaregistry [View full logs]  [Preview SDK Changes]
    ️❌ azure-sdk-for-js failed [Detail]
    • Failed [Logs] Generate from 9f8b1154146fe5b37e6327c3b5833bec118a4b0d. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      warn		specification/schemaregistry/data-plane/readme.md skipped due to azure-sdk-for-js not found in swagger-to-sdk
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
      cmderr	[automation_generate.sh] [ERROR] Error:
      cmderr	[automation_generate.sh] [ERROR] An error occurred while run build for typespec project: "specification/schemaregistry/SchemaRegistry":
      cmderr	[automation_generate.sh] [ERROR] Err: Error: Command failed: rush build -t @azure/schema-registry
      cmderr	[automation_generate.sh] [ERROR] Stderr: "null"
      cmderr	[automation_generate.sh] [ERROR] Stdout: "null"
      cmderr	[automation_generate.sh] [ERROR] ErrorStack: "Error: Command failed: rush build -t @azure/schema-registry
      cmderr	[automation_generate.sh] [ERROR]     at checkExecSyncError (node:child_process:885:11)
      cmderr	[automation_generate.sh] [ERROR]     at Object.execSync (node:child_process:957:15)
      cmderr	[automation_generate.sh] [ERROR]     at Object.<anonymous> (/home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/dist/llc/generateRLCInPipeline/generateRLCInPipeline.js:209:29)
      cmderr	[automation_generate.sh] [ERROR]     at Generator.next (<anonymous>)
      cmderr	[automation_generate.sh] [ERROR]     at fulfilled (/home/cloudtest/.nvm/versions/node/v18.15.0/lib/node_modules/@azure-tools/js-sdk-release-tools/node_modules/tslib/tslib.js:112:62)
      cmderr	[automation_generate.sh] [ERROR]     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"
    • @azure/schema-registry [View full logs]  [Preview SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs] Generate from 9f8b1154146fe5b37e6327c3b5833bec118a4b0d. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn		specification/schemaregistry/data-plane/readme.md skipped due to azure-sdk-for-net-track2 not found in swagger-to-sdk
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:131[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1mLine |[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m 131 | [0m               [36;1mGeneratePackage `[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m     | [31;1m               ~~~~~~~~~~~~~~~~~[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m     | [31;1mFailed to generate sdk. exit code: False[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGet-ChildItem: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1mLine |[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m 807 | [0m … rtifacts += [36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s[0m …[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m     | [31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m     | [31;1mCannot find path[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m[31;1m[36;1m     | [31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m[31;1m[36;1m[31;1m[36;1m     | [31;1mit does not exist.[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:131[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1mLine |[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m 131 | [0m               [36;1mGeneratePackage `[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m     | [31;1m               ~~~~~~~~~~~~~~~~~[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[0m[36;1m[36;1m[0m[36;1m[0m[36;1m[31;1m[31;1m[36;1m     | [31;1mFailed to generate sdk artifact[0m
    • Azure.Data.SchemaRegistry [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    Posted by Swagger Pipeline | How to fix these errors?

    Hi @swathipil! The automation detected this pull request introduces changes to at least one existing API version that violate Azure's versioning policy. To comply with the policy, these changes must be made in a new API version. As a result, the automation added the NewApiVersionRequired label.

    You cannot proceed with merging this PR until you complete one of the following action items:

    ACTION ITEM ALTERNATIVE A: Introduce a new API version.
    Submit a new PR instead of this one, or modify this PR, so that it adds a new API version instead of introducing changes to existing API versions.

    ACTION ITEM ALTERNATIVE B: Request approval.
    Alternatively, if you cannot avoid modifying existing API versions, then you can request an approval for them. Please follow the breaking changes process.
    This case applies even if:

    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason. Such claims must be reviewed, and the process is the same.

    Swagger Validation Report

    ️⌛BreakingChange pending [Detail]
    ️🔄Breaking Change(Cross-Version) inProgress [Detail]
    ️⌛CredScan pending [Detail]
    ️🔄LintDiff inProgress [Detail]
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️🔄SwaggerAPIView inProgress [Detail]
    ️⌛TypeSpecAPIView pending [Detail]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⌛PoliCheck pending [Detail]
    ️🔄PrettierCheck inProgress [Detail]
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️🔄Lint(RPaaS) inProgress [Detail]
    ️⌛PR Summary pending [Detail]
    ️⌛Automated merging requirements met pending [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Validation Report

    ️🔄BreakingChange inProgress [Detail]
    ️🔄Breaking Change(Cross-Version) inProgress [Detail]
    ️⌛CredScan pending [Detail]
    ️🔄LintDiff inProgress [Detail]
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️🔄SwaggerAPIView inProgress [Detail]
    ️⌛TypeSpecAPIView pending [Detail]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⌛PoliCheck pending [Detail]
    ️🔄PrettierCheck inProgress [Detail]
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️🔄Lint(RPaaS) inProgress [Detail]
    ️⌛PR Summary pending [Detail]
    ️⌛Automated merging requirements met pending [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking


    ️⌛ azure-sdk-for-python pending [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    Next Steps to Merge

    Next steps that must be taken to merge this PR:
    • ❌ Your PR has at least one breaking change from a previous GA version (label: BreakingChangeReviewRequired). See the PR description for help.
    • ❌ Your PR has at least one change violating Azure versioning policy (label: VersioningReviewRequired). You must introduce a new API version with these changes instead of modifying an existing one. See the PR description for help.
    • ❌ Your PR requires an API stewardship board review. See the PR description for help.
    • ❌ The required check named Swagger BreakingChange has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it. In addition, refer to step 1 in the PR workflow diagram (even if your PR is for data plane, not ARM).

    PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

    We also need to get CI passing on this PR. Looks like TypeSpec validation is pointing out that the tspconfig.yaml isnt extending the azure core linter ruleset. You can follow the instructions provided in CI to run this check locally and fix any issues it reports.

    catalinaperalta avatar Jan 25 '24 01:01 catalinaperalta

    /azp run

    qiaozha avatar Feb 08 '24 08:02 qiaozha

    Azure Pipelines successfully started running 4 pipeline(s).

    azure-pipelines[bot] avatar Feb 08 '24 08:02 azure-pipelines[bot]

    Per the breaking changes check, the old paths we removed, this is due to the directory update being made in this PR. The paths exist in the updated swagger.

    Likewise the removedparameters warning seems to be a false positive, the api version param, endpoint, schema version params exist on the apis.

    Reasons for failures in the SDK generations steps are in the PR description.

    catalinaperalta avatar Feb 29 '24 01:02 catalinaperalta