azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Run command managed identities parameters for blobs

Open viveklingaiah opened this issue 3 years ago • 8 comments

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?

    • [ Yes] new API version (API version 2022-08-01 for Run Command PUT APIs, adds managedIdentities inputs for blobs used in RunCommand PUT APIs). The Runcommand v2 (PUT APIs) are in Preview at the moment (as far as communication with users). We are planning to take it to GA by Oct 31, 2022.
      • Managed identities is another way to provide user's VMs and VMSSs access to storage blobs that can contain user's script that is run on VM and VMSS using Run Command PUT APIs. Users have ability to provide SAS URIs of blobs today. Managed identities are more secure.
      • No changes to GET APIs
      • I have copied the RunCommand.json spec and examples from 2022-03-01 and made changes to PUT VM Run Command and PUT VMSS VM Run Command APIs and their examples.
      • Design Doc related to this change: https://microsoft.sharepoint.com/:w:/t/ComputeVM/EWTzlVJsh3hKpmDxD0KLi1oBFsVWwP2G7tmbXggij2XaXw?e=rlItUp
    • [ Yes] update existing version for new feature
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. - Oct 31 2022

  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. Oct 01, 2022 (After we take the Run Command 2022-08-01 APIs to GA)

  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

  • SDKs need to be updated.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs - No data plane Changes
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [Yes ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new API version -[ Yes] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • [Yes ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [Yes ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

viveklingaiah avatar Sep 16 '22 22:09 viveklingaiah

Hi, @vivlingaiah Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.10.2)] new version base version
    computeRPCommon.json 2022-11-01(66e9dc6) 2022-08-01(main)
    runCommand.json 2022-11-01(66e9dc6) 2022-08-01(main)
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2022-11-01 package-2022-11-01(66e9dc6) package-2022-11-01(feature/cplat-2022-11-01)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Compute/operations' does not match the ARM specification. Please standardize the schema.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L52
    MissingTypeObject The schema 'ComputeOperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L178
    MissingTypeObject The schema 'ComputeOperationValue' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L194
    MissingTypeObject The schema 'ComputeOperationValueDisplay' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L213
    MissingTypeObject The schema 'UsageName' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L238
    MissingTypeObject The schema 'Usage' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L251
    MissingTypeObject The schema 'ListUsagesResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L287
    MissingTypeObject The schema 'SubResourceWithColocationStatus' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L355
    MissingTypeObject The schema 'VirtualMachineSize' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L368
    MissingTypeObject The schema 'VirtualMachineSizeListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L402
    MissingTypeObject The schema 'Plan' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L417
    MissingTypeObject The schema 'HardwareProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L438
    MissingTypeObject The schema 'ImageReference' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L639
    MissingTypeObject The schema 'KeyVaultSecretReference' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L690
    MissingTypeObject The schema 'KeyVaultKeyReference' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L715
    MissingTypeObject The schema 'DiskEncryptionSettings' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L732
    MissingTypeObject The schema 'VirtualHardDisk' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L771
    MissingTypeObject The schema 'DiffDiskSettings' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L869
    MissingTypeObject The schema 'ManagedDiskParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L882
    MissingTypeObject The schema 'OSDisk' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L904
    MissingTypeObject The schema 'DataDisk' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L969
    MissingTypeObject The schema 'StorageProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L1050
    MissingTypeObject The schema 'UefiSettings' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L1077
    MissingTypeObject The schema 'SecurityProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L1090
    MissingTypeObject The schema 'AdditionalCapabilities' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L1165
    MissingTypeObject The schema 'AdditionalUnattendContent' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L1178
    MissingTypeObject The schema 'WinRMListener' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L1221
    MissingTypeObject The schema 'WinRMConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L1242
    MissingTypeObject The schema 'WindowsConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L1255
    MissingTypeObject The schema 'SshPublicKey' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: ComputeRP/stable/2022-11-01/computeRPCommon.json#L1292
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    :warning: MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/compute/resource-manager/readme.md
    tag: specification/compute/resource-manager/readme.md#tag-package-2022-11-01
    ️❌ModelValidation: 4 Errors, 0 Warnings failed [Detail]
    Rule Message
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: ComputeRP/stable/2022-11-01/runCommand.json#L168:22
    ExampleUrl: 2022-11-01/examples/runCommandExamples/VirtualMachineRunCommand.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: ComputeRP/stable/2022-11-01/runCommand.json#L235:22
    ExampleUrl: 2022-11-01/examples/runCommandExamples/VirtualMachineScaleSetVMRunCommand.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: ComputeRP/stable/2022-11-01/runCommand.json#L424:22
    ExampleUrl: 2022-11-01/examples/runCommandExamples/VirtualMachineRunCommand_Delete.json
    LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
    Url: ComputeRP/stable/2022-11-01/runCommand.json#L764:22
    ExampleUrl: 2022-11-01/examples/runCommandExamples/VirtualMachineScaleSetVMRunCommand_Delete.json
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️⚠️SDK Breaking Change Tracking warning [Detail]

    Breaking Changes Tracking


    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-compute - 29.0.0
    +	Model CreationData no longer has parameter performance_plus
    +	Model Disk no longer has parameter bursting_enabled_time
    +	Model Disk no longer has parameter optimized_for_frequent_attach
    +	Model DiskUpdate no longer has parameter optimized_for_frequent_attach
    +	Model GalleryApplication no longer has parameter custom_actions
    +	Model GalleryApplicationUpdate no longer has parameter custom_actions
    +	Model GalleryApplicationVersion no longer has parameter safety_profile
    +	Model GalleryApplicationVersionPublishingProfile no longer has parameter custom_actions
    +	Model GalleryApplicationVersionUpdate no longer has parameter safety_profile
    +	Model GalleryImageVersion no longer has parameter safety_profile
    +	Model GalleryImageVersionUpdate no longer has parameter safety_profile
    +	Model SharedGalleryImage no longer has parameter eula
    +	Model SharedGalleryImage no longer has parameter privacy_statement_uri
    +	Model Snapshot no longer has parameter incremental_snapshot_family_id
    +	Model SupportedCapabilities no longer has parameter disk_controller_types
    +	Model TargetRegion no longer has parameter exclude_from_latest
    ⚠️azure-sdk-for-js - @azure/arm-compute - 20.0.0
    +	Interface GalleryArtifactVersionSource no longer has parameter uri
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs] Generate from e1aa5524dd8599a4e883516d294c73aa045efade. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [91mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:611
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [96mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [96m 611 | [0m         [96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [96m     | [91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [91m[96m     | [91mFailed to build sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
    • Azure.ResourceManager.Compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.BinaryData Azure.ResourceManager.Compute.VirtualMachineScaleSetExtensionData.ProtectedSettingsFromKeyVault.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public void Azure.ResourceManager.Compute.VirtualMachineScaleSetExtensionData.ProtectedSettingsFromKeyVault.set(System.BinaryData)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.BinaryData Azure.ResourceManager.Compute.VirtualMachineScaleSetVmExtensionData.ProtectedSettingsFromKeyVault.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public void Azure.ResourceManager.Compute.VirtualMachineScaleSetVmExtensionData.ProtectedSettingsFromKeyVault.set(System.BinaryData)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Collections.Generic.IReadOnlyList<Azure.ResourceManager.Resources.Models.SubResource> Azure.ResourceManager.Compute.Models.CapacityReservationInstanceView.UtilizationInfoVirtualMachinesAllocated.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Uri Azure.ResourceManager.Compute.Models.GalleryArtifactVersionSource.Uri.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public void Azure.ResourceManager.Compute.Models.GalleryArtifactVersionSource.Uri.set(System.Uri)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Compute.Models.GalleryArtifactVersionSource Azure.ResourceManager.Compute.Models.GalleryDiskImage.Source.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public void Azure.ResourceManager.Compute.Models.GalleryDiskImage.Source.set(Azure.ResourceManager.Compute.Models.GalleryArtifactVersionSource)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Compute.Models.GalleryArtifactVersionSource Azure.ResourceManager.Compute.Models.GalleryImageVersionStorageProfile.Source.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public void Azure.ResourceManager.Compute.Models.GalleryImageVersionStorageProfile.Source.set(Azure.ResourceManager.Compute.Models.GalleryArtifactVersionSource)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.BinaryData Azure.ResourceManager.Compute.Models.VirtualMachineExtensionPatch.ProtectedSettingsFromKeyVault.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public void Azure.ResourceManager.Compute.Models.VirtualMachineExtensionPatch.ProtectedSettingsFromKeyVault.set(System.BinaryData)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.BinaryData Azure.ResourceManager.Compute.Models.VirtualMachineScaleSetExtensionPatch.ProtectedSettingsFromKeyVault.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public void Azure.ResourceManager.Compute.Models.VirtualMachineScaleSetExtensionPatch.ProtectedSettingsFromKeyVault.set(System.BinaryData)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.BinaryData Azure.ResourceManager.Compute.Models.VirtualMachineScaleSetVmExtensionPatch.ProtectedSettingsFromKeyVault.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public void Azure.ResourceManager.Compute.Models.VirtualMachineScaleSetVmExtensionPatch.ProtectedSettingsFromKeyVault.set(System.BinaryData)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Compute/Debug/netstandard2.0/Azure.ResourceManager.Compute.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from e1aa5524dd8599a4e883516d294c73aa045efade. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.1.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model GalleryArtifactVersionSource has a new parameter uri
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model CreationData no longer has parameter performance_plus
      info	[Changelog]   - Model Disk no longer has parameter bursting_enabled_time
      info	[Changelog]   - Model Disk no longer has parameter optimized_for_frequent_attach
      info	[Changelog]   - Model DiskUpdate no longer has parameter optimized_for_frequent_attach
      info	[Changelog]   - Model GalleryApplication no longer has parameter custom_actions
      info	[Changelog]   - Model GalleryApplicationUpdate no longer has parameter custom_actions
      info	[Changelog]   - Model GalleryApplicationVersion no longer has parameter safety_profile
      info	[Changelog]   - Model GalleryApplicationVersionPublishingProfile no longer has parameter custom_actions
      info	[Changelog]   - Model GalleryApplicationVersionUpdate no longer has parameter safety_profile
      info	[Changelog]   - Model GalleryImageVersion no longer has parameter safety_profile
      info	[Changelog]   - Model GalleryImageVersionUpdate no longer has parameter safety_profile
      info	[Changelog]   - Model SharedGalleryImage no longer has parameter eula
      info	[Changelog]   - Model SharedGalleryImage no longer has parameter privacy_statement_uri
      info	[Changelog]   - Model Snapshot no longer has parameter incremental_snapshot_family_id
      info	[Changelog]   - Model SupportedCapabilities no longer has parameter disk_controller_types
      info	[Changelog]   - Model TargetRegion no longer has parameter exclude_from_latest
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from e1aa5524dd8599a4e883516d294c73aa045efade. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-compute-generated [View full logs]  [Preview SDK Changes]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from e1aa5524dd8599a4e883516d294c73aa045efade. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-compute [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Interface GalleryApplicationCustomAction
      info	[Changelog]   - Added Interface GalleryApplicationCustomActionParameter
      info	[Changelog]   - Added Interface GalleryApplicationVersionSafetyProfile
      info	[Changelog]   - Added Interface GalleryArtifactSafetyProfileBase
      info	[Changelog]   - Added Interface GalleryArtifactVersionFullSource
      info	[Changelog]   - Added Interface GalleryDiskImageSource
      info	[Changelog]   - Added Interface GalleryImageVersionSafetyProfile
      info	[Changelog]   - Added Interface LatestGalleryImageVersion
      info	[Changelog]   - Added Interface PolicyViolation
      info	[Changelog]   - Added Interface RunCommandManagedIdentity
      info	[Changelog]   - Added Type Alias GalleryApplicationCustomActionParameterType
      info	[Changelog]   - Added Type Alias PolicyViolationCategory
      info	[Changelog]   - Interface GalleryApplication has a new optional parameter customActions
      info	[Changelog]   - Interface GalleryApplicationUpdate has a new optional parameter customActions
      info	[Changelog]   - Interface GalleryApplicationVersion has a new optional parameter safetyProfile
      info	[Changelog]   - Interface GalleryApplicationVersionPublishingProfile has a new optional parameter customActions
      info	[Changelog]   - Interface GalleryApplicationVersionUpdate has a new optional parameter safetyProfile
      info	[Changelog]   - Interface GalleryImageVersion has a new optional parameter safetyProfile
      info	[Changelog]   - Interface GalleryImageVersionUpdate has a new optional parameter safetyProfile
      info	[Changelog]   - Interface SharedGalleryImage has a new optional parameter eula
      info	[Changelog]   - Interface SharedGalleryImage has a new optional parameter privacyStatementUri
      info	[Changelog]   - Interface TargetRegion has a new optional parameter excludeFromLatest
      info	[Changelog]   - Interface VirtualMachineRunCommand has a new optional parameter errorBlobManagedIdentity
      info	[Changelog]   - Interface VirtualMachineRunCommand has a new optional parameter outputBlobManagedIdentity
      info	[Changelog]   - Interface VirtualMachineRunCommandScriptSource has a new optional parameter scriptUriManagedIdentity
      info	[Changelog]   - Interface VirtualMachineRunCommandUpdate has a new optional parameter errorBlobManagedIdentity
      info	[Changelog]   - Interface VirtualMachineRunCommandUpdate has a new optional parameter outputBlobManagedIdentity
      info	[Changelog]   - Added Enum KnownPolicyViolationCategory
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Interface GalleryArtifactVersionSource no longer has parameter uri
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from e1aa5524dd8599a4e883516d294c73aa045efade. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/compute/armcompute [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New struct `RunCommandManagedIdentity`
      info	[Changelog] - New field `ErrorBlobManagedIdentity` in struct `VirtualMachineRunCommandProperties`
      info	[Changelog] - New field `OutputBlobManagedIdentity` in struct `VirtualMachineRunCommandProperties`
      info	[Changelog] - New field `ScriptURIManagedIdentity` in struct `VirtualMachineRunCommandScriptSource`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 4 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from e1aa5524dd8599a4e883516d294c73aa045efade. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️compute [View full logs]  [Preview Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs] Generate from e1aa5524dd8599a4e883516d294c73aa045efade. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.compute [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/compute/armcompute Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-compute-generated Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    .Net Azure.ResourceManager.Compute Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-compute Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Python track2_azure-mgmt-compute Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    Hi @vivlingaiah, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    NewApiVersionRequired reason: A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support. EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @ArcturusZhang ArcturusZhang, could you check and let me know if anything else needed from my side on this PR ? I have done my best to run the validation tools and fix.

    viveklingaiah avatar Sep 20 '22 10:09 viveklingaiah

    PR looks good. I will proceed this with the rest of 2022-11-01 release when ready

    grizzlytheodore avatar Oct 17 '22 20:10 grizzlytheodore

    Hi, @vivlingaiah. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Nov 06 '22 16:11 ghost

    Hi, @vivlingaiah. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    ghost avatar Nov 21 '22 05:11 ghost

    Hi @vivlingaiah, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval.

    Hi, @vivlingaiah. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Dec 25 '22 16:12 ghost