Azure
{AzureCosmosDB} fixes Azure/azure-rest-api-specs#20268
ARM API Information (Control Plane)
It seems that Parse is deprecated. However, it still exists in the latest version of DatabaseAccounts_CreateOrUpdate API.
AFAIK, Parse is an extremely old API that was supported when the service first launched as DocumentDB. Now that we have GlobalDocumentDB itself as a accepted value (default value) for the --kind can the Parse kind be removed to avoid confusion ?
I see the same discussion here by Mark Brown from Az CosmosDb team. Hope this clarifies the ask.
GitHub Issue is reported here https://github.com/Azure/azure-rest-api-specs/issues/20268 MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow. Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
- What's the purpose of the update?
- [ ] new service onboarding
- [ ] new API version
- [ ] update existing version for new feature
- [ ] update existing version to fix swagger quality issue in s360
- [ ] Other, please clarify
- When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
- When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
- By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.
Contribution checklist (MS Employees Only):
- [ ] I commit to follow the Breaking Change Policy of "no breaking changes"
- [ ] I have reviewed the documentation for the workflow.
- [ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.
- Change to data plane APIs
- Adding new properties
- All removals
Otherwise your PR may be subject to ARM review requirements. Complete the following:
-
[ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
-
[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
-
[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.
Hi, @navba-MSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips.
![openapi-workflow-bot[bot] avatar](https://avatars.githubusercontent.com/in/81125?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Validation Report
️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
| compared swaggers (via Oad v0.9.7)] | new version | base version |
|---|---|---|
| cosmos-db.json | 2022-05-15(ee0cd6f) | 2022-05-15(main) |
| Rule | Message |
|---|---|
|
The new version is removing enum value(s) 'Parse' from the old version. New: Microsoft.DocumentDB/stable/2022-05-15/cosmos-db.json#L5453:9 Old: Microsoft.DocumentDB/stable/2022-05-15/cosmos-db.json#L5453:9 |
|
The new version is removing enum value(s) 'Parse' from the old version. New: Microsoft.DocumentDB/stable/2022-05-15/cosmos-db.json#L6393:9 Old: Microsoft.DocumentDB/stable/2022-05-15/cosmos-db.json#L6394:9 |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-2022-05 | package-2022-05(ee0cd6f) | package-2022-05(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"\nfatal error: Failed to load step "step":"DatabaseAccounts_GetReadOnlyKeys", "exampleFile":"../examples/CosmosDBDatabaseAccountListReadOnlyKeys.json": Example file is referenced by multiple operation: DatabaseAccounts_GetReadOnlyKeys, DatabaseAccounts_ListReadOnlyKeys ../examples/CosmosDBDatabaseAccountListReadOnlyKeys.json, \n" |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/ee0cd6f3ff826b136ea7b254cc053f939fb1af7f/specification/cosmos-db/resource-manager/readme.md#tag-package-2022-05">cosmos-db/resource-manager/readme.md#package-2022-05
| Rule | Message |
|---|---|
| :warning: UnkownSecurityScheme | "readme":"cosmos-db/resource-manager/readme.md", "tag":"package-2022-05", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
![openapi-pipeline-app[bot] avatar](https://avatars.githubusercontent.com/in/65541?v=4 "Published by a pub.dev verified publisher"){kind=small}
Swagger Generation Artifacts
️️✔️ApiDocPreview succeeded [Detail] [Expand]
Please click here to preview with your @microsoft account.
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-js - @azure/arm-cosmosdb - 16.0.0-beta.4- Interface RestoreParameters no longer has parameter restoreSource - Interface RestoreParameters no longer has parameter restoreTimestampInUtc
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from 219cef8fba2e86072d20ad6d181c4697a4f80c1b. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-cosmosdb [View full logs] [Preview SDK Changes]info [Changelog]
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 219cef8fba2e86072d20ad6d181c4697a4f80c1b. SDK Automation 14.0.0command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json warn File azure-sdk-for-net_tmp/initOutput.json not found to read command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
️✔️Azure.ResourceManager.CosmosDB [View full logs] [Preview SDK Changes]info [Changelog]
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 219cef8fba2e86072d20ad6d181c4697a4f80c1b. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-cosmos-generated [View full logs] [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 219cef8fba2e86072d20ad6d181c4697a4f80c1b. SDK Automation 14.0.0command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/cosmos/armcosmos [View full logs] [Preview SDK Changes]info [Changelog] ### Other Changes info [Changelog] info [Changelog] Total 0 breaking change(s), 0 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from 219cef8fba2e86072d20ad6d181c4697a4f80c1b. SDK Automation 14.0.0command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
- Only show 120 items here, please refer to log for details.
️✔️@azure/arm-cosmosdb [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] - Added Interface PhysicalPartitionStorageInfo info [Changelog] - Added Interface PhysicalPartitionStorageInfoCollection info [Changelog] - Added Interface PhysicalPartitionThroughputInfoProperties info [Changelog] - Added Interface PhysicalPartitionThroughputInfoResource info [Changelog] - Added Interface PhysicalPartitionThroughputInfoResult info [Changelog] - Added Interface PhysicalPartitionThroughputInfoResultPropertiesResource info [Changelog] - Added Interface Privilege info [Changelog] - Added Interface PrivilegeResource info [Changelog] - Added Interface RedistributeThroughputParameters info [Changelog] - Added Interface RedistributeThroughputPropertiesResource info [Changelog] - Added Interface RestorableGremlinDatabaseGetResult info [Changelog] - Added Interface RestorableGremlinDatabasePropertiesResource info [Changelog] - Added Interface RestorableGremlinDatabasesListOptionalParams info [Changelog] - Added Interface RestorableGremlinDatabasesListResult info [Changelog] - Added Interface RestorableGremlinGraphGetResult info [Changelog] - Added Interface RestorableGremlinGraphPropertiesResource info [Changelog] - Added Interface RestorableGremlinGraphsListOptionalParams info [Changelog] - Added Interface RestorableGremlinGraphsListResult info [Changelog] - Added Interface RestorableGremlinResourcesGetResult info [Changelog] - Added Interface RestorableGremlinResourcesListOptionalParams info [Changelog] - Added Interface RestorableGremlinResourcesListResult info [Changelog] - Added Interface RestorableTableGetResult info [Changelog] - Added Interface RestorableTablePropertiesResource info [Changelog] - Added Interface RestorableTableResourcesGetResult info [Changelog] - Added Interface RestorableTableResourcesListOptionalParams info [Changelog] - Added Interface RestorableTableResourcesListResult info [Changelog] - Added Interface RestorableTablesListOptionalParams info [Changelog] - Added Interface RestorableTablesListResult info [Changelog] - Added Interface RetrieveThroughputParameters info [Changelog] - Added Interface RetrieveThroughputPropertiesResource info [Changelog] - Added Interface Role info [Changelog] - Added Interface SqlResourcesCreateUpdateClientEncryptionKeyOptionalParams info [Changelog] - Added Interface SqlResourcesGetClientEncryptionKeyOptionalParams info [Changelog] - Added Interface SqlResourcesListClientEncryptionKeysOptionalParams info [Changelog] - Added Interface SqlResourcesListSqlContainerPartitionMergeOptionalParams info [Changelog] - Added Interface SqlResourcesSqlContainerRedistributeThroughputOptionalParams info [Changelog] - Added Interface SqlResourcesSqlContainerRetrieveThroughputDistributionOptionalParams info [Changelog] - Added Interface TableResourcesRetrieveContinuousBackupInformationOptionalParams info [Changelog] - Added Type Alias CassandraClustersGetBackupResponse info [Changelog] - Added Type Alias CassandraClustersListBackupsResponse info [Changelog] - Added Type Alias CassandraResourcesCreateUpdateCassandraViewResponse info [Changelog] - Added Type Alias CassandraResourcesGetCassandraViewResponse info [Changelog] - Added Type Alias CassandraResourcesGetCassandraViewThroughputResponse info [Changelog] - Added Type Alias CassandraResourcesListCassandraViewsResponse info [Changelog] - Added Type Alias CassandraResourcesMigrateCassandraViewToAutoscaleResponse info [Changelog] - Added Type Alias CassandraResourcesMigrateCassandraViewToManualThroughputResponse info [Changelog] - Added Type Alias CassandraResourcesUpdateCassandraViewThroughputResponse info [Changelog] - Added Type Alias ContinuousTier info [Changelog] - Added Type Alias DataTransferComponent info [Changelog] - Added Type Alias DataTransferDataSourceSinkUnion info [Changelog] - Added Type Alias DataTransferJobsCancelResponse info [Changelog] - Added Type Alias DataTransferJobsCreateResponse info [Changelog] - Added Type Alias DataTransferJobsGetResponse info [Changelog] - Added Type Alias DataTransferJobsListByDatabaseAccountNextResponse info [Changelog] - Added Type Alias DataTransferJobsListByDatabaseAccountResponse info [Changelog] - Added Type Alias DataTransferJobsPauseResponse info [Changelog] - Added Type Alias DataTransferJobsResumeResponse info [Changelog] - Added Type Alias EnableFullTextQuery info [Changelog] - Added Type Alias GraphResourcesCreateUpdateGraphResponse info [Changelog] - Added Type Alias GraphResourcesGetGraphResponse info [Changelog] - Added Type Alias GraphResourcesListGraphsResponse info [Changelog] - Added Type Alias GremlinResourcesRetrieveContinuousBackupInformationResponse info [Changelog] - Added Type Alias MongoDBResourcesCreateUpdateMongoRoleDefinitionResponse info [Changelog] - Added Type Alias MongoDBResourcesCreateUpdateMongoUserDefinitionResponse info [Changelog] - Added Type Alias MongoDBResourcesGetMongoRoleDefinitionResponse info [Changelog] - Added Type Alias MongoDBResourcesGetMongoUserDefinitionResponse info [Changelog] - Added Type Alias MongoDBResourcesListMongoDBCollectionPartitionMergeResponse info [Changelog] - Added Type Alias MongoDBResourcesListMongoRoleDefinitionsResponse info [Changelog] - Added Type Alias MongoDBResourcesListMongoUserDefinitionsResponse info [Changelog] - Added Type Alias MongoDBResourcesMongoDBContainerRedistributeThroughputResponse info [Changelog] - Added Type Alias MongoDBResourcesMongoDBContainerRetrieveThroughputDistributionResponse info [Changelog] - Added Type Alias MongoRoleDefinitionType info [Changelog] - Added Type Alias RestorableGremlinDatabasesListResponse info [Changelog] - Added Type Alias RestorableGremlinGraphsListResponse info [Changelog] - Added Type Alias RestorableGremlinResourcesListResponse info [Changelog] - Added Type Alias RestorableTableResourcesListResponse info [Changelog] - Added Type Alias RestorableTablesListResponse info [Changelog] - Added Type Alias SqlResourcesCreateUpdateClientEncryptionKeyResponse info [Changelog] - Added Type Alias SqlResourcesGetClientEncryptionKeyResponse info [Changelog] - Added Type Alias SqlResourcesListClientEncryptionKeysResponse info [Changelog] - Added Type Alias SqlResourcesListSqlContainerPartitionMergeResponse info [Changelog] - Added Type Alias SqlResourcesSqlContainerRedistributeThroughputResponse info [Changelog] - Added Type Alias SqlResourcesSqlContainerRetrieveThroughputDistributionResponse info [Changelog] - Added Type Alias TableResourcesRetrieveContinuousBackupInformationResponse info [Changelog] - Added Type Alias ThroughputPolicyType info [Changelog] - Interface ARMResourceProperties has a new optional parameter identity info [Changelog] - Interface ContinuousModeBackupPolicy has a new optional parameter continuousModeProperties info [Changelog] - Interface DatabaseAccountCreateUpdateParameters has a new optional parameter diagnosticLogSettings info [Changelog] - Interface DatabaseAccountCreateUpdateParameters has a new optional parameter enableMaterializedViews info [Changelog] - Interface DatabaseAccountCreateUpdateParameters has a new optional parameter keysMetadata info [Changelog] - Interface DatabaseAccountGetResults has a new optional parameter diagnosticLogSettings info [Changelog] - Interface DatabaseAccountGetResults has a new optional parameter enableMaterializedViews info [Changelog] - Interface DatabaseAccountGetResults has a new optional parameter keysMetadata info [Changelog] - Interface DatabaseAccountUpdateParameters has a new optional parameter diagnosticLogSettings info [Changelog] - Interface DatabaseAccountUpdateParameters has a new optional parameter enableMaterializedViews info [Changelog] - Interface DatabaseAccountUpdateParameters has a new optional parameter keysMetadata info [Changelog] - Interface DataCenterResourceProperties has a new optional parameter authenticationMethodLdapProperties info [Changelog] - Interface LocationProperties has a new optional parameter status info [Changelog] - Interface RestorableDatabaseAccountGetResult has a new optional parameter oldestRestorableTime info [Changelog] - Interface RestorableMongodbCollectionsListOptionalParams has a new optional parameter endTime info [Changelog] - Interface RestorableMongodbCollectionsListOptionalParams has a new optional parameter startTime info [Changelog] - Interface RestoreParameters has a new optional parameter gremlinDatabasesToRestore info [Changelog] - Interface RestoreParameters has a new optional parameter tablesToRestore info [Changelog] - Interface SqlContainerResource has a new optional parameter clientEncryptionPolicy info [Changelog] - Class CosmosDBManagementClient has a new parameter dataTransferJobs info [Changelog] - Class CosmosDBManagementClient has a new parameter graphResources info [Changelog] - Class CosmosDBManagementClient has a new parameter restorableGremlinDatabases info [Changelog] - Class CosmosDBManagementClient has a new parameter restorableGremlinGraphs info [Changelog] - Class CosmosDBManagementClient has a new parameter restorableGremlinResources info [Changelog] - Class CosmosDBManagementClient has a new parameter restorableTableResources info [Changelog] - Class CosmosDBManagementClient has a new parameter restorableTables info [Changelog] - Added Enum KnownContinuousTier info [Changelog] - Added Enum KnownDataTransferComponent info [Changelog] - Added Enum KnownThroughputPolicyType info [Changelog] - Enum KnownAuthenticationMethod has a new value Ldap info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Interface DatabaseAccountCreateUpdateParameters no longer has parameter identity info [Changelog] - Interface DatabaseAccountGetResults no longer has parameter identity
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from 219cef8fba2e86072d20ad6d181c4697a4f80c1b. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️cosmos-db [View full logs] [Preview Schema Changes]
️❌ azure-powershell failed [Detail]
❌Failed [Logs] Generate from 219cef8fba2e86072d20ad6d181c4697a4f80c1b. SDK Automation 14.0.0command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
❌Az.cosmos-db [View full logs] [Preview SDK Changes]
Generated ApiView
| Language | Package Name | ApiView Link |
|---|---|---|
| Go | sdk/resourcemanager/cosmos/armcosmos | Create ApiView failed. Please ask PR assignee for help |
| Python | track2_azure-mgmt-cosmosdb | Create ApiView failed. Please ask PR assignee for help |
| Java | azure-resourcemanager-cosmos-generated | Create ApiView failed. Please ask PR assignee for help |
| .Net | Azure.ResourceManager.CosmosDB | Create ApiView failed. Please ask PR assignee for help |
| JavaScript | @azure/arm-cosmosdb | Create ApiView failed. Please ask PR assignee for help |
Hi @navba-MSFT, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.
@pjohari-ms Could you please review this once you get a chance ? Thanks in advance.
@navba-MSFT Could you explain the change a bit, either in comments or in the PR description? Thanks.
@pjohari-ms Apologies for missing the issue details in the PR. I am sending the details in this comment below:
It seems that Parse is deprecated. However, it still exists in the latest version of DatabaseAccounts_CreateOrUpdate API.
AFAIK, Parse is an extremely old API that was supported when the service first launched as DocumentDB. Now that we have GlobalDocumentDB itself as a accepted value (default value) for the --kind can the Parse kind be removed to avoid confusion ?
I see the same discussion here by Mark Brown from Az CosmosDb team. Hope this clarifies the ask.
GitHub Issue is reported here https://github.com/Azure/azure-rest-api-specs/issues/20268
@navba-MSFT Could you explain the change a bit, either in comments or in the PR description? Thanks.
@pjohari-ms I have added my comments here. Please review this once you get a chance. Thanks in advance.
Hi @navba-MSFT, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.
@navba-MSFT , please follow above action to get breaking change reviewed.
Hi, @navba-MSFT. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
@raych1 what's the process of deprecating and removing this parameter? Can we simply remove it since it serves no purpose anymore?
@raych1 what's the process of deprecating and removing this parameter? Can we simply remove it since it serves no purpose anymore?
@pjohari-ms , can you talk to breaking change review board in detail?
Hi, @navba-MSFT. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.
Hi, @navba-MSFT. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.