azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

MI standby replica

Open a-lazarlazic opened this issue 3 years ago • 11 comments

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow. Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [x] new API version
    • [ ] update existing version for new feature
    • [ ] update existing version to fix swagger quality issue in s360
    • [ ] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. End of August/start of September
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. Start of September
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • [ ] SDK of .NET (need service team to ensure code readiness)
    • [ ] SDK of Python
    • [ ] SDK of Java
    • [ ] SDK of Js
    • [ ] SDK of Go
    • [ ] PowerShell
    • [ ] CLI
    • [ ] Terraform
    • [ ] No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [x] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • [x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [x] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • [ ] Removing API(s) in a stable version
  • [ ] Removing properties in a stable version
  • [ ] Removing API version(s) in a stable version
  • [ ] Updating API in a stable or public preview version with Breaking Change Validation errors
  • [ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

a-lazarlazic avatar Aug 15 '22 15:08 a-lazarlazic

Hi, @a-lazarlazic Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    Hi, @a-lazarlazic your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.9.6)] new version base version
    InstanceFailoverGroups.json 2022-05-01-preview(cea376f) 2021-11-01(main)
    InstanceFailoverGroups.json 2022-05-01-preview(cea376f) 2022-02-01-preview(main)
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-preview-2022-05 package-preview-2022-05(cea376f) package-preview-2022-05(dev-sql-Microsoft.Sql-2022-05-01-preview)

    The following errors/warnings exist before current PR submission:

    Rule Message
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.Sql/preview/2022-05-01-preview/InstanceFailoverGroups.json#L426
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.Sql/preview/2022-05-01-preview/InstanceFailoverGroups.json#L437
    :warning: R2010 - LongRunningOperationsOptionsValidator A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled.
    Location: Microsoft.Sql/preview/2022-05-01-preview/InstanceFailoverGroups.json#L234
    :warning: R2010 - LongRunningOperationsOptionsValidator A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled.
    Location: Microsoft.Sql/preview/2022-05-01-preview/InstanceFailoverGroups.json#L288
    :warning: R4009 - RequiredReadOnlySystemData The response of operation:'InstanceFailoverGroups_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Sql/preview/2022-05-01-preview/InstanceFailoverGroups.json#L66
    :warning: R4009 - RequiredReadOnlySystemData The response of operation:'InstanceFailoverGroups_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Sql/preview/2022-05-01-preview/InstanceFailoverGroups.json#L114
    :warning: R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List failover group
    Location: Microsoft.Sql/preview/2022-05-01-preview/InstanceFailoverGroups.json#L58
    :warning: R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get failover group
    Location: Microsoft.Sql/preview/2022-05-01-preview/InstanceFailoverGroups.json#L108
    :warning: R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Create failover group
    Location: Microsoft.Sql/preview/2022-05-01-preview/InstanceFailoverGroups.json#L175
    :warning: R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Delete failover group
    Location: Microsoft.Sql/preview/2022-05-01-preview/InstanceFailoverGroups.json#L227
    :warning: R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Planned failover of a failover group
    Location: Microsoft.Sql/preview/2022-05-01-preview/InstanceFailoverGroups.json#L281
    :warning: R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Forced failover of a failover group allowing data loss
    Location: Microsoft.Sql/preview/2022-05-01-preview/InstanceFailoverGroups.json#L335
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    :warning: MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/sql/resource-manager/readme.md
    tag: specification/sql/resource-manager/readme.md#tag-package-composite-v5
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️SDK Track2 Validation succeeded [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/cea376ff8949be3dcc98a03aea5af6a18a5a0855/specification/sql/resource-manager/readme.md#tag-package-preview-2022-05">sql/resource-manager/readme.md#package-preview-2022-05
    The following errors/warnings exist before current PR submission:
    Rule Message
    DuplicateOperation "readme":"sql/resource-manager/readme.md",
    "tag":"package-preview-2022-05",
    "details":"Duplicate Operation 'DatabaseSqlVulnerabilityAssessmentBaselines' > 'CreateOrUpdate' detected(This is most likely due to 2 operation using the same 'operationId' or 'tags'). Duplicates have those paths:\n - put /subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.Sql/servers/serverName/databases/databaseName/sqlVulnerabilityAssessments/vulnerabilityAssessmentName/baselines/baselineName\n - put /subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.Sql/servers/serverName/sqlVulnerabilityAssessments/vulnerabilityAssessmentName/baselines/baselineName"
    DuplicateOperation "readme":"sql/resource-manager/readme.md",
    "tag":"package-preview-2022-05",
    "details":"Duplicate Operation 'DatabaseSqlVulnerabilityAssessmentRuleBaselines' > 'Delete' detected(This is most likely due to 2 operation using the same 'operationId' or 'tags'). Duplicates have those paths:\n - delete /subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.Sql/servers/serverName/databases/databaseName/sqlVulnerabilityAssessments/vulnerabilityAssessmentName/baselines/baselineName/rules/ruleId\n - delete /subscriptions/subscriptionId/resourceGroups/resourceGroupName/providers/Microsoft.Sql/servers/serverName/sqlVulnerabilityAssessments/vulnerabilityAssessmentName/baselines/baselineName/rules/ruleId"
    "readme":"sql/resource-manager/readme.md",
    "tag":"package-preview-2022-05",
    "details":"Duplicate object schemas with 'SecurityAlertPolicyName' name detected."
    "readme":"sql/resource-manager/readme.md",
    "tag":"package-preview-2022-05",
    "details":"Error: 3 errors occured -- cannot continue."
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - armsql - 1.1.0-beta.1
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-sql - 4.0.0b3
    ️✔️azure-sdk-for-js - @azure/arm-sql - 10.0.0-beta.1
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 5ecf85dad40b37a264035fe93ae630bc4ff14c8e. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-sql [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation group ManagedDatabaseAdvancedThreatProtectionSettingsOperations
      info	[Changelog]   - Added operation group ManagedDatabaseMoveOperationsOperations
      info	[Changelog]   - Added operation group ManagedInstanceAdvancedThreatProtectionSettingsOperations
      info	[Changelog]   - Added operation group ManagedInstanceDtcsOperations
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs] Generate from 5ecf85dad40b37a264035fe93ae630bc4ff14c8e. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [91mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:515
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [96mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [96m 515 | [0m         [96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [96m     | [91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [91m[96m     | [91mFailed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [91mGet-ChildItem: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:599
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [96mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [96m 599 | [0m … rtifacts += [96mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [96m     | [91m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [91m[96m     | [91mCannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [96m     | [91m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because it does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [91mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:515
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [96mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [96m 515 | [0m         [96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [96m     | [91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [91m[96m     | [91mFailed to generate sdk artifact
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
    • Azure.ResourceManager.Sql [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 5ecf85dad40b37a264035fe93ae630bc4ff14c8e. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armsql [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `MoveOperationModeCopy`
      info	[Changelog] - New const `DtcNameCurrent`
      info	[Changelog] - New const `MoveOperationModeMove`
      info	[Changelog] - New function `*ManagedDatabaseAdvancedThreatProtectionSettingsClient.CreateOrUpdate(context.Context, string, string, string, AdvancedThreatProtectionName, ManagedDatabaseAdvancedThreatProtection, *ManagedDatabaseAdvancedThreatProtectionSettingsClientCreateOrUpdateOptions) (ManagedDatabaseAdvancedThreatProtectionSettingsClientCreateOrUpdateResponse, error)`
      info	[Changelog] - New function `NewManagedDatabaseMoveOperationsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagedDatabaseMoveOperationsClient, error)`
      info	[Changelog] - New function `NewManagedServerDNSAliasesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagedServerDNSAliasesClient, error)`
      info	[Changelog] - New function `*ManagedDatabaseAdvancedThreatProtectionSettingsClient.Get(context.Context, string, string, string, AdvancedThreatProtectionName, *ManagedDatabaseAdvancedThreatProtectionSettingsClientGetOptions) (ManagedDatabaseAdvancedThreatProtectionSettingsClientGetResponse, error)`
      info	[Changelog] - New function `*ManagedInstanceDtcsClient.BeginCreateOrUpdate(context.Context, string, string, DtcName, ManagedInstanceDtc, *ManagedInstanceDtcsClientBeginCreateOrUpdateOptions) (*runtime.Poller[ManagedInstanceDtcsClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*ManagedServerDNSAliasesClient.Get(context.Context, string, string, string, *ManagedServerDNSAliasesClientGetOptions) (ManagedServerDNSAliasesClientGetResponse, error)`
      info	[Changelog] - New function `*ManagedInstanceAdvancedThreatProtectionSettingsClient.BeginCreateOrUpdate(context.Context, string, string, AdvancedThreatProtectionName, ManagedInstanceAdvancedThreatProtection, *ManagedInstanceAdvancedThreatProtectionSettingsClientBeginCreateOrUpdateOptions) (*runtime.Poller[ManagedInstanceAdvancedThreatProtectionSettingsClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `*ManagedDatabaseAdvancedThreatProtectionSettingsClient.NewListByDatabasePager(string, string, string, *ManagedDatabaseAdvancedThreatProtectionSettingsClientListByDatabaseOptions) *runtime.Pager[ManagedDatabaseAdvancedThreatProtectionSettingsClientListByDatabaseResponse]`
      info	[Changelog] - New function `*ManagedDatabaseMoveOperationsClient.Get(context.Context, string, string, string, *ManagedDatabaseMoveOperationsClientGetOptions) (ManagedDatabaseMoveOperationsClientGetResponse, error)`
      info	[Changelog] - New function `*ManagedDatabaseMoveOperationsClient.NewListByLocationPager(string, string, *ManagedDatabaseMoveOperationsClientListByLocationOptions) *runtime.Pager[ManagedDatabaseMoveOperationsClientListByLocationResponse]`
      info	[Changelog] - New function `*ManagedServerDNSAliasesClient.NewListByManagedInstancePager(string, string, *ManagedServerDNSAliasesClientListByManagedInstanceOptions) *runtime.Pager[ManagedServerDNSAliasesClientListByManagedInstanceResponse]`
      info	[Changelog] - New function `*ManagedInstanceAdvancedThreatProtectionSettingsClient.NewListByInstancePager(string, string, *ManagedInstanceAdvancedThreatProtectionSettingsClientListByInstanceOptions) *runtime.Pager[ManagedInstanceAdvancedThreatProtectionSettingsClientListByInstanceResponse]`
      info	[Changelog] - New function `*ManagedServerDNSAliasesClient.BeginCreateOrUpdate(context.Context, string, string, string, ManagedServerDNSAliasCreation, *ManagedServerDNSAliasesClientBeginCreateOrUpdateOptions) (*runtime.Poller[ManagedServerDNSAliasesClientCreateOrUpdateResponse], error)`
      info	[Changelog] - New function `PossibleDtcNameValues() []DtcName`
      info	[Changelog] - New function `*ManagedServerDNSAliasesClient.BeginAcquire(context.Context, string, string, string, ManagedServerDNSAliasAcquisition, *ManagedServerDNSAliasesClientBeginAcquireOptions) (*runtime.Poller[ManagedServerDNSAliasesClientAcquireResponse], error)`
      info	[Changelog] - New function `*ManagedInstanceAdvancedThreatProtectionSettingsClient.Get(context.Context, string, string, AdvancedThreatProtectionName, *ManagedInstanceAdvancedThreatProtectionSettingsClientGetOptions) (ManagedInstanceAdvancedThreatProtectionSettingsClientGetResponse, error)`
      info	[Changelog] - New function `*ManagedInstanceDtcsClient.NewListByManagedInstancePager(string, string, *ManagedInstanceDtcsClientListByManagedInstanceOptions) *runtime.Pager[ManagedInstanceDtcsClientListByManagedInstanceResponse]`
      info	[Changelog] - New function `NewManagedInstanceDtcsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagedInstanceDtcsClient, error)`
      info	[Changelog] - New function `NewManagedDatabaseAdvancedThreatProtectionSettingsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagedDatabaseAdvancedThreatProtectionSettingsClient, error)`
      info	[Changelog] - New function `NewManagedInstanceAdvancedThreatProtectionSettingsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagedInstanceAdvancedThreatProtectionSettingsClient, error)`
      info	[Changelog] - New function `*ManagedServerDNSAliasesClient.BeginDelete(context.Context, string, string, string, *ManagedServerDNSAliasesClientBeginDeleteOptions) (*runtime.Poller[ManagedServerDNSAliasesClientDeleteResponse], error)`
      info	[Changelog] - New function `*ManagedInstanceDtcsClient.Get(context.Context, string, string, DtcName, *ManagedInstanceDtcsClientGetOptions) (ManagedInstanceDtcsClientGetResponse, error)`
      info	[Changelog] - New function `PossibleMoveOperationModeValues() []MoveOperationMode`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtection`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionListResult`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionSettingsClient`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionSettingsClientCreateOrUpdateOptions`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionSettingsClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionSettingsClientGetOptions`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionSettingsClientGetResponse`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionSettingsClientListByDatabaseOptions`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionSettingsClientListByDatabaseResponse`
      info	[Changelog] - New struct `ManagedDatabaseMoveOperationListResult`
      info	[Changelog] - New struct `ManagedDatabaseMoveOperationResult`
      info	[Changelog] - New struct `ManagedDatabaseMoveOperationResultProperties`
      info	[Changelog] - New struct `ManagedDatabaseMoveOperationsClient`
      info	[Changelog] - New struct `ManagedDatabaseMoveOperationsClientGetOptions`
      info	[Changelog] - New struct `ManagedDatabaseMoveOperationsClientGetResponse`
      info	[Changelog] - New struct `ManagedDatabaseMoveOperationsClientListByLocationOptions`
      info	[Changelog] - New struct `ManagedDatabaseMoveOperationsClientListByLocationResponse`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtection`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionListResult`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionSettingsClient`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionSettingsClientBeginCreateOrUpdateOptions`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionSettingsClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionSettingsClientGetOptions`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionSettingsClientGetResponse`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionSettingsClientListByInstanceOptions`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionSettingsClientListByInstanceResponse`
      info	[Changelog] - New struct `ManagedInstanceDtc`
      info	[Changelog] - New struct `ManagedInstanceDtcListResult`
      info	[Changelog] - New struct `ManagedInstanceDtcProperties`
      info	[Changelog] - New struct `ManagedInstanceDtcSecuritySettings`
      info	[Changelog] - New struct `ManagedInstanceDtcTransactionManagerCommunicationSettings`
      info	[Changelog] - New struct `ManagedInstanceDtcsClient`
      info	[Changelog] - New struct `ManagedInstanceDtcsClientBeginCreateOrUpdateOptions`
      info	[Changelog] - New struct `ManagedInstanceDtcsClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `ManagedInstanceDtcsClientGetOptions`
      info	[Changelog] - New struct `ManagedInstanceDtcsClientGetResponse`
      info	[Changelog] - New struct `ManagedInstanceDtcsClientListByManagedInstanceOptions`
      info	[Changelog] - New struct `ManagedInstanceDtcsClientListByManagedInstanceResponse`
      info	[Changelog] - New struct `ManagedServerDNSAlias`
      info	[Changelog] - New struct `ManagedServerDNSAliasAcquisition`
      info	[Changelog] - New struct `ManagedServerDNSAliasCreation`
      info	[Changelog] - New struct `ManagedServerDNSAliasListResult`
      info	[Changelog] - New struct `ManagedServerDNSAliasProperties`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClient`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClientAcquireResponse`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClientBeginAcquireOptions`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClientBeginCreateOrUpdateOptions`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClientBeginDeleteOptions`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClientDeleteResponse`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClientGetOptions`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClientGetResponse`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClientListByManagedInstanceOptions`
      info	[Changelog] - New struct `ManagedServerDNSAliasesClientListByManagedInstanceResponse`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 134 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 5ecf85dad40b37a264035fe93ae630bc4ff14c8e. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-sql [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Interface ServerAdvancedThreatProtectionSettingsCreateOrUpdateOptionalParams
      info	[Changelog]   - Added Interface ServerAdvancedThreatProtectionSettingsGetOptionalParams
      info	[Changelog]   - Added Interface ServerAdvancedThreatProtectionSettingsListByServerNextOptionalParams
      info	[Changelog]   - Added Interface ServerAdvancedThreatProtectionSettingsListByServerOptionalParams
      info	[Changelog]   - Added Interface ServerAutomaticTuning
      info	[Changelog]   - Added Interface ServerAzureADAdministrator
      info	[Changelog]   - Added Interface ServerAzureADOnlyAuthentication
      info	[Changelog]   - Added Interface ServerBlobAuditingPolicy
      info	[Changelog]   - Added Interface ServerCommunicationLink
      info	[Changelog]   - Added Interface ServerConnectionPolicy
      info	[Changelog]   - Added Interface ServerDevOpsAuditingSettings
      info	[Changelog]   - Added Interface ServerDnsAlias
      info	[Changelog]   - Added Interface ServerKey
      info	[Changelog]   - Added Interface ServerOperation
      info	[Changelog]   - Added Interface ServerSecurityAlertPolicy
      info	[Changelog]   - Added Interface ServerTrustCertificate
      info	[Changelog]   - Added Interface ServerTrustCertificatesCreateOrUpdateOptionalParams
      info	[Changelog]   - Added Interface ServerTrustCertificatesDeleteOptionalParams
      info	[Changelog]   - Added Interface ServerTrustCertificatesGetOptionalParams
      info	[Changelog]   - Added Interface ServerTrustCertificatesListByInstanceNextOptionalParams
      info	[Changelog]   - Added Interface ServerTrustCertificatesListByInstanceOptionalParams
      info	[Changelog]   - Added Interface ServerTrustCertificatesListResult
      info	[Changelog]   - Added Interface ServerTrustGroup
      info	[Changelog]   - Added Interface ServerVulnerabilityAssessment
      info	[Changelog]   - Added Interface ServiceObjective
      info	[Changelog]   - Added Interface SqlAgentConfiguration
      info	[Changelog]   - Added Interface SubscriptionUsage
      info	[Changelog]   - Added Interface SyncAgent
      info	[Changelog]   - Added Interface SyncAgentLinkedDatabase
      info	[Changelog]   - Added Interface SyncGroup
      info	[Changelog]   - Added Interface SyncMember
      info	[Changelog]   - Added Interface TdeCertificate
      info	[Changelog]   - Added Interface TimeZone
      info	[Changelog]   - Added Interface TrackedResource
      info	[Changelog]   - Added Interface UpdateManagedInstanceDnsServersOperation
      info	[Changelog]   - Added Interface VirtualCluster
      info	[Changelog]   - Added Interface VirtualNetworkRule
      info	[Changelog]   - Added Interface VulnerabilityAssessmentScanRecord
      info	[Changelog]   - Added Interface WorkloadClassifier
      info	[Changelog]   - Added Interface WorkloadGroup
      info	[Changelog]   - Added Type Alias AdvancedThreatProtectionName
      info	[Changelog]   - Added Type Alias AdvancedThreatProtectionState
      info	[Changelog]   - Added Type Alias DatabaseAdvancedThreatProtectionSettingsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias DatabaseAdvancedThreatProtectionSettingsGetResponse
      info	[Changelog]   - Added Type Alias DatabaseAdvancedThreatProtectionSettingsListByDatabaseNextResponse
      info	[Changelog]   - Added Type Alias DatabaseAdvancedThreatProtectionSettingsListByDatabaseResponse
      info	[Changelog]   - Added Type Alias DistributedAvailabilityGroupsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias DistributedAvailabilityGroupsGetResponse
      info	[Changelog]   - Added Type Alias DistributedAvailabilityGroupsListByInstanceNextResponse
      info	[Changelog]   - Added Type Alias DistributedAvailabilityGroupsListByInstanceResponse
      info	[Changelog]   - Added Type Alias DistributedAvailabilityGroupsUpdateResponse
      info	[Changelog]   - Added Type Alias DtcName
      info	[Changelog]   - Added Type Alias EndpointCertificatesGetResponse
      info	[Changelog]   - Added Type Alias EndpointCertificatesListByInstanceNextResponse
      info	[Changelog]   - Added Type Alias EndpointCertificatesListByInstanceResponse
      info	[Changelog]   - Added Type Alias IPv6FirewallRulesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias IPv6FirewallRulesGetResponse
      info	[Changelog]   - Added Type Alias IPv6FirewallRulesListByServerNextResponse
      info	[Changelog]   - Added Type Alias IPv6FirewallRulesListByServerResponse
      info	[Changelog]   - Added Type Alias ManagedDatabaseAdvancedThreatProtectionSettingsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ManagedDatabaseAdvancedThreatProtectionSettingsGetResponse
      info	[Changelog]   - Added Type Alias ManagedDatabaseAdvancedThreatProtectionSettingsListByDatabaseNextResponse
      info	[Changelog]   - Added Type Alias ManagedDatabaseAdvancedThreatProtectionSettingsListByDatabaseResponse
      info	[Changelog]   - Added Type Alias ManagedDatabaseMoveOperationsGetResponse
      info	[Changelog]   - Added Type Alias ManagedDatabaseMoveOperationsListByLocationNextResponse
      info	[Changelog]   - Added Type Alias ManagedDatabaseMoveOperationsListByLocationResponse
      info	[Changelog]   - Added Type Alias ManagedInstanceAdvancedThreatProtectionSettingsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ManagedInstanceAdvancedThreatProtectionSettingsGetResponse
      info	[Changelog]   - Added Type Alias ManagedInstanceAdvancedThreatProtectionSettingsListByInstanceNextResponse
      info	[Changelog]   - Added Type Alias ManagedInstanceAdvancedThreatProtectionSettingsListByInstanceResponse
      info	[Changelog]   - Added Type Alias ManagedInstanceDtcsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ManagedInstanceDtcsGetResponse
      info	[Changelog]   - Added Type Alias ManagedInstanceDtcsListByManagedInstanceNextResponse
      info	[Changelog]   - Added Type Alias ManagedInstanceDtcsListByManagedInstanceResponse
      info	[Changelog]   - Added Type Alias ManagedServerDnsAliasesAcquireResponse
      info	[Changelog]   - Added Type Alias ManagedServerDnsAliasesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ManagedServerDnsAliasesGetResponse
      info	[Changelog]   - Added Type Alias ManagedServerDnsAliasesListByManagedInstanceNextResponse
      info	[Changelog]   - Added Type Alias ManagedServerDnsAliasesListByManagedInstanceResponse
      info	[Changelog]   - Added Type Alias MoveOperationMode
      info	[Changelog]   - Added Type Alias ReplicationLinksFailoverAllowDataLossResponse
      info	[Changelog]   - Added Type Alias ReplicationLinksFailoverResponse
      info	[Changelog]   - Added Type Alias ReplicationMode
      info	[Changelog]   - Added Type Alias ServerAdvancedThreatProtectionSettingsCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ServerAdvancedThreatProtectionSettingsGetResponse
      info	[Changelog]   - Added Type Alias ServerAdvancedThreatProtectionSettingsListByServerNextResponse
      info	[Changelog]   - Added Type Alias ServerAdvancedThreatProtectionSettingsListByServerResponse
      info	[Changelog]   - Added Type Alias ServerTrustCertificatesCreateOrUpdateResponse
      info	[Changelog]   - Added Type Alias ServerTrustCertificatesGetResponse
      info	[Changelog]   - Added Type Alias ServerTrustCertificatesListByInstanceNextResponse
      info	[Changelog]   - Added Type Alias ServerTrustCertificatesListByInstanceResponse
      info	[Changelog]   - Added Type Alias SyncGroupsType
      info	[Changelog]   - Interface ElasticPoolUpdate has a new optional parameter highAvailabilityReplicaCount
      info	[Changelog]   - Class SqlManagementClient has a new parameter databaseAdvancedThreatProtectionSettings
      info	[Changelog]   - Class SqlManagementClient has a new parameter distributedAvailabilityGroups
      info	[Changelog]   - Class SqlManagementClient has a new parameter endpointCertificates
      info	[Changelog]   - Class SqlManagementClient has a new parameter iPv6FirewallRules
      info	[Changelog]   - Class SqlManagementClient has a new parameter managedDatabaseAdvancedThreatProtectionSettings
      info	[Changelog]   - Class SqlManagementClient has a new parameter managedDatabaseMoveOperations
      info	[Changelog]   - Class SqlManagementClient has a new parameter managedInstanceAdvancedThreatProtectionSettings
      info	[Changelog]   - Class SqlManagementClient has a new parameter managedInstanceDtcs
      info	[Changelog]   - Class SqlManagementClient has a new parameter managedServerDnsAliases
      info	[Changelog]   - Class SqlManagementClient has a new parameter serverAdvancedThreatProtectionSettings
      info	[Changelog]   - Class SqlManagementClient has a new parameter serverTrustCertificates
      info	[Changelog]   - Added Enum KnownAdvancedThreatProtectionName
      info	[Changelog]   - Added Enum KnownDtcName
      info	[Changelog]   - Added Enum KnownMoveOperationMode
      info	[Changelog]   - Added Enum KnownReplicationMode
      info	[Changelog]   - Added Enum KnownSyncGroupsType
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation group OperationsHealthOperations
      info	[Changelog]   - Removed operation ReplicationLinks.beginUnlink
      info	[Changelog]   - Removed operation ReplicationLinks.beginUnlinkAndWait
      info	[Changelog]   - Operation SyncGroups.listLogs has a new signature
      info	[Changelog]   - Interface DatabaseIdentity no longer has parameter delegatedResources
      info	[Changelog]   - Interface DatabaseUpdate no longer has parameter primaryDelegatedIdentityClientId
      info	[Changelog]   - Class SqlManagementClient no longer has parameter operationsHealthOperations
      info	[Changelog]   - Removed Enum KnownEnum60
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 5ecf85dad40b37a264035fe93ae630bc4ff14c8e. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs] Generate from 5ecf85dad40b37a264035fe93ae630bc4ff14c8e. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    Posted by Swagger Pipeline | How to fix these errors?

    Generated ApiView

    Language Package Name ApiView Link
    Java azure-resourcemanager-sql-generated Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Python track2_azure-mgmt-sql Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-sql Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    Can you add your 2022-05-01-preview swagger file into the V5 SDK? I am thinking the seconadaryType enum name will lead to conflict.

    ericshape avatar Aug 16 '22 06:08 ericshape

    Can you add your 2022-05-01-preview swagger file into the V5 SDK? I am thinking the seconadaryType enum name will lead to conflict.

    When I tried to set x-ms-enum name to SecondaryType, I was getting name conflict. Now x-ms-enum name is SecondaryInstanceType and there's no conflict (if that's what you're talking about). How can I add 2022-05-01-preview swagger file into the V5 SDK?

    a-lazarlazic avatar Aug 16 '22 08:08 a-lazarlazic

    /azp run

    a-lazarlazic avatar Aug 16 '22 13:08 a-lazarlazic

    Azure Pipelines successfully started running 1 pipeline(s).

    azure-pipelines[bot] avatar Aug 16 '22 13:08 azure-pipelines[bot]

    Can you add your 2022-05-01-preview swagger file into the V5 SDK? I am thinking the seconadaryType enum name will lead to conflict.

    When I tried to set x-ms-enum name to SecondaryType, I was getting name conflict. Now x-ms-enum name is SecondaryInstanceType and there's no conflict (if that's what you're talking about). How can I add 2022-05-01-preview swagger file into the V5 SDK?

    update this section: https://github.com/Azure/azure-rest-api-specs/tree/cea376ff8949be3dcc98a03aea5af6a18a5a0855/specification/sql/resource-manager#tag-package-composite-v5

    ericshape avatar Aug 16 '22 16:08 ericshape

    Can you add your 2022-05-01-preview swagger file into the V5 SDK? I am thinking the seconadaryType enum name will lead to conflict.

    When I tried to set x-ms-enum name to SecondaryType, I was getting name conflict. Now x-ms-enum name is SecondaryInstanceType and there's no conflict (if that's what you're talking about). How can I add 2022-05-01-preview swagger file into the V5 SDK?

    update this section: https://github.com/Azure/azure-rest-api-specs/tree/cea376ff8949be3dcc98a03aea5af6a18a5a0855/specification/sql/resource-manager#tag-package-composite-v5

    As discussed on mail thread and offline, there's no conflict since the enum names are different

    a-lazarlazic avatar Aug 17 '22 08:08 a-lazarlazic