azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Added new parameter isRestrictedUse boolean in the putSVI API

Open dindurkhya opened this issue 3 years ago • 10 comments

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow. Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [ ] new API version
    • [ ] update existing version for new feature
    • [ ] update existing version to fix swagger quality issue in s360
    • [ ] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • [ ] SDK of .NET (need service team to ensure code readiness)
    • [ ] SDK of Python
    • [ ] SDK of Java
    • [ ] SDK of Js
    • [ ] SDK of Go
    • [ ] PowerShell
    • [ ] CLI
    • [ ] Terraform
    • [ ] No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [ ] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • [ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • [ ] Removing API(s) in a stable version
  • [ ] Removing properties in a stable version
  • [ ] Removing API version(s) in a stable version
  • [ ] Updating API in a stable or public preview version with Breaking Change Validation errors
  • [ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

dindurkhya avatar Aug 05 '22 11:08 dindurkhya

Hi, @dindurkhya Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    Swagger Validation Report

    ️❌BreakingChange: 3 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.9.6)] new version base version
    SAPVirtualInstance.json 2021-12-01-preview(43d0385) 2021-12-01-preview(main)
    Rule Message
    1045 - AddedOptionalProperty The new version has a new optional property 'isRestrictedUse' that was not found in the old version.
    New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2288:7
    Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2285:7
    1045 - AddedOptionalProperty The new version has a new optional property 'isRestrictedUse' that was not found in the old version.
    New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2410:7
    Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2407:7
    1045 - AddedOptionalProperty The new version has a new optional property 'isRestrictedUse' that was not found in the old version.
    New: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2445:7
    Old: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2442:7
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 1 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2021-12-01-preview package-2021-12-01-preview(43d0385) package-2021-12-01-preview(main)

    The following errors/warnings are introduced by current PR:

    Rule Message
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isRestrictedUse
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2453


    The following errors/warnings exist before current PR submission:

    Rule Message
    :warning: R1003 - ListInOperationName Since operation 'SAPSupportedSku' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L99
    :warning: R1003 - ListInOperationName Since operation 'SAPDiskConfigurations' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L155
    :warning: R1003 - ListInOperationName Since operation 'SAPAvailabilityZoneDetails' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L205
    :warning: R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1732
    :warning: R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'getsizingrecommendations' in:'SAPSizingRecommendations'. Consider updating the operationId
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L43
    :warning: R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'getsapsupportedsku' in:'SAPSupportedSku'. Consider updating the operationId
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L99
    :warning: R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'getdiskconfigurations' in:'SAPDiskConfigurations'. Consider updating the operationId
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L155
    :warning: R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'getavailabilityzonedetails' in:'SAPAvailabilityZoneDetails'. Consider updating the operationId
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L205
    :warning: R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'applicationInstances' with immediate parent 'SAPVirtualInstance', must have a list by immediate parent operation.
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2974
    :warning: R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'centralInstances' with immediate parent 'SAPVirtualInstance', must have a list by immediate parent operation.
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3186
    :warning: R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'databaseInstances' with immediate parent 'SAPVirtualInstance', must have a list by immediate parent operation.
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3249
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disablePasswordAuthentication
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L1870
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isAppServerCertified
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2092
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDatabaseCertified
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2096
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: hardStop
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2574
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isSecondaryIpEnabled
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L3268
    :warning: R4021 - DescriptionAndTitleMissing 'virtualMachineId' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2718
    :warning: R4021 - DescriptionAndTitleMissing 'virtualMachineId' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json#L2728
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 1 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/43d0385361e04d8ed7d278fdc303b3abd0677fd2/specification/workloads/resource-manager/readme.md#tag-package-2021-12-01-preview">workloads/resource-manager/readme.md#package-2021-12-01-preview
    The following errors/warnings are introduced by current PR:
    Rule Message
    :warning: Modeler/MissingType "readme":"workloads/resource-manager/readme.md",
    "tag":"package-2021-12-01-preview",
    "details":"The schema 'OperationsDefinition-properties' has no type or format information whatsoever. Location:\n file:///mnt/vss/_work/1/azure-rest-api-specs/specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/monitors.json#/components/schemas/OperationsDefinition-properties"


    The following errors/warnings exist before current PR submission:

    Rule Message
    :warning: UnkownSecurityScheme "readme":"workloads/resource-manager/readme.md",
    "tag":"package-2021-12-01-preview",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking


    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from afe3bfffb9faab676d0f2b1c8ffc32a463c002b8. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  global `--global`, `--local` are deprecated. Use `--location=global` instead.
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.11.0 -> 8.16.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.16.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-workloads [View full logs]  [Preview SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model InfrastructureConfiguration has a new parameter is_restricted_use
      info	[Changelog]   - Model Monitor has a new parameter zone_redundancy_preference
      info	[Changelog]   - Model SingleServerConfiguration has a new parameter is_restricted_use
      info	[Changelog]   - Model ThreeTierConfiguration has a new parameter is_restricted_use
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️❌ azure-sdk-for-go failed [Detail]
    • Failed [Logs] Generate from afe3bfffb9faab676d0f2b1c8ffc32a463c002b8. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
      ENOENT: no such file or directory, copyfile 'azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/workloads/armworkloads.gosource' -> 'sdkApiViewArtifacts/armworkloads.gosource'
      Error: ENOENT: no such file or directory, copyfile 'azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/workloads/armworkloads.gosource' -> 'sdkApiViewArtifacts/armworkloads.gosource'
          at Object.copyFileSync (fs.js:2062:3)
          at workflowPkgSaveApiViewArtifact (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:210:10)
          at Object.exports.workflowPkgMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:60:11)
          at async workflowHandleReadmeMd (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:172:9)
          at async Object.exports.workflowMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
          at async Object.exports.sdkAutoMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:188:13)
          at async /mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
    • ️✔️armworkloads [View full logs
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New field `IsRestrictedUse` in struct `ThreeTierConfiguration`
      info	[Changelog] - New field `IsRestrictedUse` in struct `SingleServerConfiguration`
      info	[Changelog] - New field `ZoneRedundancyPreference` in struct `MonitorProperties`
      info	[Changelog] - New field `IsRestrictedUse` in struct `InfrastructureConfiguration`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 4 additive change(s).
      error	Fatal error: ENOENT: no such file or directory, copyfile 'azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/workloads/armworkloads.gosource' -> 'sdkApiViewArtifacts/armworkloads.gosource'
      error	The following packages are still pending:
      error		armworkloads
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from afe3bfffb9faab676d0f2b1c8ffc32a463c002b8. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-workloads [View full logs]  [Preview SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Interface InfrastructureConfiguration has a new optional parameter isRestrictedUse
      info	[Changelog]   - Interface Monitor has a new optional parameter zoneRedundancyPreference
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs] Generate from afe3bfffb9faab676d0f2b1c8ffc32a463c002b8. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/workloads/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] No usable version of the libssl was found
      cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
      cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
      warn	Skip package processing as generation is failed
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from afe3bfffb9faab676d0f2b1c8ffc32a463c002b8. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️workloads [View full logs]  [Preview Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    Generated ApiView

    Language Package Name ApiView Link
    Python track2_azure-mgmt-workloads Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. If issue still exists, please ask PR assignee for help
    Java azure-resourcemanager-workloads Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. If issue still exists, please ask PR assignee for help
    JavaScript @azure/arm-workloads Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. If issue still exists, please ask PR assignee for help

    NewApiVersionRequired reason: A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support. EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    Hi @dindurkhya, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    Hi, @dindurkhya. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Aug 28 '22 16:08 ghost

    Hi, @dindurkhya. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Sep 18 '22 16:09 ghost

    Hi, @dindurkhya. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Oct 16 '22 16:10 ghost

    Hi @dindurkhya , A kindly remainder that would you please resolve the conflict if still want to get this PR merged.

    changlong-liu avatar Oct 17 '22 01:10 changlong-liu

    Hi, @dindurkhya. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Nov 06 '22 16:11 ghost

    Hi, @dindurkhya. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    ghost avatar Nov 21 '22 05:11 ghost