azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Updated DatadogOrganizationProperties for reduce onboarding friction story | Datadog

Open harsh007kumar opened this issue 3 years ago • 13 comments

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [x] new API version
    • [ ] update existing version for new feature
    • [ ] update existing version to fix swagger quality issue in s360
    • [ ] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • [ ] SDK of .NET (need service team to ensure code readiness)
    • [ ] SDK of Python
    • [ ] SDK of Java
    • [ ] SDK of Js
    • [ ] SDK of Go
    • [ ] PowerShell
    • [ ] CLI
    • [ ] Terraform
    • [x] No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [x] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • [ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • [ ] Removing API(s) in a stable version
  • [ ] Removing properties in a stable version
  • [ ] Removing API version(s) in a stable version
  • [ ] Updating API in a stable or public preview version with Breaking Change Validation errors
  • [ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

harsh007kumar avatar Jul 29 '22 10:07 harsh007kumar

Hi, @harsh007kumar Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 2 Errors, 6 Warnings failed [Detail]
    compared swaggers (via Oad v0.9.6)] new version base version
    datadog.json 2022-06-01(56aa359) 2021-03-01(main)
    datadog.json 2022-06-01(56aa359) 2020-02-01-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1535:9
    Old: Microsoft.Datadog/stable/2021-03-01/datadog.json#L1535:9
    1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1543:9
    Old: Microsoft.Datadog/stable/2021-03-01/datadog.json#L1540:9


    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    :warning: 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: common-types/resource-management/v2/types.json#L289:9
    Old: Microsoft.Datadog/preview/2020-02-01-preview/datadog.json#L1252:9
    :warning: 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: common-types/resource-management/v2/types.json#L294:9
    Old: Microsoft.Datadog/preview/2020-02-01-preview/datadog.json#L1255:9
    :warning: 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: common-types/resource-management/v2/types.json#L299:9
    Old: Microsoft.Datadog/preview/2020-02-01-preview/datadog.json#L1258:9
    :warning: 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: common-types/resource-management/v2/types.json#L304:9
    Old: Microsoft.Datadog/preview/2020-02-01-preview/datadog.json#L1261:9
    :warning: 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1535:9
    Old: Microsoft.Datadog/preview/2020-02-01-preview/datadog.json#L1550:9
    :warning: 1029 - ReadonlyPropertyChanged The read only property has changed from 'true' to 'false'.
    New: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1543:9
    Old: Microsoft.Datadog/preview/2020-02-01-preview/datadog.json#L1555:9
    ️⌛CredScan pending [Detail]
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2022-06 package-2022-06(56aa359) default(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    :warning: R1001 - OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'Monitors' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L367
    :warning: R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1185
    :warning: R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1718
    :warning: R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1769
    :warning: R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1900
    :warning: R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1979
    :warning: R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'tagRules' with immediate parent 'DatadogMonitorResource', must have a list by immediate parent operation.
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1880
    :warning: R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'singleSignOnConfigurations' with immediate parent 'DatadogMonitorResource', must have a list by immediate parent operation.
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1960
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: accepted
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1160
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendingMetrics
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1378
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendingLogs
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1386
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1446
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendAadLogs
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1825
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendSubscriptionLogs
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1829
    :warning: R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: sendResourceLogs
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1833
    :warning: R4000 - ParameterDescriptionRequired 'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L91
    :warning: R4000 - ParameterDescriptionRequired 'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L239
    :warning: R4000 - ParameterDescriptionRequired 'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L604
    :warning: R4000 - ParameterDescriptionRequired 'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L667
    :warning: R4000 - ParameterDescriptionRequired 'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L876
    :warning: R4000 - ParameterDescriptionRequired 'body' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1036
    :warning: R4002 - LocationMustHaveXmsMutability Property 'location' must have ''x-ms-mutability':['read', 'create']' extension defined. Resource Model: 'DatadogMonitorResource'
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1126
    :warning: R4021 - DescriptionAndTitleMissing 'DatadogAgreementResource' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1166
    :warning: R4021 - DescriptionAndTitleMissing 'DatadogApiKey' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1212
    :warning: R4021 - DescriptionAndTitleMissing 'DatadogInstallMethod' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1256
    :warning: R4021 - DescriptionAndTitleMissing 'DatadogLogsAgent' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1273
    :warning: R4021 - DescriptionAndTitleMissing 'DatadogHostMetadata' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1282
    :warning: R4021 - DescriptionAndTitleMissing 'DatadogHost' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1297
    :warning: R4021 - DescriptionAndTitleMissing 'ResourceSku' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1472
    :warning: R4021 - DescriptionAndTitleMissing 'ProvisioningState' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.Datadog/stable/2022-06-01/datadog.json#L1484
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️⌛PoliCheck pending [Detail]
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/56aa35956b5e976da8758e78326f2fe6202da287/specification/datadog/resource-manager/readme.md#tag-package-2022-06">datadog/resource-manager/readme.md#package-2022-06
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - armdatadog - Approved - 2.0.0
    +	Field `Body` of struct `MarketplaceAgreementsClientCreateOrUpdateOptions` has been removed
    +	Field `Body` of struct `MonitorsClientBeginCreateOptions` has been removed
    +	Field `Body` of struct `MonitorsClientBeginUpdateOptions` has been removed
    +	Field `Body` of struct `SingleSignOnConfigurationsClientBeginCreateOrUpdateOptions` has been removed
    +	Field `Body` of struct `TagRulesClientCreateOrUpdateOptions` has been removed
    +	Function `*MarketplaceAgreementsClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, *MarketplaceAgreementsClientCreateOrUpdateOptions)` to `(context.Context, AgreementResource, *MarketplaceAgreementsClientCreateOrUpdateOptions)`
    +	Function `*MonitorsClient.BeginCreate` parameter(s) have been changed from `(context.Context, string, string, *MonitorsClientBeginCreateOptions)` to `(context.Context, string, string, MonitorResource, *MonitorsClientBeginCreateOptions)`
    +	Function `*MonitorsClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, *MonitorsClientBeginUpdateOptions)` to `(context.Context, string, string, MonitorResourceUpdateParameters, *MonitorsClientBeginUpdateOptions)`
    +	Function `*SingleSignOnConfigurationsClient.BeginCreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, *SingleSignOnConfigurationsClientBeginCreateOrUpdateOptions)` to `(context.Context, string, string, string, SingleSignOnResource, *SingleSignOnConfigurationsClientBeginCreateOrUpdateOptions)`
    +	Function `*TagRulesClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, *TagRulesClientCreateOrUpdateOptions)` to `(context.Context, string, string, string, MonitoringTagRules, *TagRulesClientCreateOrUpdateOptions)`

    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from 2e48c102980cfe2a330e634fd018dc6646c02183. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/datadog/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] No usable version of the libssl was found
      cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
      cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
      warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2e48c102980cfe2a330e634fd018dc6646c02183. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.15.0 -> 8.19.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.19.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-datadog [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2e48c102980cfe2a330e634fd018dc6646c02183. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/datadog/armdatadog [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2e48c102980cfe2a330e634fd018dc6646c02183. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
      cmderr	[automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.
    • ️✔️@azure/arm-datadog [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2e48c102980cfe2a330e634fd018dc6646c02183. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️datadog [View full logs]  [Release Schema Changes]
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2e48c102980cfe2a330e634fd018dc6646c02183. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.Datadog [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/datadog/armdatadog Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Python track2_azure-mgmt-datadog Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-datadog Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-datadog Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    Hi @harsh007kumar, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    Most of the changes are already reviewed and merged to private repo, check => https://github.com/Azure/azure-rest-api-specs-pr/pull/7482 for details.

    raising this PR to Generate SDKs/update CLI with new api version.

    harsh007kumar avatar Jul 29 '22 10:07 harsh007kumar

    Generated ApiView

    Language Package Name ApiView Link Python track2_azure-mgmt-datadog Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and re-trigger the CI. If issue still exists, please ask PR assignee for help Java azure-resourcemanager-datadog Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and re-trigger the CI. If issue still exists, please ask PR assignee for help JavaScript @azure/arm-datadog Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and re-trigger the CI. If issue still exists, please ask PR assignee for help

    please ignore this comment. thanks

    dw511214992 avatar Jul 29 '22 11:07 dw511214992

    @ArcturusZhang I see in new API Version 3 checks are failing 2 of them because I have updated the property of 'DatadogOrganizationProperties' ID & Name to remove readonly attribute and added "x-ms-mutability": ["create", "read"] attribute which is intended in the latest Stable API Version.

    I have not updated these properties in any of the existing versions.

    can you please help me out here on resolving this issue?

    harsh007kumar avatar Jul 29 '22 12:07 harsh007kumar

    Hi, @harsh007kumar your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    Can you please get the approval from the breaking change board and then remove the "ARMChangesRequested" label when this PR is ready for review again .

    raosuhas avatar Aug 01 '22 20:08 raosuhas

    The breaking changes reported in Go SDK come from recent changes in the code generator. Approved

    ArcturusZhang avatar Aug 03 '22 06:08 ArcturusZhang

    Hi, @harsh007kumar. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Aug 21 '22 16:08 ghost

    How do I remove a label? want to remove the 'no-recent-activity' label

    harsh007kumar avatar Aug 30 '22 06:08 harsh007kumar

    Hi, @harsh007kumar breaking change approve is required.

    tianxchen-ms avatar Aug 31 '22 02:08 tianxchen-ms

    @raosuhas @tianxchen-ms I have got approval from the 'breaking change board' can you guys please review my PR now.

    harsh007kumar avatar Sep 17 '22 08:09 harsh007kumar