azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard
verified publisher icon Azure

[Hub Generated] Publish private branch 'user/jimmyca/fixAppConfigSpec'

Open jimmyca15 opened this issue 3 years ago • 24 comments

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [ ] new API version
    • [ ] update existing version for new feature
    • [ ] update existing version to fix swagger quality issue in s360
    • [ ] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • [ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

jimmyca15 avatar Jul 21 '22 16:07 jimmyca15

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/7780

jimmyca15 avatar Jul 21 '22 16:07 jimmyca15

Hi, @jimmyca15 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    openapi-workflow-bot[bot] avatar Jul 21 '22 16:07 openapi-workflow-bot[bot]

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    appconfiguration.json 2022-05-01(7abd680) 2022-05-01(main)
    Rule Message
    ❌ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppConfiguration/configurationStores/{configStoreName}/keyValues' removed or restructured?
    Old: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L815:5
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2022-05-01 package-2022-05-01(7abd680) package-2022-05-01(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L154
    ❌ DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L216
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L240
    ❌ LroPatch202 The async patch operation should return 202.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L289
    ❌ ResourceNameRestriction The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L562
    ❌ CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L610
    ❌ DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L673
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L704
    ❌ ResourceNameRestriction The resource name parameter 'groupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L770
    ❌ ResourceNameRestriction The resource name parameter 'keyValueName' should be defined with a 'pattern' restriction.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L819
    ❌ DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L923
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L954
    ❌ PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L1057
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L1082
    ❌ XmsParameterLocation The parameter 'SubscriptionIdParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L2186
    ❌ XmsParameterLocation The parameter 'ApiVersionParameter' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L2212
    :warning: XmsLongRunningOperationOptions The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L154
    :warning: XmsLongRunningOperationOptions The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L216
    :warning: XmsLongRunningOperationOptions The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L260
    :warning: RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L563
    :warning: RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L610
    :warning: XmsLongRunningOperationOptions The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L610
    :warning: XmsLongRunningOperationOptions The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L673
    :warning: RequiredReadOnlySystemData The response of operation:'KeyValues_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L820
    :warning: RequiredReadOnlySystemData The response of operation:'KeyValues_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L867
    :warning: XmsLongRunningOperationOptions The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L923
    :warning: XmsLongRunningOperationOptions The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L1057
    :warning: UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ConfigurationStores_CheckNameAvailable
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L1143
    :warning: UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ConfigurationStores_CheckNameNotAvailable
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L1143
    :warning: EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.AppConfiguration/stable/2022-05-01/appconfiguration.json#L1260
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand] 
    Validation passes for ServiceAPIReadinessTest.

    Operation coverage: total: 0, untested: 0, failed: 0, passed: 0

    Traffic Validation is finished. Check pipeline artifact for detail report.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    openapi-pipeline-app[bot] avatar Jul 21 '22 16:07 openapi-pipeline-app[bot]

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go - armappconfiguration - Approved - 2.0.0
    +	Field `KeyValueParameters` of struct `KeyValuesClientCreateOrUpdateOptions` has been removed
+	Function `*KeyValuesClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, *KeyValuesClientCreateOrUpdateOptions)` to `(context.Context, string, string, string, KeyValue, *KeyValuesClientCreateOrUpdateOptions)`
+	Function `*KeyValuesClient.NewListByConfigurationStorePager` has been removed
+	Struct `KeyValuesClientListByConfigurationStoreOptions` has been removed
+	Struct `KeyValuesClientListByConfigurationStoreResponse` has been removed
    ❌azure-sdk-for-python-track2 - track2_azure-mgmt-appconfiguration - Approved - 2.2.0
    +	Removed operation KeyValuesOperations.list_by_configuration_store
    ❌azure-sdk-for-js - @azure/arm-appconfiguration - Approved - 4.0.0
    +	Interface ConfigurationStoresListByResourceGroupNextOptionalParams no longer has parameter skipToken
+	Interface ConfigurationStoresListKeysNextOptionalParams no longer has parameter skipToken
+	Interface ConfigurationStoresListNextOptionalParams no longer has parameter skipToken
+	Interface OperationsListNextOptionalParams no longer has parameter skipToken
+	Removed operation KeyValues.listByConfigurationStore
    ❌azure-sdk-for-go - sdk/resourcemanager/appconfiguration/armappconfiguration - Approved - 2.0.0
    +	Function `*KeyValuesClient.NewListByConfigurationStorePager` has been removed
+	Struct `KeyValuesClientListByConfigurationStoreResponse` has been removed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2c4244e5bcb8939167b79f633cdc17a1f0eae9be. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-appconfiguration [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Removed operation KeyValuesOperations.list_by_configuration_store
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • ❌Failed [Logs]Release - Generate from 2c4244e5bcb8939167b79f633cdc17a1f0eae9be. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m 672 | [0m         [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m     | [31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGet-ChildItem: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:760
cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m 760 | [0m … rtifacts += [36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m     | [31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m 672 | [0m         [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m     | [31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
    • ❌Azure.ResourceManager.AppConfiguration [View full logs]  [Release SDK Changes] 
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2c4244e5bcb8939167b79f633cdc17a1f0eae9be. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-appconfiguration [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2c4244e5bcb8939167b79f633cdc17a1f0eae9be. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-appconfiguration [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed operation KeyValues.listByConfigurationStore
info	[Changelog]   - Interface ConfigurationStoresListByResourceGroupNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface ConfigurationStoresListKeysNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface ConfigurationStoresListNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface OperationsListNextOptionalParams no longer has parameter skipToken
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2c4244e5bcb8939167b79f633cdc17a1f0eae9be. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/appconfiguration/armappconfiguration [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*KeyValuesClient.NewListByConfigurationStorePager` has been removed
info	[Changelog] - Struct `KeyValuesClientListByConfigurationStoreResponse` has been removed
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 0 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2c4244e5bcb8939167b79f633cdc17a1f0eae9be. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
    • ️✔️appconfiguration [View full logs] 
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2c4244e5bcb8939167b79f633cdc17a1f0eae9be. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.AppConfiguration [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    openapi-pipeline-app[bot] avatar Jul 21 '22 16:07 openapi-pipeline-app[bot]

    Hi @jimmyca15, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    openapi-workflow-bot[bot] avatar Jul 21 '22 16:07 openapi-workflow-bot[bot]

    Hi @jimmyca15, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    openapi-workflow-bot[bot] avatar Jul 21 '22 16:07 openapi-workflow-bot[bot]

    All breaking changes have been approved in the private repo PR.

    jimmyca15 avatar Jul 21 '22 16:07 jimmyca15

    Hello @qiaozha please let me know if there is anything I need to do to complete this PR. All approvals, including breaking change approval can be found in the private branch PR that this was published from.

    jimmyca15 avatar Jul 25 '22 20:07 jimmyca15

    Hello @qiaozha

    The breaking changes for this were approved in the private repo. can we merge this?

    jimmyca15 avatar Aug 01 '22 19:08 jimmyca15

    @jimmyca15 Can you fix the avocado failure and prettier check failure ?

    qiaozha avatar Aug 04 '22 01:08 qiaozha

    The api breaking change is approved in previous private repo PR.

    qiaozha avatar Aug 04 '22 02:08 qiaozha

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/appconfiguration/armappconfiguration https://apiview.dev/Assemblies/Review/b42110e31f784c09af66461fd69bb87c
    Java azure-resourcemanager-appconfiguration https://apiview.dev/Assemblies/Review/0445368e2ce64458a3ad442432a5d56c
    JavaScript @azure/arm-appconfiguration https://apiview.dev/Assemblies/Review/10f46da794dd47b680f2738e64009390

    openapi-pipeline-app[bot] avatar Aug 04 '22 22:08 openapi-pipeline-app[bot]

    @qiaozha

    I have fixed Avocado and Prettier failures.

    jimmyca15 avatar Aug 04 '22 22:08 jimmyca15

    Hi, @jimmyca15. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Aug 21 '22 16:08 ghost

    Hi, @jimmyca15. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

    ghost avatar Sep 05 '22 05:09 ghost

    @ArcturusZhang @qiaozha

    This was approved but never merged. Can you merge it?

    jimmyca15 avatar Nov 04 '22 20:11 jimmyca15

    Hi @jimmyca15, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval.

    openapi-workflow-bot[bot] avatar Nov 04 '22 20:11 openapi-workflow-bot[bot]

    Hi, @jimmyca15. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Nov 27 '22 16:11 ghost

    @ArcturusZhang @qiaozha

    This was approved but never merged. Can you merge it?

    jimmyca15 avatar Dec 11 '22 22:12 jimmyca15

    Hi, @jimmyca15. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Jan 01 '23 16:01 ghost

    @ArcturusZhang @qiaozha

    This was approved but never merged. Can you merge it?

    jimmyca15 avatar Jan 03 '23 16:01 jimmyca15

    @jimmyca15 can you fix the swagger model validation errors ?

    qiaozha avatar Jan 04 '23 01:01 qiaozha

    Also, there's staging lint diff error

    qiaozha avatar Jan 04 '23 01:01 qiaozha

    @qiaozha Wouldn't fixing those model validation errors be an unapproved breaking change?

    Also, the lint diff error is the approved breaking change this PR is making. Is there a way for me to silence that lint diff error?

    jimmyca15 avatar Jan 12 '23 17:01 jimmyca15

    @raych1 Can you help take a look at the Model Validation error ? Thanks

    qiaozha avatar Jan 13 '23 10:01 qiaozha

    @ArcturusZhang Can you help take a look at the dotnet sdk track2 generation error ? Thanks

    qiaozha avatar Jan 13 '23 10:01 qiaozha

    @qiaozha I see you mentioned some people. Should I be reaching out to these individuals for the concerns you mentioned? We really need this checked in.

    Please note that all these breaking changes were requested and approved in the private repo PR this was generated from.

    https://github.com/Azure/azure-rest-api-specs-pr/pull/7780

    jimmyca15 avatar Feb 01 '23 23:02 jimmyca15

    @jimmyca15 , please refer to this example to add LRO headers to swagger examples to fix model validation errors.

    raych1 avatar Feb 02 '23 02:02 raych1

    @raych1 I have added it and resolved the model validation errors.

    jimmyca15 avatar Feb 02 '23 22:02 jimmyca15