azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Added 'configMergeRule' property to swagger 'sparkConfiguration.json'…

Open sparatala opened this issue 3 years ago • 9 comments

… spec

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [ ] new API version
    • [ ] update existing version for new feature
    • [x] update existing version to fix swagger quality issue in s360
    • [ ] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • [ ] SDK of .NET (need service team to ensure code readiness)
    • [ ] SDK of Python
    • [ ] SDK of Java
    • [ ] SDK of Js
    • [ ] SDK of Go
    • [ ] PowerShell
    • [ ] CLI
    • [ ] Terraform
    • [ ] No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [ ] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • [x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [x] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • [ ] Removing API(s) in a stable version
  • [ ] Removing properties in a stable version
  • [ ] Removing API version(s) in a stable version
  • [x] Updating API in a stable or public preview version with Breaking Change Validation errors
  • [ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

sparatala avatar Jul 21 '22 06:07 sparatala

Hi, @sparatala Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.9.6)] new version base version
    sparkConfiguration.json 2022-03-01-preview(4509570) 2021-06-01-preview(main)
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️❌LintDiff: 1 Errors, 1 Warnings failed [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2022-03-01-preview package-2022-03-01-preview(4509570) default(main)

    The following errors/warnings are introduced by current PR:

    Rule Message
    R3023 - OperationsAPIImplementation Operations API must be implemented for '/providers/Microsoft.Synapse/operations'.
    Location: Microsoft.Synapse/preview/2022-03-01-preview/sparkConfiguration.json#L23
    :warning: R4009 - RequiredReadOnlySystemData The response of operation:'SparkConfiguration_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/preview/2022-03-01-preview/sparkConfiguration.json#L25


    The following errors/warnings exist before current PR submission:

    Rule Message
    R4039 - ParametersOrder The parameters:resourceGroupName,sparkConfigurationName,workspaceName should be kept in the same order as they present in the path.
    Location: Microsoft.Synapse/preview/2022-03-01-preview/sparkConfiguration.json#L25
    ️❌Avocado: 1 Errors, 1 Warnings failed [Detail]
    Rule Message
    NOT_LATEST_API_VERSION_IN_DEFAULT_TAG The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag.
    readme: specification/synapse/resource-manager/readme.md
    json: Microsoft.Synapse/preview/2022-03-01-preview/sparkConfiguration.json
    :warning: MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/synapse/resource-manager/readme.md
    tag: specification/synapse/resource-manager/readme.md#tag-package-composite-v2
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌ModelValidation: 6 Errors, 0 Warnings failed [Detail]
    Rule Message
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: configMergeRule
    Url: Microsoft.Synapse/preview/2022-03-01-preview/sparkConfiguration.json#L158:35
    ExampleUrl: preview/2022-03-01-preview/examples/SparkConfiguration_Get.json#L39:28
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: configMergeRule
    Url: Microsoft.Synapse/preview/2022-03-01-preview/sparkConfiguration.json#L158:35
    ExampleUrl: preview/2022-03-01-preview/examples/SparkConfigurations_ListByWorkspace.json#L40:32
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: configMergeRule
    Url: Microsoft.Synapse/preview/2022-03-01-preview/sparkConfiguration.json#L158:35
    ExampleUrl: preview/2022-03-01-preview/examples/SparkConfigurations_ListByWorkspace.json#L69:32
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: configMergeRule
    Url: Microsoft.Synapse/preview/2022-03-01-preview/sparkConfiguration.json#L158:35
    ExampleUrl: preview/2022-03-01-preview/examples/SparkConfiguration_Get.json#L39:28
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: configMergeRule
    Url: Microsoft.Synapse/preview/2022-03-01-preview/sparkConfiguration.json#L158:35
    ExampleUrl: preview/2022-03-01-preview/examples/SparkConfigurations_ListByWorkspace.json#L40:32
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: configMergeRule
    Url: Microsoft.Synapse/preview/2022-03-01-preview/sparkConfiguration.json#L158:35
    ExampleUrl: preview/2022-03-01-preview/examples/SparkConfigurations_ListByWorkspace.json#L69:32
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/4509570749a199d43588be4b3e45ef37cef6f3ec/specification/synapse/resource-manager/readme.md#tag-package-2022-03-01-preview">synapse/resource-manager/readme.md#package-2022-03-01-preview
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - armsynapse - 0.6.0
    +	Const `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityActualStateDisabled` has been removed
    +	Const `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityActualStateDisabling` has been removed
    +	Const `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityActualStateEnabled` has been removed
    +	Const `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityActualStateEnabling` has been removed
    +	Const `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityActualStateUnknown` has been removed
    +	Const `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityDesiredStateDisabled` has been removed
    +	Const `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityDesiredStateEnabled` has been removed
    +	Function `PossibleManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityActualStateValues` has been removed
    +	Function `PossibleManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityDesiredStateValues` has been removed
    +	Type of `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentity.ActualState` has been changed from `*ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityActualState` to `*ActualState`
    +	Type of `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentity.DesiredState` has been changed from `*ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityDesiredState` to `*DesiredState`

    azure-sdk-for-js - @azure/arm-synapse - 9.0.0-beta.1
    +	Removed Enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState
    +	Removed Enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState
    ️❌ azure-sdk-for-python-track2 failed [Detail]
    • Failed [Logs] Generate from 6736adf667a3791d48483cd7c8bcf791151dc9ea. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.11.0 -> 8.16.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.16.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
      

      HttpError at /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@[email protected][email protected]/node_modules/@octokit/request/dist-node/index.js:86:21 at runMicrotasks (<anonymous>) at processTicksAndRejections (internal/process/task_queues.js:95:5) at async workflowPkgUpdatePR (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:361:35) at async Object.exports.workflowPkgMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:63:5) at async workflowHandleReadmeMd (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:172:9) at async Object.exports.workflowMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9) at async Object.exports.sdkAutoMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:188:13) at async /mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18

    • ️✔️track2_azure-mgmt-synapse [View full logs
      info	[Changelog] Features
      info	[Changelog]
      info	[Changelog]   - Model ClusterPrincipalAssignment has a new parameter aad_object_id
      info	[Changelog]   - Model DatabasePrincipalAssignment has a new parameter aad_object_id
      error	Fatal error:
      error	The following packages are still pending:
      error		track2_azure-mgmt-synapse
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️❌ azure-sdk-for-go failed [Detail]
    • Failed [Logs] Generate from 6736adf667a3791d48483cd7c8bcf791151dc9ea. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
      ENOENT: no such file or directory, copyfile 'azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/synapse/armsynapse.gosource' -> 'sdkApiViewArtifacts/armsynapse.gosource'
      Error: ENOENT: no such file or directory, copyfile 'azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/synapse/armsynapse.gosource' -> 'sdkApiViewArtifacts/armsynapse.gosource'
          at Object.copyFileSync (fs.js:2062:3)
          at workflowPkgSaveApiViewArtifact (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:210:10)
          at Object.exports.workflowPkgMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:60:11)
          at async workflowHandleReadmeMd (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:172:9)
          at async Object.exports.workflowMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:83:9)
          at async Object.exports.sdkAutoMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:188:13)
          at async /mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
    • ️✔️armsynapse [View full logsBreaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentity.DesiredState` has been changed from `*ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityDesiredState` to `*DesiredState`
      info	[Changelog] - Type of `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentity.ActualState` has been changed from `*ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityActualState` to `*ActualState`
      info	[Changelog] - Const `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityActualStateEnabled` has been removed
      info	[Changelog] - Const `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityActualStateDisabling` has been removed
      info	[Changelog] - Const `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityDesiredStateEnabled` has been removed
      info	[Changelog] - Const `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityActualStateDisabled` has been removed
      info	[Changelog] - Const `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityActualStateEnabling` has been removed
      info	[Changelog] - Const `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityDesiredStateDisabled` has been removed
      info	[Changelog] - Const `ManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityActualStateUnknown` has been removed
      info	[Changelog] - Function `PossibleManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityActualStateValues` has been removed
      info	[Changelog] - Function `PossibleManagedIdentitySQLControlSettingsModelPropertiesGrantSQLControlToManagedIdentityDesiredStateValues` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `ActualStateEnabled`
      info	[Changelog] - New const `ActualStateEnabling`
      info	[Changelog] - New const `ActualStateUnknown`
      info	[Changelog] - New const `ActualStateDisabling`
      info	[Changelog] - New const `ActualStateDisabled`
      info	[Changelog] - New const `DesiredStateDisabled`
      info	[Changelog] - New const `DesiredStateEnabled`
      info	[Changelog] - New function `PossibleActualStateValues() []ActualState`
      info	[Changelog] - New function `PossibleDesiredStateValues() []DesiredState`
      info	[Changelog] - New field `AADObjectID` in struct `DatabasePrincipalProperties`
      info	[Changelog] - New field `AADObjectID` in struct `ClusterPrincipalProperties`
      info	[Changelog]
      info	[Changelog] Total 10 breaking change(s), 11 additive change(s).
      error	Fatal error: ENOENT: no such file or directory, copyfile 'azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/mnt/vss/_work/1/s/azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/synapse/armsynapse.gosource' -> 'sdkApiViewArtifacts/armsynapse.gosource'
      error	The following packages are still pending:
      error		armsynapse
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 6736adf667a3791d48483cd7c8bcf791151dc9ea. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-synapse [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettings
      info	[Changelog]   - Added Interface AttachedDatabaseConfiguration
      info	[Changelog]   - Added Interface AzureADOnlyAuthentication
      info	[Changelog]   - Added Interface AzureEntityResource
      info	[Changelog]   - Added Interface BigDataPoolResourceInfo
      info	[Changelog]   - Added Interface ClusterPrincipalAssignment
      info	[Changelog]   - Added Interface CmdkeySetup
      info	[Changelog]   - Added Interface ComponentSetup
      info	[Changelog]   - Added Interface Database
      info	[Changelog]   - Added Interface DatabasePrincipalAssignment
      info	[Changelog]   - Added Interface DataConnection
      info	[Changelog]   - Added Interface DataMaskingPolicy
      info	[Changelog]   - Added Interface DataMaskingRule
      info	[Changelog]   - Added Interface DataWarehouseUserActivities
      info	[Changelog]   - Added Interface DedicatedSQLminimalTlsSettings
      info	[Changelog]   - Added Interface DedicatedSQLminimalTlsSettingsListResult
      info	[Changelog]   - Added Interface DedicatedSQLminimalTlsSettingsPatchInfo
      info	[Changelog]   - Added Interface EncryptionProtector
      info	[Changelog]   - Added Interface EnvironmentVariableSetup
      info	[Changelog]   - Added Interface EventGridDataConnection
      info	[Changelog]   - Added Interface EventHubDataConnection
      info	[Changelog]   - Added Interface ExtendedServerBlobAuditingPolicy
      info	[Changelog]   - Added Interface ExtendedSqlPoolBlobAuditingPolicy
      info	[Changelog]   - Added Interface GeoBackupPolicy
      info	[Changelog]   - Added Interface IntegrationRuntimeResource
      info	[Changelog]   - Added Interface IotHubDataConnection
      info	[Changelog]   - Added Interface IpFirewallRuleInfo
      info	[Changelog]   - Added Interface Key
      info	[Changelog]   - Added Interface KustoPool
      info	[Changelog]   - Added Interface KustoPoolUpdate
      info	[Changelog]   - Added Interface LibraryResource
      info	[Changelog]   - Added Interface LinkedIntegrationRuntimeKeyAuthorization
      info	[Changelog]   - Added Interface LinkedIntegrationRuntimeRbacAuthorization
      info	[Changelog]   - Added Interface MaintenanceWindowOptions
      info	[Changelog]   - Added Interface MaintenanceWindows
      info	[Changelog]   - Added Interface ManagedIdentitySqlControlSettingsModel
      info	[Changelog]   - Added Interface ManagedIntegrationRuntime
      info	[Changelog]   - Added Interface ManagedIntegrationRuntimeStatus
      info	[Changelog]   - Added Interface MetadataSyncConfig
      info	[Changelog]   - Added Interface PrivateEndpointConnection
      info	[Changelog]   - Added Interface PrivateEndpointConnectionForPrivateLinkHub
      info	[Changelog]   - Added Interface PrivateLinkHub
      info	[Changelog]   - Added Interface PrivateLinkResource
      info	[Changelog]   - Added Interface ProxyResource
      info	[Changelog]   - Added Interface ReadOnlyFollowingDatabase
      info	[Changelog]   - Added Interface ReadWriteDatabase
      info	[Changelog]   - Added Interface RecommendedSensitivityLabelUpdate
      info	[Changelog]   - Added Interface RecoverableSqlPool
      info	[Changelog]   - Added Interface ReplicationLink
      info	[Changelog]   - Added Interface RestorableDroppedSqlPool
      info	[Changelog]   - Added Interface RestorePoint
      info	[Changelog]   - Added Interface SecureString
      info	[Changelog]   - Added Interface SelfHostedIntegrationRuntime
      info	[Changelog]   - Added Interface SelfHostedIntegrationRuntimeStatus
      info	[Changelog]   - Added Interface SensitivityLabel
      info	[Changelog]   - Added Interface SensitivityLabelUpdate
      info	[Changelog]   - Added Interface ServerBlobAuditingPolicy
      info	[Changelog]   - Added Interface ServerSecurityAlertPolicy
      info	[Changelog]   - Added Interface ServerVulnerabilityAssessment
      info	[Changelog]   - Added Interface SparkConfigurationResource
      info	[Changelog]   - Added Interface SqlPool
      info	[Changelog]   - Added Interface SqlPoolBlobAuditingPolicy
      info	[Changelog]   - Added Interface SqlPoolColumn
      info	[Changelog]   - Added Interface SqlPoolConnectionPolicy
      info	[Changelog]   - Added Interface SqlPoolOperation
      info	[Changelog]   - Added Interface SqlPoolSchema
      info	[Changelog]   - Added Interface SqlPoolSecurityAlertPolicy
      info	[Changelog]   - Added Interface SqlPoolTable
      info	[Changelog]   - Added Interface SqlPoolVulnerabilityAssessment
      info	[Changelog]   - Added Interface SqlPoolVulnerabilityAssessmentRuleBaseline
      info	[Changelog]   - Added Interface SqlPoolVulnerabilityAssessmentScansExport
      info	[Changelog]   - Added Interface SsisEnvironment
      info	[Changelog]   - Added Interface SsisFolder
      info	[Changelog]   - Added Interface SsisPackage
      info	[Changelog]   - Added Interface SsisProject
      info	[Changelog]   - Added Interface SubResource
      info	[Changelog]   - Added Interface TrackedResource
      info	[Changelog]   - Added Interface TransparentDataEncryption
      info	[Changelog]   - Added Interface VulnerabilityAssessmentScanRecord
      info	[Changelog]   - Added Interface WorkloadClassifier
      info	[Changelog]   - Added Interface WorkloadGroup
      info	[Changelog]   - Added Interface Workspace
      info	[Changelog]   - Added Interface WorkspaceAadAdminInfo
      info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsGetOptionalParams
      info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListNextOptionalParams
      info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListOptionalParams
      info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsUpdateOptionalParams
      info	[Changelog]   - Added Type Alias ActualState
      info	[Changelog]   - Added Type Alias DedicatedSQLMinimalTlsSettingsName
      info	[Changelog]   - Added Type Alias DesiredState
      info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsGetResponse
      info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListNextResponse
      info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListResponse
      info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsUpdateResponse
      info	[Changelog]   - Class SynapseManagementClient has a new parameter workspaceManagedSqlServerDedicatedSQLMinimalTlsSettings
      info	[Changelog]   - Added Enum KnownDedicatedSQLMinimalTlsSettingsName
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed Enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState
      info	[Changelog]   - Removed Enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs] Generate from 6736adf667a3791d48483cd7c8bcf791151dc9ea. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.synapse [View full logs]  [Preview SDK Changes]
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs] Generate from 6736adf667a3791d48483cd7c8bcf791151dc9ea. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] No usable version of the libssl was found
      cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
      cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      cmderr	[Autorest] Failure during batch task - {"tag":"$(tag)"} -- false.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
      warn	Skip package processing as generation is failed
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 6736adf667a3791d48483cd7c8bcf791151dc9ea. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️synapse [View full logs
    Posted by Swagger Pipeline | How to fix these errors?

    NewApiVersionRequired reason: A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support. EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    Hi @sparatala, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    We should create a new api version for this change.

    bansalaseem avatar Aug 04 '22 04:08 bansalaseem

    Generated ApiView

    Language Package Name ApiView Link
    Python track2_azure-mgmt-synapse Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. If issue still exists, please ask PR assignee for help
    Java azure-resourcemanager-synapse Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. If issue still exists, please ask PR assignee for help
    JavaScript @azure/arm-synapse Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. If issue still exists, please ask PR assignee for help

    CLA assistant check
    All CLA requirements met.

    ghost avatar Aug 05 '22 10:08 ghost

    Hi @sparatala, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    Hi, @sparatala. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    ghost avatar Sep 04 '22 16:09 ghost

    … spec

    MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

    Changelog

    Add a changelog entry for this PR by answering the following questions:

    1. What's the purpose of the update?

      • [ ] new service onboarding
      • [ ] new API version
      • [ ] update existing version for new feature
      • [x] update existing version to fix swagger quality issue in s360
      • [ ] Other, please clarify
    2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.

    3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.

    4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.

      • [ ] SDK of .NET (need service team to ensure code readiness)
      • [ ] SDK of Python
      • [ ] SDK of Java
      • [ ] SDK of Js
      • [ ] SDK of Go
      • [ ] PowerShell
      • [ ] CLI
      • [ ] Terraform
      • [ ] No refresh required for updates in this PR

    Contribution checklist:

    If any further question about AME onboarding or validation tools, please view the FAQ.

    ARM API Review Checklist

    Applicability: ⚠️ If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

    • Change to data plane APIs
    • Adding new properties
    • All removals

    Otherwise your PR may be subject to ARM review requirements. Complete the following:

    • [ ] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

      • Adding a new service
      • Adding new API(s)
      • Adding a new API version -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
    • [x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

    • [x] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

    Breaking Change Review Checklist

    If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

    • [ ] Removing API(s) in a stable version
    • [ ] Removing properties in a stable version
    • [ ] Removing API version(s) in a stable version
    • [x] Updating API in a stable or public preview version with Breaking Change Validation errors
    • [ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

    Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

    Please follow the link to find more details on PR review process.

    This PR is not required since change has been merged with another PR.

    sparatala avatar Sep 12 '22 06:09 sparatala